From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9488C3600C for ; Thu, 3 Apr 2025 04:15:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6AEE9280003; Thu, 3 Apr 2025 00:15:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 65C88280001; Thu, 3 Apr 2025 00:15:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 54A0E280003; Thu, 3 Apr 2025 00:15:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 32B42280001 for ; Thu, 3 Apr 2025 00:15:46 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 7EE4CACA14 for ; Thu, 3 Apr 2025 04:15:46 +0000 (UTC) X-FDA: 83291419092.26.E1F694D Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf05.hostedemail.com (Postfix) with ESMTP id BAA5B100007 for ; Thu, 3 Apr 2025 04:15:44 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=jBywIYdD; dmarc=none; spf=pass (imf05.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743653744; a=rsa-sha256; cv=none; b=jnaSrPQcWKtKeYWL6XUxuwPpS9/0pM8KONgHhdNOooRR+Yz0wOheXeYpmac7TXmpzpsisc XCjZ2eUZjttGnPuuLMSlYoDOAVDZmsj923a23zVlrd6p/W3uhBIhaz4lcOnjcn6frOJP44 +EbYpEegdMQR22Zwe+yRIIgzrXPj88Y= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=jBywIYdD; dmarc=none; spf=pass (imf05.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743653744; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3DR6gg6ZL79KV3IoiLXcFe33K49mSIYdd4IhekSy9Ns=; b=f3KDJNmiP8sxJSGjwQjwDOMLKLg5ACyoRYrzTQ7P7lApAJ3StsYo9JGIB93ogABo4JxvuX d6o+forwom4keSIu6MlvwCN2cp1DIkD+XO9vMa1eiVrY+OQkepq1Bi5BE55Y2HC6bovFh0 QqB7mOarVrl2qAUHGVQrWCoq3N+aU0M= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 19014A460AE; Thu, 3 Apr 2025 04:10:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 06FF2C4CEE3; Thu, 3 Apr 2025 04:15:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1743653743; bh=cGKBxioptz7Nf5wl9y/wguPaG9HFs+hqPmKSo7At7Tw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=jBywIYdDOXWFYkfEbnMHxBk604y0HTHpucz1Hi0XZzO6fzITzLsPH9TZSrR83r9oX PFFNmPip+2ATDWejuZSGZc7zKpkHYsIFEcvBRw0mxeEaHU+F+/vAhMI1zFd1x5XVWT kT1Q6pIiLVRZZ9Q1ZkoyKwlO/Nt0nBrxztQP87t0= Date: Wed, 2 Apr 2025 21:15:42 -0700 From: Andrew Morton To: Waiman Long Cc: Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] memcg: Don't generate low/min events if either low/min or elow/emin is 0 Message-Id: <20250402211542.6bfb9ab3a6511ea26ce3cdf8@linux-foundation.org> In-Reply-To: <20250403031212.317837-1-longman@redhat.com> References: <20250403031212.317837-1-longman@redhat.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: BAA5B100007 X-Stat-Signature: d5n3pbfhx1qhgxpa6nwsnu7m1ka9mibj X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1743653744-281586 X-HE-Meta: U2FsdGVkX19SIuwz+4VS5dKZnLcTo3+6I3+f9x7ck7o/sdbW9aqX3GEt0lLVv8zB4r6eGA03sN7G24pemJ7X3B//hM9zQnSpzAclKvveDim2LeSZ0h7xFFRtQs+ysYXvqPzRiyIHP08GDqBHjZhY2FX+yPgmqgWN/yd4CR6oALOzFbCXq23ZRA39oJfYKsL4YmEAlq1seQaPTZuSWLPj0FBX8wCiNQtVsv4kbrCo9X/soDk/jJ5TAl87DyAg8wrV6bxQwoU15hY/+arda1a0+vIdyQ3XShOhpU8n2hlnPEgASOoIZFhXAc7Y9opWlkTPZMo6PWTVguovE+7kyJQB0ZeL5ivB+Vr30lBn0vfdc+Xk9aij/Zrvc0ctpKHrR3g2f2HKB0jW958lSav2lopq38VTYHJMK1hGeovX9i0+EG2KFYAeOTlIKoJXgXmjSqMHLVK9F8FNlwDYjiTv7Wh4ZBSr0VXSDcn41DLkDLPPLc0EnKLqr7ten7rUM6ncPEaVh1WVdCX4GV7gPv6NqDueKZDPkevFJ9dMXeqn/YL8cQS6KhjmtkxxXSFPl9PInh1kLG6y2gwZ2eq7DP3c6zXu2FfZPru1K/7wSUBCQonFJDCX9aiwUN0EVioj9pl2KyvkMkwUMca6iAoWsZOsbFFg0RNVJb20twz8KcIbKHWnD7YGp55+de5v8g73RDCGnMIH2irmrQbjV6agYWTYHAbAJpI307njr30ku0Sdvh1IqGJby1QSXmUzRjZykkuwNEzzYW+biJha/glMvyliV4gFajyMFTf/P4b4LZ97ARpF7qfyb2lgivIQQXMDtLmkgkGv3TKLWQVbb4wZfWBCs3160WoS3g+Ff9KYAdEmjuoxXa3pTxnosVVE4/mc6gdoG+IH738TqlONNC87WXGWW2o6Rj3uL7AIAy37cYTXSSBehRKwWNjSgBOTQqaEZO7Ijn9z9kAkw3y0Dwa1qhH6WC7 KeilOfdp z3NhDNnYk0EVcyttvyHTjBi8vYclkrZmicgGGkPJtuI9eVZPOUgaLislP3Mg3KF8bpo/HdZuvTklkWMSdKrgW2SFhBVqbXO/bQNdObaSDXK3lEYE6mip7FLrFLNLFSTsTFV77CkdsXyqjRQXPW/KF5mFAt7BJMuBMJQtVXlguP5mD5gV/3D6QcWEl1QnscI8QUflRnj1fN5s1ztnb/3XCPeSaVUPyYMtjSANkVNG//MFaN9XpjpZPHAeF1yvJ2L1Q/zDr8Yei+zz4vvo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 2 Apr 2025 23:12:12 -0400 Waiman Long wrote: > The test_memcontrol selftest consistently fails its test_memcg_low > sub-test because of the fact that two of its test child cgroups which > have a memmory.low of 0 or an effective memory.low of 0 still have low > events generated for them since mem_cgroup_below_low() use the ">=" > operator when comparing to elow. > > The simple fix of changing the operator to ">", however, changes the > way memory reclaim works quite drastically leading to other failures. > So we can't do that without some relatively riskier changes in memory > reclaim. > > Another simpler alternative is to avoid reporting below_low failure > if either memory.low or its effective equivalent is 0 which is done > by this patch. > > With this patch applied, the test_memcg_low sub-test finishes > successfully without failure in most cases. Though both test_memcg_low > and test_memcg_min sub-tests may fail occasionally if the memory.current > values fall outside of the expected ranges. > Well, maybe the selftest needs to be changed? Please describe this patch in terms of "what is wrong with the code at present" and "how that is fixed" and "what is the impact upon userspace". Is this change backwardly compatible with existing userspace? > To be consistent, similar change is appled to mem_cgroup_below_min() > as well. Ditto.