From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 626C3C3600C for ; Thu, 3 Apr 2025 04:06:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 228B9280003; Thu, 3 Apr 2025 00:06:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1AF40280001; Thu, 3 Apr 2025 00:06:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0775A280003; Thu, 3 Apr 2025 00:06:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id DD0DD280001 for ; Thu, 3 Apr 2025 00:06:12 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 14E271613A5 for ; Thu, 3 Apr 2025 04:06:14 +0000 (UTC) X-FDA: 83291395068.27.F5D32B0 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf24.hostedemail.com (Postfix) with ESMTP id 4277E180004 for ; Thu, 3 Apr 2025 04:06:12 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=ImOU2w14; dmarc=none; spf=pass (imf24.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743653172; a=rsa-sha256; cv=none; b=Q2RKi8sFnYgnS5l6JQ2eOKDcF5CFQIwSU3uSQLpJci1r/WfBsHQwr4Yv4BjPkr0DikbPwr e2Ax/OH7FtHOXa1uFkL7BtUwY9vB1bCjbQhSd5LNX9GLu+eEjHoIUFE7vERiafDdFqi4DM fI9M//f5Me7kELGE41p3E71Hv4K+Dec= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=ImOU2w14; dmarc=none; spf=pass (imf24.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743653172; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PCMBMbnGgYAn9k6FnyTpp9LW4cHL9+/qyRjljMENZcY=; b=K/VbwxPTtL76ljYWmBwMcUHlVKHGEp2gUeXFwgfTxif/Q+OeRV2hZ7xySlC4IDBtMRFgtc W/wgxfWG8RHlzYReP1zHjXrYPtLteHGPk0zR+wMZg9HundPXfTXGNch3hpR5+k9X/mfZNp rUewYPoQBE0BGfxkPzqwVkH/i/EQunI= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 268405C628E; Thu, 3 Apr 2025 04:03:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 65755C4CEE3; Thu, 3 Apr 2025 04:06:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1743653170; bh=tx7Q6sxWKaEyBEvbYMAJX5reWYJ30urOhzxsfXs360k=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ImOU2w14Q+gG5DxCwCIMOlhP5QvRjvEeRVIy8FhIBgCMIKR12jeUuFschXhKEvD+Z p0jbh3/IvcqAQmtMAeQuDeBinx0vrYt5Ct6JE18mjaq1WIpO7VE8T+CNdhyy/mULC1 Uwxo9HGNv0aDsA341mFhpDZObJrRm1drNlKRU4hQ= Date: Wed, 2 Apr 2025 21:06:09 -0700 From: Andrew Morton To: Alexei Starovoitov Cc: bpf , linux-mm , Linus Torvalds , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Peter Zijlstra , Vlastimil Babka , Sebastian Sewior , Steven Rostedt , Shakeel Butt , Michal Hocko , LKML Subject: Re: [PATCH v3] locking/local_lock, mm: Replace localtry_ helpers with local_trylock_t type Message-Id: <20250402210609.8277eb512a78dcc4fa3702b3@linux-foundation.org> In-Reply-To: References: <20250403025514.41186-1-alexei.starovoitov@gmail.com> <20250402201252.8926c547a327ce91c61fd620@linux-foundation.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 4277E180004 X-Stat-Signature: h6989gfz3stc11zy13qgfnwta9hx8cmo X-Rspam-User: X-HE-Tag: 1743653172-53143 X-HE-Meta: U2FsdGVkX19+3NPLpGvO18PUftBRE4de/RuRM0J5jP5P6Y9zoKXS5FjbavtIpe+/zWmIGjAer3Z/ir5Jk0EseA6ZT89C8NLDSTfbr9eYid2EEhhK2pDwqs0hSBWvnZAnjv4wjaIsftKlMYQhRQ+PuLnwHGjM3ZdSXI7KyKQFz5WPQvLAmcffVQjkdpmp1EVYfSZofznXxWNbTe0XXoJv7/mVmGp3BUk2PXsU64moMiQog2BmAuG4E06jl+BecOEdNsOD00giqzXUPuj856VJc8xecm64emkzD606U+cogA7/8DXforJLxBKclgZkZipRWmDTrUU8R9hTJYRaAZvyAvOiuKLmtfl+qoo5IzjaVB4PPr211BRfP2noqAp/ck5D3fcTqqm73as1MTylHKAGP0muLdj6ee2TwAFUo8p2scGuAO+R8XOBXqsMLSCSRMAIXHCeruP5SndSfFir93FZD1sKycJQcxhOdrze8NSGLCE9qMlvKF2YE+rMvW34XP8ZG5cKWbjBeuRXuz3SjjajiOqqGY4IT0cgXgVNpBGBO4cE3tdSfXFu5eFdUw7Heu/LYExLpWNyfbdu3HkU3Ubrxjr4vJJSgKHgJCAjBR9eSGhXtVejmYeCaxRMQ/J3bEtKhiCEDqinlqrAzYkwHdpwsQvETy29xnd/ZiNHR+fmHHbAFdt7lQy3tlMueVgqngrdDane0w8377EsvsnW/mtl7XM6/kxxTOFMGH1o3NR+CfchFWOoQ0WnCeCLRncRvxoz4N3LScqFO2PIuq7ztc76uCehKc99Q36HAMmwyDD8i/+iaCi07n1FAydN4otwzyaz+/QqZJIgntigQsrY20z4+LxdSSg5O5VxBev6qaP6r2y4sDZvyBYe8CgC67girTXIRAVBTj9N4lGcFOkDlNrCqVrk/hfrThXLDAOFEsRWp4UkjAnbS3dfSb8f7orN+W5YvhUfEuLdMo3LjfblUgF N82+cbQt /9NmZWMrAv3nL1t4X157pa8Kzbf+VcTiwzMB1fVWB/7T1dAYAor2iKALPnXgxMPXlnqlHtDzYkRH0DF6Gepyk0RDKBD+h6D6Y2Fe2nQBNs7urTnsQLnlvgiB6WDY2pqUpcPno9ZQUhIwNKwLFwo/RBq5tr2xNBZNwitKvj3EbUXnZqHI2mYvMLiKPPayJd5o3sc6AuKR14CUYfQZY5i+N0yzj/ST0kBYHfjlxwhR7Fn5IWGrsBvQ8p7QgetoU6Ww45AzO8sVVza+wOosgvdYbiC5HhWIZ8sRC/itjwyKw1+6QFJKqMA/Mz/S6unF629dO6Lez0Kg6SfOiURoz5ALdpL1BnmBnWI4mkY6hWox78ZiPd+DfiQ+KjRyZWueMxOTIE/09XDhs2OB3qwANKxyBPXjcQVn4ChYZ6Ab/i4DVwZDtWwTuokbyfk2TM0BuyVcGGhwToKFYhwomRItBxv71P8xL32rYvDmmZX8a X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 2 Apr 2025 20:48:39 -0700 Alexei Starovoitov wrote: > On Wed, Apr 2, 2025 at 8:12 PM Andrew Morton wrote: > > > > On Wed, 2 Apr 2025 19:55:14 -0700 Alexei Starovoitov wrote: > > > > > Partially revert commit 0aaddfb06882 ("locking/local_lock: Introduce localtry_lock_t"). > > > Remove localtry_*() helpers, since localtry_lock() name might > > > be misinterpreted as "try lock". > > > > > > > So many macros grumble. > > > > +#define local_trylock_init(lock) __local_trylock_init(lock) > > +#define local_trylock(lock) __local_trylock(lock) > > +#define local_trylock_irqsave(lock, flags) \ > > +#define __local_trylock_init(lock) __local_lock_init(lock.llock) > > +#define __local_lock_acquire(lock) \ > > +#define __local_trylock(lock) \ > > +#define __local_trylock_irqsave(lock, flags) \ > > +#define __local_lock_release(lock) \ > > +#define __local_unlock(lock) \ > > +#define __local_unlock_irq(lock) \ > > +#define __local_unlock_irqrestore(lock, flags) \ > > +#define __local_lock_nested_bh(lock) \ > > +#define __local_unlock_nested_bh(lock) \ > > +#define __local_trylock_init(l) __local_lock_init(l) > > +#define __local_trylock(lock) \ > > +#define __local_trylock_irqsave(lock, flags) \ > > > > I expect many of these could have been implemented as static inlines. > > > > Oh well, that's a separate project for someone sometime. > > They need to be macroses otherwise _Generic() trick won't work. Ah. > Thanks for applying v3. > > Do you want to take "mm/page_alloc: Avoid second trylock of zone->lock" > fix as well ? Added, thanks.