From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14A95C36014 for ; Thu, 3 Apr 2025 03:12:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C81EA280003; Wed, 2 Apr 2025 23:12:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C30E6280001; Wed, 2 Apr 2025 23:12:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B1F8A280003; Wed, 2 Apr 2025 23:12:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 93EDD280001 for ; Wed, 2 Apr 2025 23:12:54 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id BF91258A43 for ; Thu, 3 Apr 2025 03:12:55 +0000 (UTC) X-FDA: 83291260710.28.C9D8C8E Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf15.hostedemail.com (Postfix) with ESMTP id 24D37A0003 for ; Thu, 3 Apr 2025 03:12:54 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=YJE0OOvF; spf=pass (imf15.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743649974; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ug0Pi7rCdQWMQkHlpNkgj0aL/LY0NPMFhKI0PzGBQkk=; b=MO4kX1PTOYJpVP8QPBeTeMcygH0z38E86ZekxA7oZ8zeX5sdnI7AG6ML10MGa9+Ow5oPJe CEe+XGiR2VFKcpaJo/80LoUcLA+X5zbeGu54nTzlU2GcZmH1vh/3SV5kg7zuv7o1+wJLh4 F9H8IDFNOy9aIlRHU0p7uGJJpnmTW30= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=YJE0OOvF; spf=pass (imf15.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743649974; a=rsa-sha256; cv=none; b=3GP4b1qWZFDj3glmm41QkdbHeWEsV3loe/kndI+TAzmHMxWgJ7gRn5dPYhO6Inbzr9RDwW X1xWLGITDwN2JoObteWwBBxQG+LB/DKgQ9GTOGYz98Nh2CCWCvf8/gYiqdbAEssu5+pjQh oU8uRMO3l+nOJMd+E+QCH7U4s3SUIH0= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 7802FA41F4B; Thu, 3 Apr 2025 03:07:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8A2A9C4CEE7; Thu, 3 Apr 2025 03:12:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1743649973; bh=1xDAv7xNFkDp0p5nPVZCofADwxBSlY8y96TWnOtMZmw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=YJE0OOvFUUtYU9PfndqJ7H4TJj7zfhe/IQzBoknRXzTeAO/UVpk9G9qej60jXRtdj KSjXVGGSTYwnY13G81URc8I54W4146W86tqSrwCDEjQGU3W008TeqVZB5MPMjPNpaO d6EIkaDkZPy9WBdsQl4lFQq+bmbEhOhl/1X+SaFI= Date: Wed, 2 Apr 2025 20:12:52 -0700 From: Andrew Morton To: Alexei Starovoitov Cc: bpf@vger.kernel.org, linux-mm@kvack.org, torvalds@linux-foundation.org, daniel@iogearbox.net, andrii@kernel.org, martin.lau@kernel.org, peterz@infradead.org, vbabka@suse.cz, bigeasy@linutronix.de, rostedt@goodmis.org, shakeel.butt@linux.dev, mhocko@suse.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] locking/local_lock, mm: Replace localtry_ helpers with local_trylock_t type Message-Id: <20250402201252.8926c547a327ce91c61fd620@linux-foundation.org> In-Reply-To: <20250403025514.41186-1-alexei.starovoitov@gmail.com> References: <20250403025514.41186-1-alexei.starovoitov@gmail.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 24D37A0003 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: p165cq18a1q7utafzkmhgzs6odd4qhrd X-HE-Tag: 1743649974-667508 X-HE-Meta: U2FsdGVkX1+SM06lzDs/bxXtT8YTIQVI/tJtrQuXKzbgOwBwF9/xevEU4Ao8fFLxYy5cjVjdI1dl88ztblctMt3lYvI6K0M+NJYeWGlAX9lObWlgm6qVgLjILXuTBYVNu/zSRMN6kEZYHYajrrSfZ/wpaJs+Yn9W/cjrBDqh21iGdckRJnKmdPYcg/UL+q+X26pPXuNmbxiT+dJ4YKl0obYUDFkKuQnqgDhdIaWKks7bt6SYtdgXHxOE+8RUQWLKR1us2eaYL8ku3UwA4FdnYcpa05cbSksbbMYSuNDdqvxUgOjs7U0zVcStnML27/cgC3nbn59IDL7z/1ltrfzztCj16JUYXFf5M1il7laoeQzI2cklQ9UmSwRFI9lXhNFVsu0RACAbBDRwFGWkKBVjnO42/PaCyjlRoP30Hq+syBazyqGrxXsiA8X29InmCiyWlw/z/hnn1+ro+EJWdiHIG6oAHq+N9drdGTEHuwhIRz642ybewsnLZJUP3Dn0NCXOjmPuncqkViMfOtne+Hosn23JrFRzQdmFP1ZiRDFIG5ALDamSpuyFCXjxJTFY067eOdPFw/rEicGEhuunkD3Nam3kWuLT/piwNp52M0nlFV/6MgFzPtnnzPRvbU0MEKX5URNdy6qn6XIQXdGxFullfyt+90uqgoffT6gWc2PB90Ktasaxc5FPm0Sk39ZbBB4JlYjHRNmHgEitgGOKMYnknqXeFPrzVFRZ4ziiQie4hlfGYC37iHMiG0PJ6dp6yyczfolW6XLPpYYOTbOd2H+32DrfNqNwwIYQ6VLrJeKICzHt8I4XUPflnyuiVHdfVe94vC/L7bHaNgLDjCFHfgubp/aTLNWMSoeQ7oetleHQLSMB1UVVj3PLjQugA8HlNZm+k41UiF3pMPPKy1sZQEda3R5nEap/m7ZhRAkSmKAe4f2JJSKtIdhTeSvhg/OQfUx8ToueiLM/7bbwlpPayc/ M8uDrOHk svWNo8iQrZ5nwzSZpxIWdKa1ap3CBCbXtX6531txD6sEPU81l1XbZNqSF8JQ+6JgXedOM6Hg8FVtzsBBWIE3KtbxGfBzk9HceAV2lViH+n5ext623913Q3WFWaLv3hx3qyl3yjIMbhTvWkFJkurOGDS3AgMl3XTTY1FzMlw9cpszh1JbRaWdPvsPZHhYeXCVbD/r96NXqgzpaUc7B+kc0ueLZeshsFXJkHWveGD8m4I2WzPlHKKkj8JiOsxap3n4UzUQL/b2Ux71UyJfWS/N8dsyAfYL/Y/fmexfrRrbADwb/phn5UDkPn2UVKykDdqLFb5HDA34ofiobVUlZus72Nt75JBl/LG7W46Mb04jk2+F/tkHPnfSdSugK1lv5uiJXnPWpNFqKOrxolaQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 2 Apr 2025 19:55:14 -0700 Alexei Starovoitov wrote: > Partially revert commit 0aaddfb06882 ("locking/local_lock: Introduce localtry_lock_t"). > Remove localtry_*() helpers, since localtry_lock() name might > be misinterpreted as "try lock". > So many macros grumble. +#define local_trylock_init(lock) __local_trylock_init(lock) +#define local_trylock(lock) __local_trylock(lock) +#define local_trylock_irqsave(lock, flags) \ +#define __local_trylock_init(lock) __local_lock_init(lock.llock) +#define __local_lock_acquire(lock) \ +#define __local_trylock(lock) \ +#define __local_trylock_irqsave(lock, flags) \ +#define __local_lock_release(lock) \ +#define __local_unlock(lock) \ +#define __local_unlock_irq(lock) \ +#define __local_unlock_irqrestore(lock, flags) \ +#define __local_lock_nested_bh(lock) \ +#define __local_unlock_nested_bh(lock) \ +#define __local_trylock_init(l) __local_lock_init(l) +#define __local_trylock(lock) \ +#define __local_trylock_irqsave(lock, flags) \ I expect many of these could have been implemented as static inlines. Oh well, that's a separate project for someone sometime.