From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 766DAC28B20 for ; Wed, 2 Apr 2025 16:45:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F3F40280003; Wed, 2 Apr 2025 12:45:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EEDB4280001; Wed, 2 Apr 2025 12:45:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D8F81280003; Wed, 2 Apr 2025 12:45:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id AE07C280001 for ; Wed, 2 Apr 2025 12:45:00 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 073781A01F3 for ; Wed, 2 Apr 2025 16:45:02 +0000 (UTC) X-FDA: 83289678444.16.4145BA2 Received: from mail-ot1-f74.google.com (mail-ot1-f74.google.com [209.85.210.74]) by imf19.hostedemail.com (Postfix) with ESMTP id 227221A0004 for ; Wed, 2 Apr 2025 16:44:59 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=phB04r7L; spf=pass (imf19.hostedemail.com: domain of 3imntZwoKCFk381E7PL1EC7FF7C5.3FDC9ELO-DDBM13B.FI7@flex--changyuanl.bounces.google.com designates 209.85.210.74 as permitted sender) smtp.mailfrom=3imntZwoKCFk381E7PL1EC7FF7C5.3FDC9ELO-DDBM13B.FI7@flex--changyuanl.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743612300; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VuzG4R3fGEOVCAcfPoOTUO+6ntcv0bfx+Pvn/LkzyGI=; b=Xk6qbC1Rjb5NBLG+sx/ek1t+ajht1GoQy+fBwV/+6oPNZ0Cb8izb4y+Dwc4UJQ5jIMf3ie UbOkibC2kCwJhHYB90YpOrc3a4lwoQdTzuptiquvT4ZmJV+8tAiQn6MVSNG4lPCVACrQtm TDyJLzlzaEyCx3krl70vRoFGdk9CPyQ= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=phB04r7L; spf=pass (imf19.hostedemail.com: domain of 3imntZwoKCFk381E7PL1EC7FF7C5.3FDC9ELO-DDBM13B.FI7@flex--changyuanl.bounces.google.com designates 209.85.210.74 as permitted sender) smtp.mailfrom=3imntZwoKCFk381E7PL1EC7FF7C5.3FDC9ELO-DDBM13B.FI7@flex--changyuanl.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743612300; a=rsa-sha256; cv=none; b=ezgLkva/dinEiGtJf9DSsK4gQM+J8Ic2QYMSSXPBh/7BqUeTno4jVoNj4mUL4Flce7lI8f mCWa016dneaKRN36B21Nx38ZTiv0IfCv8AN20UwMogTBF7EmtOgOeBhkayNBDdQypnVl/i HcJXugHuYKBVOS58inIZHVsC1GDTYZU= Received: by mail-ot1-f74.google.com with SMTP id 46e09a7af769-72a0de193b2so63092a34.3 for ; Wed, 02 Apr 2025 09:44:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1743612298; x=1744217098; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=VuzG4R3fGEOVCAcfPoOTUO+6ntcv0bfx+Pvn/LkzyGI=; b=phB04r7Lp72G9+vR+o4Uihhf3AvUF3d6EO27wEqBQ7H8PUTa0ytfQj89rvdfSWZj11 D5ly6GoSNTBV3g/f2tFKggXF1bDkBI7aC7Z9/naolFOWUECfZ8Cw1dBK11Qfh1rlXIV/ z5S03z2Ez4J+dSE92JDTLNoQqQv2FCLdGx96N6P1LPv21E/KN62MFAAqx8ruHwP3tuB3 rt+oQ+DHZJ6pteA9OJNF6vRWKRwP4y0yyqo4UwFND61dxWBJiDPVPXd3wBqc/cuTz5zk rdttP2DD+0kDKaIzp98c2UsdP17wWCf5sQbAZVvchrPidTSjBxW0Wf5K4Ub4dsJ3cuyA ewyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743612298; x=1744217098; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VuzG4R3fGEOVCAcfPoOTUO+6ntcv0bfx+Pvn/LkzyGI=; b=DjPt7fOTXX7QCCN9BTKv6hOsRLqMddyVH+uPNXuFbhNrSDSn3wRaFk0ueQR8jzxPdz IDXNybHJv/6pxaNaPwsTelActcogC6u9fYZ5l0icsgfu9zD/SZRM31H/Ba9CYk73glkb lzM9ZqyxDVg5D66GFFGcqOaoKwu15HatlgmXoLjw5w8X3cVweZ4sU/JcD4QpebldoJag xlpoRlctXeF70pIFc6+opm/mWZjkCxGGSvuIhaXMz4QVrfEA02ennEUXl6JJNsywcgEU PoMmv0S1YBTXNi5QJ7lu4dN+brlXBKVR1HZ0m9POXoO9TSLOYE6wbunN7cf4xknkt3n8 NHgA== X-Forwarded-Encrypted: i=1; AJvYcCXm73jEkfyrBesQnfDz/Cb8v6ZRMxN1oJBbYGYaJWKm4Yy37F7+CE6fFDx9HWOwgZgkP7VOXJitsA==@kvack.org X-Gm-Message-State: AOJu0YwVpOlOwKs+fzIT+3nZIEwPNZGf+6ExwRDSSuSM7//hd06C3F23 eDN1grXxjd51LIVhFeakSt1PlW5/ymOdK0OuNV6/ONzF4UT3caDPTPyDIZtb85MfSMazPIjIaZg 6+k9fTBxnwaocKyPI3g== X-Google-Smtp-Source: AGHT+IEtfiQ81dhFjIlo1nhzzYpS6z7yTo9b5I2hiuFriTAYh9htxtNtSS00ENc+Qm/R9+CszjB93qxoNQJ5CKjh X-Received: from oacpy11.prod.google.com ([2002:a05:6871:e40b:b0:2bc:6c19:c219]) (user=changyuanl job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6830:2902:b0:72b:9f90:56c5 with SMTP id 46e09a7af769-72c6382cde9mr10771860a34.17.1743612298587; Wed, 02 Apr 2025 09:44:58 -0700 (PDT) Date: Wed, 2 Apr 2025 09:44:53 -0700 In-Reply-To: Mime-Version: 1.0 References: X-Mailer: git-send-email 2.49.0.472.ge94155a9ec-goog Message-ID: <20250402164453.2470750-1-changyuanl@google.com> Subject: Re: [PATCH v5 09/16] kexec: enable KHO support for memory preservation From: Changyuan Lyu To: ptyadav@amazon.de Cc: akpm@linux-foundation.org, anthony.yznaga@oracle.com, arnd@arndb.de, ashish.kalra@amd.com, benh@kernel.crashing.org, bp@alien8.de, catalin.marinas@arm.com, changyuanl@google.com, corbet@lwn.net, dave.hansen@linux.intel.com, devicetree@vger.kernel.org, dwmw2@infradead.org, ebiederm@xmission.com, graf@amazon.com, hpa@zytor.com, jgg@nvidia.com, jgowans@amazon.com, kexec@lists.infradead.org, krzk@kernel.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, luto@kernel.org, mark.rutland@arm.com, mingo@redhat.com, pasha.tatashin@soleen.com, pbonzini@redhat.com, peterz@infradead.org, robh+dt@kernel.org, robh@kernel.org, rostedt@goodmis.org, rppt@kernel.org, saravanak@google.com, skinsburskii@linux.microsoft.com, tglx@linutronix.de, thomas.lendacky@amd.com, will@kernel.org, x86@kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 227221A0004 X-Stat-Signature: zwezjxifyy84u1uqhhexd6se4jxjj4em X-HE-Tag: 1743612299-669823 X-HE-Meta: U2FsdGVkX19dpAgJo/8iyq+dgbjADTjxLQ1UK9SSMMjurWMfYO1jnF0e3qsg+sh3JjMv53kEMAvK/Lo5ji6W60voWviqLKteOMQIAhN86VVCe3OoG8qynp81DubeC6fvV2N0V0phGj7yl902t6IVo7jEERk2UmAyq9hTQ22vHmx+v9deYDvedjUyDMpsr2FkWsgPzxuSdRXRmkPWTqwuSLdmKuJTTiKOX8b5jSEvcm8hqxQmNluKqM4iysTHs/9jbjixCbPwVsJLUFj/JmJw80Iy5ZSWGBdCX8ZHv6gKr6BYp4NrqwSvr16VjUFWAe08ea9MdhNYOqslV2bPMkQQeWRqpbzVddrXZ4c8ezli/kjb0xKwftFveTBG7DE8Az80bhzvMxH18VRWrF8CyjIgxKA9CKdFYxup476tiwOfshS1NOD0aGz2Sja5xatdQzV3e4fL0w83wVwx2wUr98XZAxadKMhkn3AmaWJGqq9m6dcRQunaZFnd0zj9xx3p7GFziJC9lZlH7wG5X2uuuxJu1oV0Qrb5t34PrbOz4F1AQk/2CY/RIEH/deAveIzojX7kCqYi9LMOhSvbnb9naucQRCgPC6X9YonwWBmV+/xcmZUNiCPmIrEN+cDKaFdkT1mIvnJU2fSSClb+6rO46xUk7hxpfUR4Wed4PNgDUmWW9e4zxMTrkZTyBO18Ap5KWc0TODRIfCQNlbXjH6cGDHuqgsJv8h/cyWhTOVQjtk/9L1FJBVMKqLGejk93L60PbayMJEPV9Yu11/S/e0BJyunS/aCKxQHKTS2VNNWpHgIEzeMtcj4jEJVkBBpZ1ztGJYfq9ytxtHHvIgnixIK+8BiUKTNMQ4EVyfokXPRydjMzS22wMwcY0p726c+qskifMtLz8kApeh4NiN96a/xTxtDoMmntaWcguSZQNRG/V37I9yjYfKgNk87zeL8CVX6aYFqCO8voodtxMA4mnKw+2Or YBE5yl9m F0fXh2qQKKADsxxQP5hKZFUaZj1V9PNXxVMiG0tHJ7rHuicdB3U+jyitocnzZBv99e7gnvL0Yx6LIgunVZAMvcuuBoD3eeskuM+2Wa/DqpXoAb8MeNx1EOdcLrWVQzcCQP/+4jaRJg/ZNcwGE8ypBKVUeeLZdLYzDOaiz2zCZuiXeBBLwLmW+reQEwjI+wOsvcSiA/8Jf+3OtcuVORRp9CfOgyDYWIkFkqCFAOgjs34VaPt4CxTA70t3itByM6qoaq/bkce+QUE9zO5aRFtgpsY0i3oy/Yv0XwBTApJ+jamj0ln+wBNuOiMj75sY3xYkez5XS01p152ctxBYUvGGAwUphG9zBc+Tp7xHSwkeEy32LhH5ZvwCUEN5j5EVQVNU0xjBF+CjGVRJhqH0/gdu1I/uIF6cyzffHuUvXFTnNt2vxZAJPiTyehIkbFlda/oOu3QbGWinUq99dRHB8d1ag7ybZkZB0cGWKB+ka9l8/Q2lbvtVQRCxfbk9Ni0bd0OEta8A/R7Pp99XR6T4s0esGjiN2r3opVyPSWnhfDVfpCtVf+XRwcM5QZWV/y6nQk4ltlOALwSPFw13ssA9bfZnjT37uYt/EkOOqYOYQ4Do0Yx3VvxYsM29jkQBTYl15hi/OY6IdsKM1pAQmcjHclgwAVbmCCOybOHR5BOMh X-Bogosity: Ham, tests=bogofilter, spamicity=0.000241, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Pratyush, Thanks for suggestions! On Thu, Mar 27, 2025 at 17:28:40 +0000, Pratyush Yadav wrote: > On Thu, Mar 27 2025, Jason Gunthorpe wrote: > > > On Thu, Mar 27, 2025 at 10:03:17AM +0000, Pratyush Yadav wrote: > > > >> Of course, with the current linked list structure, this cannot work. But > >> I don't see why we need to have it. I think having a page-table like > >> structure would be better -- only instead of having PTEs at the lowest > >> levels, you have the bitmap. > > > > Yes, but there is a trade off here of what I could write in 30 mins > > and what is maximally possible :) The xarray is providing a page table > > implementation in a library form. > > > > I think this whole thing can be optimized, especially the > > memblock_reserve side, but the idea here is to get started and once we > > have some data on what the actual preservation workload is then > > someone can optimize this. > > > > Otherwise we are going to be spending months just polishing this one > > patch without any actual data on where the performance issues and hot > > spots actually are. > > The memblock_reserve side we can optimize later, I agree. But the memory > preservation format is ABI and I think that is worth spending a little > more time on. And I don't think it should be that much more complex than > the current format. > > I want to hack around with it, so I'll give it a try over the next few > days and see what I can come up with. I agree with Jason that "nothing is ABI at this point" and it will take some time for KHO to stabilize. On the other hand if you have already came up with something working and simple, we can include it in the next version. (Sorry for the late reply, I was traveling.) Best, Changyuan