From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE41AC36018 for ; Wed, 2 Apr 2025 22:19:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4E249280004; Wed, 2 Apr 2025 18:19:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 49145280001; Wed, 2 Apr 2025 18:19:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 38099280004; Wed, 2 Apr 2025 18:19:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 18AD2280001 for ; Wed, 2 Apr 2025 18:19:43 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 91CC8C0930 for ; Wed, 2 Apr 2025 22:19:44 +0000 (UTC) X-FDA: 83290521888.23.0687856 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf24.hostedemail.com (Postfix) with ESMTP id C38F1180003 for ; Wed, 2 Apr 2025 22:19:42 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=MN0rwul8; dmarc=none; spf=pass (imf24.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743632382; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FhIivHD744EadMwn81wLmWBDhYmvzSC7eqCWQNrAHdk=; b=LRbz9eVSMcIBC2Dqes2vIXWGBWUUQOwlkVzQUeG1flyRwC/syqNDG/0oIDUNulabVB1ZO3 8QqqEI3LgQtkr2E1l4VwMQoYOHW4kCJSsS0W8Wkk/iVpCmWk8KHwRFPi3SzR1b9wyNn28P pWuBWHDYy5p/G/DORJQxscJbyGsdn2k= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=MN0rwul8; dmarc=none; spf=pass (imf24.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743632383; a=rsa-sha256; cv=none; b=W4ncLnGgBrYmc1h6LipqlLW9g2Q/oYAdFBIveM9lH+mmn/IhfsTLW5AtKkL8bophrXR7W/ ctUXkw3xNA5XHBhiVN/QC42nbrxTxiBLJKsPVAgd+rSyG0lP2aGbMz4LXNJJy1ngZ7VxcW zoo+qA+RtoT++GLVf/VxTJoi9Y5DsPg= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id CDECA5C6B83; Wed, 2 Apr 2025 22:17:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D6891C4CEDD; Wed, 2 Apr 2025 22:19:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1743632381; bh=wPsvqq2TSbIuz1MPM2VtyP0iPPL9yl5M+hWPehgLpqo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=MN0rwul88GP900T3ka3+dXtLjh8IwNNA9RT3nEWRa8o9B1lbXW5PF6oFB+Y5PaxEc cB0Ulv+iObS+6Y0OHvTHokSUx5zRS+Q/fbfSYkfG8SYFhRUS4XDMPm6+JWt6JQ+0u+ YcPFQ7Oql9WH35j4upaWbTtXV/UQjFcsL9gY5LxQ= Date: Wed, 2 Apr 2025 15:19:40 -0700 From: Andrew Morton To: Mike Rapoport Cc: Thomas =?ISO-8859-1?Q?Wei=DFschuh?= , Dave Hansen , Andy Lutomirski , Ard Biesheuvel , Arnd Bergmann , Borislav Petkov , "David S. Miller" , Geert Uytterhoeven , Ingo Molnar , Peter Zijlstra , Thomas Gleixner , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, Naresh Kamboju , lkft-triage@lists.linaro.org, Linux Regressions Subject: Re: [PATCH v2 10/13] arch, mm: set high_memory in free_area_init() Message-Id: <20250402151940.145c3bf65387b10735fe5c4f@linux-foundation.org> In-Reply-To: References: <20250313135003.836600-1-rppt@kernel.org> <20250313135003.836600-11-rppt@kernel.org> <20250402140521-bf9b3743-094e-4097-a189-10cdf1db9255@linutronix.de> <20250402145330-3ff21a6b-fb03-4bc8-8178-51a535582c6f@linutronix.de> <20250402181842-f25872a1-00f7-4a8f-ae6d-3927899ee3a6@linutronix.de> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: C38F1180003 X-Stat-Signature: qh13pfcs7yzisozx4sniuwjnon9w35da X-Rspam-User: X-HE-Tag: 1743632382-135190 X-HE-Meta: U2FsdGVkX18ZJbewhcZGvez/wOD5AnPzL2IHzETjihyxDa2zR1Z17B6WagcHXKEHhFRiwHAORsmy7lHqJ6Yry9DiaDg7DJvE9Nj5lT3+jRIigXd21+axP9EorPjHpSX3adnnMgOCHEdScw4JyFJlXxYeqSthbdMr1F5EjDQ7QKtWu9qEDZFEBVXj/hbUYbQhbYii46ttVox38kUtWU4ot7MDaCj2Qm5f08wro2JuNnPQACaQoP5LG1esLdXFbWaqHdtWsGiZqtPvrSK+l0wGgOxHP+1PC1HcOP4ab2DM+HTD19gaOrKmS2PDALozV0w9u8o4Rnr1pnxTQG9htKOJyUk9zZZuaJcs1B9U7vl1KQtYXeHOJU4vsi0GD/zLOvta1sZXx6kO0pCoD4k9dq8ohOAfyBdeTmOWib99O+Dvcia5QEeRrorVnS0pFgCqaEvarr/rDQAOMDwnKUVHMUfot7S/oKFAAqPg7fBUgPEqFoQXV+wwmZWNENNAg7EbUsEOk++zVZpMsZ23UWJhSa/d8tjV2+mEegGBDiLF88fcqKrbCEFxeGbWu2ZH1lsKK3UmpIxvqpcFAb/M6tui5s6SbfOlrs2nWHgayCo9CQMmWV4nJ45dzAuk7LoRXjIVzBiusmEYzO7kepgAgWrTjZmamQRqYFyy5zs1x+YkMvbW7ahsdVJpX7W48WRmciOZYTacWxjT70Mm8G4hZ+0kIPvnmTkNe8PfGBoXBOA9MZbeu0CXe+LhdNMW2xY+elbthOTDHYzCe75mszkK6rM8T6QZCAX69OSHVPaBChXKoKFiPmD2jIiXBPq4AGtWaPmrELTRtxpBCbXdvRsEM71FaXOTpcwlGE8uoA4ygCf4Z3XhZ5oSyTDGEeMhxH59qXWRu/BjFbANdDE1VbrXga2F2JEzhHjgAY9daw2FPwALsQdZs5+2YiFObLJQ4qQ2wo2DUEFJIrtWZ3R3BiLK7NSWQyM WgYAsC2v 4vxfXRgfZVIiC+M3KldvBfzOMlyRdAfUUH8CXU93MFxepNWYn9nDQse+UJENZ/0s8odFJtWvyHKY6lUwG6c5eJRGK8jY9rrzLDH/CKhfaoeGycGM1NV4UGVtDjpcivDsGK/nWJjhHRncw24jwvFBNX7UdQymogVfrClTCiDwwutFZ323ZccigbRSg93WdJRBUKusnnq+87gtPDfsIaGoXG2pqsEZcthJf7qKCaxxgJsaG/xcD3uzAGEzxlN3HOlBZCXP2OyTAiTDUrNHk6ODdcZJYqLuojV7ZJfFWRenvcAFs0JmCL8kRg/C3+h4CTomiaNT5 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 2 Apr 2025 23:18:55 +0300 Mike Rapoport wrote: > The proper fix is > > diff --git a/mm/memblock.c b/mm/memblock.c > index 64ae678cd1d1..d7ff8dfe5f88 100644 > --- a/mm/memblock.c > +++ b/mm/memblock.c > @@ -2166,6 +2166,9 @@ static unsigned long __init __free_memory_core(phys_addr_t start, > unsigned long start_pfn = PFN_UP(start); > unsigned long end_pfn = PFN_DOWN(end); > > + if (!IS_ENABLED(CONFIG_HIGHMEM) && end_pfn > max_low_pfn) > + end_pfn = max_low_pfn; > + > if (start_pfn >= end_pfn) > return 0; > > I've sent it along with the fix for x86 [1] (commit 7790c9c9265e > ("memblock: don't release high memory to page allocator when HIGHMEM is > off") in mm-unstable), but for some reason it didn't make it to the Linus > tree :/ > > @Andrew, are you going to send it to Linus or you prefer if I take it via > memblock tree? > > [1] https://lore.kernel.org/all/20250325114928.1791109-3-rppt@kernel.org/ That fix is now in mm-stable for a second round of merge window material. I'll send that off to Linus later today.