From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3568AC3601A for ; Wed, 2 Apr 2025 12:21:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E04C7280007; Wed, 2 Apr 2025 08:21:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DBFA2280001; Wed, 2 Apr 2025 08:21:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C7C02280007; Wed, 2 Apr 2025 08:21:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id A9E39280001 for ; Wed, 2 Apr 2025 08:21:09 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 3B9D6BB411 for ; Wed, 2 Apr 2025 12:21:11 +0000 (UTC) X-FDA: 83289013542.18.C341B66 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf22.hostedemail.com (Postfix) with ESMTP id 1DEA3C000A for ; Wed, 2 Apr 2025 12:21:08 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ubXR4d7k; dmarc=none; spf=none (imf22.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743596469; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=g6S1SZ66evHddI0d0mVypp923OoaFor/bIVE2U1Pgsc=; b=Y525dzqfx9cEM3gxuQM6shJJza62RvIQvgGFw+EFWr78MG0dpNyJK2GGqXOLNjzPqHQ3tA F8VDp//xOmyt8h5l3yYpuhEavAkJBUbBgpxF2y8PoyrqUVm50SLgiRrc59xt/ilF4bEa/R IsSD5fX+oPaVw4YI+i1qFgSPhTjDvlw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743596469; a=rsa-sha256; cv=none; b=slHoZpZoYaAHXgSFsOa74XQQ32UjTMu6D0aEMz7QnjYir7G5DxzqyGA0I82J4HBl+ybEaW 2N6g5A3fwcjiZvdqlxeV4wYY45YENsOwrVD5ymKdvkc9wxWecZmWEhBaRdzKagWBpJWJqs EGRa6P+7xVNtCQmU7Cjt88qt+ryVgZI= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ubXR4d7k; dmarc=none; spf=none (imf22.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=g6S1SZ66evHddI0d0mVypp923OoaFor/bIVE2U1Pgsc=; b=ubXR4d7kUAA/nRulsdV6sYIsTB +PDpjYSpFirN3jL4jd9bRMNf0XfhGpR48ZyEjANimmVSMWEEKF7JDwybsWeISvFuyotquqibaFWoB jbGxsmk0VB3P3u2FcbGBpf9OpnFFFPINRHQcS/rR+Fj4a1KYNQWD3WWoVpXuQNyI+yj53O0Q3ete9 xUwdzFsxTtV3DBENz3QyglkvwnEGH09ROHpUe8HFAIyNr+N1pCXa4mzhCQFkhClpJyB3OFsPDUIso PdqbLUIi1wz/xgrTZ968kjFaLEIBCk/d0FwYhkmGnOl2LrhsEne559XltLAvddTri0mdyOyJzvpjh YTDpBuXA==; Received: from 77-249-17-252.cable.dynamic.v4.ziggo.nl ([77.249.17.252] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.98.1 #2 (Red Hat Linux)) id 1tzx5c-00000009RmX-34Nr; Wed, 02 Apr 2025 12:21:04 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id 5614130049D; Wed, 2 Apr 2025 14:21:04 +0200 (CEST) Date: Wed, 2 Apr 2025 14:21:04 +0200 From: Peter Zijlstra To: Andy Shevchenko Cc: Przemek Kitszel , linux-kernel@vger.kernel.org, linux-mm@kvack.org, vbabka@suse.cz, torvalds@linux-foundation.org, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org Subject: Re: [RFC] slab: introduce auto_kfree macro Message-ID: <20250402122104.GK25239@noisy.programming.kicks-ass.net> References: <20250401134408.37312-1-przemyslaw.kitszel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 1DEA3C000A X-Stat-Signature: mjcmntbycm51991yt61qmbmwypuoy8bf X-Rspam-User: X-HE-Tag: 1743596468-507784 X-HE-Meta: U2FsdGVkX1/lYhDHyoBldNAp6AF3IGOhZzt4hTaflB/hGqusjOBR6chot6qOp5bcJH/CZeeVHWR2qjH9KmbgJL5nu/m17FmeBHZEj6TzY5cYYK8aQozpcsWkswM6WX2QZL9SDBeW6fuuXKNXaSU2y+9pbRAal6/Kmoan8JKFkkKlNEiqOmO4X0SiIIZeVJ2dPF3543SplPS4nccqfxUe/kQd5OY3ausrBQrbkz3PntXl4GH073H5RBqbCGPf3BTtnflSCgzvybz46YEBVI+ONLB24JsQ1OLTNTF4vjnEAXZCg9LYFC1AJhwYK4aWZt/K9Po013THfr0XVu4fH04Iyab04zwK4Y1GX93SU53dwOSBYrEaG8YTaANaSyf4B86VVEha6nuWuAKKA3hQCYuyXCv5JtIlv/8yQpDFhxIQCRhXcc6d8Sl/w3fKf6gwOyjJ/C4BaybQlKsaZEScu8Q+LGpiyO28Ymezzr9dOl/wcd4iWyJ8A1VQ7h5MmH83V9U7dDIlAIi3JsmErcAHeMjoJbIQFI8lW4iC5jr5iATD0yX1EtIJrOLTsHqA0XXTango2KFaCZ5MwCwOacDqBYO7Hak1vNL49pXWphDuhNAdrY4+yapXKQB2lYCNLEOso+zAYny1RZaGxclL+p6PIET65pmxuiWT0Lmem1xIhf6f+h/9M0cpg75g+dRjs2RndLqyWQrSzj2N7R0g7VrOva81kTsi35vMhxNgt27S/prC9wf5YpnC5WVz1Slu161wShoIGFiE7Pa/4ANfEjo8n2GEam/EbY9N11lJB5m3ZfSnQpHrguxrVipPmi2Tt0AiqEOAto4eQo/Wje0qH306rrr4tAEVixp5aJ4V3KE1sfTo1VtWvXk/Ycd/Dhu68CPaMM15V7TpFGnP4AHj5BjkRYzLpnz09IDf0irk/4qVnzDlruVCC0W6TFWeSvzR3DlT1S/Y2EoZONV+xY+iBk7Mzbq wWptVTnX 5mJk/o0nr+OYeK2PR3bHkbftJgedcx1s8jUeR7SyTNEzO97hGWNoj5eHWhY2Y9pwJO2S1wuz8meXL/VOJjl84iny/R2gvRpoOUKXysxPWtG0sMA7z1iIUfkGgRV6WFA7EihyrVZloa3FFVC7hr/smikjOiWOx2bMN4EGY/oLroHdwi+ldWHpB6U8UQrr6MTV1A9zkpFtug5xaUPLb1B0eTn+6YnAvt6BI/l5miwp3j//VRhE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 02, 2025 at 01:32:51PM +0300, Andy Shevchenko wrote: > What would be better in my opinion is to have it something like DEFINE_*() > type, which will look more naturally in the current kernel codebase > (as we have tons of DEFINE_FOO(). > > DEFINE_AUTO_KFREE_VAR(name, struct foo); Still weird. Much better to have the compiler complain about the obvious use of uninitialized.