From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1EEBC36010 for ; Tue, 1 Apr 2025 23:37:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DBE20280002; Tue, 1 Apr 2025 19:37:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D4464280001; Tue, 1 Apr 2025 19:37:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BE547280002; Tue, 1 Apr 2025 19:37:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A1999280001 for ; Tue, 1 Apr 2025 19:37:18 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 60F081609F7 for ; Tue, 1 Apr 2025 23:37:19 +0000 (UTC) X-FDA: 83287088598.03.B56D6B3 Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) by imf15.hostedemail.com (Postfix) with ESMTP id 8C418A0003 for ; Tue, 1 Apr 2025 23:37:17 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ggVwJ+be; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf15.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.45 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743550637; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=32sV3gxkOVS2t1uE8UFKDP3OeBd5mPhudUSUlhfeqhc=; b=GJrB0k3raczMpe6x+zgSC7J3MSgR5WcXz+Th++uqRQvAaKY7CDnsDpuWUGCMM3hcdvvj0k w9PvKLqJC+DZZDanMpdfFiG9yQlCgs8ZCtz1Von5voiFaxrGvAg6NDzIxEcuqrecZG/sMh mUi9I7JF/aQ8EY4wLFfAm/KXwn4VjGM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743550637; a=rsa-sha256; cv=none; b=Qoid2nx7XLMCMkIDsPhQLZYuc/Ndld00lpolQMnYDuEO0R4XoV1Nk3eMqSPEi305tppSzd NqUnGlBfsx/DvA7Q/L8RktkXA487fiEy36hFfACGEEgN+Yf27xBL7vQVKxJjA6nuyg2Iuk rDQMSke099ZcE4pAioSAusLC1UCVi4w= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ggVwJ+be; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf15.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.45 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-5edc07c777eso6344140a12.3 for ; Tue, 01 Apr 2025 16:37:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743550636; x=1744155436; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=32sV3gxkOVS2t1uE8UFKDP3OeBd5mPhudUSUlhfeqhc=; b=ggVwJ+beS5i58RyNCzXTccrVU9Zt7NYHefF5lC5CfTo9cYS8fZJjmUxWzIPAqUDgJW ZMtG8dYZU0EYs6gW8sOiyaRDljuMFZ4MZCmVXPguyLSrK6rVMWZtoHrLunfZ2rpmSKZe IqNC5o0ZC4TvI3pcnh54g7tr2qzMTSdG5bMVgG9qKFd70S3zC3H1v+LnOWORF6VILG5D cZD/jIK25Ov3CkdWuFKxB0gGF38M8C5biozAPOHO/jFHKXbmZ1H3/awnGeVTDo08VLb3 kgvs5nsE8dJ4zugWcuzRu/G9ZrSPQTlKNc2NW6hRX9lIeWpum32xEPB95ClU/037Lj2w 2xTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743550636; x=1744155436; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=32sV3gxkOVS2t1uE8UFKDP3OeBd5mPhudUSUlhfeqhc=; b=fKHCkhls4lR6EAjG3WjI6/lo4tScOVo4PVMEHfqdakBMdbbh0ZhgYmBWQ46yQ6I63E ySzWbgkBgUM5g4+IongcYIVt+cKmPcq/Ryakqa8k2kOfyNLPk45XlgN2ESyZ17dLifqO /jRM2uxcPFC+jlCc5JYkDbXzaCSNEJMgsvDHurVABwF8hAnZ4kkJttd85zHHwVpJA3GY +PjfG8H6n+Yb4VBFw+noazkEDNmI01wLUnBK4UuT+kTyBR/SDGatPS3nXT00PgLdmwIe mrbGWKzrULz1YNnjj9C22WFQxf1crRBagM5LUMNbd5SK2rX1xsDMf7GaDN5Q1fX5WwT2 03pQ== X-Forwarded-Encrypted: i=1; AJvYcCWxs3+5yd0rTwrzSgIZbUZcWBo5xw/Ob4BWd9nABdfHSPfZ1Ryz57y0BTySkcgtY3WLgecsYVKldQ==@kvack.org X-Gm-Message-State: AOJu0YyVQmEDzey0NwooQ8IF0RwnoQ5lkTZrhG2kV+zKn5W6Uag6dIH4 PrdA1x22z079bjnPLA6KAB0CuhxMAJRpcj7h6YLzk8Eo2/nwzbK8 X-Gm-Gg: ASbGnct7cO4f2fJakw/lXRIIi8zJ5dVYvozIapTAjlM4/rRYpiR2bKEZ/T/LYze0Qhw umBJyqO65TVnd2uOqa6zKYevL5rDtmAfrqfc6/SGV5U8aVpHBWShcIdPZxgwLoko6bwTU3/e/+R Ty0hkZlo8Ql3ONOiexNclgUh5w0dItl5KixD9TWbAfrQVqGJNQflnEY3izlsaCh2uBL9JGvrhk/ pqQRWBD3icJZ+ciWjH3h1QJGfT87OZbe1OfsSxD9hjrBzM0ns/bUHGXktfK96xVrF618f082gVI JMcm8Sn/jDSHHLxWPce0L7JUfVOXyni9Ez04MRu8jAJT X-Google-Smtp-Source: AGHT+IFfNrPUiPGPR9r4jkMzrfXR/EpAbwMqRMdBC0UbxOT31q6JYHjl8GeHk/TGs5We4HRzPvpJtg== X-Received: by 2002:a05:6402:90b:b0:5e0:8c55:504 with SMTP id 4fb4d7f45d1cf-5f04eaa7932mr300439a12.7.1743550635752; Tue, 01 Apr 2025 16:37:15 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5edc16aade6sm7656476a12.5.2025.04.01.16.37.14 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 01 Apr 2025 16:37:14 -0700 (PDT) Date: Tue, 1 Apr 2025 23:37:14 +0000 From: Wei Yang To: Lorenzo Stoakes Cc: Wei Yang , akpm@linux-foundation.org, linux-mm@kvack.org, Jann Horn , Vlastimil Babka , Michel Lespinasse Subject: Re: [PATCH] mm/vma: correct legacy comment in vm_[un]lock_anon_vma() Message-ID: <20250401233714.nkis7fhgncgro62n@master> Reply-To: Wei Yang References: <20250401094346.25200-1-richard.weiyang@gmail.com> <20250401114629.5wtk7jiv7e7ijvwg@master> <33729bb3-c561-4809-bb20-ca929f85c5e0@lucifer.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <33729bb3-c561-4809-bb20-ca929f85c5e0@lucifer.local> User-Agent: NeoMutt/20170113 (1.7.2) X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 8C418A0003 X-Stat-Signature: uuqp1cx1xmd9wypjusknjjw6tkwmnkyw X-Rspam-User: X-HE-Tag: 1743550637-116366 X-HE-Meta: U2FsdGVkX1+QdgXopZNOeGi0m/J3RQNHeWQLU2vvARCFburDwsHCDwDM28aZg8NIIEeqZbgpi9f/y61qBvVKOkYeJGCRVMufnT2iu/YpIGi3zkQsckBvbkow6e4vS2JeIUIhkHhGEkeTEzo7Tqg0rM9HTzlXyMD11/fT8MWyniSGj1gqtnKTqPH6Qu51dqOsOrbU0J4fu74BnmXiHkw+CO9LnehSEzMFU5Z6x2XRTSeXbVYqlgTohQBBEI9YnaCIfpo30ePkpRmfqjLxUBD3C8NpMZbTzfYuR/41DvuJF9gRxFUuwd57wlg0JMxMQ8dKM9qvHDZ0ISGHWcXjQOP2A84NQFuGa4zJ3WPM3/8LeQuOYEaKG3VeYHmtzC9jaTiCVRwfESKWN+uP9f3378GAA3ArMQpzCoIEV99uzLZnv13qd8/oHKDQh8GWasF/JUVlczoG1rn5DV24S4pDeZu6HAyovCpJhxLLgEbKWAiqCrSs6wmnvtga9kiIcpMReBV3U+/xHVbaj3zINVLjNllPXfDKYr6VNVX0IIS25kfF4JD/hCMPp/gZ+4qsiA2fWJ7EUmUvgGguoZUsfEhwl/4oD74/kH/lMLTbf7rQHCUMPQmUWjVKY/y1Jd4fv0rI5TQQ33mRLtZYuck0YCVuFCuKacwDqbNU1C2I07x0YrkHWJIRrj0MCG3FKcYJcM/DZcsLyaR89TMcQ4BRI9ZE+hwP38Un13lCxs0J+89twh9CfrsTWExV2neEbglZaoM+i28ig3Kmm/U3IZfkKza/LHKWDCtRTU1BuiBLIU6UJwo9t8Frhax06DRrAElDozwbA2MJ/scqkpli5D3qgT704I7hN5v746yTmXictF0CYYc4KL3Ve9pfe/Yfq7TSVla+Kn+4TIzhbbqqPuTeZSgW8jhQsJOGfxJIz7p05WSFRSNGiiCyaUeaXOLvHFAbI3Q/KK9jN/P2K8hRkekVYFFVgKg tbJXEXfb WBuqdUWQ3MORRT+s1RDIX1clCGo/S6I/9d9P7qhvA1AAj+fq2p95djfZAvXppHhzVm1CVUFU/5MT2DyXGjtt9m2S933EmLqK/khd58gWlghj0u14DHvudUVK1rD5uygjH21yJ5TxUzKWlhOerfVduJQO8cguSXHYRg8G7ONt0YYXWHYGinHnHKkTP+micJWrIJ3ZMisDyi0SRWa6xpSRROU8LvOzJr198akpZTYhjDVgGFCkI6lBqJPQ+KXR7Yx4Ghdqvim+nJtIHLOSyZGsb4fq7Nw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.233997, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 01, 2025 at 01:11:15PM +0100, Lorenzo Stoakes wrote: >On Tue, Apr 01, 2025 at 11:46:29AM +0000, Wei Yang wrote: >> On Tue, Apr 01, 2025 at 10:55:16AM +0100, Lorenzo Stoakes wrote: >> >On Tue, Apr 01, 2025 at 09:43:46AM +0000, Wei Yang wrote: >> >> In commit bf181b9f9d8d ("mm anon rmap: replace same_anon_vma linked >> >> list with an interval tree."), the anon_vma.same_anon_vma is replaced by >> >> interval tree. >> >> >> >> But the related comment is left behind. Correct it here. >> >> >> >> Signed-off-by: Wei Yang >> > >> >Sorry, but I'd rather we didn't, this is un-useful churn, and I am planning to >> >make fairly wide-ranging alterations to anon_vma going forward, at which point >> >things like this can be addressed if needed. >> > >> >> Would you mind telling more about your plan on anon_vma alteration? > >Well ultimately finding some means of representing this better _in general_ :) > >But you can see some early spring roots of this in the LWN article on my talk at >lsf/mm - https://lwn.net/Articles/1015762/ > >There's a bunch of patches in relation to this, the article links the >MREMAP_RELOCATE_ANON stuff but there's also a preparatory patch that improves >merging. > Thanks for your information. I would take a look. >I plan to do quite a bit more with all of this. -- Wei Yang Help you, Help me