From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A7BDC36017 for ; Tue, 1 Apr 2025 22:53:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 57F33280002; Tue, 1 Apr 2025 18:53:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 50926280001; Tue, 1 Apr 2025 18:53:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 37F44280002; Tue, 1 Apr 2025 18:53:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 169E8280001 for ; Tue, 1 Apr 2025 18:53:29 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id AFBB31A09D5 for ; Tue, 1 Apr 2025 22:53:30 +0000 (UTC) X-FDA: 83286978180.26.4351361 Received: from dog.elm.relay.mailchannels.net (dog.elm.relay.mailchannels.net [23.83.212.48]) by imf01.hostedemail.com (Postfix) with ESMTP id 36D6B4000B for ; Tue, 1 Apr 2025 22:53:26 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=stgolabs.net header.s=dreamhost header.b=jEE3WfX7; dmarc=none; arc=reject ("signature check failed: fail, {[1] = sig:mailchannels.net:reject}"); spf=pass (imf01.hostedemail.com: domain of dave@stgolabs.net designates 23.83.212.48 as permitted sender) smtp.mailfrom=dave@stgolabs.net ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1743548008; a=rsa-sha256; cv=fail; b=xDXzDUj+XeNw+kK6zQXZsDflQ7t+qDjURkGRJPajWhmtLApEM/8jMb2Y0TjaoAaV63aeJl F8lHlMkfL+TRgo4sEFENut14MSoCODvaB8vmZnk64OZCIcmxwJggAVEPydjI9Mht+VBbvp 8Yp/eHG9U4W4E5BeA8f/mb6qBtfuShw= ARC-Authentication-Results: i=2; imf01.hostedemail.com; dkim=pass header.d=stgolabs.net header.s=dreamhost header.b=jEE3WfX7; dmarc=none; arc=reject ("signature check failed: fail, {[1] = sig:mailchannels.net:reject}"); spf=pass (imf01.hostedemail.com: domain of dave@stgolabs.net designates 23.83.212.48 as permitted sender) smtp.mailfrom=dave@stgolabs.net ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743548008; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9qcEjBI/jntNKbsu31QIldbh3WSFsiDqWDYrQyuc12s=; b=cZN57aW4Z/cDMVjWsLekPSf3+3WYTj8Vz17T1tofpvwqBvNpm6ymr6Z1Z/Sb7i3k0avPGu A+suofw36/TkD9flixIZv/JI+qmMiTD8/eRVWCpoZncGHDiOba/inm+fz9PMou6Vbj3BPf dRiUv36ZiKYlOkG4PXzwivp2ERceUbw= X-Sender-Id: dreamhost|x-authsender|dave@stgolabs.net Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 0416B162AC6; Tue, 1 Apr 2025 22:53:25 +0000 (UTC) Received: from pdx1-sub0-mail-a226.dreamhost.com (trex-8.trex.outbound.svc.cluster.local [100.103.0.25]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 51EEF162750; Tue, 1 Apr 2025 22:53:24 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1743548004; a=rsa-sha256; cv=none; b=3uBL9qnv++k8OpHa3PgBEJwvJ8U8AHgXv6FgTzuxLlV9Yz9mSQooQ/E/6kXTVXMf/DAGl9 e4h0H3K5YLCr2EmyzFXKHigoInalvYimoQmMPUjaL+BQlermGDaeQ37S6RfvLSqA8rCqkU zUF4EtnShqpS8FNZGmZP3Ia1W9F3YI6eWf4Wb6mWfY1/cCDrK3q2Rx9/6iXXHEmG+3bGeG HkQ2FxJ4G9pHPBFcMgOaBrhcESp7PvHeN05/W1V9t+94So07eE1dYj9D8PJ1ff1G6oXSkc 3pABELere2SuHQ75Y9ZaESdRsdNovzp6dF+l2HN7LHwdBmr4DZmQ/JNBFfI+mA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1743548004; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TmEuivAsrB2aUlVpouUlJVZjbNXTLUQDImWDuTkDTiE=; b=EUDX5hcTIpCjSjWuDLS1bAtxEVSoQYmONtVM60aiC50tUQL9it6HRJ71WBIRMd47xsykXO DcsAuqfVpe4gWqe5LttB84D3b+H0omYanZicXole5+kXpbaj8yXdlNfbDl24vJaWaExvPQ WFjQ7rNSx5soh5TmqWKpwDPth5hcgbXF75gTT8Yq4+e3GWDDz+zgaWOqO5/aDVt4Umv6Go s6U/xvVGdWYiKKev7ky0WfNOmSzj8C4sfu1TnrqVguNkWd6UamvfrEWOKZYwkiWLNohmXO tc3zzhvy5KjIKNQZW/hDL7EDGELL+9WggXDY5vocIZIBYuP75bMcqALUw6Eazg== ARC-Authentication-Results: i=1; rspamd-85757496c5-g86gm; auth=pass smtp.auth=dreamhost smtp.mailfrom=dave@stgolabs.net X-Sender-Id: dreamhost|x-authsender|dave@stgolabs.net X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|dave@stgolabs.net X-MailChannels-Auth-Id: dreamhost X-Language-Tank: 20dc4a942d884c8f_1743548004812_1395248438 X-MC-Loop-Signature: 1743548004812:471694618 X-MC-Ingress-Time: 1743548004812 Received: from pdx1-sub0-mail-a226.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.103.0.25 (trex/7.0.3); Tue, 01 Apr 2025 22:53:24 +0000 Received: from offworld (ip72-199-50-187.sd.sd.cox.net [72.199.50.187]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: dave@stgolabs.net) by pdx1-sub0-mail-a226.dreamhost.com (Postfix) with ESMTPSA id 4ZS3FH05k8z3p; Tue, 1 Apr 2025 15:53:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stgolabs.net; s=dreamhost; t=1743548004; bh=9qcEjBI/jntNKbsu31QIldbh3WSFsiDqWDYrQyuc12s=; h=Date:From:To:Cc:Subject:Content-Type; b=jEE3WfX7ryEyDJ+B+hP/VQtq1AmS1A086BXxaSLLxgQPAYUOB9sBLuN8C1EOrPYkl hClS6qK+RComUqXTJnBnPjJWa4K2EYYYiOcPJ5suRivi4aJ45jEl4+VBnSypdzeN2o JYt8+t3eqPtkr8E3djYUEFvuHUpfoi5FMGP4pbkbQ6BnxD3PDPWnnWmWvnPiol6G0+ 9NsiCuyHL6HVPdalEwA9BkMAMntJ9g6lU3PP+vfCDS1UlA5pf3fLdqnQuWuMZ9Tilh aFN8u5+Ty9KzStqDO9veLzF0eVsWd/4GmE8bO+/3rurk4L4K0HUGzjcLm4YsYlxbce DxoyWwNC985vw== Date: Tue, 1 Apr 2025 15:53:20 -0700 From: Davidlohr Bueso To: Matthew Wilcox Cc: Luis Chamberlain , brauner@kernel.org, jack@suse.cz, tytso@mit.edu, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, riel@surriel.com, hannes@cmpxchg.org, oliver.sang@intel.com, david@redhat.com, axboe@kernel.dk, hare@suse.de, david@fromorbit.com, djwong@kernel.org, ritesh.list@gmail.com, linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-mm@kvack.org, gost.dev@samsung.com, p.raghav@samsung.com, da.gomez@samsung.com Subject: Re: [PATCH 1/3] mm/migrate: add might_sleep() on __migrate_folio() Message-ID: <20250401225320.uee5as2bmw4p6ygl@offworld> Mail-Followup-To: Matthew Wilcox , Luis Chamberlain , brauner@kernel.org, jack@suse.cz, tytso@mit.edu, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, riel@surriel.com, hannes@cmpxchg.org, oliver.sang@intel.com, david@redhat.com, axboe@kernel.dk, hare@suse.de, david@fromorbit.com, djwong@kernel.org, ritesh.list@gmail.com, linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-mm@kvack.org, gost.dev@samsung.com, p.raghav@samsung.com, da.gomez@samsung.com References: <20250330064732.3781046-1-mcgrof@kernel.org> <20250330064732.3781046-2-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20220429 X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 36D6B4000B X-Stat-Signature: fxs5imiz9d5cgs7dyok11cucz3azbcnk X-HE-Tag: 1743548006-344936 X-HE-Meta: U2FsdGVkX1+E+quDZWJyNVMXVS2OjsLSh7//8umn2h13JbXL7xDz7clogifffJTZ4m/VB5/r/WvIy/tRshxGuzNqbLmIxZp/joWK0qIH3+cRLSYYSMTq0z+KKWlPwf6ir6hw2NJs/47XtR5h9t1KZLYSPgFY2dU0skqsGyRG2dkB9Q1qBirfXZB2juDMrtVZp3eDsNEkFeqNxVirz/9Ax9eD2bK3dMU/HuTiIPrvNDqZUtYGx7zne7Aeh1fabci2xOOAaBf0yLkzb1reYllnZoQ+4A7GWheoQEwy6PgH5wpXEz2HWcgSlK+0h/zPQ2w+cNCkY7f5c632Ehzu1qInZh8a2XJcUr1nxaUKi//mzqcnV/jvFOHlaNAcqs6N2I2g1kO6e/BB9u2ylyolRf6gNZx9oIIYWBai0UNqV0dMvprfCbpXSaCZEqG4zW7xjHj0kfCbW2zeud1TLhdhjUBv5tCQkx4pSiVfGsGJwtNfBe+/bHSgsv8wdSYePnQbC+trYvgLGN+SRXYxpZthZ4gm5ARHKi7ihgKwz2ekIEXToftrhy94h3soTcMJ5tAE2Lsw94kP/4f+U2boKd2mWNOKNqtYrKq2yocaQHDx9KSA6UvpLnSp88XEsVbk/GK+loQnqO5sCwmihZODnF9i8mMum+mDTsE3SOYuIf5lO7HPprY94PcGWB1iFKXz99De0KBAKhfqTIYxxdS1kRolRaNvxrlMjMJ78G2S5/I9EAvW5pcbF9h5Sl34nQUqI3vqV2+o1ecymLiM1CXbNJWqsokOJVpHgU6s2aWa5c/fxPUTdmRWdz8gyieNtyO24ZQ37d0EmYPAHsFsqNVzufQTkP+I3enX/IJGWeNBJrm7GxbOEdEgbYcYpQPMpcxvuYQYkC0ZBdoHWiFWsM9RWZ8PCw7mc3INO+nluv9u4HwLVOkPSD3kYWW7C4ImJJAlD9RmIL271Rv7+n/JA5drk0dT4nC BxKIdul/ p9wDVYohnT+LZMhqUbZYu7QqD0lnXc1f5NqAnknplMb+QOXmxrmDi3uxBSSL60ePSbnTfnTS4GsP5pPB4tmuZSGUg+3b56lkh3SfYSDa9S6texuJOuLuL4QzoLqNkYte5LDi118xi8MfPHZMFjxNZTnrptc/e7iIOfJpOIFrzSifv+jGLJR1kpHTzPMbm/iocCMlRlHVNx2WQoBWltIGf4Uwsvpqu+QCJVSQ/cuI43LibeBMBLjLPARu6LSF8b2teyBMseSQfbjJDULQrT0rNaQ8BG8USrSN4XrlDaE2Bz2QXu5zgizr8xE2ZtW6tMUSmuqoOfK7+/Zx08ILAFZNwxNgF3QIPLNq4dSeeHK8J1W/PtVbdl4PpJylBJO24Uaa8ryrOiKD6oxorawuOpeEXLOCo/BvVeo/N5CukB51hKTctwjBfkGTsLKe9HcfXfFEL/tg1gYNd4jBNkUYCKYOR7fl+kpYeNXUFgFab6ca6B4D3YX5QHXx8gQ14At4n2gwYLSnwcGqYtM7ZPIw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000394, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, 30 Mar 2025, Matthew Wilcox wrote: >We deliberately don't sleep when the folio is only a single page. >So this needs to be: > > might_sleep_if(folio_test_large(folio)); Along with willy's suggestion: Acked-by: Davidlohr Bueso ... and the same rules apply for copy_folio(): fs/aio.c: atomic context but no large folio: safe fs/fuse/file.c: no large folio: safe fs/nilfs2/page.c: blocking safe, has large folio: safe mm/migrate_device.c: no large folio: safe mm/shmem.c: blocking safe, has large folio: safe shmem_replace_folio() could use a might_sleep() I guess. Thanks, Davidlohr