From: Davidlohr Bueso <dave@stgolabs.net>
To: Matthew Wilcox <willy@infradead.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>,
brauner@kernel.org, jack@suse.cz, tytso@mit.edu,
adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org,
riel@surriel.com, hannes@cmpxchg.org, oliver.sang@intel.com,
david@redhat.com, axboe@kernel.dk, hare@suse.de,
david@fromorbit.com, djwong@kernel.org, ritesh.list@gmail.com,
linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org,
linux-mm@kvack.org, gost.dev@samsung.com, p.raghav@samsung.com,
da.gomez@samsung.com
Subject: Re: [PATCH 1/3] mm/migrate: add might_sleep() on __migrate_folio()
Date: Tue, 1 Apr 2025 15:53:20 -0700 [thread overview]
Message-ID: <20250401225320.uee5as2bmw4p6ygl@offworld> (raw)
In-Reply-To: <Z-kzMlwJXG7V9lip@casper.infradead.org>
On Sun, 30 Mar 2025, Matthew Wilcox wrote:
>We deliberately don't sleep when the folio is only a single page.
>So this needs to be:
>
> might_sleep_if(folio_test_large(folio));
Along with willy's suggestion:
Acked-by: Davidlohr Bueso <dave@stgolabs.net>
... and the same rules apply for copy_folio():
fs/aio.c: atomic context but no large folio: safe
fs/fuse/file.c: no large folio: safe
fs/nilfs2/page.c: blocking safe, has large folio: safe
mm/migrate_device.c: no large folio: safe
mm/shmem.c: blocking safe, has large folio: safe
shmem_replace_folio() could use a might_sleep() I guess.
Thanks,
Davidlohr
next prev parent reply other threads:[~2025-04-01 22:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-30 6:47 [PATCH 0/3] mm: move migration work around to buffer-heads Luis Chamberlain
2025-03-30 6:47 ` [PATCH 1/3] mm/migrate: add might_sleep() on __migrate_folio() Luis Chamberlain
2025-03-30 12:04 ` Matthew Wilcox
2025-03-31 6:28 ` Luis Chamberlain
2025-04-01 22:53 ` Davidlohr Bueso [this message]
2025-03-30 6:47 ` [PATCH 2/3] fs/buffer: avoid races with folio migrations on __find_get_block_slow() Luis Chamberlain
2025-03-31 19:58 ` Luis Chamberlain
2025-04-02 23:11 ` Luis Chamberlain
2025-04-04 15:55 ` Luis Chamberlain
2025-04-01 10:57 ` Jan Kara
2025-04-01 21:49 ` Davidlohr Bueso
2025-04-02 1:58 ` Matthew Wilcox
2025-04-03 2:04 ` Luis Chamberlain
2025-04-03 13:43 ` Jan Kara
2025-04-03 16:11 ` Theodore Ts'o
2025-04-03 1:02 ` Luis Chamberlain
2025-03-30 6:47 ` [PATCH 3/3] mm/migrate: avoid atomic context on buffer_migrate_folio_norefs() migration Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250401225320.uee5as2bmw4p6ygl@offworld \
--to=dave@stgolabs.net \
--cc=adilger.kernel@dilger.ca \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=da.gomez@samsung.com \
--cc=david@fromorbit.com \
--cc=david@redhat.com \
--cc=djwong@kernel.org \
--cc=gost.dev@samsung.com \
--cc=hannes@cmpxchg.org \
--cc=hare@suse.de \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mcgrof@kernel.org \
--cc=oliver.sang@intel.com \
--cc=p.raghav@samsung.com \
--cc=riel@surriel.com \
--cc=ritesh.list@gmail.com \
--cc=tytso@mit.edu \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox