From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCFEDC36010 for ; Tue, 1 Apr 2025 21:22:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 56A31280003; Tue, 1 Apr 2025 17:22:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5172C280001; Tue, 1 Apr 2025 17:22:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3B926280003; Tue, 1 Apr 2025 17:22:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 1DDBA280001 for ; Tue, 1 Apr 2025 17:22:49 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id C99E41C9863 for ; Tue, 1 Apr 2025 21:22:50 +0000 (UTC) X-FDA: 83286749700.12.22885AB Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf07.hostedemail.com (Postfix) with ESMTP id 6BB854000F for ; Tue, 1 Apr 2025 21:22:48 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=JJB+chDP; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf07.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743542568; a=rsa-sha256; cv=none; b=VdITYYcP8zVKhOiBftiMvJrvVz4SJbrvjIIKhUq9wlRDclKKxnLJTvxB7ZH/DeGHE4fmW1 AdYnOn2wgjq2W+ANYqq9s5eb2418pXjUmGCNKBb6OYsUBz89a50ERZrsgEV87Af081isYU vqm827PmlMCnRKbU5zdVHjiHvLDbi3k= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=JJB+chDP; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf07.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743542568; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xWbeaknwWA8fbTt/j7/uG3E08mJwgvZbz1hCK8OtIrE=; b=Cl4I5pF88ZkhH17q4b3VUvnaI0BbVa9GcGSF/bwrnWdl07XH47DloBQo2o2TTLaTLmL57I X+oIpC7GUa07+6F5JBtLE8iHsinD7xx/UcIs81yMnaHUMZTvhOIbZn6eC+wnM6GYyHqiHu qvls91auGFl0qX1BH1MbiEBkjADdWwA= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id DE9CFA42E4D; Tue, 1 Apr 2025 21:17:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3AD17C4CEE4; Tue, 1 Apr 2025 21:22:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1743542567; bh=iJ5hAt4ZYrZ1lmIKjC7eupI+Cemp/nML+Ih+V2zVXKs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JJB+chDPpAmSfykBaIMX1hLiu5kcwVjLIIP6Gn3XuY+KhyJsJ0CA8wNb04kdOo1CO t/i5PorgsnPZ631Kx0kSGLDibLuD71UHPPUNlBqgOryMCfX4YJa/EvenscnigbKdnV hGeXjioheuyhvWpkMg9VSQkJLoBvw7cHOHDs4YTx6khrCr6YxKxWuRUvrBMGibyCTO 2Dl3Zre375bh49V1mY1mla+TZhnB/XVXQFrJ0hkcEpI3HxN5+aGcvwqSc8+Zu+wKR/ BkvZv2PyzpZ27zJZk9iBDCOMvIHhL+4bH+w/eRwIsBb2/aRgPcUQHCfMasA4sBf1Vv RQFD31Dvtlx0g== From: SeongJae Park To: Lorenzo Stoakes Cc: SeongJae Park , Andrew Morton , "Liam R. Howlett" , David Hildenbrand , Shakeel Butt , Vlastimil Babka , kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 9/9] mm/madvise: remove !tlb support from madvise_{dontneed,free}_single_vma() Date: Tue, 1 Apr 2025 14:22:44 -0700 Message-Id: <20250401212244.81644-1-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <9891d4a4-954f-42f2-b60e-d42796627c7e@lucifer.local> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 6BB854000F X-Stat-Signature: 9anzmb68ctq4ewp5rrmai5nt5oaz5dcx X-HE-Tag: 1743542568-238242 X-HE-Meta: U2FsdGVkX19blx6ejA+Rj8JVmeUnHzRbKvakrbfVOuvW3ps6najodV6jHlhpcii8eGTcU7EuJQYNXNhKOyfnkYQocFB5j6PuBPtwJoAgMUZROqCI4zMRwJbEAdOMFja0je96KUFRyzA5N6uekY8J7JQ2/OHP6wzHk3CSV50aYAJmEev0aJr8cRa5iHTY1nddRAibt+E8A7QTPdCqPZ+B99Soju5XpkwruBLkF5MNWJW3dO2f/hl4JrspEZvhH03M9LKlZQnm0cI02B2XImTbG6bND17JCz2K1ZzQ94NhS/YZu+JnyxF0alb7/YUvSatsDiA3EM0F77NVcSmy4E83UEyoVSYpvToZ24PChEHS/pPcpUfOvJJhpCnPagI4hrs9MJiRVPx/a5Q80tXBHnG8AQKsT5+okYJ/K0BaNgoI+OxgK+VnKs6eRudHedsZMsPGdbAhm+z43BSuym7xwlTnicraMMi2N9uiMj+NnMn7cqdfL4J7Zs4VRBYTXT96nZiJ3p2AyEvwNJJM4LQs/hPiVz53yMz3fKDXQC+szzFcYh2F2w32Yn3wOTsYm2HmZ3DCgamQQbmLe9aXckQIHt0ZbbJjiv9wf0dSjwYmX+nnGUtM02Yp4lBYdetAlOlQPm+1rofh/8X/ZtYGuQrRgS3OKobKWEyJTCaQ+9ZOWUAIQyGCn0HK3HY+rZAlfqdsxUCcvy9XzH9fm2LbL9jXB37dJ2v9OiYPr2b2h3nG2JAQiVUONVDZyTECErHQ8q0JzDKfjOdIJHRr1PMl4gu8iuF6OVk2bLp9CckDpc5pdYqZgfKMkWXAo5f5NaNOfLfocicyMkImvEMTbIr58mbIowPAXaa7jABOIlQRsoVm0ZEfe6bemnio1UXBNfA8NiK3VH73EywqJDTYTJriwJ74vyKBnj8PloDMGVPXn0Aaq4etYMN5wFmd0veC9d0bujDzAullqF3U9Iui5AogLOCG7ZX jmZdS0Eq Z3URzaO9dY+DnTmVw4qa9Z7y94g+E/dYP82+r05u1bn2egMnnvZ4Y1QBHHZS2yk1b1LoxyyzQLEom1sMJdNbvl3N+Pw9sh4P3UOcLViGbUrmsoMm2N6GL9PmuZowjOtsZ25ZJ5xEPppmuixnhauop7YjSmYlBDQA483KF+CnZcOfSlb9zblXmVbSASBGWzwJFuVlWpkzEw96wEdrfYbr79TDbqeehTppPqu6AmQa4HqeubT45VKE/qcGJyrfGvb2XffqlaGKfb8kwTdoS15yvxC5VX2zP38+V66nvrfnWCNEybESZ888J2hFjb5YV4In9iP6Tg1/83P+Qx+uW1KorgZLqSA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.010722, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 12 Mar 2025 13:46:38 +0000 Lorenzo Stoakes wrote: > On Tue, Mar 11, 2025 at 02:02:11PM -0700, SeongJae Park wrote: > > On Tue, 11 Mar 2025 14:01:20 +0000 Lorenzo Stoakes wrote: > > > > > On Mon, Mar 10, 2025 at 10:23:18AM -0700, SeongJae Park wrote: > > > > madvise_dontneed_single_vma() and madvise_free_single_vma() support both > > > > batched tlb flushes and unbatched tlb flushes use cases depending on > > > > received tlb parameter's value. The supports were for safe and fine > > > > transition of the usages from the unbatched flushes to the batched ones. > > > > Now the transition is done, and therefore there is no real unbatched tlb > > > > flushes use case. Remove the code for supporting the no more being used > > > > cases. > > > > > > > > Signed-off-by: SeongJae Park > > > > > > Obviously I support this based on previous preview :) but I wonder if we > > > can avoid this horrid caller_tlb pattern in the first instance. > > > > I will try, though I have no good idea for that for now. > > > > Maybe we could simply squash patches 7-9. I'm bit concerned if it makes > > changes unnecessariy mixed and not small, but I have no strong opinion about > > it. Please feel free to let me know if you want that. > > Yeah, though maybe try to make things as incremental as possible within > that? Now I think we can make entire batching change for MADV_FREE first, and then make another change for MADV_DONTNEED[_LOCKED]. In the way, the caller_tlb pattern will not be introduced at all and changes in individual commit would be small and dense. Please let me know if you have any concern about it. If I don't hear some concerns about it, I will format the next spin in the way. Thanks, SJ [...]