From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE576C36010 for ; Tue, 1 Apr 2025 14:46:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 26DB6280002; Tue, 1 Apr 2025 10:46:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 21C26280001; Tue, 1 Apr 2025 10:46:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0974B280002; Tue, 1 Apr 2025 10:46:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id DDC34280001 for ; Tue, 1 Apr 2025 10:46:34 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 9528F802C0 for ; Tue, 1 Apr 2025 14:46:35 +0000 (UTC) X-FDA: 83285751150.26.FD44D27 Received: from mail-qt1-f180.google.com (mail-qt1-f180.google.com [209.85.160.180]) by imf08.hostedemail.com (Postfix) with ESMTP id 6B962160003 for ; Tue, 1 Apr 2025 14:46:33 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b="MR7hm8/2"; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf08.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.180 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743518793; a=rsa-sha256; cv=none; b=IAbN4Jb0w30THEuoFA3Ev6Sx6VRFMzEc2jNS0sfaAIaMu2SQ60kxj6IGFdS0mQjuv8cGyk 6FQW6Y8fTNccKSkv49k9aEBG5XQvkNt7ejjFkmqiLpwXNuLokz1/i8V8u4/fG3HxhzTmyc HMDnhrDLq5yFnB7KoatvtX/VuYTfJpc= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b="MR7hm8/2"; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf08.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.180 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743518793; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lKIK6TCBXh0/b2x+QLNcCebRgqt7ofZ2t0FZ+6hle2A=; b=rl4MHvGSam02/9ATkdGSg4o1ZZS9UrpZArXAtcdXjWsgQMI0vn5NBt67Jrf63jdjl6KinL 23D2nFnJZNCx6LhlBYxvYXQMa/2d56TTjNcLpon2jGb92EvTJQiNG0iLq96xhFpiTbB19a +CXCrvWq+18Zl/BN7RbFmL5Z44zP2aQ= Received: by mail-qt1-f180.google.com with SMTP id d75a77b69052e-476964b2c1dso44313491cf.3 for ; Tue, 01 Apr 2025 07:46:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1743518792; x=1744123592; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=lKIK6TCBXh0/b2x+QLNcCebRgqt7ofZ2t0FZ+6hle2A=; b=MR7hm8/29mJVsTgC4m4CACcsYNih8cI9BgzPQVcRZyv+/RU086/r8YLSHPYy64VHdg cewhHrpBcpho8sXh7ugqazm8J003tPz5556Hkv8LT8PhLN99VMpGwMwjDcHt1D4H0npB hAsl2gxBtUiLbYQxKR46cjCM9RTfmhw64jL3zqDOe4NOZBwkE1GpZX8jT/nLM12cquC1 2tUdK++qOtsvAFuiSASQOU+uFQkUWMcTtgXW4oBRBSINmBJvUPjCJ+jeC/vazxSShTNF X6e5FKIDxxKUEbAtPVRESTgqFcIplYdvl5fWoNM6xptZLI769nvmtNyp4pnbhZsYml0y VwYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743518792; x=1744123592; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lKIK6TCBXh0/b2x+QLNcCebRgqt7ofZ2t0FZ+6hle2A=; b=PgM1EuYyKZ4EQH1ivoG59xFwRfwpUEvosaaLLm5lgNxis7aS8qWhP2WOg3TZru8z0e kbi8Mqi34x1fcox+e3/yAZ0IrmyKvE9Sbfg1wTqp+grsFlmnze1C7nAlBx2SmiWw3YEx F4TLMIp8DTDM8RhannztAYXdiaKjauKhjhnV8lxajQj71uXz4CnYf5P1R7mswsIhtdCV lH59MNwWzOTPydng/FLO2zdjx9ugBaoPkFKpbruCQcfMI+HtnPoJ399u9bek9dyH75Tm JHJb8DPQ9ZHhw3/+MsDmw7YQnQwhQ+mn5tABVfItJMBxCifqkQ8WPepSyI6FZUEY2SAs Qncw== X-Forwarded-Encrypted: i=1; AJvYcCW7qj9dUIKveohvXsVu/vPAYsF9cxOjm/nhvkHEsdc30ILrs7ltvDWZzADOuuoH4F+DUx1+GeU+Xw==@kvack.org X-Gm-Message-State: AOJu0Yxi2Sv115XN2Ry6R6coozPWS1UAL74qWDofCYt3H4lkJPZG7a1+ /l8iuEwra2pOOmm7lVs4kzYlT6O4nxvhfkRhvwWK0Y+ExXtrcRjImW4jMH90buY= X-Gm-Gg: ASbGnctJ8sxwxi+iZW1IBVyN8qIoFxzNaQUPS/dNzL9uKGFki0cEMxvWr2ekTJkWczm txBtHjKNaJS24qOvASW/XxztvwqqjCiTzdKDq3/aP6v+4E54JCIKCTfOHP446onUuQObAFLSbJS H1E/KOyyyMt0viH9FObb85XCdtlLC4M57J8V1dPT+gP2S3Dp+JYUS3Mb+Gmqw1A5hj4Y+VDqgLX tnVYWI9nDd8uM1tdOqkdwqSYpdJhvHgl+g7WREDOWECXQ5zp+E6Z6hX7W4OnpVREGIbNG88KRB1 A7cNw+XLcIwzPhcXMte8FoIwdx8f3ibjeN8i7f9sD/k= X-Google-Smtp-Source: AGHT+IGd0l70xIGEWpYX73CKDI+dwq5hu7ZsUvU5UjGhV4zCBAv+3/StH2ePjwFPAPO8gUXMP6WvbA== X-Received: by 2002:a05:620a:bca:b0:7c5:afa6:83ed with SMTP id af79cd13be357-7c6862ebfa1mr1681281385a.11.1743518792461; Tue, 01 Apr 2025 07:46:32 -0700 (PDT) Received: from localhost ([2603:7000:c01:2716:da5e:d3ff:fee7:26e7]) by smtp.gmail.com with UTF8SMTPSA id 6a1803df08f44-6eec9779bdfsm62174286d6.92.2025.04.01.07.46.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Apr 2025 07:46:31 -0700 (PDT) Date: Tue, 1 Apr 2025 10:46:26 -0400 From: Johannes Weiner To: Vlastimil Babka Cc: "Liam R. Howlett" , "Matthew Wilcox (Oracle)" , Andrew Morton , Lorenzo Stoakes , Jann Horn , linux-mm@kvack.org Subject: Re: [PATCH] mm: Rename vm_area_struct to mm_area Message-ID: <20250401144626.GB2117727@cmpxchg.org> References: <20250401122602.1738511-1-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 6B962160003 X-Stat-Signature: iup9zag9ishg9a6si9jmjs59nxnrkecs X-HE-Tag: 1743518793-611308 X-HE-Meta: U2FsdGVkX1+Y0kFRnzFC85ueFe2xjBQDIXxqAH3/BqSL4a37yWnonisGQwbSY0HCBBq1AWUUcFw/+jcmvnFTUtjzobGkUxdY5z1K8K3HXpUAq+kqjazUGDGri/Z/ZysXgRWrxh93ESYPTdwNxH8wGFjKFGd8z+tI8N3VU6vdcQnqu0WQ09SQHwfkfkWrQgFhDij9izUrsB+nioCxZwfv8Q5ratTmGI5aE6ukBAgUiu79Rs9bW5j1FXRwY+2MDKOULcqr7gJHfDYjbXI5q0CFzOZNR3noNCNwVgxF+K6jmYYtUXeII8qkOi3+j3k1cPmFEDsNf4mlrXf6/iyf4i3nsbrfEAS2qV9xq7NC4IbJUDsYw3/PwMaQJi1HTs7U2yT1M8smRXV9Dhm8G9h/+Ws0TKgz/WCPUwD0SJUIYkQZjUZylGH1M7C2YJhXHZUmDAcI2p5gj6u1NazJd6Ei4Vk1Ss0378wmcKMghwHLxANhVJzdfMT/dOsoxQ13ijPUjlJyoXAa6pSo5AicRmTerGjwAS+Qc2VVWOZS1oXDxDzqJT/jbSi9MeYkCVM55lpgkBDX6LbfduYelnzvhnQHfxDETRARsapP/JGTVIUUPazUWI8caKc/TWe0ruAIENuC2DqIhHDBG9/VOmDM7j5AurhF7v8J+f5eFkeXF83IFaAAb7kz2UeAALUJmrcxHviWJYbv30FnIH7xs9jGz+DpBGiSAHELMuO+HBDfomPNCjFlwA69B3fiveSEVjx2Nq3yKVFOX3PEkzq4jO0J80AeRmGEI2h4jFFieLekhTgGF9UsEX1JoXuIPgO7LJ8W3xqbRK+mYmJYrUZbLPUTBAH64rv+7fnGfvFyWqIMwFDyli77NrOCZ3mJgLcvSijOWGbbOfkMx5J4Bafmk4hgTLdVWSZzFM9p1Hq5vxYS2vXwNSDPM0J/FNNJLYQ+lo/fGH/j7F8/mNuYozrd8xmAOGBeRmF G78H/xTI SQkrf8t0dAQZvTxtQEfgpBaW7vTbud58rnYU4CN/uSQRK+Ws3wDIxxXPrHyJnwBLMuknSUmW1i70TJclpCisoO51mdIp62WaDflczyroMMZi/5M9axYl+gEFXD+Ll0YbEnDZy3bwYKokrS8dl+0u1Ebomvk0UdO/8/Etjhn0LXw5oVblXGzGxLdsvCI3byhu1LrGcuh2XWeN5/fFF0eF0YgKk7ywL6MxeG5yIXlXBVJOpePMEphhdl0tdRCVWZuwjpAODKNHxhMSPBqV7041UgZaYYmm5Zsi9ZRJHmGVDT5fD8341G2VBop+qJLvzywo5nqzCv27mCL3Mn2QYe7VrlxrHyaalX0UA2Yu5oNFnoViedx4jzZxtIeGNRmzdApbWX5De+jqOq5PcPHZmzp244OjW6MF47/EuPabS35uoiIa4NXbIutvYsC/RKkZtb5i3248Wyo1G/iYGHPtNepfuMg2DG1J1nJeq5fo9tVXaEybjnljoAWu+uZKWCvPWD8UbjWuPrzvc90GQCWVLM2s5m3jcXhJD+8uGM1FHkkCwyVv7JYPe5jf+zBUGMWM7RyCRxHmy X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 01, 2025 at 04:21:53PM +0200, Vlastimil Babka wrote: > On 4/1/25 16:17, Liam R. Howlett wrote: > > * Matthew Wilcox (Oracle) [250401 08:26]: > >> We don't need to put "_struct" on the end of the name. It's obviously > >> a struct. Just look at the word "struct" before the name. The acronym > >> "vm" tends to mean "virtual machine" rather than "virtual memory" these > >> days, so use "mm_area" instead of "vm_area". I decided not to rename > >> the variables (typically "vma") of type "struct mm_area *" as that would > >> be a fair bit more disruptive. > > > > I'm not sure I like this idea. I mean, we should be more clear about > > the type. It's not even saying it is _in_ a struct. > > > > Maybe we should go another direction and change vm_area_struct to > > "memory_area_virtual_in_struct" to really clarify what we are talking > > about. > > > > Obviously the variables "vma" should be updated (over time, as code is > > changed..) to "mavis" to match the new struct name, for type clarity - > > like a beacon. I really like the mavis beacon idea, it makes typing > > easier. > > I agree with this direction. We should also rename "struct address_space" to > "struct address_space_struct" and rename folio.mapping accordingly. folio.paddress_space_struct has a nice ring to it. It's a bit of a mouthful, but that shouldn't matter as much anymore with Copilot doing most of the writing at this point.