From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14918C36010 for ; Tue, 1 Apr 2025 11:46:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2A275280002; Tue, 1 Apr 2025 07:46:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 22AC5280001; Tue, 1 Apr 2025 07:46:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0CBE2280002; Tue, 1 Apr 2025 07:46:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id DF587280001 for ; Tue, 1 Apr 2025 07:46:32 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 0E7361CCCC7 for ; Tue, 1 Apr 2025 11:46:34 +0000 (UTC) X-FDA: 83285297508.28.C1C01B3 Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) by imf30.hostedemail.com (Postfix) with ESMTP id 371CE80004 for ; Tue, 1 Apr 2025 11:46:31 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ZulPKRmi; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf30.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.53 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743507992; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TpkQWELbIJVodLiqCx1ElP0HcF+7Nzv3vgQF8WfDbEo=; b=YKaeHlTOXQuLoel/rtAxblUhvuPdDX3UWRNKAVuzr36tqauM3ymvuMhK3tqOmt7XahcaH0 opj0Wanw3+GhFHPvoSGeYlgKPKMHtXWAOj8bGDi8wm2RZ5i0/JKW7Doz/KzCSboBjx79jf XVF9zF4zLO5D/qi1nTP+qhESYtkOSTs= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ZulPKRmi; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf30.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.53 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743507992; a=rsa-sha256; cv=none; b=SxwXAdg0YePuaaYaGwS3ljfNHTNqeHr8MOnx60H3fggCbRCem3qqgMTyD72JV/5Py/E5Lp 0Tv3H3KXd+/xu/cC3IMoR7cTz4DTkcorZjGnlaO/TeJWtroG9HwbJO9M8fuE+lzxo7N/YL lhguo/UVm9c7X1sOLa49M6K9oYEeiB8= Received: by mail-ed1-f53.google.com with SMTP id 4fb4d7f45d1cf-5e5e22e6ed2so8244255a12.3 for ; Tue, 01 Apr 2025 04:46:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743507990; x=1744112790; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=TpkQWELbIJVodLiqCx1ElP0HcF+7Nzv3vgQF8WfDbEo=; b=ZulPKRmi8G7AD4fN031SsOms9jxVqVM94ysv7LYXsXgPqyv3COqAUT3miH9m7LUXCR zHvUTuTTThV4UD5Zj5FcKNg0igKTc/q2JQlKBR0VXK5mV8BpBZjo2QnedKf7HzPgkZ+5 AI36n0mccN4PwJEgt0FWrwQ914oh6Ztqm13ArRWTq5tbjBU90w1b5bviMcNARg/IdRpz 8/wvu3vdJqAFtiCgDoZEULIiHCI4hTLY5tBJW+huL4L5P5Z/qg0CmIkOUZA8ZnmUc/Rw HGZlpcLIUgBI3aNoEhbo6Ao2NigJox8jYfzTOVFrUec/ce6/AeNNBEe4xubnA1jurWFQ 90/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743507990; x=1744112790; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=TpkQWELbIJVodLiqCx1ElP0HcF+7Nzv3vgQF8WfDbEo=; b=Gq1eowiCijr5xtOivMXmFqNvlEjkGb0U8megWdpOgeH9GdwcE9+Sta7Vn6fauWXAi9 AL2/r4Y5xgtILhXzehhz1rMmTsYBdqisnCNTmvee09bECusA6Rf6R4/NfDOnSpsOa8XE Wr+X4b1kTnAHGqPV9dOuj5QWYW8p1FNfxk/Jr8i/1C6fomwpaD8r5mNy00rimVoJHXS+ PASLy/heFgprHmjvY42w3kXG/TSH61XQmJ7vS9h2+g48hZsGgclxCFOrRfs0rHEawU3Y dJT4MuGRVlaijnXqBjMOp0tjcjk4RXGhWKQOi5ZusohSrJ31YZ8TdeAH2vw0TqLogoj/ 8n5g== X-Forwarded-Encrypted: i=1; AJvYcCUsmUSrMzZ2T24Ei0V++2ajhwF670vbIRao/J+iDlLuCs+vnvkc4C5+oq3Os1sO+He6xf62I4XWdA==@kvack.org X-Gm-Message-State: AOJu0YyZyW700xle9uWSTizBK32xL350Oa3nHwha7I5h7vIxcjAf3VAh gS+SbWzqjsrMEII8AdRNqjgiX131aurrZeqXDCyttIsjapZd7O6W X-Gm-Gg: ASbGncufkA6msSr8ufnimvxNgIsY0RvzEHJ4oODNfc+6E/kcaVFez7Ul/SICpuC6xfu qoXjPMmGJ+7DtU63I/AtAVOA1M20PFAYp4DcKUXumyAWdSuc7c1flw4TaYsnTgvK8UtL8H5Xw/z 1yQRb4dQhngi7vFd80KUr5IeM5fkQapuiKqRaCZc5AhDAw7xoaa0y2jz8Jdq4jMH7zzfbfs8/T1 lbxP9SNEHwS06Eiexw6juFPR6jQR1AV/xHbT20PKDe+8D5pTrSQIOe60T7MqKzSLjlv6kXenSfs Z2p2qytx+ODEyqmtdhvebKQUT2Hngm+qW3pJBsc87Nmy X-Google-Smtp-Source: AGHT+IHhDwMRdfY4wS5GjZ4YODC4oXMZT7wp7xF4XVxfhJwX959mlifR6pV3U3b7LYNn8A4DqfwQ8Q== X-Received: by 2002:a17:907:72d1:b0:ac2:b9c8:b7ba with SMTP id a640c23a62f3a-ac73895fbbemr1098107766b.10.1743507990280; Tue, 01 Apr 2025 04:46:30 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ac71922ba02sm767037466b.10.2025.04.01.04.46.29 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 01 Apr 2025 04:46:29 -0700 (PDT) Date: Tue, 1 Apr 2025 11:46:29 +0000 From: Wei Yang To: Lorenzo Stoakes Cc: Wei Yang , akpm@linux-foundation.org, linux-mm@kvack.org, Jann Horn , Vlastimil Babka , Michel Lespinasse Subject: Re: [PATCH] mm/vma: correct legacy comment in vm_[un]lock_anon_vma() Message-ID: <20250401114629.5wtk7jiv7e7ijvwg@master> Reply-To: Wei Yang References: <20250401094346.25200-1-richard.weiyang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 371CE80004 X-Stat-Signature: fkt4muako9rqqydymmfprot3x9fdccws X-Rspam-User: X-HE-Tag: 1743507991-680534 X-HE-Meta: U2FsdGVkX19cZ/MOBb2a3XO9vDcHPg0C7beci5M2IrBsHSnBuioLchTUG5c5r9BMVBx7GKLlaj+nDNuYdSF4GEdDxUELGfQiLl/MyFPEU/MdfRxMqJ6bT2zj3VczpcFlY3vnTFJE5Q9CgGpCKZNQmGRvd6EcPIrmiJKW3UEYLI3MpDjNf9SRzmF+M2+Xb6Cp9XXAwJxyR3cvgnH85qthwi1Xgq/39bMOejSceeId8Hin/+RrkvnFmLe3sVlcbr9wTzhCt+gbHYV2hdpvPdEN132/79vWvJHBGdON8ZVtmNzg0bW64DeFnpJEsAATkzppwSTVupIQR7epiSXizHVHDprGOCcm2dwbLqJctweLHG2PquqwVrk60B6jlYJKfyaqw39uRF+WZKcz0/3u6ISipBKDLUta2LGWDouQ4JYhSiE8dp5bWiB8umIcHrYVtuBSb3jpwvVYS1QYPihus8Ydz6TlSvTUkgp/smMPqi/Pf1bEAmGCC4QZpKUU3C0T6oK42eEkzotJe9HaOrBUqLJ+GiYAd93vAHE7XCrCgH3OZTZYz6/AOyyG3t0pDPcZH9AgwhBuavPL06OSoyHjgeg6baDeBL7N10fhI3TtVrRE2CUYRgGYxeO4GFUF9KoQp96EyPu1J8yoqrE96KB1axSus1L2LSIk2OYO55a7PQwR9vyN+OzDfh4wQYoyAgmb/ZwMSpShyJ3B/Axc650aa+ChtSSJkWIFkI7EnSQ5zMHhnbFWtd0t7CQF+OFZejxb0L3hdVaYmm388hsJ+MtUJ5zY3xEGY36sHAJufAVu+MryVVT4Wzf1ljWzoqs1Nt84YEL/eS0/q45RAq0jaFG3E3TOXUMjP9U1YsPygxrQ+COHCWgCpinl1umENa8eWJS67Uhe9LiX6e+Ev0kErBfjowAWZrIxGyj8OxF3bULq9eZ84AgW8q99D63CC07DnpQUdDxI8/GF0rnHSrQOgY00ENx JEhudsuD AlAZnn7tHzakwbXirdDYRg7/2Xqq14/mxU+lK9Hn9UcrTp0hCxjWK45HOTP6SiWCuxBEYXeo80tP+VWsmfJ3V7fOg5KTFDBwqI5xEtvJKCXNSs4bxcEa2zdxvKLN1HVFVtKytXk0/rilHUhh4v/4LKiJ0ec91s88PFu8P2SYAZrDSZa3jnnVzjEutxVBLiOk8SoQKXSbVEu1ldUg38nGljW64XvqeLqgBpYK+/adEVznJtVpY3y9CmWO1sU33gLlqbLdwb6zxk5ZB28RB/DgMPn2ppQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000101, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 01, 2025 at 10:55:16AM +0100, Lorenzo Stoakes wrote: >On Tue, Apr 01, 2025 at 09:43:46AM +0000, Wei Yang wrote: >> In commit bf181b9f9d8d ("mm anon rmap: replace same_anon_vma linked >> list with an interval tree."), the anon_vma.same_anon_vma is replaced by >> interval tree. >> >> But the related comment is left behind. Correct it here. >> >> Signed-off-by: Wei Yang > >Sorry, but I'd rather we didn't, this is un-useful churn, and I am planning to >make fairly wide-ranging alterations to anon_vma going forward, at which point >things like this can be addressed if needed. > Would you mind telling more about your plan on anon_vma alteration? >Also, not to sound mean, but we have repeatedly asked you not to submit >these kinds of small 'fix up' patches. This one is relatively benign as >it's a comment change only, but previous ones you have made have been >directly problematic for us. > >So to reiterate - please stop sending patches like this. Core mm is not the >place for them. > >Thanks! > >> Cc: Lorenzo Stoakes >> Cc: Jann Horn >> Cc: Vlastimil Babka >> Cc: Michel Lespinasse >> --- >> mm/vma.c | 10 +++++----- >> 1 file changed, 5 insertions(+), 5 deletions(-) >> >> diff --git a/mm/vma.c b/mm/vma.c >> index 5cdc5612bfc1..1a155031f1fb 100644 >> --- a/mm/vma.c >> +++ b/mm/vma.c >> @@ -1989,16 +1989,16 @@ static void vm_lock_anon_vma(struct mm_struct *mm, struct anon_vma *anon_vma) >> { >> if (!test_bit(0, (unsigned long *) &anon_vma->root->rb_root.rb_root.rb_node)) { >> /* >> - * The LSB of head.next can't change from under us >> + * The LSB of rb_root.rb_node can't change from under us >> * because we hold the mm_all_locks_mutex. >> */ >> down_write_nest_lock(&anon_vma->root->rwsem, &mm->mmap_lock); >> /* >> - * We can safely modify head.next after taking the >> + * We can safely modify rb_root.rb_node after taking the >> * anon_vma->root->rwsem. If some other vma in this mm shares >> * the same anon_vma we won't take it again. >> * >> - * No need of atomic instructions here, head.next >> + * No need of atomic instructions here, rb_root.rb_node >> * can't change from under us thanks to the >> * anon_vma->root->rwsem. >> */ >> @@ -2124,14 +2124,14 @@ static void vm_unlock_anon_vma(struct anon_vma *anon_vma) >> { >> if (test_bit(0, (unsigned long *) &anon_vma->root->rb_root.rb_root.rb_node)) { >> /* >> - * The LSB of head.next can't change to 0 from under >> + * The LSB of rb_root.rb_node can't change to 0 from under >> * us because we hold the mm_all_locks_mutex. >> * >> * We must however clear the bitflag before unlocking >> * the vma so the users using the anon_vma->rb_root will >> * never see our bitflag. >> * >> - * No need of atomic instructions here, head.next >> + * No need of atomic instructions here, rb_root.rb_node >> * can't change from under us until we release the >> * anon_vma->root->rwsem. >> */ >> -- >> 2.34.1 >> >> -- Wei Yang Help you, Help me