From: Bhupesh <bhupesh@igalia.com>
To: akpm@linux-foundation.org
Cc: bhupesh@igalia.com, kernel-dev@igalia.com,
linux-kernel@vger.kernel.org, bpf@vger.kernel.org,
linux-perf-users@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-mm@kvack.org, oliver.sang@intel.com, lkp@intel.com,
laoar.shao@gmail.com, pmladek@suse.com, rostedt@goodmis.org,
mathieu.desnoyers@efficios.com, arnaldo.melo@gmail.com,
alexei.starovoitov@gmail.com, andrii.nakryiko@gmail.com,
mirq-linux@rere.qmqm.pl, peterz@infradead.org,
willy@infradead.org, david@redhat.com, viro@zeniv.linux.org.uk,
keescook@chromium.org, ebiederm@xmission.com, brauner@kernel.org,
jack@suse.cz, mingo@redhat.com, juri.lelli@redhat.com,
bsegall@google.com, mgorman@suse.de, vschneid@redhat.com
Subject: [PATCH v2 3/3] kthread: Use 'task_struct->full_name' to store kthread's full name
Date: Mon, 31 Mar 2025 17:48:20 +0530 [thread overview]
Message-ID: <20250331121820.455916-4-bhupesh@igalia.com> (raw)
In-Reply-To: <20250331121820.455916-1-bhupesh@igalia.com>
Commit 6986ce24fc00 ("kthread: dynamically allocate memory to store
kthread's full name"), added 'full_name' in parallel to 'comm' for
kthread names.
Now that we have added 'full_name' added to 'task_struct' itself,
drop the additional 'full_name' entry from 'struct kthread' and also
its usage.
Signed-off-by: Bhupesh <bhupesh@igalia.com>
---
kernel/kthread.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/kernel/kthread.c b/kernel/kthread.c
index 5dc5b0d7238e..46fe19b7ef76 100644
--- a/kernel/kthread.c
+++ b/kernel/kthread.c
@@ -66,8 +66,6 @@ struct kthread {
#ifdef CONFIG_BLK_CGROUP
struct cgroup_subsys_state *blkcg_css;
#endif
- /* To store the full name if task comm is truncated. */
- char *full_name;
struct task_struct *task;
struct list_head hotplug_node;
struct cpumask *preferred_affinity;
@@ -108,12 +106,12 @@ void get_kthread_comm(char *buf, size_t buf_size, struct task_struct *tsk)
{
struct kthread *kthread = to_kthread(tsk);
- if (!kthread || !kthread->full_name) {
+ if (!kthread || !tsk->full_name) {
strscpy(buf, tsk->comm, buf_size);
return;
}
- strscpy_pad(buf, kthread->full_name, buf_size);
+ strscpy_pad(buf, tsk->full_name, buf_size);
}
bool set_kthread_struct(struct task_struct *p)
@@ -153,7 +151,6 @@ void free_kthread_struct(struct task_struct *k)
WARN_ON_ONCE(kthread->blkcg_css);
#endif
k->worker_private = NULL;
- kfree(kthread->full_name);
kfree(kthread);
}
@@ -430,7 +427,7 @@ static int kthread(void *_create)
kthread_exit(-EINTR);
}
- self->full_name = create->full_name;
+ self->task->full_name = create->full_name;
self->threadfn = threadfn;
self->data = data;
--
2.38.1
next prev parent reply other threads:[~2025-03-31 15:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-31 12:18 [PATCH v2 0/3] Dynamically allocate memory to store task's " Bhupesh
2025-03-31 12:18 ` [PATCH v2 1/3] exec: " Bhupesh
2025-04-01 2:07 ` Yafang Shao
2025-04-04 6:35 ` Bhupesh Sharma
2025-04-06 2:28 ` Yafang Shao
2025-04-09 11:13 ` Bhupesh Sharma
2025-04-01 4:02 ` Harry Yoo
2025-04-04 5:31 ` Bhupesh Sharma
2025-04-03 16:17 ` Andrii Nakryiko
2025-04-04 5:36 ` Bhupesh Sharma
2025-04-03 16:30 ` Kees Cook
2025-04-04 6:48 ` Bhupesh Sharma
2025-04-04 17:24 ` Kees Cook
2025-04-09 11:31 ` Bhupesh Sharma
2025-03-31 12:18 ` [PATCH v2 2/3] fs/proc: Pass 'task->full_name' via 'proc_task_name()' Bhupesh
2025-03-31 12:18 ` Bhupesh [this message]
2025-04-03 16:24 ` [PATCH v2 3/3] kthread: Use 'task_struct->full_name' to store kthread's full name Kees Cook
2025-04-04 6:38 ` Bhupesh Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250331121820.455916-4-bhupesh@igalia.com \
--to=bhupesh@igalia.com \
--cc=akpm@linux-foundation.org \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii.nakryiko@gmail.com \
--cc=arnaldo.melo@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=brauner@kernel.org \
--cc=bsegall@google.com \
--cc=david@redhat.com \
--cc=ebiederm@xmission.com \
--cc=jack@suse.cz \
--cc=juri.lelli@redhat.com \
--cc=keescook@chromium.org \
--cc=kernel-dev@igalia.com \
--cc=laoar.shao@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=mirq-linux@rere.qmqm.pl \
--cc=oliver.sang@intel.com \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=viro@zeniv.linux.org.uk \
--cc=vschneid@redhat.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox