From: Baoquan He <bhe@redhat.com>
To: akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
yanjun.zhu@linux.dev, Baoquan He <bhe@redhat.com>
Subject: [PATCH v2 3/7] mm/gup: Fix the outdated code comments above get_user_pages_unlocked()
Date: Mon, 31 Mar 2025 16:13:23 +0800 [thread overview]
Message-ID: <20250331081327.256412-4-bhe@redhat.com> (raw)
In-Reply-To: <20250331081327.256412-1-bhe@redhat.com>
Since commit f0818f472d8d ("mm: gup: add get_user_pages_locked
and get_user_pages_unlocked"), get_user_pages() doesn't need to have
mmap_lock held anymore. It calls __get_user_pages_locked() which
can acquire and drop the mmap_lock internaly.
Hence remove the incorrect code comments now.
Signed-off-by: Baoquan He <bhe@redhat.com>
---
mm/gup.c | 16 +++-------------
1 file changed, 3 insertions(+), 13 deletions(-)
diff --git a/mm/gup.c b/mm/gup.c
index f9bce14ed3cd..a15317cf6641 100644
--- a/mm/gup.c
+++ b/mm/gup.c
@@ -2702,19 +2702,9 @@ long get_user_pages(unsigned long start, unsigned long nr_pages,
EXPORT_SYMBOL(get_user_pages);
/*
- * get_user_pages_unlocked() is suitable to replace the form:
- *
- * mmap_read_lock(mm);
- * get_user_pages(mm, ..., pages, NULL);
- * mmap_read_unlock(mm);
- *
- * with:
- *
- * get_user_pages_unlocked(mm, ..., pages);
- *
- * It is functionally equivalent to get_user_pages_fast so
- * get_user_pages_fast should be used instead if specific gup_flags
- * (e.g. FOLL_FORCE) are not required.
+ * get_user_pages_unlocked() is functionally equivalent to
+ * get_user_pages_fast so get_user_pages_fast should be used instead
+ * if specific gup_flags (e.g. FOLL_FORCE) are not required.
*/
long get_user_pages_unlocked(unsigned long start, unsigned long nr_pages,
struct page **pages, unsigned int gup_flags)
--
2.41.0
next prev parent reply other threads:[~2025-03-31 16:29 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-31 8:13 [PATCH v2 0/7] mm/gup: Minor fix, cleanup and improvements Baoquan He
2025-03-31 8:13 ` [PATCH v2 1/7] mm/gup: fix wrongly calculated returned value in fault_in_safe_writeable() Baoquan He
2025-04-01 8:10 ` David Hildenbrand
2025-04-01 14:00 ` Oscar Salvador
2025-04-01 14:12 ` Baoquan He
2025-04-01 14:11 ` Baoquan He
2025-03-31 8:13 ` [PATCH v2 2/7] mm/gup: check if both GUP_GET and GUP_PIN are set in __get_user_pages() earlier Baoquan He
2025-04-01 8:02 ` David Hildenbrand
2025-04-01 14:34 ` Baoquan He
2025-04-01 14:37 ` David Hildenbrand
2025-04-02 1:26 ` Baoquan He
2025-03-31 8:13 ` Baoquan He [this message]
2025-04-01 8:14 ` [PATCH v2 3/7] mm/gup: Fix the outdated code comments above get_user_pages_unlocked() David Hildenbrand
2025-04-01 14:36 ` Baoquan He
2025-04-01 13:51 ` Oscar Salvador
2025-04-01 15:29 ` Baoquan He
2025-03-31 8:13 ` [PATCH v2 4/7] mm/gup: remove gup_fast_pgd_leaf() and clean up the relevant codes Baoquan He
2025-04-01 8:19 ` David Hildenbrand
2025-04-01 14:11 ` Oscar Salvador
2025-03-31 8:13 ` [PATCH v2 5/7] x86/mm: remove pgd_leaf definition in arch Baoquan He
2025-04-01 8:21 ` David Hildenbrand
2025-04-01 14:03 ` Oscar Salvador
2025-04-02 3:39 ` Baoquan He
2025-03-31 8:13 ` [PATCH v2 6/7] x86/mm: remove p4d_leaf definition Baoquan He
2025-03-31 9:57 ` Ingo Molnar
2025-03-31 14:20 ` Baoquan He
2025-04-01 7:20 ` Ingo Molnar
2025-04-03 13:44 ` Baoquan He
2025-04-01 14:05 ` Oscar Salvador
2025-03-31 8:13 ` [PATCH v2 7/7] mm/pgtable: remove unneeded pgd_devmap() Baoquan He
2025-04-01 8:21 ` David Hildenbrand
2025-04-02 3:33 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250331081327.256412-4-bhe@redhat.com \
--to=bhe@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=yanjun.zhu@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox