From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE600C3600B for ; Mon, 31 Mar 2025 16:04:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E7B85280005; Mon, 31 Mar 2025 12:04:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E2BA4280003; Mon, 31 Mar 2025 12:04:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D1AA5280005; Mon, 31 Mar 2025 12:04:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id B3FFF280003 for ; Mon, 31 Mar 2025 12:04:38 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 557921A0D08 for ; Mon, 31 Mar 2025 07:45:46 +0000 (UTC) X-FDA: 83281061892.03.9A1E48B Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf18.hostedemail.com (Postfix) with ESMTP id AD2E51C0006 for ; Mon, 31 Mar 2025 07:45:44 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=Vl23Tf11; dkim=pass header.d=linutronix.de header.s=2020e header.b=aIf8YGPq; dmarc=pass (policy=none) header.from=linutronix.de; spf=pass (imf18.hostedemail.com: domain of bigeasy@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=bigeasy@linutronix.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743407144; a=rsa-sha256; cv=none; b=3o2irjE0qpAYch0PsjuE427wI0KCWDIujKOWgStjZ9cS+qaJ/sSnB5RwJ7eU4GbpxQp1Cu Q2RD745I2SbjtyMM6/PJvPsdKzON+px8AAaeBrj2f+hu9TVmWhFrsfZM86cG+R9dkjTvMV KI/WTZoS5ypYDl6cXA1EOExn/6ktSW0= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=Vl23Tf11; dkim=pass header.d=linutronix.de header.s=2020e header.b=aIf8YGPq; dmarc=pass (policy=none) header.from=linutronix.de; spf=pass (imf18.hostedemail.com: domain of bigeasy@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=bigeasy@linutronix.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743407144; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QQ/BW6GXmNSlhD+uZ4t2ZYkR1yvCJQ3S7CnL9jv1y1Y=; b=uk2ADZBzzziiekP5GHnSbFw0zw8PqRlnuYh3fKbjIg8H4vQPvOlq7oQ1gZPqnsiwwkBnfa B46um9fDVYHnCVXTyuGPUkAb+PDe0pTiYMCS1QVEuZ4koTPt+JUwOmQ8fbLdhnuTx3ecXp +7+TVomOSvpF1xOglEYDgHQvhZDaPzY= Date: Mon, 31 Mar 2025 09:45:41 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1743407142; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QQ/BW6GXmNSlhD+uZ4t2ZYkR1yvCJQ3S7CnL9jv1y1Y=; b=Vl23Tf117IRS0N8GCZpT3mpyI5f/8m/vdIZDlPBiKzoW0ZvlR/RLSm2fdecTpsk84JwZPO aqNWOlx+pzRXNWB8wgjq3E68MYDFTi2vqduq8C5yTkhDptkEcmfZiwV5AK5R9isk/8WJlC tIpKx4XVHoWt70JOrKScwLPytPUqgTMt+vlCJQK5arjVjXP6o8BxVRSqwZLO7Y/nrFje0V gissUjTnI0dZac4Eha2AFcE7g+E1xOkaenLwx/UO81iVt0BC67QHK5tE09UjKQZu0Ijx3p SCT2Ds0mdtaq7SND1we5DRnSyzK/cHA9t8Emvi/RLKS4HYGFFfvfIoqTo6JttA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1743407142; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QQ/BW6GXmNSlhD+uZ4t2ZYkR1yvCJQ3S7CnL9jv1y1Y=; b=aIf8YGPqFS8UpqoKhqvAU7P9fA10ugdQ1RoPIZishJZJx9R1P54CgoFNcGw4uRtGF1SuST aXDqXRwiAaj1LDDw== From: Sebastian Andrzej Siewior To: Luis Chamberlain Cc: Jan Kara , Kefeng Wang , David Bueso , Tso Ted , Ritesh Harjani , Johannes Weiner , Oliver Sang , Matthew Wilcox , David Hildenbrand , Alistair Popple , linux-mm@kvack.org, Christian Brauner , Hannes Reinecke , oe-lkp@lists.linux.dev, lkp@intel.com, John Garry , linux-block@vger.kernel.org, ltp@lists.linux.it, Pankaj Raghav , Daniel Gomez , Dave Chinner , gost.dev@samsung.com Subject: Re: [linux-next:master] [block/bdev] 3c20917120: BUG:sleeping_function_called_from_invalid_context_at_mm/util.c Message-ID: <20250331074541.gK4N_A2Q@linutronix.de> References: <20250322231440.GA1894930@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: AD2E51C0006 X-Stat-Signature: pzzwdo8osjret9rtqkse4rpt6yjc6wxi X-HE-Tag: 1743407144-423691 X-HE-Meta: U2FsdGVkX1+dghVUSL0nIwRebwcAXealw4XMetqfYVHHT6/QyDKofJZPetFKWOePys0gNWQIP5TttAddOaKYCo+SzZX+g+hgDA/nVlyKW/E5uVWroOgLABhn5PUl/bOxlqPKK+jVhZlcm9k9bCfDevhanwKUa00Q63uiTlqW0TUGz2bzrUnVVeQPBBE0zS5+rD9M2ryYdTqLZ5r58ODsFM3SwbQXhrtIbBEJBfzFodGx9gCxbrQsWEE1ko8zBHh1og/0hEkB+JoAfT+7EC6I9F87fKGJhsz0A80eu29L5eOZRg7gyvVh1fUs8GAdaTNCn5kkDPj0RkhWbDMP45fMma0DKMdGALsU+e+OI5BVBwSKKxPr+xgtxJ1T1bvs8/uqVX1+Qb1SfdDDfaXBOLtdxCIp2F8+HooscApusR5WrCA97A976ZCLflK1Wmbv8WLmWc6PAyNIsGu+/2L1Z9HiykuVnT8Di59j1vXFTS/qMOvUu7YYzOb2GGdf5QlKCNvOYaY6oMTGGNmJwhDjU2gKNSsIoc6/Odo3OlM92CbICwPv9KmMz0HZIqAfTl8Su+rsVYSuyLxH3L/q7u/aknW8HujnBb54qQnULi9hd0v6KvUc2/U+h4nX+4iUElBBzQb9M4+IDDF7bCrJQRohJy8hjOMxgGz7qgQdsuf6MUtmEA/p1X1nVrVYjDKlH5X/bwgB7niIvZube34bH7l8Y18ZOjkA6ukX3T4YK4jovkUGieQ3YcSZRlVTs/pK80FTE6/38HksHY093VFQ5mNXiyw/tjf/AgvrJZIJ/tRHbpHRn1W3D8KNax1DkjS8uxIcVEKhQoGMq6tt7uWL9tnCa2JpZE0Imv6wQS5dqC/B3jC1eKXLWUksipnuLiiJrSRLmJrvrC/A9DIukCdF36wMWha8HDtu5QOHiOR8rmjXklYKhW1G+qpyFW9oqwIFRQczmTQmfnQLtUx9am4gbmllNsx OKbdRDFC Exne2T3/jPuoGSJ39lKCEWwZ42j114KDMXo0/ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025-03-28 17:08:38 [-0700], Luis Chamberlain wrote: =E2=80=A6 > > Are there some preemption configs under which cond_resched() won't > > trigger a kernel splat where expected so the only thing I can think of > > is perhaps some preempt configs don't implicate a sleep? If true, > > instead of adding might_sleep() to one piece of code (in this case > > foio_mc_copy()) I wonder if instead just adding it to cond_resched() may > > be useful. >=20 > I think the answer to the above is "no". I would say so. You need CONFIG_DEBUG_ATOMIC_SLEEP for the might-sleep magic to work. And then the splat from might_sleep() isn't different than the one from cond_resched().=20 >=20 > Luis Sebastian