From: Siddarth G <siddarthsgml@gmail.com>
To: shuah@kernel.org
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org, linux-mm@kvack.org,
Siddarth G <siddarthsgml@gmail.com>,
David Binderman <dcb314@hotmail.com>
Subject: [PATCH] selftests/mm: Fix loss of information warnings
Date: Sat, 29 Mar 2025 03:30:37 +0530 [thread overview]
Message-ID: <20250328220037.149763-1-siddarthsgml@gmail.com> (raw)
Cppcheck reported a style warning:
int result is assigned to long long variable. If the variable is long long
to avoid loss of information, then you have loss of information.
Changing the type of page_size from 'unsigned int' to 'unsigned long long'
was considered. But that might cause new conversion issues in other
parts of the code where calculations involving 'page_size' are assigned
to int variables. So we approach by appending ULL suffixes
Reported-by: David Binderman <dcb314@hotmail.com>
Closes: https://lore.kernel.org/all/AS8PR02MB10217315060BBFDB21F19643E9CA62@AS8PR02MB10217.eurprd02.prod.outlook.com/
Signed-off-by: Siddarth G <siddarthsgml@gmail.com>
---
tools/testing/selftests/mm/pagemap_ioctl.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/tools/testing/selftests/mm/pagemap_ioctl.c b/tools/testing/selftests/mm/pagemap_ioctl.c
index 57b4bba2b45f..f3b12402ca89 100644
--- a/tools/testing/selftests/mm/pagemap_ioctl.c
+++ b/tools/testing/selftests/mm/pagemap_ioctl.c
@@ -244,7 +244,7 @@ int sanity_tests_sd(void)
long walk_end;
vec_size = num_pages/2;
- mem_size = num_pages * page_size;
+ mem_size = num_pages * (long long)page_size;
vec = malloc(sizeof(struct page_region) * vec_size);
if (!vec)
@@ -432,7 +432,7 @@ int sanity_tests_sd(void)
free(vec2);
/* 8. Smaller vec */
- mem_size = 1050 * page_size;
+ mem_size = 1050ULL * page_size;
vec_size = mem_size/(page_size*2);
vec = malloc(sizeof(struct page_region) * vec_size);
@@ -487,7 +487,7 @@ int sanity_tests_sd(void)
total_pages = 0;
/* 9. Smaller vec */
- mem_size = 10000 * page_size;
+ mem_size = 10000ULL * page_size;
vec_size = 50;
vec = malloc(sizeof(struct page_region) * vec_size);
@@ -1058,7 +1058,7 @@ int sanity_tests(void)
char *tmp_buf;
/* 1. wrong operation */
- mem_size = 10 * page_size;
+ mem_size = 10ULL * page_size;
vec_size = mem_size / page_size;
vec = malloc(sizeof(struct page_region) * vec_size);
@@ -1507,7 +1507,7 @@ int main(int __attribute__((unused)) argc, char *argv[])
sanity_tests_sd();
/* 2. Normal page testing */
- mem_size = 10 * page_size;
+ mem_size = 10ULL * page_size;
mem = mmap(NULL, mem_size, PROT_READ | PROT_WRITE, MAP_PRIVATE | MAP_ANON, -1, 0);
if (mem == MAP_FAILED)
ksft_exit_fail_msg("error nomem\n");
@@ -1520,7 +1520,7 @@ int main(int __attribute__((unused)) argc, char *argv[])
munmap(mem, mem_size);
/* 3. Large page testing */
- mem_size = 512 * 10 * page_size;
+ mem_size = 512ULL * 10 * page_size;
mem = mmap(NULL, mem_size, PROT_READ | PROT_WRITE, MAP_PRIVATE | MAP_ANON, -1, 0);
if (mem == MAP_FAILED)
ksft_exit_fail_msg("error nomem\n");
--
2.43.0
next reply other threads:[~2025-03-28 22:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-28 22:00 Siddarth G [this message]
2025-03-28 23:22 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250328220037.149763-1-siddarthsgml@gmail.com \
--to=siddarthsgml@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dcb314@hotmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox