From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D85CFC28B20 for ; Fri, 28 Mar 2025 23:22:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7F39828016F; Fri, 28 Mar 2025 19:22:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 69433280165; Fri, 28 Mar 2025 19:22:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4723A28016F; Fri, 28 Mar 2025 19:22:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 17B5C280165 for ; Fri, 28 Mar 2025 19:22:45 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 20FB7806A4 for ; Fri, 28 Mar 2025 23:22:46 +0000 (UTC) X-FDA: 83272536732.12.C3F356D Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf26.hostedemail.com (Postfix) with ESMTP id 6EF3614000B for ; Fri, 28 Mar 2025 23:22:44 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=eKKomaXE; spf=pass (imf26.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743204164; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=p6UUgkJ5zX4Bbv2EXxAed7dSc6mUhm7pTbUYB1cu6zs=; b=EFVxvB3+7VzXGyJ7tviAgE7lYHKOuoNeXuJQcKDOjF9IOzWt7NRpPdylBAmnjE98wlxAL7 Jkr3yCbMuWmA3eVxmyXunJKr3UHh5NMi6UhBhlfrH8aBL0aGFC4hrApG5pvNEbNrLSVFwH jKTA462vRG3LKvenmWJjlYChKW7DyLQ= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=eKKomaXE; spf=pass (imf26.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743204164; a=rsa-sha256; cv=none; b=lL7RhT1DBegQh9qUtYdyuQ8NMUy11Um04H8l+0kpZh39oLkp2/VBS+GJ6pJhB9AVq3yAmw sUmNirUTPRj7Eaz4Kbf/+fxikrKJ53QK7HZXgi+yrrntzlpcgSHdLFcix3GQbN9WuWgqtu cCwaSevC33elKWOjZE3wjb3fUycNV3M= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id C03A7A43048; Fri, 28 Mar 2025 23:17:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 02C84C4CEE4; Fri, 28 Mar 2025 23:22:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1743204163; bh=Gw8j7vbtBV8cOx3P6MxuxBcJ1K1VyJvT6sET6jo8Bfo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=eKKomaXEwp5zWIJm6Ia5naY1FQNEmL7jJTFw7rVCwvwkddfj/l7F1DU0713kSpQXK pfDWHfZSp9DEcZN7JnBqG+nBFwS3LazekPyx9o6qNYiM8y8dKD9vk5eNvd+9KS+T+z IJDjMz4MG2dmgBB8Yf42fSysibJ+/f6qg+Y9r/LA= Date: Fri, 28 Mar 2025 16:22:42 -0700 From: Andrew Morton To: Siddarth G Cc: shuah@kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, David Binderman Subject: Re: [PATCH] selftests/mm: Fix loss of information warnings Message-Id: <20250328162242.3f7d3f0223efb9a20889b67b@linux-foundation.org> In-Reply-To: <20250328220037.149763-1-siddarthsgml@gmail.com> References: <20250328220037.149763-1-siddarthsgml@gmail.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 6EF3614000B X-Stat-Signature: c59uhioetc7w5xksq1o7fat791p9dmma X-HE-Tag: 1743204164-11291 X-HE-Meta: U2FsdGVkX1/2Uz9cFuPm2dI/UAJ1CIKM/KRb83ww8zvODSIG1py1DVGmcG0NNLCfZrP7eHGagTW3yVRjdpvtIg+RIKhe+3NQyGrgW81VfttIVttAdAR9PnvvbmZVj5cbsPQLc9agJIzvhA+ABNggQ9w+txT+rH371zybwt5g8VDXqiHuqXuFNzWAGgm6YpaT1mZOwezzfN1axfOT4UoYaFQ89OMmEzHd6hFb887MA8FKH5wlfccXx9lNagm8Zi2RlZHVToIpCT+ekSDdLHkqoeT0TSFTr+kBeG0nnRMnKqbc9d7l7QDbakkhysNJPD2gfwV/+W4vgE96ppQ/iuOnih8uhftfly9Yc+Jvu9J17xZFkIpoHMHsydotr3KUkudBtkSviKdvEFmlDKqfhbteqFxuyx/PiDvVAdZqfzd+igqOV2qDIVGmj2BKowGE8dcT7VWY7m4jtuM4Tj92eNaACNuOe4NAF+Xf8M/+3IJhcaWDACbyh0HnKp7VBoWra8IpFhcsJ3rxKQfKRor5IkqNcE9/pkYLLmLPSRa4IJbnHfL7D7AMq8JU6UErRfGuBvDGhSXzbkEzpMtBx5uNekANvECsDqXReUkgcYSbpCDg4Vk/d1w1XPybZS5Fjdy844okjFWB2jXkXEg6l+9aIqWM9gRgj7nctFBDwEk5mMwSgXGz3+U8QARaBkb1Rfjaf5TvAT7KGdL169aKatbCq5FsyFrCea4WNLnKvu4PxmJRUZXZMSEFKGmBTqlwmjq7RdToKwgOBDQjASSHuZeHuax6KoAWzuc5piQlXrqAm2HUZoB4zbTJHCsx+VHaqXhD9lMFaN59RHAKMTccuuOuzvmJWEWdqPUuwW51NiGOT0+HtYaTcEjEZSktqRpxJSPkbE6KEfOP/kqLRLpVkZLYrArRiSPw6QKWyZ9hXY0XKJvHcOfshPWzv/jHw2/NtMgi+0x8rgklzxwVEJ3KjBHx2X0 0Uqzr313 3QmVKD1PmRe5/PzfP0J+uOC4GLmDCL817HFc29kKcI3F6OnnZ61hcLSIEAaW2gepRLkPiwwE3opKdYb0GebYjyWHl2ziZZnmlzUPIyHeJHGQOcwWPGGoy75ZBczuJFNgqCJ1jNRCKZhlJ4WWkR2aYJHjrW1cqlvxW3FVQyho80BT6Hvr4hOclYQ111xigqUNPnJsgZnMKUeJp5+yr+uc0gX2dAn3oCxuoh47psUA7FVPQaByDb1BViLhDs8iYzZc2iofjLVppWlHU+NNh01gbNMyOgFyIAtTEwu74 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, 29 Mar 2025 03:30:37 +0530 Siddarth G wrote: > Cppcheck reported a style warning: > int result is assigned to long long variable. If the variable is long long > to avoid loss of information, then you have loss of information. > > Changing the type of page_size from 'unsigned int' to 'unsigned long long' > was considered. But that might cause new conversion issues in other > parts of the code where calculations involving 'page_size' are assigned > to int variables. So we approach by appending ULL suffixes I think that approach remains preferable. Keep changing things to `unsigned long' until the warnings stop?