From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53F95C3600B for ; Fri, 28 Mar 2025 00:55:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DD90A280123; Thu, 27 Mar 2025 20:55:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D87A7280120; Thu, 27 Mar 2025 20:55:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C5114280123; Thu, 27 Mar 2025 20:55:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A705B280120 for ; Thu, 27 Mar 2025 20:55:46 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 8947DBAE79 for ; Fri, 28 Mar 2025 00:55:47 +0000 (UTC) X-FDA: 83269142334.26.74222C0 Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) by imf12.hostedemail.com (Postfix) with ESMTP id 8D07340008 for ; Fri, 28 Mar 2025 00:55:45 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=HjzTxjiJ; spf=pass (imf12.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.46 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743123345; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=y8G81JEz2uI2RDXTwyc99Q5aIzsfFZJ1dMtQvoEzCQ4=; b=EPfHMW+yxuWJzAo0hdhTcGDHJ3fkTqFjnsfL8kas/yJi0LHSIKOlGt6TLDTUuHvL98R+aF oxKH0shGS5gQEmD0edNDK9K2SwSoGFPsYQ/Q/ArThY+2krxpk7pKpQTMTMAnkNtetI4c6Y gj8kCQPitXg9AZ4fjWoaRVoJJOs55bo= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=HjzTxjiJ; spf=pass (imf12.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.46 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743123345; a=rsa-sha256; cv=none; b=S40o2mVFTgkQF+pIVyFAvt8P8kyTJU8gj9QddU6g0dtZU/kgStq9aQKSx0EfjrvJFiC+FW ZG7BbHx9t6qc2WbkqkvNQw2ZIqj+4lvCCGX6fvWbm6Cap7+Du7F6HJc1i3tOl3ggtiPakp E4vZ0YN5D9kp/AQB/f9umqwWA0rcylk= Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-5e8be1c6ff8so3023296a12.1 for ; Thu, 27 Mar 2025 17:55:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743123344; x=1743728144; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=y8G81JEz2uI2RDXTwyc99Q5aIzsfFZJ1dMtQvoEzCQ4=; b=HjzTxjiJ3vSXJaxd5cAZcxX72sguhifR6i7VCMVQUuEZ3Hu9/g+G4jj1Ff73dII2W4 gOUDBFAIe7356pUXk7A4hsFMX80GPlXXKZ+WR47XuEnlnyDkf8Vws2OaTmfaHmfb6XuC 53DIwTkmBzG/rosM2f6J+844rGARu7VTW1w3GRQi6Dr2byqGcgRkbUyAXf6xdNpeCHPN 7XK3z4EKHGC+1s3LAMbuBY5+Kvxb3cZp2iwYfNzIeHsaGV6lFGWeYKtQ3PUyEcd61UMY qEeMtG7185Jwwv/PfAYX8lzAPRiuRZQYCFgePREpaaDzD0coyJTHKw3W0cL/291opiil raGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743123344; x=1743728144; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=y8G81JEz2uI2RDXTwyc99Q5aIzsfFZJ1dMtQvoEzCQ4=; b=r1RHrrlg82A7pHCmHqMB/of/+V4lrR0rq2DfqBk2sfjbZZM4kWp98GL57o1SJITgvc 2GQoP/dtL/AE8WR8QG4Odn5JhbWkXaZRI5d49ergZwlX3ANuwe/Abhu9M287zp4JB+c9 79cNKGIfR2KWzyk3B6CtYNzADzDoBPCTp+dit4pgd3Os/yd5pQAaOkDZ61x1o4bgZgLV PdAW9OTS7nGynmxT7GnWgWdNx9ArgWo/qPrpFJw8A5iNymlWjkBKiEOq4qQvHut9MZXd TzAvkAfaZzj4ZhCocY+/dEOxURkyz5tn4Fr4yO2P33S3BfB8pEZ+gGCmcT1vWjNvMsVH 3epw== X-Forwarded-Encrypted: i=1; AJvYcCVVOjduQ7rFpnHHPu7YF2M5pay8z4T/PStUC192AphCVgTlLj7Fd2Stp9fb8tVPUs66zOOTiFzXug==@kvack.org X-Gm-Message-State: AOJu0YzUOT3G4R1YtvQDInfnSSDaI4AKzAKeWPaEcFR8R2xsAHj3FFQR hgfBqjiLRa7bflNnQjWtJxhUVcD/hH+p54BCIJHe9igEnRf7pgtI X-Gm-Gg: ASbGncsg62O1T3t8of2mMIWEq3cT4pZ3IFHtLk3CqbAOEoi2EOyufAkdfB7afCZmit9 XkOJcWC9IwPiJyqCDa6Uf3t3oEFJgul1QjZW0ZJqCLBy8P2GasxzVx+3BTwMIAFet8v/Dcr2JQl wkgIONKEWMZPq1TqOkRt9ORryHP8MKLmWCftQcMUgswn2OnC33s5nAobuly4KU6Zt2/glIcvOAc hjYN0Dub9wHtVtEq+sX39H9aGCQhn6qWgKiA/EY8vaovgM9CqUENLc21UBwymsWc1P+PL2+0bXt 3lozLzDrhEKWNw59sOkKrsUWB0B281PEvVo70W93Vqbj X-Google-Smtp-Source: AGHT+IGDo0+yCIbyrvl6erWfoKV5FSSUnDNahplQfwCA25cuWKidVAHgKmI6fhzo4C8M81dxJCIWqA== X-Received: by 2002:a17:907:9611:b0:ac2:7d72:c2aa with SMTP id a640c23a62f3a-ac6fb1bd18dmr568959066b.51.1743123343637; Thu, 27 Mar 2025 17:55:43 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ac71961f8b7sm73949566b.121.2025.03.27.17.55.42 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 27 Mar 2025 17:55:42 -0700 (PDT) Date: Fri, 28 Mar 2025 00:55:42 +0000 From: Wei Yang To: Andrew Morton Cc: Wei Yang , kernel test robot , Masahiro Yamada , oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, Linux Memory Management List Subject: Re: WARNING: modpost: vmlinux: section mismatch in reference: mm_cmdline_setup+0x94 (section: .text.unlikely) -> memblock (section: .init.data) Message-ID: <20250328005542.q7oumy7v2bvpuyyd@master> Reply-To: Wei Yang References: <202503241259.kJV3U7Xj-lkp@intel.com> <20250327011312.mj55byrfatiprddh@master> <20250327123624.bd59f1307d5c5b29b1b9ac08@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250327123624.bd59f1307d5c5b29b1b9ac08@linux-foundation.org> User-Agent: NeoMutt/20170113 (1.7.2) X-Rspamd-Queue-Id: 8D07340008 X-Rspamd-Server: rspam05 X-Rspam-User: X-Stat-Signature: 5ma5ub96t9ighzfbwm5843oimozstnx5 X-HE-Tag: 1743123345-21093 X-HE-Meta: U2FsdGVkX1+Yz8PGxPEYHI/YYuIFmy9ny3RLN89JVEkf6wup4TFlp+y8tuivQ6LZXZO5lgPjm6kzj9wO5it2G59T+t/bRKl1CvIOBegslOOnRzEVCee6FO9QMDuZ52yBGr31yPYy2Y62TJmaMNBrlnvPHFsAYIOohGePbp/Jti6c/To3+YrR+BrdtubGwSBwoQVJ3EUboUyqjXhAPglPBI7VaxbmTri+9SOBd0mmfs7eqTUAJPT4EG/tQVV4rybfDQJq4Qd1ADQgfA/Olj4gwbp0FqnU0ryEUbZzaBhREvqqIVpWWl6j5HGtqQ50ASwQdOvHgZGr/4X/DNH5LZn4zR5e3qiCL7qMKp+lFcf5Laly21phJpIH/e61kkHs+IZLrfkTddqxjT6tMSlY44GDoBIBtOkdYcDt685c7d85aty1gBIIyaVp8L8sTfVQ7LfhLJ8wndHX/8igd8LFHhKLu+fckb8/7iDZScSLTN7oxhbgVkdLoCT2QSQAqV1tFRWBe/Hg8u+xFqM7b21BTY8SjwljcDMRq/EKBR9vH+sCcZ8XY7hp3EI7DzINXZ5UyMV6mcqb3QtxPsjFQzoeRwzLnml56JUA3OvLRREu9xnJ/fLnEeUA1KoRAHkiSDcxmkj2IyqaF2UuoJRRdLvYJEd2bdY6KkVdt7eX/HI0bdbCItmi61/Rs6E0Z7c4XCjR2sKh+V6mAEkLYpJzdSizSq+KZoasIBvHBmlJ9aufZQ122haRcnbs9FafoRQP2AqxgKzOo8FMqXQLlYVibjQ9+H0ozSHh65kC03+aCNvsc1K2d9uzi9321itTrhEnmzg/28ZpY5CNt7LIFoaGt7AJMoMBNyekwcYTVpvs1/4tVtiB1ZCu1CBPq8hqRtua1UPtt5wnZj2bUNg4hcr2Tjv7vVJzzYMV0tY6a54nxCJg5q5Dsq8eTJVhCjNqixQf0AhwQWUcs8SC1cOkmD6Y4dUTI/j 9argLAA5 h3aUPmnsfPkMNg6bNiCZ6i8sbL3CmtQDsb9EsmUhe2iMX/jh99vrtsPSSq1QQMEJ0083w2oKkJoOu8tRGEXc5RbmV2QmzcQNhSODC7+dmy229o96PIuTsV/BOl6niOO0M0tp36pLS2zBDKUF+UvhVjzQou9m9djTbe5MSA39IW6N+UL2GCl3ANF5U0dcyYYFFoW1/MiUuGPliRGbfq5NWgUHc7L2m7riWBzrCQUN5K1njYQ+09mJhibht8qyCd+CWaOGgb1JiooFYnjCD0fCCCkQLLQuZnDAJKbBQC4TmNunfr6CbOk8vV/AboeD3OmO3/FdDOno6HIB3pQckf+gIFRghrEvCW8I3mf+DD9DDfkhijQaVRlYfh92jjcZx0Su0vjCxDvd4vivkotTBD8imT5C1/xgkaSfgC8FyE6Vglr9WsidzcnpeTPr9aP41Tq6FD+VYXc7DeT4I78CoBq9LlHCI+wOXA12TO9aue2A9aKRf/OCQexlGILGgUZL7+JD5eoIRMX3KTNSd/pNPoGs+YRuXX1A1vXcoWkyuADhXkufTwJPw/04rZXMlFvUEXvlK/YP/7glJFWvy1JyU+/Im9nUI6tNYZnFc/cqwsgnakH5YOyB0kJXCTD3u1v78oP/3tGG3bhBzn0/4/X7ERR9zEv0NHshF1NTuT2ADkIoFoTDnEyQfClZ+hL6umFAQZEsVShK5gQKRORPx1UsRdg0LFhSi6nNpx7i5G5W2Qx0bdoeYqk8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Mar 27, 2025 at 12:36:24PM -0700, Andrew Morton wrote: >On Thu, 27 Mar 2025 01:13:12 +0000 Wei Yang wrote: > >> Since it is only used by mmu_init() which is annotated by __init, I think the >> proper way is to add __init to mm_cmdline_setup. >> >> >> diff --git a/arch/microblaze/mm/init.c b/arch/microblaze/mm/init.c >> index 4520c5741579..e98cfaf1c62b 100644 >> --- a/arch/microblaze/mm/init.c >> +++ b/arch/microblaze/mm/init.c >> @@ -143,7 +143,7 @@ int page_is_ram(unsigned long pfn) >> /* >> * Check for command-line options that affect what MMU_init will do. >> */ >> -static void mm_cmdline_setup(void) >> +static void __init mm_cmdline_setup(void) >> { >> unsigned long maxmem = 0; >> char *p = cmd_line; > >That's a correct change anyway. Please send along a patch sometime? Sure. -- Wei Yang Help you, Help me