From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EA3EC3600B for ; Thu, 27 Mar 2025 17:09:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B958628010A; Thu, 27 Mar 2025 13:09:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B1C452800FF; Thu, 27 Mar 2025 13:09:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9972E28010A; Thu, 27 Mar 2025 13:09:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 7B2942800FF for ; Thu, 27 Mar 2025 13:09:42 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 48339141351 for ; Thu, 27 Mar 2025 17:09:43 +0000 (UTC) X-FDA: 83267967846.25.3B8AA95 Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf20.hostedemail.com (Postfix) with ESMTP id 544141C001F for ; Thu, 27 Mar 2025 17:09:41 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b="Y/0agaZd"; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf20.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743095381; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qZUNinMbG6xFv949XeNqIHvfDyV9uAyDOlNCvnC1syY=; b=o89wq3I3aMTxhoZFSDlkAWttZW/CtQN/jKn4HM/dMCrIytC701TE9xVee6/yK4u5Qc8Vww zvmNZ3nttv/9f5Elen7Lu2YT3D6RInAWFPk4oeKfCAVSheeYckjZFKAYGgJBIluBsd2mUo yi6++ZN2Rq5azzzFRafwwFQPY2exG/Q= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b="Y/0agaZd"; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf20.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743095381; a=rsa-sha256; cv=none; b=MYpKt/wmeefpQnSW1GhFo26rtDJBWPlQ9/SGqlJwZ77nzyIq5Zq5seuCDMiobWxiTXiZ5Q 0ZLRUGOKQ4q6jlMyK3qprmfqls2/2/AHQlIeYWgy8LJxEV/sveFuyT8vVNzX4MvF76I8bg PoHZFfTmJk3y3vDZlJxLOJSGwVspPtU= Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id A59E640E020E; Thu, 27 Mar 2025 17:09:37 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id mxc8vZqOWA5V; Thu, 27 Mar 2025 17:09:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1743095372; bh=qZUNinMbG6xFv949XeNqIHvfDyV9uAyDOlNCvnC1syY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Y/0agaZdSd33YCrsI69LFRQ9SzszRvmYA/kLx9tDenLQfOHbJuvabiEiVKNY0Whgn UiNR65iAva3VgnMtqRiOnLc9B5Hk7Env7HjwfIQOm1UOtC7XLHG325Cf2DBfntWMt/ AI5HhE9RRmlnApfC2JLuz70KoDKYKr5I4qOpbRjM48OOjSkwXeE/nbIgLJUDbI1Nsb 6jUORe5i8CCYeXe74Pd6hY615uiIHKXYZ9sE958ImtBiYlN+siCe5X4r91EgkGVdiz 8zYgegaG9S91Nw3bUAKUx3APdL5wiykJLlqih+JdDDuGUEtgufhC0MPjaqERD/mJP9 1gbCxgllugKSbCcDXbrF/DD7zC8acyhTX6gegvKjJv5iVb6Pqq1tctlvuZt7P22DVj xP9BNMOyqF/CDoe7NNBIplM2eqQuK1x6EZQH0DS/+V+qX7SM4gPpFMMYZQNt/oueCu id6Fq8IPffI+eeu3rVys240GOIXoeY4PlaRD63mNAuS1d79EM8AH86+AQlh+ig/zDu 8h+AqfJY+SHOVbVSZ8OGRrA8YUDQLfa3yBET2Whvnd5r9pUcx1fk2xzzvq16Hx7TCu cuRCfAmyHBoZigThlyUYH6MRagX+2Lc+Pi1QLVFLmB0Xr2EwixoLGbSp9kBDtGlAMQ kX+3am8K14cpRr25XSwsW9i8= Received: from zn.tnic (pd95303ce.dip0.t-ipconnect.de [217.83.3.206]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 1DC9A40E0169; Thu, 27 Mar 2025 17:08:49 +0000 (UTC) Date: Thu, 27 Mar 2025 18:08:48 +0100 From: Borislav Petkov To: shiju.jose@huawei.com Cc: linux-cxl@vger.kernel.org, dan.j.williams@intel.com, dave@stgolabs.net, jonathan.cameron@huawei.com, dave.jiang@intel.com, alison.schofield@intel.com, vishal.l.verma@intel.com, ira.weiny@intel.com, david@redhat.com, Vilas.Sridharan@amd.com, linux-edac@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, tony.luck@intel.com, rafael@kernel.org, lenb@kernel.org, mchehab@kernel.org, leo.duran@amd.com, Yazen.Ghannam@amd.com, rientjes@google.com, jiaqiyan@google.com, Jon.Grimm@amd.com, dave.hansen@linux.intel.com, naoya.horiguchi@nec.com, james.morse@arm.com, jthoughton@google.com, somasundaram.a@hpe.com, erdemaktas@google.com, pgonda@google.com, duenwen@google.com, gthelen@google.com, wschwartz@amperecomputing.com, dferguson@amperecomputing.com, wbs@os.amperecomputing.com, nifan.cxl@gmail.com, tanxiaofei@huawei.com, prime.zeng@hisilicon.com, roberto.sassu@huawei.com, kangkang.shen@futurewei.com, wanghuiqiang@huawei.com, linuxarm@huawei.com Subject: Re: [PATCH v2 7/8] cxl/memfeature: Add CXL memory device soft PPR control feature Message-ID: <20250327170848.GDZ-WGIM553HJ61xj6@fat_crate.local> References: <20250320180450.539-1-shiju.jose@huawei.com> <20250320180450.539-8-shiju.jose@huawei.com> <20250327170156.GCZ-WEhNREaxQaH_ya@fat_crate.local> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250327170156.GCZ-WEhNREaxQaH_ya@fat_crate.local> X-Rspamd-Server: rspam01 X-Stat-Signature: o5mbmpe5auj1rsiepwjwng4yy4ma3ugs X-Rspam-User: X-Rspamd-Queue-Id: 544141C001F X-HE-Tag: 1743095381-995207 X-HE-Meta: U2FsdGVkX1/Xh60NdhNgPuwDuBZjURxF1kDNXK43a6d0idifjFLpWB6laWjT1Gfz1AfvPeA/fZ8K8amCzjtZ8p0nwEuGG/M3VhO8t/r0JRWZCFhG7szvua3mU6f7QQ6qzTOaOUgQ8wJSpcwyTE6hz1p3LXtBezHFROdXIQ6JC49aM94D++es3YkfynNk9nT8vT5MUc+RcX5a8+agRi0KW2ZuL/Ufar0wnKnG/NEprldUCwcNEmz3IzV4xiHZXIbXidskEWdSfgOasl8GOd9OIxA3bG2LZ+GLXOmvcZmJ1MomFgS5Jgw5C2Xl4qpnCPV/ghHkYlzam3e1IUB0K+0YaoFeL/w7PdnF14g+qVick8ntzRtiNnXHH7XNhYsUgANWhpfZ0gncOrbw5uSXXgxv1bTUq730RfALiqQGI+6AHD+6hNIbquBnIYvegLyyitnL9rXK3C0j9d28t0RnIyJvSpP7DfLBrucFhr9jzACAhDFroTXHzFvhdZKkm8K0D+NaFWBUnElpiSwDpNoih5tHOlFrpdPP+2QSASdiFbsCFczepwd2ofAKtXUumh+XCu3UVHhrzCRbRk8No3356i+RqCELUmFzVKM9Jv/iWfDEd1AVIwzmF42W5l8jihZ0YqVlLg+Am1Pw72VcAOiEVouG6PZCuFE9zTJn15untmbx4rM39kVVkavd+lxPvO9//NsOlFaB/tmlTEXTSRuaW9JPZa1gbZs64OJwzydjYNx5ul9Ug2UBCsghs/9QLYHFfysolc7pO6gdo+OaHQ/ZV9lTmkfvd/8ob9lTyM9nSr4kn/rDjppEw0iS+Lq3DgJERi1peCs8FG51kimWgQvA954ep7EvsaeuE6dGJWDd2hSqyZrXC5AFFGDGecBBpHK46Unbc8C6Qt86EhtvZuqVK/XBW3EKVH5RjSemp3uBUIAh1sktbokfxCFkJdMRvZ5g7Huiwl27k9/Fi9SvO7bWidx TSfvx57D mz10+Uok0G08M/kGmt7OjxoSGZrmWDD0uyeAJsOkj+5t4hvk4fb+5IE0ly7XniFz1KleWcqpit9Hfxq85tNOgAyy73G4mJaY5oPgTH77nczS+IfMQWOW4Zxk47bOVVG/+9YCgHhz/6D/6T5ylQuWRwDkCCquseXCrXhm+pZ2G7Sb42Typ1M/zKP569Sob1vsRQJQ9QfEy/NhFlGrntN1AgWcyWBgMGVKLjTsFSfPA2LaFOzX5FpOCbDkBnXhclsITLK8BTRy21Qqv3UJlzJSzR2BxLx1gm5ngUh8/xmrwUUMvCPl2Zm5OnsevGKJhOk37LEEDqSM63GTxkIMLZQ+DjkOZDfBUwX1Zpdf9mCCZGmgyG5A= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Mar 27, 2025 at 06:01:56PM +0100, Borislav Petkov wrote: > On Thu, Mar 20, 2025 at 06:04:44PM +0000, shiju.jose@huawei.com wrote: > > diff --git a/drivers/edac/mem_repair.c b/drivers/edac/mem_repair.c > > index 3b1a845457b0..bf7e01a8b4dd 100755 > > --- a/drivers/edac/mem_repair.c > > +++ b/drivers/edac/mem_repair.c > > @@ -45,6 +45,11 @@ struct edac_mem_repair_context { > > struct attribute_group group; > > }; > > > > +const char * const edac_repair_type[] = { > > + [EDAC_PPR] = "ppr", > > +}; > > +EXPORT_SYMBOL_GPL(edac_repair_type); > > Why is this thing exported instead of adding a getter function and having all > its users pass in proper defines as arguments? > > And "EDAC_PPR" is not a proper define - it doesn't tell me what it is. > > It should be more likely a > > EDAC_REPAIR_PPR, > EDAC_REPAIR_ROW_SPARING, > EDAC_REPAIR_BANK_SPARING, > > and so on. Looking at this more: +static int cxl_ppr_get_repair_type(struct device *dev, void *drv_data, + const char **repair_type) +{ + *repair_type = edac_repair_type[EDAC_PPR]; + + return 0; +} Can this be any more silly? An ops member which copies a string pointer into some argument. What for? If those strings are for userspace, why don't you simply return *numbers* and let userspace convert them into strings? Oh boy. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette