From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B282CC3600B for ; Thu, 27 Mar 2025 17:02:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D42E5280109; Thu, 27 Mar 2025 13:02:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CF0F72800FF; Thu, 27 Mar 2025 13:02:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BB95E280109; Thu, 27 Mar 2025 13:02:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 9FF162800FF for ; Thu, 27 Mar 2025 13:02:56 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 9D964ABEF4 for ; Thu, 27 Mar 2025 17:02:58 +0000 (UTC) X-FDA: 83267950836.27.35B60D9 Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf05.hostedemail.com (Postfix) with ESMTP id F131D100023 for ; Thu, 27 Mar 2025 17:02:55 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=U4cVd5wO; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf05.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743094976; a=rsa-sha256; cv=none; b=6N14jUnP23k0eh/H7wrV22TtRC5IW+acbPQrNLw2V7FA9/84+A8nHyju1pbfQpG0ImO9IU pL8BuKZ5nUqM9DQI7NC+pvavRozS1zY7ykY+zwmZ/eoyLtQU37p9X+JxFRKrri5bTt80CD 3Jan7rUhfuuubtQC3osBjEmJz7fEbl0= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=U4cVd5wO; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf05.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743094976; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IRroS5Aq4fm3j99yiL8SYLl/wPiF4M3AoqI3PR/tB7E=; b=6WrbfwugjoJbp5/YwSCNSGPdo03M2GN8ceBFrtEqK9gusCwPrVZtWZbMZ+V7b2KX5fI1+T XDY5PLLQAPK6IiUxLB6//UWPvAfOHQ+qG66SqYEx7H1FkDb9jVRe8IQu53Vibfr3t2rcCa zUZ3qDpLA3liRSaSe/+YxnZn6uTRPjg= Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id 16E0140E020E; Thu, 27 Mar 2025 17:02:52 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id XYkpMZ1b9u1p; Thu, 27 Mar 2025 17:02:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1743094965; bh=IRroS5Aq4fm3j99yiL8SYLl/wPiF4M3AoqI3PR/tB7E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=U4cVd5wOPnxt4yWyBLfmqQ+WUieDZ99QsIYy/WEAR+7FhmXt3ZsIaUuHmqeG5Byxc WnDS9D2PXn6v9coYLoqKa47clsCYYTISfxbBgT1/VPR2mWzAAXaYGEd2DI49k6Y6Zp 2JBSU56Vt7UIlGD3znx8NyX56QNIFfbGyRnhNEtJL+NOd3VnvxxwOkuYGOTG3oUhvb 9hCol2/o+qPy+mE6mP8TFg8fEZ3VQbYgB3XmDi+6yZIk/zFTD0cUib8aduoGUXC4XM TOfLxk3k8gA6Pm3fxDcr7lpZ+dji+dO/qVPOG2cbyhkZnTQDwGObUAkxeQAKro/V6/ GWK7tg9r8fkx5U11UjE6Vr5YW97tBdtzHJ3IxeO73ys7vo/bmelVhbfM7hGCPQgOAI AibW/XCexM2Jy0RoPw0BGyv0irML1HCy5U2npjM4kLZlsRbDx01SaiaqCC5GWRQyw9 qhepP8UbRKuUqfbZSDlX/MOnjonNIjrNgrYBOqNHIW6U9M8PSzes5FQAJE1vwcyiqO IUtrjfnmwY65WU+k+nI1xM1CYg6gDFoD0D13ZHDEEYACyGoPzT5tHcmXeYqPoNgChO +CHAuuMz8QFNI22EpYTrs6eDKL/k+pOCiEAjCfU4wJwV6pQ32JQbjuaQN18unQy3na 4/dhhv1pkI56QyswR0Pc5QXU= Received: from zn.tnic (pd95303ce.dip0.t-ipconnect.de [217.83.3.206]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 579A840E0196; Thu, 27 Mar 2025 17:02:02 +0000 (UTC) Date: Thu, 27 Mar 2025 18:01:56 +0100 From: Borislav Petkov To: shiju.jose@huawei.com Cc: linux-cxl@vger.kernel.org, dan.j.williams@intel.com, dave@stgolabs.net, jonathan.cameron@huawei.com, dave.jiang@intel.com, alison.schofield@intel.com, vishal.l.verma@intel.com, ira.weiny@intel.com, david@redhat.com, Vilas.Sridharan@amd.com, linux-edac@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, tony.luck@intel.com, rafael@kernel.org, lenb@kernel.org, mchehab@kernel.org, leo.duran@amd.com, Yazen.Ghannam@amd.com, rientjes@google.com, jiaqiyan@google.com, Jon.Grimm@amd.com, dave.hansen@linux.intel.com, naoya.horiguchi@nec.com, james.morse@arm.com, jthoughton@google.com, somasundaram.a@hpe.com, erdemaktas@google.com, pgonda@google.com, duenwen@google.com, gthelen@google.com, wschwartz@amperecomputing.com, dferguson@amperecomputing.com, wbs@os.amperecomputing.com, nifan.cxl@gmail.com, tanxiaofei@huawei.com, prime.zeng@hisilicon.com, roberto.sassu@huawei.com, kangkang.shen@futurewei.com, wanghuiqiang@huawei.com, linuxarm@huawei.com Subject: Re: [PATCH v2 7/8] cxl/memfeature: Add CXL memory device soft PPR control feature Message-ID: <20250327170156.GCZ-WEhNREaxQaH_ya@fat_crate.local> References: <20250320180450.539-1-shiju.jose@huawei.com> <20250320180450.539-8-shiju.jose@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250320180450.539-8-shiju.jose@huawei.com> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: F131D100023 X-Stat-Signature: 6jk1hb6gcgrc39qadqc468dijkngnk3u X-Rspam-User: X-HE-Tag: 1743094975-889007 X-HE-Meta: U2FsdGVkX1/uEMm9UDn0A+wfqsQeq5jTiNIG9TP1QGjoRWlvKgHcvQi1sIXQwZOg13BS5jp111N820WgbW6HVgj4ye4dy+4R+vA6R1kpap0CdOLh/9rU6a7QQeBQYph29Aq1296FToRWouEscIFzlS1Mk2WukwHD307dtQ7BhPmornCrbmeESJgaWoUT/q4ucks6WYDcDPnNYF0ZLRrmNiUH713C0PRDLXDhPH6caeyr2dVytpe+ucvNB2/Nu5Tnq8eWVCypDxhfQuBvu5t2zvgLP4u4CnmJYnE5U07dMr4n0u8mdvpO1omksww9cGdPRq2nRIFZPwH2WTXRRVmJsL2Et8j0VynlXrMdKPkp0aYpHStUr2nctN7RrRsKaFuj2VeWgz4LdK8LwjdOFt0vp9S9i3xRd9YO11a1E/UUkDmt0P5lBtBlMVFAqCtrQKuOou4IgBT0+3SaxmXGGy6E4PPSMLthekwI6AvHBgpj4fCTn4o8jO90RzG8FYxq7mTgm12+35z5duVF6h5kr1+jrh35EC7WE96HCVffqhCLajGEkEuqHJmRCI7n7HrdI/Zvoc4OGL/PsdeueeWr0FJycDhyhb7VllB6DaMW3RhmGoWmaiN1NzNbigToTj5GCLJFVyRdzUItSZ7chRaPsg8wRKWM3tmLIijaQYDeIDh8vX12866P7uSop3cpmB1L7Qi12PMrUwmv5gWEBBzbVbjXZ+cmuozxtoo/sQH6d7joEOK9p0qk2O4BCXYithXi6NHwnRC20dopBSmh/59eXWILT9Z1e6jQerf2o6BDRt/9rcz9itFQNv2G4foEd4WCTpLZsH0w4I34PM9/kV+CfXjh1jApmcecq04uTG+hi9KZm1gM3P9G4afuKkCEd3U3YdnG/nW98Ha6K4LM76tZ/wZ9SLUmlNqnSoMhLWm2AyXU934FCp+oJjJOW10Iz0sMuDq6wQQmRMtxyy9nYEYRNhZ vZ4ZEU/i 9qJE3WW1/Bx5KjAcMgaU2yNwaQifMIINYyYV1WMlrB1J/wASjW5M9tM1++XuFoox2CoqRtR3sd7Qb8DsblOrV8gGR7sJXqkwOjVVEXmtcIlNsTHj1kv+0Clo7Rz0J66th0zD+OCOF4KuX+B+IyzOerXe6+bwqJfKnBarp3DF2E+RizrTGXWhxAiaSPc9FQtzMhuWRGyywTIG1jYt36D4VTsQsVZqJhcqqqTqdPX99CPOar9RwB3MOMgYDFff3Fc+NCE5MysN75HmVk6d2uywsA6BqeXWE3QS3mEubSDlEjR/AIkj7rvhMpqqQgHR9/6N4HHFUNjz3uWLeamyE8+jXg62PUNmlMx5kl4xcKBPCSJLDc/0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Mar 20, 2025 at 06:04:44PM +0000, shiju.jose@huawei.com wrote: > diff --git a/drivers/edac/mem_repair.c b/drivers/edac/mem_repair.c > index 3b1a845457b0..bf7e01a8b4dd 100755 > --- a/drivers/edac/mem_repair.c > +++ b/drivers/edac/mem_repair.c > @@ -45,6 +45,11 @@ struct edac_mem_repair_context { > struct attribute_group group; > }; > > +const char * const edac_repair_type[] = { > + [EDAC_PPR] = "ppr", > +}; > +EXPORT_SYMBOL_GPL(edac_repair_type); Why is this thing exported instead of adding a getter function and having all its users pass in proper defines as arguments? And "EDAC_PPR" is not a proper define - it doesn't tell me what it is. It should be more likely a EDAC_REPAIR_PPR, EDAC_REPAIR_ROW_SPARING, EDAC_REPAIR_BANK_SPARING, and so on. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette