From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45DCCC3600B for ; Thu, 27 Mar 2025 19:36:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 47A52280116; Thu, 27 Mar 2025 15:36:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4286E2800FF; Thu, 27 Mar 2025 15:36:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2A131280116; Thu, 27 Mar 2025 15:36:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 0AB722800FF for ; Thu, 27 Mar 2025 15:36:31 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id E2D261CAA67 for ; Thu, 27 Mar 2025 19:36:29 +0000 (UTC) X-FDA: 83268337698.28.9F13301 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf17.hostedemail.com (Postfix) with ESMTP id E07664000C for ; Thu, 27 Mar 2025 19:36:27 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=wAseErxv; spf=pass (imf17.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743104188; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BXFUmupSYbE1qKxJzCrdZ84xpZVoKDeBgTN6hekTKQg=; b=WMAOTMZVyVY3vhKpaHh259N5thPlFxXXOH9umPFMOSV3bRk2zlJCdFkzb87XFKDF0d4F/d vASsK7H8AiifoVeQ4fecD8ZL3/o4mDTMFjeyzYjYUoVlfjmrrpHQyADpfTt6Z1GKFU5E3K QEdXl0NfUBcfD3QkOlZ8MPgFeHwc58o= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743104188; a=rsa-sha256; cv=none; b=zHiOxJr5D6D5myZt9jlpMH+D3GB6fsjzNRcIUcjr17tYgYi4Qq0OacATW4UTkcMp0zARai /hCEpfFfeZ8fLojUk1UffdXcol0LQ42SnNXLv2YED212VAOxIAjk28AKo/3KkF8i6i13do SiBqR7tE97GR6g0T8L9gGy6LReVbATI= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=wAseErxv; spf=pass (imf17.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 52E825C6485; Thu, 27 Mar 2025 19:34:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D2F67C4CEE5; Thu, 27 Mar 2025 19:36:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1743104186; bh=hfqieFEwNm+tDHwi7gJU2irVgal6ugfPESMToOGaQx8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=wAseErxvF0eqgqbc1+iMobmw/0QY9Q1xxoTOC0Y/mxlnzHzchQVsl8IaB34977HJF u5F9B9OQSn7EzKQNRUkyO0eGG7SWvLyFGp4WrMSUcARmpJ7fU/j0ezhPFuvhBx+gD0 CNgV8YhGPtRJonuMh/IqDDue98rlDRIe0JJgcae8= Date: Thu, 27 Mar 2025 12:36:24 -0700 From: Andrew Morton To: Wei Yang Cc: kernel test robot , Masahiro Yamada , oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, Linux Memory Management List Subject: Re: WARNING: modpost: vmlinux: section mismatch in reference: mm_cmdline_setup+0x94 (section: .text.unlikely) -> memblock (section: .init.data) Message-Id: <20250327123624.bd59f1307d5c5b29b1b9ac08@linux-foundation.org> In-Reply-To: <20250327011312.mj55byrfatiprddh@master> References: <202503241259.kJV3U7Xj-lkp@intel.com> <20250327011312.mj55byrfatiprddh@master> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: su95zgnr5upj3gekypg19zacsj76sgt9 X-Rspam-User: X-Rspamd-Queue-Id: E07664000C X-Rspamd-Server: rspam08 X-HE-Tag: 1743104187-866172 X-HE-Meta: U2FsdGVkX1/6DlAwFiTdVC9+WKII9PsWgzx8Ln13nXja45aN4VPVsQGbAZAOL3a32Xvkk6Ode5L7HKQPmw5BUybnSrsZ8/ZaBukGzoa9Wyp8oKYt4ugiTbGME/RNV/tdJ7x/ESQosgH+amuYiOrarqWNYcHUpzVzER4SS8qoW9QAPRW64Yt7shN0JuSNH9qo1RhckZeTTBxVlKOBi8DGWaCQLJ1GmxgHbxNcTBNOpaygaHxhzw3PTwMBwH41Im5wI5NGF1D9DA3JImpqqdIJibbhsIXNUZgINYmKiSuaonbtL/yrwQFUIInf2gYJeQdjRm0JgNCErecxq8FxKQ+wH3m0FgMnyBQ5Kn7BMLLauK3BwHgLqN2AlzFM5qrDKsmyZKUMpQUwpflg4PkW6Jt/2DDK8P5dTpBjS/5BqNLnK5dXpq/8PWcWZwoLIhZ5eZ2ZbH9euznziOKyK2b2lQB2mrt3LjFdTD+UkVdMuzoZh95k8w5Kg/3lAdUTaPFvjFQOUs4Ji9w5TGLn7qMlP5CmmT/ggrAn0pH0JRnb8HGx61jZkdOeRGYOvebcF17Rtl+Ad/MFybOK6mKwFSsrVgaUSOyrcMkAzIQpsFeI7enjz9w0eVT3iq3HaN++DEZvc/6deUugkMaG4RaxCT0EsvUSbWJlYniqGhF/F0CFWp5dHr4GwlaiCVtZ26WTuigRBt4z+jQ/EK1VeVfeqBRi/LpNkAAlZDVFRWm92mbscE2vL2T3FRtjjFDp+aCiCC7OKe4MJApf3kuCBrsOrUQv7fyOBxYdSOzKYClfyKUNITan4C/FYIyf2/11jx7YbcnRNXdNwEmmtv7cVrKPHuaqdcSGEt0nQaKUJCImAduAQMV0PDehJnvCW2MF95yY1eOaqwK/DaM11ZgJmjh3LAOCcVngjXx/HY8eiazo4yludpkFVZhFcz658n+j12x/Ch5pSq/49By8Bj9Ss4wMcmTxD8t djtAjBa5 4hP2CiP5VVatdvLTTyy3mJU/9K4XibVXLlbfIMOHe4TwkRMaWR3YQ/kDKoHWHdY5w4uXFD0akUYVuu/VnWex11VZP7dYqpH2gYza68Xv38mLp6GGuu2/V7Wm8CiiXUgG3FErCy6TQKJF3OY/HWrsWnK2W2ksotaDRqgVVhtvR6dNCIPP0djvNnjRO/ufJAIPdQE7j40AmnBKBRUIK3YHSfSmOKri98rOcsV+E0rqPc8lc9GbL1xVGyOBOcUewkWXjGf3N8beIkppSTXFN+OMSm8cd/+Q5Y0oMJeqFU+e4ILxhyQdtv5UAANu+pDmhMuqcsg3rHwV1Kf6jU5EiH2dRw4qIgQpmt/JahlA12WKjvLBgzdNrA4bY7LJJj7/n686daaXfTzWlqNXx4gY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 27 Mar 2025 01:13:12 +0000 Wei Yang wrote: > Since it is only used by mmu_init() which is annotated by __init, I think the > proper way is to add __init to mm_cmdline_setup. > > > diff --git a/arch/microblaze/mm/init.c b/arch/microblaze/mm/init.c > index 4520c5741579..e98cfaf1c62b 100644 > --- a/arch/microblaze/mm/init.c > +++ b/arch/microblaze/mm/init.c > @@ -143,7 +143,7 @@ int page_is_ram(unsigned long pfn) > /* > * Check for command-line options that affect what MMU_init will do. > */ > -static void mm_cmdline_setup(void) > +static void __init mm_cmdline_setup(void) > { > unsigned long maxmem = 0; > char *p = cmd_line; That's a correct change anyway. Please send along a patch sometime?