From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11DFFC3600C for ; Thu, 27 Mar 2025 10:44:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 223EF2800CF; Thu, 27 Mar 2025 06:44:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1855B2800DB; Thu, 27 Mar 2025 06:44:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F1C6D2800CF; Thu, 27 Mar 2025 06:44:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C3C182800DB for ; Thu, 27 Mar 2025 06:44:38 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 82B981C90D2 for ; Thu, 27 Mar 2025 10:44:40 +0000 (UTC) X-FDA: 83266997520.08.DE773FC Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf29.hostedemail.com (Postfix) with ESMTP id CFD32120009 for ; Thu, 27 Mar 2025 10:44:37 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VrZjG8CZ; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf29.hostedemail.com: domain of toke@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=toke@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743072277; a=rsa-sha256; cv=none; b=pA9qENc+zepz7yWxFj28XwBZ8UBc8CLYLljELzJQMCgrsre4vmSQQU3MC35K0EW5V7Xb3D Uk7eT8ZxVRjNq/A8O0ArpM4z2kHxdu8gAW0xAcwxjq+UnWDcPDsZ/zaO0izXKlZJo7W584 WgJZrBXej85VgQMxT7DQrwCuZZzBbZ0= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VrZjG8CZ; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf29.hostedemail.com: domain of toke@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=toke@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743072277; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=WyWvRzluSiEXBBT2a7VCBlnyJ21GZtU6y+n9uBuHn7I=; b=yhQY4iVJfCtoWnKyp8q57A+UF3qw/i9KIbRYXqzFGcQOhgsqUHp60GTaOJsEUzmTeLRLDx gD6cQbP6KbY1y2KbcSOHG7bjoJ+V6b/jNea0qN+JBkckXNFn+Rgugp30UdMXJf6kH34lrQ JqVFjRwKXeUPtM/A1a2Jl9TO4azbSSI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1743072277; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=WyWvRzluSiEXBBT2a7VCBlnyJ21GZtU6y+n9uBuHn7I=; b=VrZjG8CZCndrI4OpuMG7CQ8+/cPwxqWcM0DS/SWZrIQb9txn/NmH1Zh1IMr4zh/7JUpOXl 8/ux8GYYkSh2squS6MITr2ihlBzLmHJ5+OHx1Vy9TQKQA7VjhTLGq7Bt4cFFTD2WzxoCD9 2qojXfHkKR8A/4l3Y3VbEyRMlE6tla4= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-449-YTyFYqJcMw-FFg3BHN_-YQ-1; Thu, 27 Mar 2025 06:44:34 -0400 X-MC-Unique: YTyFYqJcMw-FFg3BHN_-YQ-1 X-Mimecast-MFC-AGG-ID: YTyFYqJcMw-FFg3BHN_-YQ_1743072273 Received: by mail-ed1-f71.google.com with SMTP id 4fb4d7f45d1cf-5e82ed0f826so874061a12.0 for ; Thu, 27 Mar 2025 03:44:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743072273; x=1743677073; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WyWvRzluSiEXBBT2a7VCBlnyJ21GZtU6y+n9uBuHn7I=; b=bJ99JThINBsZWRW+HIgvPR6huJkGukyThi3XzxnHQRYix/S6IsU3+C3npVXWxLik9v fn2gFQRxeLjuhUvRcXHr4Fo7oKwi3kxlmup1oObpwfM+IonB/F7NGnIZwuneK5keYP0d ytCF+S4i3eH26hDggmopXtN3JqaY1kOogZSWg8EPsSXq7DyPeJ8o5FNUhDElIqOVuESU ENJN8ICaYqRLbFtloinA/0uhsRQEk7TLOV/fQYvG6HqTKb9R38UxG0/58R645dmEPRbp tMAESH1Qg3isgozns5qENjx9/2CijndvImt/SJo14fgUal3XfZPNFmJGdHYpeNunMoff nFLg== X-Forwarded-Encrypted: i=1; AJvYcCXzU/d37VdaIP0ElB0s8oORsurc+lKQY4PkSV4bWEa+yu6Hvgd2mgC9TTwcUk+EJbeWGycPsgVOog==@kvack.org X-Gm-Message-State: AOJu0YzIqfXvvJZwAsrl4OY1FrNw2TvkcOVBajTOCxF+cOIkx09/lk4s iM9KRa53IuiTW2XTMnsb+TRC/H1ahGJFQO94IJbUJOOElyYn/5jZR66zQbxBmINk/1KDszVmyjE 4ORpJDuV7wmM0TGM/kWxuqIQ1WSJR9XxIsQQ2ZN1Gi+KU4R9J X-Gm-Gg: ASbGncvJsItKaZyYJyfNtWCATT03KidWUlveE1Ry+dzLcKYsu4I6RkLcJUTe2hCPWKZ S2suVn0BIt1UKjZ2Z9wnNGKipei6rw5RjtWSorFWLV6a/04kWEQ7HbhStwk/uMm1CNj0bStLtDN /EsKsGsPHStZD0DX6z78iKTL2U+5id/WlN3hF5AK74ehc6I8qAIfnaEDwL8fBF0Th48Y9ovwcGh pJvHPakcxM75NyDSv2JO4/1rfMhURNe091Vz79GToasWhK9ZV8IXuH3ftUGJiCLkYnWTqnz/tyd 8Aif12e6bspUHsLI1SW+trjMcRK2Kkns6zGQiQss X-Received: by 2002:a05:6402:430c:b0:5ec:cc90:b126 with SMTP id 4fb4d7f45d1cf-5ed8e5a5d7dmr2920449a12.19.1743072272766; Thu, 27 Mar 2025 03:44:32 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFxY9QVIO/VsgSyaKIBh62Jyrq8IaKt0cDmXoin9ToYvgK/LxQKcrJwZ0uLZmyq2x9mCaJPWQ== X-Received: by 2002:a05:6402:430c:b0:5ec:cc90:b126 with SMTP id 4fb4d7f45d1cf-5ed8e5a5d7dmr2920405a12.19.1743072272282; Thu, 27 Mar 2025 03:44:32 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk ([45.145.92.2]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5ebcce36d66sm10908646a12.0.2025.03.27.03.44.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Mar 2025 03:44:31 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id AC5B618FCBF9; Thu, 27 Mar 2025 11:44:30 +0100 (CET) From: =?utf-8?q?Toke_H=C3=B8iland-J=C3=B8rgensen?= Subject: [PATCH net-next v4 0/3] Fix late DMA unmap crash for page pool Date: Thu, 27 Mar 2025 11:44:10 +0100 Message-Id: <20250327-page-pool-track-dma-v4-0-b380dc6706d0@redhat.com> MIME-Version: 1.0 X-B4-Tracking: v=1; b=H4sIAPor5WcC/23NQQ6CMBAF0KuYrq1pZ0pRV97DuKhlkEZpSWkIh nB3G+ICI8s/P//NxHqKjnp23k0s0uB6F3wOar9jtjH+QdxVOTMQUAiUgncm37oQXjxFY5+8ag0 XiIAKjdKCWF52kWo3LuqVeUrc05jYLTeN61OI7+XdIJf+K6tNeZBccAsSqChNqSxcIlWNSQcb2 gUcYIVAsY1ARqREult5UrrGPwTXiN5GMCNHUloJqUkY+4PM8/wBzpEw+UsBAAA= X-Change-ID: 20250310-page-pool-track-dma-0332343a460e To: "David S. Miller" , Jakub Kicinski , Jesper Dangaard Brouer , Saeed Mahameed , Leon Romanovsky , Tariq Toukan , Andrew Lunn , Eric Dumazet , Paolo Abeni , Ilias Apalodimas , Simon Horman , Andrew Morton , Mina Almasry , Yonglong Liu , Yunsheng Lin , Pavel Begunkov , Matthew Wilcox Cc: netdev@vger.kernel.org, bpf@vger.kernel.org, linux-rdma@vger.kernel.org, linux-mm@kvack.org, =?utf-8?q?Toke_H=C3=B8iland-J=C3=B8rgensen?= , Qiuling Ren , Yuying Ma X-Mailer: b4 0.14.2 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: vWj4r3cpLCkLakGWViSmwcU-_lrq3u3y-1RxhsT_TgU_1743072273 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: CFD32120009 X-Stat-Signature: a9rdadgc8see8xdknwfe6k7brfkq513z X-Rspam-User: X-HE-Tag: 1743072277-808621 X-HE-Meta: U2FsdGVkX1+/W/CD4KY2W24S5qWvYRBsuCdxLsuUck2uOXFxvSHg1HjSQRp2LyVi4NJ2/8yuhlqVobXFemuT5/M4PI8Wj1KgiFvDLdtVbP3NHqNEnDO88+BILaFZVzeSUqG23VhliLgQL4YNzLY5lFEpfp5tCAyg6Qi1G3wvD4HDBLUXL715CA/kuVLahsjhpfcoWhgBat1vSm4iPITh+/e/kWaIeU2YtNHNtjQACh0NuM+PbI2ixmhzkjDROGgGdCfmZg6/xRu7tofKg9Y/Xn94V7NOh8QSE7mMGpJJSfh80NVo4YqLZio1hYqmT64HmOEGorQbkIRc/BdEz4ASxiIGrvc6ybZp0e77/hPKAJCprdJPYNhaU3zGitbqeWoNv0dRwaz6cniTtCKVjfTkRrq4RrNtb1tV4xTNwFXqsQOHwZdeKjXePBQV8FtzR0BkJuxV+yJt2hnA9MFwIu3vvpjZmhvs+VWmOJbBnSB0Jy6/bpuXp06N/nbkAX9PpAqAgfLu/pjx1Xejyb7GKh3rmb/QqQ4bYal/kw1P9+mE+l2iIxy+49OH0IuhS8GDqmptzfBHIg0SS8LgiYyvWzSbKG6PB45GI35K6LH3psPTQ8TzwujHgSTW2Ti0WTY0a/eFKovc1na+cGRs+NPA+bCGeJRDKqun3AZ8z9eYLjDsZWiES/S5K0Dh2bSTwLFJhUri8WACaz35e6ADlyynnLSCPxXbViKvzZ0F0CpdLpsCourZPFxPNZ1K71QuDOEzZa72qpHpmJY6R/eV3SaWrl3/eJuve82PaXkAJdo6wisDpGivLCGoDBNXVsFlFJuzY58bWUCupIFuPLiv8l1ocexFWslAL+/mY2Kw+RaCeUWw47Nhq7xagQYrlOJf/2qu7OKxMmNyUtRzmpNBsL5gdCWiFgx+DVg/wppHZzK7RuFp8RI/DhpJQ17u/fV8JppL1/VPuBDqkscfkIqogG8IZmG 5K38y4v/ ObydS/qchCr8XWgOzM31GcN2kzCERSBcZWuyyDDg7kCvQC3YhVu2kwCxaIMH13fCE1Ei0Tn25fKKugjQtHF+lbBKtpsIjzb97Ad5ZwSzpAmoFOyzGzxPlA04DCnfqJaBHZU0ID3a2GR/Yw0L6/nurgP9JYM2v3FOgiij4gRw+KT6FKlI9XfmOVbyLQ1U27YzOHcgHcv0A0Dlq+8B218WzOflV8RTyu4GrJTxAmNd8he+wLEivOS1l7lEQS221eTbhEHcyExbJwlB5sSxWF+1zniiy1Vg5HcGj2ZumxcqNxKdSvJmYr9bxLj00enRNMA1JGCE2bpFanRaqlK7OYjcRNfvQLcfHMCxBtyD19jghASckkPL1u/Uvnb7Qv3TGfi5SsjPwvBxPA0CasFF7uY7CvoiQuFUZqjEDPtxB5AQgOSrPtoXIFcM8UTXEVh6dj/e4Mhct5DPUQBS33FVpttSV2jlBSQGgOBQbGu7m2Wjp2Tq1vCF9e65FqJ/2v+h6FO3vgP67tMsQbmd0ypMvKB8sJYzGpZcsw18hx21891AFUSxzMmU2fS26V0qx+aMSykQkxYtzrD4TecrAv4iIYJe+o7idiA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: This series fixes the late dma_unmap crash for page pool first reported by Yonglong Liu in [0]. It is an alternative approach to the one submitted by Yunsheng Lin, most recently in [1]. The first two commits are small refactors of the page pool code, in preparation of the main change in patch 3. See the commit message of patch 3 for the details. -Toke [0] https://lore.kernel.org/lkml/8067f204-1380-4d37-8ffd-007fc6f26738@kernel.org/T/ [1] https://lore.kernel.org/r/20250307092356.638242-1-linyunsheng@huawei.com Signed-off-by: Toke Høiland-Jørgensen --- Changes in v4: - Rebase on net-next - Collect tags - Link to v3: https://lore.kernel.org/r/20250326-page-pool-track-dma-v3-0-8e464016e0ac@redhat.com Changes in v3: - Use a full-width bool for pp->dma_sync instead of a full unsigned long (in patch 2), and leave pp->dma_sync_cpu alone. - Link to v2: https://lore.kernel.org/r/20250325-page-pool-track-dma-v2-0-113ebc1946f3@redhat.com Changes in v2: - Always leave two bits at the top of pp_magic as zero, instead of one - Add an rcu_read_lock() around __page_pool_dma_sync_for_device() - Add a comment in poison.h with a reference to the bitmask definition - Add a longer description of the logic of the bitmask definitions to the comment in types.h, and a summary of the security implications of using the pp_magic field to the commit message of patch 3 - Collect Mina's Reviewed-by and Yonglong's Tested-by tags - Link to v1: https://lore.kernel.org/r/20250314-page-pool-track-dma-v1-0-c212e57a74c2@redhat.com --- Toke Høiland-Jørgensen (3): page_pool: Move pp_magic check into helper functions page_pool: Turn dma_sync into a full-width bool field page_pool: Track DMA-mapped pages and unmap them when destroying the pool drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c | 4 +- include/linux/poison.h | 4 ++ include/net/page_pool/types.h | 65 ++++++++++++++++++- mm/page_alloc.c | 9 +-- net/core/netmem_priv.h | 33 +++++++++- net/core/page_pool.c | 81 ++++++++++++++++++++---- net/core/skbuff.c | 16 +---- net/core/xdp.c | 4 +- 8 files changed, 176 insertions(+), 40 deletions(-) --- base-commit: 1a9239bb4253f9076b5b4b2a1a4e8d7defd77a95 change-id: 20250310-page-pool-track-dma-0332343a460e