From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5397C36008 for ; Wed, 26 Mar 2025 15:22:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7C67328008E; Wed, 26 Mar 2025 11:22:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7721228008D; Wed, 26 Mar 2025 11:22:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 63C5428008E; Wed, 26 Mar 2025 11:22:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 46AC328008D for ; Wed, 26 Mar 2025 11:22:37 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 4AD5B1A0963 for ; Wed, 26 Mar 2025 15:22:38 +0000 (UTC) X-FDA: 83264069196.28.E93BC85 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf05.hostedemail.com (Postfix) with ESMTP id 8045B100015 for ; Wed, 26 Mar 2025 15:22:36 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="lC2YE/oT"; spf=pass (imf05.hostedemail.com: domain of nathan@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=nathan@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743002556; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yOHApDjwYhY60VIB4ZjOatKCLCwxQm/o/0P20qXia8E=; b=Bqe+yBKjXfEEQABkw7xGbUy7Xr7EikFcD6/OHE05Cn9StrTwiNGYVtJLg34bDMh2pLJ8Cm 3eKYXBnb5h1+5nCA/NsWll8EgexQs3idtukM4NxeN5FayILxXnAr/PdRCrpNmP+RJ/JrwY 5iD91JcKZVIMPMY4oGF5JOVQcK+tmHo= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="lC2YE/oT"; spf=pass (imf05.hostedemail.com: domain of nathan@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=nathan@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743002556; a=rsa-sha256; cv=none; b=xXJwGtVvwUriNi21h3x1lgrkotbCz6RuJdwzfkTd1P/MCsNMYBVncVya6PGTKUZqW9mDBZ hcWXrAtSeW5qbfy6WpVL/F1+g4KYUr8sjcmdhNa8IIfSUBIbeHb9mFh5IeKrPXtT1ijDYh v/jYwAZgI4Sd6QpBl0AxihFq6AL0Qvs= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id CD39B43706; Wed, 26 Mar 2025 15:22:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DA0DFC4CEE2; Wed, 26 Mar 2025 15:22:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1743002555; bh=qaYn04pl0bOmbX7Q3sOhRWu/QUj4q3xvvH/bXbpjwDI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lC2YE/oT3fyupPQ2QRcZzHgza1/sOCa5chbFYaMXFQg5pq7QL6oPsHPlqCbpCWn9F q5Hp/gTd3oqCS4oz4rWf34knTycSCfoS41l9NOMpXEz2rRiTv7uZPoZhPYHyhh3qsz OJW3W5qBp8L6ee7YrSb2dELYMDG2NMiKYT9vZPWUYA7D3+4Q2IHWKFNp+kRdFNE2TP 4r1sSODu8+5rkSTBYFzsb6yiS21pEvi3ouaEKhW/VjGeZS0DQro+gxJXjgvxIPd5/X aqQDXgWY0UtzZmsMjtx0uBh6EXfjSlcUD26jMuRszxW3kxL4xXrcwUJLX/8nKYuNp4 u6z1n/jTSeFNQ== Date: Wed, 26 Mar 2025 08:22:28 -0700 From: Nathan Chancellor To: Mike Rapoport Cc: Andrew Morton , Andy Lutomirski , Borislav Petkov , Dave Hansen , Ingo Molnar , "H. Peter Anvin" , Peter Zijlstra , Thomas Bogendoerfer , Thomas Gleixner , Jiaxun Yang , kernel test robot , linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org Subject: Re: [PATCH 2/2] memblock: don't release high memory to page allocator when HIGHMEM is off Message-ID: <20250326152228.GA1105284@ax162> References: <20250325114928.1791109-1-rppt@kernel.org> <20250325114928.1791109-3-rppt@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250325114928.1791109-3-rppt@kernel.org> X-Rspamd-Queue-Id: 8045B100015 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: qaq8ejnx8znk5zif5c1oi3p3nu6hzoc8 X-HE-Tag: 1743002556-33862 X-HE-Meta: U2FsdGVkX18X5gX4OS+zkUJgRsE8MDBwzsZBs5BHeweLK4bEmuY4bsikm4dZ+S9Gc4s/pqrEpvv0Gjmz8boQTmLXVBSNPKlshV5JgNSUjyttFoWHYZVqu8bidbY13nmyqIOmIJun1Ot7CsMDQvoESQgP5b7T/hm4goSoTcB/cgT8u/18AmWqLCMy5F+sgzpl3xkC/b/Y2kzFVCq5shfvIo1BkXMdm3JHdJ3b9VXqgzixJizhkbzbFisEYN8zF6y163hQNiX7526uvpQgjSquQQtm6NmdRQvlvMZJZXPWOCivzB3V6jkXSEXzP6UAJL781y3l+c75K/+MVvvjgVOkyoMwE0pJmIylgzZkAHVO/3LZpTq26pQqGndsfUxF6jEYPWz2+yw2Jz7r9CA36LxJTDjgvNuu2T0IgcV9KiZY/KZJprx57tlyBJZ/gigOby1dYYqjIUrBXObIOHwsm68Uhx6c48MThir4iLuWVVaaRH5Zeq7CPqJFWKxN5Jc6be1+61h3gIyLx0ywpeMMQ8nLhgN3dBOgyr8P29fy6YHxoLUty7KlfXaeXssNo3z8/BAwNUR1YFrrFQQZ6N03dGqnblBdSyAac7dJd3CkiCC1ynRZQes+x/pLu5dMcvPjTXI0M3Pe6njQe3wtdCc6piJZuDpNacieBOKZI60JFig5gnPx7ibidOX1AS9My+BQnYvkAcHwYS732aeBuV8p/md8DzDMAsm7ScepmNhj2X7zLZvhK2JpGBvsfrK352dI260Ov0eyr+CrOK7HldcJdZ41PywF6A4XcrPhJW/6mrNiwhJnTXxrVbhjDW4sL4Yq5Am7jq3vECmPrev59hvxe8tNALpEHKAvvjELqYwMGHUBSg7VMfED8hsFcj5z8OsRJ3m3QMvS+5+XrbcP+ZgdrB6vfIgmYsxjE5/ycwC4sx5E+T9ztVdJOpLBYyiiJt6iOIFLmIPDvdn0PVagAc8qUWP QPLn2QEW Jtu+Je0R1ukVp0aAv273XN9dkX1LBe3g4I09h5IFusvVeVOS4+dqH+c6bDevEeDdCA8RO9ueeCunrpKRymlNxxuyTYR+fyC02FfAffkY9ZYWggi8epEtWDL4rWypP24v9nqWnSR2c2bPRSrbl2NJE8Eon52xtQr3yw7RxJzMu9h5ytG30FlZddJGYageKe869BIhbt8NIso9iQVOwUu8MNl+XZACv8Owh4IdL88CgS6OOUBggCV4NU8+mr6qCFrEySak0qyWNt536c/c3L5zevs4DyA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Mar 25, 2025 at 01:49:28PM +0200, Mike Rapoport wrote: > From: "Mike Rapoport (Microsoft)" > > Nathan Chancellor reports the following crash on a MIPS system with > CONFIG_HIGHMEM=n: ... > The crash happens because commit 6faea3422e3b ("arch, mm: streamline > HIGHMEM freeing") too eagerly frees high memory to the page allocator even > when HIGHMEM is disabled. > > Make sure that when CONFIG_HIGHMEM=n the high memory is not released to the > page allocator. > > Link: https://lore.kernel.org/all/20250323190647.GA1009914@ax162 > Reported-by: Nathan Chancellor > Fixes: 6faea3422e3b ("arch, mm: streamline HIGHMEM freeing") > Signed-off-by: Mike Rapoport (Microsoft) Tested-by: Nathan Chancellor > --- > mm/memblock.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/mm/memblock.c b/mm/memblock.c > index 64ae678cd1d1..d7ff8dfe5f88 100644 > --- a/mm/memblock.c > +++ b/mm/memblock.c > @@ -2166,6 +2166,9 @@ static unsigned long __init __free_memory_core(phys_addr_t start, > unsigned long start_pfn = PFN_UP(start); > unsigned long end_pfn = PFN_DOWN(end); > > + if (!IS_ENABLED(CONFIG_HIGHMEM) && end_pfn > max_low_pfn) > + end_pfn = max_low_pfn; > + > if (start_pfn >= end_pfn) > return 0; > > -- > 2.47.2 >