From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E748BC36008 for ; Wed, 26 Mar 2025 11:29:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E1FB3280075; Wed, 26 Mar 2025 07:29:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DCC5D280069; Wed, 26 Mar 2025 07:29:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C93E2280075; Wed, 26 Mar 2025 07:29:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id A0CF6280069 for ; Wed, 26 Mar 2025 07:29:36 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 6BFB7B7E13 for ; Wed, 26 Mar 2025 11:29:37 +0000 (UTC) X-FDA: 83263481994.30.E3C42DE Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf05.hostedemail.com (Postfix) with ESMTP id EBC2110000E for ; Wed, 26 Mar 2025 11:29:35 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=A687vLK7; spf=pass (imf05.hostedemail.com: domain of kuba@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=kuba@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742988576; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0W40E+MjeqZQkBuk8tnPNvX/HUCuBcz4p74YJ3VPasw=; b=m54MyOIluFc7rPO8ZcpVmUz7kGE6CKPPdn+x3UneHHs+ygbPKdnuLdgZzQndAYsgGJIHHG wvl2z3zM4oRFlj0kD1lwQPlbLHgoEeS+hjJ5uBivaAkng/hjsSsIwmSvni8OAhHG0N1knH gUwTRGnS5Z/JhH6aaaMht+kx5+ZZL9A= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=A687vLK7; spf=pass (imf05.hostedemail.com: domain of kuba@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=kuba@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742988576; a=rsa-sha256; cv=none; b=qA0FmM4acqmIG9rVbD3bqXjGBi7cgjc2S9zYvTXRdzQU1cLfKhC8seAEWsHlefsSWdtTyU d1FBv8vDDxfyZ1kuQFtlvCZtOUQlIYB1OQe6sckmebP3y3z0WOxg9DV2h4LkTTnkmQEV/g NZKE26UQs2jPJRzREdwmR7ys8Lkcz0M= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 70EB9A4102F; Wed, 26 Mar 2025 11:24:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 487A0C4CEE2; Wed, 26 Mar 2025 11:29:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1742988575; bh=7KrEIaFFiDJaGUzoqlsWeHvOc7wxtnz8IiRDhEdUP7Y=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=A687vLK77cRScE2DQHe9r0x48BR3Dk/rrWIOaEJZSdhgkpLHZoHZZPxKNVX6ebjRN 6LfuimVd1GgCqYYlKj7nNxSBR87sv2WoLrTKintyZslPkRqQ+Hojegw6tvVvrlp8T9 bqdHpAiEmKHAKsOh5hAhWyE7Vj+ac08mZN8GeMRrbTkhekMJwgZYK/U9NDtzM/su8C XOQNDcas05PlYoWp7by0dcFLWuOKGp/4+X149d+jcO6wsXKpYs3s4i/4B2RVVgAzZd Qcj3A4tpwneSkrQqKpf/0DCTz9fU+DotHKCV6j8MIY0zQW0lMjCJCVc+k1iH9rfGwe 7dI4pZS3hU96A== Date: Wed, 26 Mar 2025 04:29:33 -0700 From: Jakub Kicinski To: Toke =?UTF-8?B?SMO4aWxhbmQtSsO4cmdlbnNlbg==?= Cc: "David S. Miller" , Jesper Dangaard Brouer , Saeed Mahameed , Leon Romanovsky , Tariq Toukan , Andrew Lunn , Eric Dumazet , Paolo Abeni , Ilias Apalodimas , Simon Horman , Andrew Morton , Mina Almasry , Yonglong Liu , Yunsheng Lin , Pavel Begunkov , Matthew Wilcox , netdev@vger.kernel.org, bpf@vger.kernel.org, linux-rdma@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH net-next v2 2/3] page_pool: Turn dma_sync and dma_sync_cpu fields into a bitmap Message-ID: <20250326042933.6bd0ae60@kernel.org> In-Reply-To: <20250326042347.279f23a8@kernel.org> References: <20250325-page-pool-track-dma-v2-0-113ebc1946f3@redhat.com> <20250325-page-pool-track-dma-v2-2-113ebc1946f3@redhat.com> <20250325151743.7ae425c3@kernel.org> <87cye4qkgd.fsf@toke.dk> <20250326042347.279f23a8@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: EBC2110000E X-Stat-Signature: o5ppmuenaeiwkzpwziboty44ykaxqsuj X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1742988575-262314 X-HE-Meta: U2FsdGVkX1+THPbc1woyIPH71cs5xUk3jXPsGT4FTa/vUkAH7TBdtvvlJ7JnR0i8KtiR3/LMr09ps4k3NdRDHqTTpOOh0GSGAWy/pXAhjqB0Doyk3zuTN7bfJ9Sthupdf3HLP2r/PyiTXEX91AR+oS0TI3N5B/fgVeKp9ILYGNYgr5hzx5oS4vlcMMfRhd312Qhlr5/5A8+U/J0CiDHUA1walyCyLmO0S+lGJtqr9dhHtcezrtfefuoV5kJ0G7+JZb4kz/qS+wKWkP7oXgLte0NvuZMHH6ULgX4+VRDXpqqtPe+jY0JEYby8bcBafGonRaKsK8k4sua9CUorF/CtyqQAKs63QuT1f8TpO/cDItrTAt3sqH834CdHBal6gWLpsHPU+EIdc0AL/XteLRqBI9CRsX2sxHcCY1KKv9P9jFIBKYGbKNoHK1qzMRsAJIZ3wCDERQd1EUifzrdWSgrRvUGnkeyEz0n4gfsnVL8ovFvx/1CNCB/w42CV0uOVOHdYlI/A46xOCXXuzhKGzm6Lp2oPjiLq34w5pT10SeTbt6bUAFezQdxi5ng4jWcJzuc0Jps7U1c25jnA1teLHJfnZlAudy9tCBdtMXt8pkwmVpwc04VLRzWksUcC28+Npws1XlVVQBENM95DdyyTmku2Yboi9rFslT5JgqlANhvYOUv4Q8KfnqRonZ7jicrdyY5pZJcuzWCAhaAXsAXpr9B608wJsx0/Vkc1bqbA4Se5TrVHexbLDO8CXfTbhS0BffENq5a9QqTuNRz28wqaNk5LGZAUvT6dBLq/7kG9+33mwwYfmTCzKr2+3EN+SJeQpg6efDpXm8NMYolqJ/UvIgtRWm1jzWsQm1ge3zJiP047ESOOLt7hZZYaqylMDUMZFNSOqrb8n1GlDlU9wMAzxjNIvFGyG/ItukiiOs27EqZ4KuTBMaQHBxUbsmD49BQFsuQlHx0Pn7CSG9LEWl2+nIp tPB9zvFB bHGzSZ0MOwADbuP8ZFPCmdb6SkaDHIFW1+1tcm6AWV12LPoFEuuh+RRW2gsZVXXgM+qxruzzMMouFRY3D/w88HPMDeA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 26 Mar 2025 04:23:47 -0700 Jakub Kicinski wrote: > On Wed, 26 Mar 2025 09:12:34 +0100 Toke H=C3=B8iland-J=C3=B8rgensen wrote: > > > I don't see why we'd need to wipe them atomically. > > > In fact I don't see why we're touching dma_sync_cpu, at all, > > > it's driver-facing and the driver is gone in the problematic > > > scenario. =20 > >=20 > > No you're right, but it felt weird to change just one of them, so > > figured I'd go with both. But keeping them both as bool, and just making > > dma_sync a full-width bool works, so I'll respin with that and leave > > dma_sync_cpu as-is. =20 >=20 > Opinion on dma_sync_cpu clearing probably depends on mental model. > No strong feelings but perhaps add a comment next to clearing it > for the likes of myself saying that this technically shouldn't be > needed as we only expect drivers to ask for CPU sync? Ah, misread, I thought you meant "as-is" =3D=3D "as is in this series". Thanks!