From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72551C36008 for ; Wed, 26 Mar 2025 11:23:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 33FA5280073; Wed, 26 Mar 2025 07:23:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2C80A280069; Wed, 26 Mar 2025 07:23:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 16C02280073; Wed, 26 Mar 2025 07:23:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id EC049280069 for ; Wed, 26 Mar 2025 07:23:51 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 30208B7D1C for ; Wed, 26 Mar 2025 11:23:52 +0000 (UTC) X-FDA: 83263467504.21.FD93911 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf13.hostedemail.com (Postfix) with ESMTP id 645F42001A for ; Wed, 26 Mar 2025 11:23:50 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=fHyDTT3h; spf=pass (imf13.hostedemail.com: domain of kuba@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kuba@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742988230; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=R4BP1NptH+VhMdTtTgYwlNby7+SvfPrG7xuFOaIwVAU=; b=cEzZsVOKvFBvqJmxbNdiYNaWEv/Gyrk3llF3sMTBfS3JOfFgsyviaLHK4/TIXWh4Uz8pfM 5ovHaoclBxdqUmmh9bONff+yx3Q3MuhbaajmnRMvsAPGyECqJR+fMGLO76Femb+9+8vfBP bZvXR5IWhjpPpxFEHjQQVkZiH7bDUW0= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=fHyDTT3h; spf=pass (imf13.hostedemail.com: domain of kuba@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kuba@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742988230; a=rsa-sha256; cv=none; b=06kXBQVgHTK13Ov9eNrTLpMO/BMCkMOP+t7A2qNZUZy8J+CSnGQdIr9AHvvf43w44ak4c+ roGYEfsEGp9PfXuJXGBJXIUBM7uzqABe5u1LraHZFKaKPniau2uOwjaVdnWO4n8bQ1Mnna /4NWoRKtDMh52fmoJ9XPr7EWEHn689g= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 5A1CE5C63FE; Wed, 26 Mar 2025 11:21:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 284B8C4CEE2; Wed, 26 Mar 2025 11:23:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1742988229; bh=R4BP1NptH+VhMdTtTgYwlNby7+SvfPrG7xuFOaIwVAU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=fHyDTT3hVuxBqyIU4oEseOMTj+c0VSHxKcZed0NNYmA8OSwZEWAgc0czFUZrjfiIh 7qgJWSXwRu1JFezkFTqyOMeCVvRlWfo3MOM2LQ6FZLD8kG9CMmdARLvg5K3HiM1EXM qH7tsj6QIkVsJjz2p9vc2e0qp2DD2cRUB7hv5mlr3HXcC9MIczwjX6a5ZdEajSspI/ KFSrtIwBx9RWXPKmVhZhdGTvbN58YkxQg11qW01Osi4T970lrdfdXamK8IDzLIQCRU evjIsSfOL5Po/jcZAKEqGd61AINteKB77XKZIxImWA2MlHI7tu66UeQ/5jW94bRPIN IPovHEz+vMqWw== Date: Wed, 26 Mar 2025 04:23:47 -0700 From: Jakub Kicinski To: Toke =?UTF-8?B?SMO4aWxhbmQtSsO4cmdlbnNlbg==?= Cc: "David S. Miller" , Jesper Dangaard Brouer , Saeed Mahameed , Leon Romanovsky , Tariq Toukan , Andrew Lunn , Eric Dumazet , Paolo Abeni , Ilias Apalodimas , Simon Horman , Andrew Morton , Mina Almasry , Yonglong Liu , Yunsheng Lin , Pavel Begunkov , Matthew Wilcox , netdev@vger.kernel.org, bpf@vger.kernel.org, linux-rdma@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH net-next v2 2/3] page_pool: Turn dma_sync and dma_sync_cpu fields into a bitmap Message-ID: <20250326042347.279f23a8@kernel.org> In-Reply-To: <87cye4qkgd.fsf@toke.dk> References: <20250325-page-pool-track-dma-v2-0-113ebc1946f3@redhat.com> <20250325-page-pool-track-dma-v2-2-113ebc1946f3@redhat.com> <20250325151743.7ae425c3@kernel.org> <87cye4qkgd.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 645F42001A X-Stat-Signature: fwsoit16hrhp8tbgjh7ki3e7uidzerd9 X-HE-Tag: 1742988230-512677 X-HE-Meta: U2FsdGVkX19NqAvOfCtClMAxOaTqolJUhRy/364NIDmbC9w6UohCD+JLFI4eozsCgu60SwmXP7sRWxWEe3rJpVF1VeyjuIwEJ7Gg5HwJdI7mfuEXReyIuT7AvqgzjFK/+NpFWEghWg2hNz/+Er9CckVi/e73G3jYiluoiq4ReVdMclOr6O09twpPkjF8+74Px3oae2Vj1A6DhhSYr11PF8BBFiR15QqXf3xeCzDZP3VEj+ZVIVYg35PvBI4+kLDwsbIQV9FB2gJ0TsfBgyIxr1BPbLUpWfgYn0EisCggMrcfPwL2cBQf/ty8v1/dRRAtyWRg9U738c4YcNWEuKtM8tkuI8jCgC9Mhx8NLEDUBDXbvwdOV+GCX4VlNxmArzb5BhgJwsj8rVNZDDmK4mBCY9C3y1wETt/SIbFgMAB5ldcSPm33wWF0fHk477ULXWF17G/guMkqe3dae46+W5FrUqVu4DQcP2QLAzO4EjoxEIC28jD6HMmudn3RggNlcTdutYAlqZts+IqjPgdJaabYsoh5ySvs6z+8Jjnl/jOZjGqieLwNDhwtmhyoHDsr9KpsC7aLUKC06/6zhAra/wKZA+odqxFkirqDhGQQ3IGGJH4QoVCPpjZ5s5o0QJNOGKXlpCviHZRmj7K7MOwdVPNLpdeSkxjViqaLHYJvrtAdDqMMCuwJ14GEb5vFsmwKD7ZROf4rwhPcgiv5BDiKJq1I3lhxL4IWKBWTveT9JCiq2UYppUEDt0jbtxO915IipfTulOfUF9iiU/eKqfAyaTxwhla8rmUko3YHpTo5NP+5ZLlTBi+/J7+p6xKLYEXs90kTWOgBp1MsWxG9DTix0WLTBdqSdZA2mszwlfYpUOVlB0jBkTZ0Jk2DALcn+mWMSkXK7SAhJg8p2mpqkI6jE0Onm81MNlSr5R5J4U9NvwNBuShgoh+7/9bHTH3YoaHqXruKs2SvVh/pVvgcudhzEgD fPBiJ2tf TIhYTQhw8KLfefOE9xqLzoV8KVFX4VpbkQ7xh+sA/zE4LrkphtP2BFTufmzKwSlh7Djjv3x6sCIzT8GIlmtl6peMYa4zIFBeCHJP81pq4rfpbr9iLGfdHFbQgNCwyMi2UQEtQFgUTmMIrhdN3OONe3kxAUN8GadZrGJ1gG3604InPJzNjJJ3neDx+uo+9h3H65slqNMdzEpLOi8ZPXwbJ3Jjwqol0HS5mWQOaGnMNavUpzTKtQifcEB5o3/+qz5GMu10JepzbVNty5kUoCDVadXH6f79W2dJ3IRmw7BNPjRqKwq3q9sQ4NflR7IB4ZDsSE9GtL75hlVf/c9QGA2JNSbT7g2kPL5yM/JP9rMuVtPviOfAuKHEKiOWtwtC92RmOtGFw X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 26 Mar 2025 09:12:34 +0100 Toke H=C3=B8iland-J=C3=B8rgensen wrote: > > I don't see why we'd need to wipe them atomically. > > In fact I don't see why we're touching dma_sync_cpu, at all, > > it's driver-facing and the driver is gone in the problematic > > scenario. =20 >=20 > No you're right, but it felt weird to change just one of them, so > figured I'd go with both. But keeping them both as bool, and just making > dma_sync a full-width bool works, so I'll respin with that and leave > dma_sync_cpu as-is. Opinion on dma_sync_cpu clearing probably depends on mental model. No strong feelings but perhaps add a comment next to clearing it for the likes of myself saying that this technically shouldn't be needed as we only expect drivers to ask for CPU sync?