From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BC4AC36008 for ; Tue, 25 Mar 2025 10:28:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B7AEC280002; Tue, 25 Mar 2025 06:28:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B0587280001; Tue, 25 Mar 2025 06:28:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 97F8F280002; Tue, 25 Mar 2025 06:28:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 7CFB2280001 for ; Tue, 25 Mar 2025 06:28:13 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id F41ADBB4E8 for ; Tue, 25 Mar 2025 10:28:13 +0000 (UTC) X-FDA: 83259698466.14.7BE8C1F Received: from invmail4.hynix.com (exvmail4.hynix.com [166.125.252.92]) by imf22.hostedemail.com (Postfix) with ESMTP id 16F93C000A for ; Tue, 25 Mar 2025 10:28:11 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=none; spf=pass (imf22.hostedemail.com: domain of rakie.kim@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=rakie.kim@sk.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742898492; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=M8dGNA3hha5XzkD6RNlJKNbzwT8rKMqH28svZEQcNv4=; b=j0yte8AxXz7vayhPEOgOIxpAf9D4d3/qj5YaLHy5NjKaWwuM/YEXStGZTxUPSeWnbboqET qNZAyr/TkSCuvQZB6N+9z1a6tOzaiJxE0EzTZN8RU+CKpjO9O4NItKIZDyO+u/hH1meAQ+ PXHn5WJX0MRSnABQYwIAPiXEx075jLQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742898492; a=rsa-sha256; cv=none; b=78g23Mp1gCUdiyvvLovXPMIUSMiWCA0sjh/A5ALxg8nM/MzyW47ma+8OF6XzPMZP4uUlNQ c4LEAuxf2nqRXYDzCm0az4eBIGoNUmM7EfSc4QwZKZff4TCHc5VHSSLRIdf/qaePooDSaq w7et7QagwwHnpaL7H9jm20rs7eWgmTs= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=none; spf=pass (imf22.hostedemail.com: domain of rakie.kim@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=rakie.kim@sk.com; dmarc=none X-AuditID: a67dfc5b-681ff7000002311f-1d-67e28538ffd3 From: Rakie Kim To: Gregory Price Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-cxl@vger.kernel.org, joshua.hahnjy@gmail.com, dan.j.williams@intel.com, ying.huang@linux.alibaba.com, david@redhat.com, Jonathan.Cameron@huawei.com, kernel_team@skhynix.com, honggyu.kim@sk.com, yunjeong.mun@sk.com, Rakie Kim Subject: Re: [PATCH v3 3/3] mm/mempolicy: Support memory hotplug in weighted interleave Date: Tue, 25 Mar 2025 19:27:39 +0900 Message-ID: <20250325102804.1020-1-rakie.kim@sk.com> X-Mailer: git-send-email 2.48.1.windows.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrPLMWRmVeSWpSXmKPExsXC9ZZnoa5F66N0g/PfVSzmrF/DZjF96gVG i6/rfzFb/Lx7nN1i1cJrbBbHt85jtzg/6xSLxeVdc9gs7q35z2qxek2GA5fHzll32T262y6z e7QcecvqsXjPSyaPTZ8msXucmPGbxWPnQ0uP9/uusnl83iQXwBnFZZOSmpNZllqkb5fAlXGt Yx17wVv2ituntBoYO9m6GDk5JARMJCZ+WsYIY29dvpGpi5GDg01ASeLY3hgQU0RAVaLtinsX IxcHs8AjJonT7UtZQcqFBcIlug8+ZAGxWYBqTjz5DjaGF2jMvdVtTBAjNSUaLt0DszkFzCTe TrwHtlZIgEfi1Yb9UPWCEidnPgGbwywgL9G8dTYzyDIJgftsEifurmGBGCQpcXDFDZYJjPyz kPTMQtKzgJFpFaNQZl5ZbmJmjoleRmVeZoVecn7uJkZgsC+r/RO9g/HTheBDjAIcjEo8vAHh D9OFWBPLiitzDzFKcDArifAeYwUK8aYkVlalFuXHF5XmpBYfYpTmYFES5zX6Vp4iJJCeWJKa nZpakFoEk2Xi4JRqYFzInOrxnnmXytuIUI5Om/Mf6wMtt/PV/UhW5foZH5WoWsGx49vPFz5G x+OVP1nvdHrPn/fcm/F9z4qnfiI7jm49cUz/ilO7uJOiqeLMvwv5vdXvGm1ed5VPeafBnAD/ 9T+qtQ4eX6lzbZYUw7Wt1+ousXucjv/7/ebxlf+SlGKOa7if7/m6iVGJpTgj0VCLuag4EQDV R8qBcgIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrJLMWRmVeSWpSXmKPExsXCNUNNS9ei9VG6wY0ZYhZz1q9hs5g+9QKj xdf1v5gtft49zm7x+dlrZotVC6+xWRzfOo/d4vDck6wW52edYrG4vGsOm8W9Nf9ZLQ5de85q sXpNhsXvbSvYHPg8ds66y+7R3XaZ3aPlyFtWj8V7XjJ5bPo0id3jxIzfLB47H1p6vN93lc3j 220Pj8UvPjB5fN4kF8AdxWWTkpqTWZZapG+XwJVxrWMde8Fb9orbp7QaGDvZuhg5OSQETCS2 Lt/I1MXIwcEmoCRxbG8MiCkioCrRdsW9i5GLg1ngEZPE6falrCDlwgLhEt0HH7KA2CxANSee fGcEsXmBxtxb3cYEMVJTouHSPTCbU8BM4u3Ee2CrhAR4JF5t2A9VLyhxcuYTsDnMAvISzVtn M09g5JmFJDULSWoBI9MqRpHMvLLcxMwcU73i7IzKvMwKveT83E2MwABfVvtn4g7GL5fdDzEK cDAq8fBGxD1MF2JNLCuuzD3EKMHBrCTCe4wVKMSbklhZlVqUH19UmpNafIhRmoNFSZzXKzw1 QUggPbEkNTs1tSC1CCbLxMEp1cAYtyO5Ye2lp9KRzepNEp+0jvPHnWWtNE5y+qwXnBz64MYf 2R+eW88c5LFc9cagr4EtT/7U0u6atnDpvSpnZp638ouf7FXFKC9iYCsnsLNH/tXFlrT919ob Ltcb7Ym48Z49tiEuMG52RfJy9lsG/I7CN/00wqVeHLxpWSHTaTzlvlvZCRbuw0osxRmJhlrM RcWJAMl8FbNsAgAA X-CFilter-Loop: Reflected X-Stat-Signature: w1cdc1zc8dz3kzz4i4kizetayis4eh4n X-Rspam-User: X-Rspamd-Queue-Id: 16F93C000A X-Rspamd-Server: rspam08 X-HE-Tag: 1742898491-597549 X-HE-Meta: U2FsdGVkX1/JgR3MVcXwNaJ94ZArtOM3cIxyHFtGfjeIOweFcY/dplvCaHl8bbs0rei93gK06AieKC/PFLBimBuZlWS2ximEhOotA+14VwucQ/lx34b0A7DG8MowkWyWJeaS6UO3MaLHZEdRUtZ3LmmCaxEb+v5hqUSFQisqSaAXq1nbPfbOlFp/cMgYRChYwbLx2+RSi0J1m8KSpmGjvpaLIn5/0UJatYDSB0o7/a/xlLsWC+xFdoOs4fvAc84gfbZQmjKvCBwwgF15/9qWjCPmnnf8Pv4J9MCnQMFJhtGR1ll0VZ2lCrGedmlUxZgQh6mqGBSgYsRVJGj6ktnHXizL9zlYQbBsBYditdpcTmiXrsn+x7daKRcLD4FuXXeo1zW0ixuT7KKLQ07RGPr1YC1+L+q581j1CME4AnsNUPmLzUmrHubX1G86ZyN62bAZWLgkgLiSn0zBplPt76l0efleRhYdm0ISOCaLNPGigbX6RiS+WgmzWH9jFeJH09MecvaGhl6FGAxQnV+XZ4uDEW1XbVdJeD7MzPDqcQt5kkUq0gzsgYH+BaeAmZeLfvERXSSxBfaNEt7wUX7gPpdEU5xZXamIMx9DR+OlhAXICJi2poLipq8URyrdhfeywNCh8KF3Y2fhf5IW5jLtRyv8jg8iuCO8ueSYraQDna56rTb6FhDX6qrvQNrg/3k8i4tQmOBd910Exy0/DqKJViJiLFiaRKJV2qdnAprcBH5q15B7bNfbLswbhG21OwC64RFuVTkYlcmZkC3MXueIG4LcWT4Z2CKlqPfN1sEVPGhULJ6mT+VKVC8sKnW2cFTYI2FA/JER53ez5UhdBh6sRUq6Jz+WZMQyHw/m0egz8XIsmwhHOK/tqAYlskD9r0RyPQ4zhyMVgkKysWysCdic/6TV94pemqlL+PUqvMYUBoiniWGfUzjaiNC6YP7wXMN8iYCX2BfLFZywK/iNrMMu3Ts vAhndD6d 5PJ3aLOlF4K1yXG+S+RpOpD7S7pgEXJE5gDxY8D9NMfb0zQVnO23uSFS46jc4sQZsNmty6NaIxjARoab+i2dWqDQ/VZlbi+5MmsT2 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 24 Mar 2025 09:32:49 -0400 Gregory Price wrote: > On Mon, Mar 24, 2025 at 05:54:27PM +0900, Rakie Kim wrote: > > > > I'm sorry, the code is missing. > > I may not fully understand the scenario you described, but I think your concern > > can be addressed by adding a simple check like the following: > > > > case MEM_OFFLINE: > > if (!node_state(nid, N_MEMORY)) --> this point > > sysfs_wi_node_release(nid); > > > > This should work. I have some questions about whether there might be > some subtle race conditions with this implementation, but I can take a > look after LSFMM. (Example: Two blocks being offlined/onlined at the > same time, is state(nid, N_MEMORY) a raced value?) > > ~Gregory I will also further review the code for any race condition issues. I intend to update v4 to incorporate the discussions from this patch series. Your feedback and review of v4 after LSFMM would be greatly appreciated. Rakie