From: Rakie Kim <rakie.kim@sk.com>
To: Gregory Price <gourry@gourry.net>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, linux-cxl@vger.kernel.org,
joshua.hahnjy@gmail.com, dan.j.williams@intel.com,
ying.huang@linux.alibaba.com, david@redhat.com,
Jonathan.Cameron@huawei.com, kernel_team@skhynix.com,
honggyu.kim@sk.com, yunjeong.mun@sk.com,
Rakie Kim <rakie.kim@sk.com>
Subject: Re: [PATCH v3 3/3] mm/mempolicy: Support memory hotplug in weighted interleave
Date: Tue, 25 Mar 2025 19:27:39 +0900 [thread overview]
Message-ID: <20250325102804.1020-1-rakie.kim@sk.com> (raw)
In-Reply-To: <Z-FfAUiGePF9mnPS@gourry-fedora-PF4VCD3F>
On Mon, 24 Mar 2025 09:32:49 -0400 Gregory Price <gourry@gourry.net> wrote:
> On Mon, Mar 24, 2025 at 05:54:27PM +0900, Rakie Kim wrote:
> >
> > I'm sorry, the code is missing.
> > I may not fully understand the scenario you described, but I think your concern
> > can be addressed by adding a simple check like the following:
> >
> > case MEM_OFFLINE:
> > if (!node_state(nid, N_MEMORY)) --> this point
> > sysfs_wi_node_release(nid);
> >
>
> This should work. I have some questions about whether there might be
> some subtle race conditions with this implementation, but I can take a
> look after LSFMM. (Example: Two blocks being offlined/onlined at the
> same time, is state(nid, N_MEMORY) a raced value?)
>
> ~Gregory
I will also further review the code for any race condition
issues. I intend to update v4 to incorporate the discussions
from this patch series. Your feedback and review of v4 after
LSFMM would be greatly appreciated.
Rakie
prev parent reply other threads:[~2025-03-25 10:28 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-20 4:17 [PATCH v3 0/3] Enhance sysfs handling for " Rakie Kim
2025-03-20 4:17 ` [PATCH v3 1/3] mm/mempolicy: Fix memory leaks in weighted interleave sysfs Rakie Kim
2025-03-20 5:40 ` Rakie Kim
2025-03-20 16:59 ` Gregory Price
2025-03-21 4:36 ` Rakie Kim
2025-03-21 4:53 ` Gregory Price
2025-03-21 5:06 ` Rakie Kim
2025-03-20 16:45 ` Joshua Hahn
2025-03-21 4:37 ` Rakie Kim
2025-03-21 14:03 ` Gregory Price
2025-03-24 8:47 ` Rakie Kim
2025-03-21 13:59 ` Gregory Price
2025-03-24 16:40 ` Markus Elfring
2025-03-25 10:27 ` Rakie Kim
2025-03-20 4:17 ` [PATCH v3 2/3] mm/mempolicy: Support dynamic sysfs updates for weighted interleave Rakie Kim
2025-03-21 14:09 ` Gregory Price
2025-03-24 8:48 ` Rakie Kim
2025-04-02 16:33 ` Dan Williams
2025-04-03 4:25 ` Rakie Kim
2025-03-20 4:17 ` [PATCH v3 3/3] mm/mempolicy: Support memory hotplug in " Rakie Kim
2025-03-21 14:24 ` Gregory Price
2025-03-24 8:48 ` Rakie Kim
2025-03-24 8:54 ` Rakie Kim
2025-03-24 13:32 ` Gregory Price
2025-03-25 10:27 ` Rakie Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250325102804.1020-1-rakie.kim@sk.com \
--to=rakie.kim@sk.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=david@redhat.com \
--cc=gourry@gourry.net \
--cc=honggyu.kim@sk.com \
--cc=joshua.hahnjy@gmail.com \
--cc=kernel_team@skhynix.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ying.huang@linux.alibaba.com \
--cc=yunjeong.mun@sk.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox