From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19F8EC36002 for ; Mon, 24 Mar 2025 08:48:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6F4D1280003; Mon, 24 Mar 2025 04:48:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6A340280001; Mon, 24 Mar 2025 04:48:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 56DDE280003; Mon, 24 Mar 2025 04:48:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 398CF280001 for ; Mon, 24 Mar 2025 04:48:29 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 1C8441CD157 for ; Mon, 24 Mar 2025 08:48:30 +0000 (UTC) X-FDA: 83255818380.10.E25572A Received: from invmail4.hynix.com (exvmail4.hynix.com [166.125.252.92]) by imf20.hostedemail.com (Postfix) with ESMTP id 1E1481C0003 for ; Mon, 24 Mar 2025 08:48:27 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=none; spf=pass (imf20.hostedemail.com: domain of rakie.kim@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=rakie.kim@sk.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742806108; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ah4a1iRfqHHNJdnokuylsnMaP8jZQmATIvyG7HfY7iE=; b=GgP/aVGIZAa80hiBl4YiyHi7WzX3lZfksvxE/JLsnCCQXCUpC7RgbgLax79CJxvYZGEM19 +F9vBBXQ2b0Bn+igjhY+zcJ605DSM6PMKfuahgY7/BLhoF2LJ5NFhkz9c7ldU4c/OeupDT H0HNLENtTBZCHcW34eLdNKraOvy3sZQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742806108; a=rsa-sha256; cv=none; b=NbwqxNZghglAQuPYYj7fNYXgt/Sedni27P2LXbjoCLJvROg2/CI8OHDZgGNanwEEwXFQeK 9iQ35w9eBpxks5x6IeXatgt8j25KejPmmxiVfJ5xICOGloozag+dkI8eLScfuWO7Znqrbn NMbNESXGtXb9QpBWPuQ/GSFBw1G2z74= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=none; spf=pass (imf20.hostedemail.com: domain of rakie.kim@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=rakie.kim@sk.com; dmarc=none X-AuditID: a67dfc5b-681ff7000002311f-cf-67e11c5ac948 From: Rakie Kim To: Gregory Price Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-cxl@vger.kernel.org, joshua.hahnjy@gmail.com, dan.j.williams@intel.com, ying.huang@linux.alibaba.com, david@redhat.com, Jonathan.Cameron@huawei.com, kernel_team@skhynix.com, honggyu.kim@sk.com, yunjeong.mun@sk.com, Rakie Kim Subject: Re: [PATCH v3 2/3] mm/mempolicy: Support dynamic sysfs updates for weighted interleave Date: Mon, 24 Mar 2025 17:48:15 +0900 Message-ID: <20250324084822.976-1-rakie.kim@sk.com> X-Mailer: git-send-email 2.48.1.windows.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrLLMWRmVeSWpSXmKPExsXC9ZZnkW6UzMN0gzU32CzmrF/DZjF96gVG i6/rfzFb/Lx7nN1i1cJrbBbHt85jtzg/6xSLxeVdc9gs7q35z2qxek2GA5fHzll32T262y6z e7QcecvqsXjPSyaPTZ8msXucmPGbxWPnQ0uP9/uusnl83iQXwBnFZZOSmpNZllqkb5fAlfF4 xiu2giM8FS0bmxgbGH9xdjFyckgImEisWraeuYuRA8xuOF8OYrIJKEkc2xsDYooIqEq0XXHv YuTiYBZ4xCRxun0pK0insEC8xJsr1xlBaliAapr2pICEeQWMJV6tO8YIMVxTouHSPSYQm1PA TOL56iawViEBHolXG/YzQtQLSpyc+YQFxGYWkJdo3jqbGaL3OZvEvK5yCFtS4uCKGywTGPln IWmZhaRlASPTKkahzLyy3MTMHBO9jMq8zAq95PzcTYzAQF9W+yd6B+OnC8GHGAU4GJV4eDe8 vJ8uxJpYVlyZe4hRgoNZSYT3GOvDdCHelMTKqtSi/Pii0pzU4kOM0hwsSuK8Rt/KU4QE0hNL UrNTUwtSi2CyTBycUg2MEh/k+Zf8d7i7M+vUQuPGdb+a/36pjjz+V3mKN/Prl1kCHVohc/mz PLyTDK7u2bLrF7vgx5ipksapv0JX6009+cwt88On47ce7apaf+Xk2cNZ6TfMdve6zzbQYSru nPVV9/OF7s23r16/oCAydd981d9XhbbYt3+rCeDJkA/KkrpkZmGebW/cqcRSnJFoqMVcVJwI AJVHpOBwAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrBLMWRmVeSWpSXmKPExsXCNUNNSzdS5mG6QcNsG4s569ewWUyfeoHR 4uv6X8wWP+8eZ7f4/Ow1s8WqhdfYLI5vncducXjuSVaL87NOsVhc3jWHzeLemv+sFoeuPWe1 WL0mw+L3thVsDnweO2fdZffobrvM7tFy5C2rx+I9L5k8Nn2axO5xYsZvFo+dDy093u+7yubx 7baHx+IXH5g8Pm+SC+CO4rJJSc3JLEst0rdL4Mp4POMVW8ERnoqWjU2MDYy/OLsYOTgkBEwk Gs6Xg5hsAkoSx/bGgJgiAqoSbVfcuxi5OJgFHjFJnG5fytrFyMkhLBAv8ebKdUaQGhagmqY9 KSBhXgFjiVfrjjGC2BICmhINl+4xgdicAmYSz1c3gbUKCfBIvNqwnxGiXlDi5MwnLCA2s4C8 RPPW2cwTGHlmIUnNQpJawMi0ilEkM68sNzEzx1SvODujMi+zQi85P3cTIzC8l9X+mbiD8ctl 90OMAhyMSjy8G17eTxdiTSwrrsw9xCjBwawkwnuM9WG6EG9KYmVValF+fFFpTmrxIUZpDhYl cV6v8NQEIYH0xJLU7NTUgtQimCwTB6dUA2P33lOcxb8trv9bXZwmXGR/2vTX0sWGZ758vmBS o29v5rngndNfU0FB7SxlthVT5ufeC2j3ZVdPb5WxOFEoVr7ooLyzdwHzTsY/rj8stZR/uV87 vyDMWLajaPub1tPHGtymNPqoF0U827JdP8RWYY/fU+788M7jCx91u1nb/TlpzCLRJG0WqMRS nJFoqMVcVJwIAF5tHjlrAgAA X-CFilter-Loop: Reflected X-Stat-Signature: fss9igow41zdfqwwxdikurjhhqfxej8o X-Rspam-User: X-Rspamd-Queue-Id: 1E1481C0003 X-Rspamd-Server: rspam08 X-HE-Tag: 1742806107-794014 X-HE-Meta: U2FsdGVkX19fbaT4tR6TAi6Q9PUaWAsKUSKWtIKo8jl1DYHo8pBZVfRDjQ8EPY0l8dRawfpLOlLSdzhrcQjggKXjTc/1o3oq9i6UUXXz/Sq7l2/SQduZJthG+beLaIae6LcAw3dJqQFh1rXBB08r37nqx8M2e9ouA4Gk0VGD4EugPCxUzC22c1PC61DnFr9MpvVTVYnIylxzXNUFeDLrmznTuDbCtaLPxLub4atnHp7xCUbRTf9oEA75xOQFhRO66niKsdsFDIRq2XRsUtPHlkJmDI4W/RFUfLpc4h/FuY2W43JFmHaSA0Nl+LAkuQKKlsn4Gd1BfsNjzf0AWoYJZ8D8GjxZYuFCyEjpWaLYrMk5G8vEXXngUynX+pNVqeufkfFEqLh6bfa7EUBXMB7YuCbQEgCSChReTttfkx4Tup8xCwqTiZaFzmjDuJiCbhFXPvtMZQkEaSKr00s6/doaxBgeBiLd8n7ID4+Cd5Wc9TpMer7AzSnQJ57GjJRhycsI69qQXx0FtCWXgnYonnetZPWfd80xI2ztKbmRWhFe2bQ+uxa93KW1MchXwVtFUjQPr1pj6n7ARX+/fexPZmAe8KpmQ3Pm5rosbI3Xd+Ri5WdguQyhPJAzkV6uUWrxBsh2ibmDz6Jk7D8jOscXdwiCi9NjizHyF70ueofzZfCG7m9dJfzzT86HT/FEKnmxob/S1MiVcJC083dBdeXBRyN+GlNSVfWmCT52P2jsF9a5gJLck3etCxTCFyJ5QoUiJievaHq73Yi5fiFcdYEeUXwa6Z9y8refBdoxPUrUUc2rgtEhqgQ2IeDRAS9Ok0yk2HSoN3UtW56X2ZjbCHwOGhHCOoCGtFPxHgGhbvUdjFIom68bOlI3AXxf8RUBcqFBWiFCtVspaeW06TzH907i4l7sTEMLmRat+8tnWb0qUoYTC/VbctN8L0tzCBsIOTaasi4z3UiDj4lxz/R1aNeEoee 8fQkya/w edzncnfd7d6F8+7FeGp2WB9WDq89+/s11zePYEf5Ke51lScrzPHrSlpXnDqTe+FPZmF07htB4KK+IdJyQLtq7gRMVbaRD99ddu2qR/jBUNNq3nUIEa/pPukUaWqFH83k81UpoE5U7hYbonTwZEH3LRwxmPsZ35N+0mMmW X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 21 Mar 2025 10:09:12 -0400 Gregory Price wrote: > On Thu, Mar 20, 2025 at 01:17:47PM +0900, Rakie Kim wrote: > > Previously, the weighted interleave sysfs structure was statically > > managed, preventing dynamic updates when nodes were added or removed. > > > > This patch restructures the weighted interleave sysfs to support > > dynamic insertion and deletion. The sysfs that was part of > > the 'weighted_interleave_group' is now globally accessible, > > allowing external access to that sysfs. > > > > With this change, sysfs management for weighted interleave is > > more flexible, supporting hotplug events and runtime updates > > more effectively. > > > > Signed-off-by: Rakie Kim > > Reviewed-by: Gregory Price > > 1 nit > > > --- > > mm/mempolicy.c | 70 ++++++++++++++++++++++---------------------------- > > 1 file changed, 30 insertions(+), 40 deletions(-) > > > > diff --git a/mm/mempolicy.c b/mm/mempolicy.c > > index 5950d5d5b85e..6c8843114afd 100644 > > --- a/mm/mempolicy.c > > +++ b/mm/mempolicy.c > > @@ -3388,6 +3388,13 @@ struct iw_node_attr { > > int nid; > > }; > > > > +struct sysfs_wi_group { > > + struct kobject wi_kobj; > > + struct iw_node_attr *nattrs[]; > > +}; > > + > > +static struct sysfs_wi_group *sgrp; > > + > > sgrp -> wi_group? Or something similar, sgrp is not very descriptive > for a global. > > ~Gregory Yes, I agree. `wi_group` is more descriptive than `sgrp`. I will rename the structure to `wi_group` as suggested. Rakie