From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BCB0C36002 for ; Mon, 24 Mar 2025 08:48:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 58A16280002; Mon, 24 Mar 2025 04:48:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 539AD280001; Mon, 24 Mar 2025 04:48:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 403F1280002; Mon, 24 Mar 2025 04:48:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 23E70280001 for ; Mon, 24 Mar 2025 04:48:08 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 7523B1211EE for ; Mon, 24 Mar 2025 08:48:08 +0000 (UTC) X-FDA: 83255817456.28.803E0CC Received: from invmail4.hynix.com (exvmail4.hynix.com [166.125.252.92]) by imf23.hostedemail.com (Postfix) with ESMTP id DAAB1140003 for ; Mon, 24 Mar 2025 08:48:05 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=none; spf=pass (imf23.hostedemail.com: domain of rakie.kim@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=rakie.kim@sk.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742806086; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=F313V5T7zCBXd6C7wpSW41TT50aRLHE65tLDA3lnJBA=; b=nty3QoZZMCF/VkNe93D1H9Z4vekca48HxRna9T3r8SXWYNPBDuew+CBI/CoYy1rAP1IpeA UVZ6MGe7kq8/qbNMnTQ11G+AM6UHetkFAlD/DH7QRwaDS07ykaTPokwWk935ggt9BZkGag j+UHCkYVmpgPDEdaIMQ1Trhh0e3Yetg= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=none; spf=pass (imf23.hostedemail.com: domain of rakie.kim@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=rakie.kim@sk.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742806086; a=rsa-sha256; cv=none; b=y0HXCeVTO1KgQANjqzxyex4GUvN4iZgyCUFbM31NkNnzWMeN+hN6wU9GMOIVHXUZDvQhTh xcPxMtHqDqmFPHkAncW2Z48UOBe0+dxMTUU+Zh8gfTTsJKt2js9Ms1rXKVZGDlYfXqt+SH X95FfbQAmwFeWsb8oOFRpwC7yELC9L4= X-AuditID: a67dfc5b-669ff7000002311f-85-67e11c41a64b From: Rakie Kim To: Gregory Price Cc: Joshua Hahn , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-cxl@vger.kernel.org, dan.j.williams@intel.com, ying.huang@linux.alibaba.com, david@redhat.com, Jonathan.Cameron@huawei.com, kernel_team@skhynix.com, honggyu.kim@sk.com, yunjeong.mun@sk.com, Rakie Kim Subject: Re: [PATCH v3 1/3] mm/mempolicy: Fix memory leaks in weighted interleave sysfs Date: Mon, 24 Mar 2025 17:47:50 +0900 Message-ID: <20250324084757.965-1-rakie.kim@sk.com> X-Mailer: git-send-email 2.48.1.windows.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrHLMWRmVeSWpSXmKPExsXC9ZZnka6jzMN0g83bVC3mrF/DZjF96gVG i6/rfzFb/Lx7nN1i1cJrbBbHt85jtzg/6xSLxeVdc9gs7q35z2qxek2GA5fHzll32T262y6z e7QcecvqsXjPSyaPTZ8msXucmPGbxWPnQ0uP9/uusnl83iQXwBnFZZOSmpNZllqkb5fAlfF7 cjdzwS3eij37J7E0MN7i6mLk5JAQMJH4ePo4K4y97v4cxi5GDg42ASWJY3tjQEwRAVWJtivu XYxcHMwCH5gk9m1tYAWJCwuES7TOEAXpZAEqmf/rOiOIzStgLLF06gsWiImaEg2X7jGBlHMK mEmcX+UIEhYS4JF4tWE/VLmgxMmZT8DKmQXkJZq3zmYGWSUh8JxN4u2rl4wQcyQlDq64wTKB kX8Wkp5ZSHoWMDKtYhTKzCvLTczMMdHLqMzLrNBLzs/dxAgM9WW1f6J3MH66EHyIUYCDUYmH d8PL++lCrIllxZW5hxglOJiVRHiPsT5MF+JNSaysSi3Kjy8qzUktPsQozcGiJM5r9K08RUgg PbEkNTs1tSC1CCbLxMEp1cBoomy/k/PK7pl9mbv/BYf/XMncraHx5PLicEflLu6edxM/Lavs iJarq/j4226/lYHJ4rzaPuUfd2J8j7HP4dC7mBTjKe+xrPgDS/2nY9p3tDKXzI2+IVy9X0PE 3X9HG1/v1qmsL3hmm79/nZ12weR203IGtYsmMRd2Rr3Pnq9oW332Unra4h1KLMUZiYZazEXF iQBCdcCvcQIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrBLMWRmVeSWpSXmKPExsXCNUNNS9dR5mG6wfOtUhZz1q9hs5g+9QKj xdf1v5gtft49zm7x+dlrZotVC6+xWRzfOo/d4vDck6wW52edYrG4vGsOm8W9Nf9ZLQ5de85q sXpNhsXvbSvYHPg8ds66y+7R3XaZ3aPlyFtWj8V7XjJ5bPo0id3jxIzfLB47H1p6vN93lc3j 220Pj8UvPjB5fN4kF8AdxWWTkpqTWZZapG+XwJXxe3I3c8Et3oo9+yexNDDe4upi5OSQEDCR WHd/DmMXIwcHm4CSxLG9MSCmiICqRNsV9y5GLg5mgQ9MEvu2NrCCxIUFwiVaZ4iCdLIAlcz/ dZ0RxOYVMJZYOvUFC8RETYmGS/eYQMo5Bcwkzq9yBAkLCfBIvNqwH6pcUOLkzCdg5cwC8hLN W2czT2DkmYUkNQtJagEj0ypGkcy8stzEzBxTveLsjMq8zAq95PzcTYzA8F5W+2fiDsYvl90P MQpwMCrx8G54eT9diDWxrLgy9xCjBAezkgjvMdaH6UK8KYmVValF+fFFpTmpxYcYpTlYlMR5 vcJTE4QE0hNLUrNTUwtSi2CyTBycUg2MOUdX2J74/Pivvup9GdOaryqx4kYGtVzrJq177Xmw 9szUimtNUraOHoueWN0yqpr9Vnjyr/hVsx8q77fRtTNKNfL88vxvhnwUL8+cSdd8On8WbVz1 c9UcV8kjm9zXhJ0X2H3Lnmf7s50Hwuz7y5m61s4+tfVyTem8J7ofVe9xJy+6fO91+eZyNyWW 4oxEQy3mouJEAGffsUdrAgAA X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: DAAB1140003 X-Stat-Signature: f6pcnrp7izwbxae4mybz1f9q3izhyfrm X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1742806085-160881 X-HE-Meta: U2FsdGVkX18j3+3Ayrv7eygttSEuCH9xhbzfYbv5lkS+HqLrNmaQkBRJznstYXQyttRvzRBX8x3fz8RbRT/pIz+bxsFPE8mTUWJ1BDj/Rib03aYZlRv9mWu4hrKojGwg726W/diu27jZEamgcnEMIMlXlHrgGBslnWD6bHnqaiPQmqpjDn3otfzcqg3P6u5VrmB6s9Bj+xc4XaYCwdOlFOvC3piyyh+MC9h/wnuBROObEf+WgSyZE3gTdoAxwjjoH9dKY8LD9nUuo3EisnmBgbRMNsryhQhb+HFzk9yLI4Jd9mCyIGFpJ63ml5e1FlH3mzRdef/c+EQ/5Z+Vuf4PtuU+yi54Hp2E4Uo4s/FoQCK0AzszpptkQMgYaceU4H/8HuTXHWwsvLZyIggT+ffSYc3PY31IwNrY9sRSiJmzu5ueyH31vkpLa3eGXYvHi2Un0NR7oO97lexTXN1b5yyRC+iZFtAbUrF81M0CfQPpkMbRcBQ13TQdounJMXH0rOVnT/CI5gtMSFKpUNPf7mT0UvtZzTXi2n2tkKrqHf/nE86sLCapEy0AFrt8YiIH6+psbjyo4VE+rg84SV4NTuWYUGwx/vsx75t6yaORFyZ1SkQPBb5AbkWi4681NgoJFqfKwSTAA33XlUVWYzCc20dYtq0/3fqpgL86pc1Q6IrFxSMnFKK7Pi6w7pEePcch9jw6drPTtaioMjs+kYtWlunyd1WO42Fu98cmPCDH0BQAYIA6cb0/1IMnzMgGfco5M+Lg2S/XVHGzWn2RXbpJ26x+TNNMav/xq1WkLLdK97dL4Ag9DfVYOjBVFSne00K89xUT6hu4Ow4brHp4wQ8CQ9xuOJxaat7jJCRmmNyCNLa7R4pwQwkxi6ho/GiKWLUIuSp761WwJX+Yt6+nSeiW4NyBUyrLXL796K+3WhO3semdtaSatdRIQwRW+cNSsIMsjYWk0raV5BE1Es8hITNB/sZ DHC47n5y UUD9cRyjB4t4XiP6bhPKapXioA5qdbhe+Kq3jHnZoHzX1KJiEnhsS8IyCbuMHHqSZUk2xVjXP6TVNqTC+Ak7njJ+DJbGUl0gH8DDH X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 21 Mar 2025 10:03:29 -0400 Gregory Price wrote: > On Fri, Mar 21, 2025 at 01:37:22PM +0900, Rakie Kim wrote: > > As you mentioned, I agree that Patch 1 may be a bit unclear. > > In fact, Patch 1 and Patch 2 share similar goals, and in my view, > > they only provide complete functionality when applied together. > > > > Initially, I thought that Patch 1 was the fix for the original issue and > > considered it the candidate for a backport. > > However, upon further reflection, I believe that all changes in Patch 1 > > through Patch 3 are necessary to fully address the underlying problem. > > > > Patch 1 does address the immediate issue of calling kfree instead of the > appropriate put() routine, so it is fine to keep this separate. Understood. I will keep this patch as-is for now, as you suggested. > > > Therefore, I now think it makes more sense to merge Patch 1 and Patch 2 > > into a single patch, then renumber the current Patch 3 as Patch 2, > > and treat the entire set as a proper -stable backport candidate. > > > > The set adds functionality and changes the original behavior of the > interface - I'm not clear on the rules on backports in this way. > > Would need input from another maintainer on that. > > Either way, I would keep it separate for now in case just the first > patch is desired for backport. Maintainers can always pick up the set > if that's desired. > > (It also makes these changes easier to review) > ~Gregory In that case, I agree it's better to treat only Patch 1 as a backport candidate for now. As for the remaining patches, it would be more appropriate to discuss their inclusion with other maintainers at a later point. Rakie