From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88CF6C36002 for ; Fri, 21 Mar 2025 21:58:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CC0FF28000B; Fri, 21 Mar 2025 17:58:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C6FF5280008; Fri, 21 Mar 2025 17:58:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B384B28000B; Fri, 21 Mar 2025 17:58:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 97615280008 for ; Fri, 21 Mar 2025 17:58:47 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 8471057383 for ; Fri, 21 Mar 2025 21:58:47 +0000 (UTC) X-FDA: 83246923494.18.37B6C23 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by imf23.hostedemail.com (Postfix) with ESMTP id 8EDCE140003 for ; Fri, 21 Mar 2025 21:58:45 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=TAZxNlmX; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf23.hostedemail.com: domain of david.laight.linux@gmail.com designates 209.85.128.47 as permitted sender) smtp.mailfrom=david.laight.linux@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742594325; a=rsa-sha256; cv=none; b=ij5GFDaoSmMnEd616dVpw7b7mm3H1x2GzwlA5qRz3d/TeX9qDFKuHSV8Yumz3F6hO3N/Do 3bFPTpfJmz7zsBgpQbvPA3TRCma1knCDJUcUngLoYG3N/rcq91z/ggnavU4VJmXQbwnkjm xIh1REKK2m2ukS4RW1a6JI16vujDicM= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=TAZxNlmX; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf23.hostedemail.com: domain of david.laight.linux@gmail.com designates 209.85.128.47 as permitted sender) smtp.mailfrom=david.laight.linux@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742594325; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vmVdno9JiW66EUzziccNjwwwsJPLYydEw+984DnsTqU=; b=LPY6cZoiZYVXWN4fdBivpTLqma2KK3WPTMKOeO8y+i429vWrqPY4C8xdfSEO2wunlqzick 1H0DpTzT2iyvf4qhMRDcOoAOVQ+7l7HSnJQbV8K8lauQHVp9XW/v2EL1RGGqApk4IF55B9 qAS9ISBqChMKLDwknHIx26j9RCCeA6I= Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-43ce70f9afbso24196315e9.0 for ; Fri, 21 Mar 2025 14:58:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742594324; x=1743199124; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=vmVdno9JiW66EUzziccNjwwwsJPLYydEw+984DnsTqU=; b=TAZxNlmXnejmBPjVMLyxSM6DbFePIZ8nwKWPFNFIqAWs1nNXFkcPCEjvArXOO5VSVz T6cr1Gkoy2jaeaSTI1W0DxJuo14tNOIKv3mej6YrF+bujSnIqnfkOsWdSXEz4TFwCqmz ux1pll3EqxMvo7KRgvFrfTUVeufFocnP/tKNAF9DhJFdnbgAy1/IHsrke4j+X/O01rkS q85dvEzg/VfJPx7ubG84f14juqsFM0Yj2KeBl00lSSmUoX2kuYDjaa2F3aCOTBazJnLK g+v4gzeLgbkgQuaY0lQamuytI9tq7iiUEv6LR6y2l4kBbhIxB2eOyJfMiZb4mT8mVkMt 8PCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742594324; x=1743199124; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vmVdno9JiW66EUzziccNjwwwsJPLYydEw+984DnsTqU=; b=wA1CIMBZjg2XDeUXmJng9Cw6wBzT+2ucgblQAScEBYcLFsGccsbwywFRpDLSKiq5Zu /7/q7r4ljB51IuEZzptjSMJVeyGw8ZglY6dXp5ntwMWR4g2EvhklpYC8CyEHcUheFq7J 77LWq89NW4kOoI5tMlVVbItoEL8ZfkP+gAEq6D3RvA8S1tgqyjsEAEeteVFgdEVBEpXn QLTXFT1329xFhemkinE8ugMGkp6UuA63p3HOMnskb9uK/ZqkFUKorB/bNmOuG6pdFnLv NrK/bEg+D0EqloVftDwx7sMja9b7yu2yPB4D8uhitkRNmi7ZBWDFbP6nQxi6qIAxl1d9 Zvow== X-Forwarded-Encrypted: i=1; AJvYcCWaiemA01Flo0DyPOrhmQEorMA7nIZfp00kyt1qA1djTB1iewdO3b15UBEQsaqpwSBLjzRWHzhxCg==@kvack.org X-Gm-Message-State: AOJu0YzXYCcnRatAMiPfJ+eP5Gf555I7bHZYy5+fHW/Y+SxAiFlwAFd2 ygPdIm6VPGa6GQNRpSWDV8YKcVIyH8WFyu5vkO/6XF//bhJDr5ozdVVPhw== X-Gm-Gg: ASbGncs8FNGA4PLYsLIlOUNSL2mxcSqoXcvubWEt19ZPsxSf2E722d7omd7vh9vNaIA ESvNDsQly+KAPxu3hcXAXd+D9LMDU42/Lwpzgt+9nd5GgXoZoxgBdSDYsJ7PxaAAktEJdtiO50a ostm3Va9XrZYBTCHD4pXRJ1YiUyk+AG2TBDPqf3HNGALlSH4OxfnCd7IQltrGn383HG9mOxWsAa s/z8Cm0j0MqYmak9L74ndJwloq6EgNYQ9ONVAk47zUySccHp5MEVBft9th34n/SIe8SKxhwwqZx GeS75pfTVrl6IWm4ggLZHu38TX0NYRFgAlbWCea5awrajQ4viIm/PWWLi3P2XU/8NZv4zH5uu4S 8uUVhOXc= X-Google-Smtp-Source: AGHT+IFeHoHB22UQipfl9400C+XWuP+arx3zZ+LkvJtYR63KKKHnv/Wd4J+oKhJ/M4esH4T5ibKoiw== X-Received: by 2002:a05:600c:1d16:b0:43d:ac5:11e8 with SMTP id 5b1f17b1804b1-43d58db52e1mr6181575e9.21.1742594323421; Fri, 21 Mar 2025 14:58:43 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43d43fdeb79sm89798935e9.25.2025.03.21.14.58.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Mar 2025 14:58:42 -0700 (PDT) Date: Fri, 21 Mar 2025 21:58:38 +0000 From: David Laight To: kernel test robot Cc: Huang Ying , oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, Andrew Morton , Linux Memory Management List Subject: Re: include/linux/minmax.h:93:30: warning: large integer implicitly truncated to unsigned type Message-ID: <20250321215838.179be239@pumpkin> In-Reply-To: <202503201231.VrUIFcq2-lkp@intel.com> References: <202503201231.VrUIFcq2-lkp@intel.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 8EDCE140003 X-Stat-Signature: 5e6b7jby3azbr54xan4t9xzk4b8r1w6i X-Rspam-User: X-HE-Tag: 1742594325-78081 X-HE-Meta: U2FsdGVkX185HxE6nIGspgdBNrN4SLfDP0JofaLH3S7nVmvzWD3/03i59K0ENoLeUt0h/TlsKONhrShwlzhaYXjz0fTNw9m+aRrIxMhjFKiMVSEopiLbwRTC7YG7rvQuLxAevZMKT048Egt+Y6zTtWzVtY2+2nKQCNM3muhm/REMrTIOPtkKxo+YGKIvjTPwn3BX965/W6oe5T0ulTZuqJm/AUHuMszxzQpDvOQ7GkFNxwciP9jG5FChOTLCA8RbFgfNsj5B2TESKMIGItGNq3tdLL+8u/MfcxKjq5Nhbz6WE9efCBvrzi6GfFzDChgdlrF7VUbCXRvN3W8jW53820epJeTMpoKSsfr9f6CWgAApDQkLd3fe84AD+guyUjnvzR802tjI13PQBmeZre38YazutSfh0u4XcGZE/gB+nzFka2OsUbXiLj2a3AZ6Akp9lUpXkO36tFoitP2Eq0OJ0YNTB7UPw9717BQ+nyYjkTZ0AZ3hUULDlf2rXxsJUPXYX60xdjfBUCOFEgUu+bP5yKidSMdBbfAX7uJnxep2KkbqLzBchf+sDXNhXU3VQ8yzhNGFggIEhggM1Q3RcJ3VVG8VGgL8W/m1TJyZv++ELIvP76bFM/hUaqXpiXtS5yAZcTJJjkeXMylnyr/kRBp29+1275m8YV5yykQvZPt/7ARXUgro0U6bW788XY592ecNHfNOKFMaDWEFPmkGQ9/I0ejkaLh1Ooskx/qMjerPv2yPJ27VN27swn7Je3/NTP6WpvJ2tu9ene6NUtDJ2Tc2dSpRs942eopO6V2A2r1+jI6rsHhA0NVPrluG4xMe8XylHMZ6V72WyBvzSN3dkXsQIyUCZOmpJveyHcmctZ7AVgtwU1jtmVB2TGeYIUaRd4k/52X1QHvDbhmR8jkGWHmncOZFeAOl1HhO3hRxySLr30lcrU+XMZIw0KpwsKJHnpACKUEw4FcwPAQH1hjX1ZN TuFpg27y i2b1Rz+5aNwcjddtE45OULFG8A5mrrwD/dY3S6jOY2n2PQSf0Kbs8f+4hIlT6OPzXfqML/w6rcGpj1gzrPqBEzsKRx++YXXnpJoZciWA45hoPzNvQauvxYa9pvvIx5O8ohXTFKNi4sObvEACNSSWhpg8Bhm9Ba/K9YmwjWujZPBlAq0ezxXw2AGZW1bsXi732+4a9mBMM0OoGXDgO3tNojGz3kB7O2wHITqVpD8Z/LZRlhxcsanfhP7jDspDluS/RSrexh35u9+fYci6qdcmwyEuyaaugQfPbW2itXhaBptibAjW5Rc+lv83W2HTA39//dUSi4bWaSoasMZIZ0V1r+9hyp6ItEGML/w/hzUPc9NfD2+JjvvIaaAWKxU/S3Pj3wD+LxCOmkheP935thhDsD54/MlIF/VvJxdtoATcftQeMpylTezRTrDOyELqh8ZXcHPeDFPTwtSkyjZyjIunYh93uyNL2VmICCi4mgejSLXIpCAOJhPpJo5kavlIxRjOOVxc1leuahoPtFqI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 20 Mar 2025 12:16:57 +0800 kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master > head: a7f2e10ecd8f18b83951b0bab47ddaf48f93bf47 > commit: 99185c10d5d9214d0d0c8b7866660203e344ee3b resource, kunit: add test case for region_intersects() > date: 6 months ago > config: arm-randconfig-r063-20250320 (https://download.01.org/0day-ci/archive/20250320/202503201231.VrUIFcq2-lkp@intel.com/config) > compiler: arm-linux-gnueabi-gcc (GCC) 7.5.0 > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250320/202503201231.VrUIFcq2-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202503201231.VrUIFcq2-lkp@intel.com/ > > All warnings (new ones prefixed by >>): > > In file included from include/linux/ioport.h:15:0, > from kernel/resource.c:15: > kernel/resource.c: In function 'gfr_start': > >> include/linux/minmax.h:93:30: warning: large integer implicitly truncated to unsigned type [-Woverflow] > ({ type ux = (x); type uy = (y); __cmp(op, ux, uy); }) > ^ > include/linux/minmax.h:96:2: note: in expansion of macro '__cmp_once_unique' > __cmp_once_unique(op, type, x, y, __UNIQUE_ID(x_), __UNIQUE_ID(y_)) > ^~~~~~~~~~~~~~~~~ > include/linux/minmax.h:213:27: note: in expansion of macro '__cmp_once' > #define min_t(type, x, y) __cmp_once(min, type, x, y) > ^~~~~~~~~~ > kernel/resource.c:1838:9: note: in expansion of macro 'min_t' > end = min_t(resource_size_t, base->end, MAX_PHYS_ADDR); The error is because MAX_PHYS_ADDR is too large for resource_size_t. The constant seems to have been changed several times. But I don't see the patch that changes it from DIRECT_MAP_PHYSMEM_END to MAX_PHYS_ADDR. I'd guess this is a 32bit build and resource_size_t is 32 bits but MAX_PHYS_ADDR is 64. Who knows what the code is supposed to do, but it is another case of min_t() discarding significant bits. It might be that just using min() will fix the compilation and DTRT. David > ^~~~~ > kernel/resource.c: In function 'gfr_continue': > >> include/linux/minmax.h:93:30: warning: large integer implicitly truncated to unsigned type [-Woverflow] > ({ type ux = (x); type uy = (y); __cmp(op, ux, uy); }) > ^ > include/linux/minmax.h:96:2: note: in expansion of macro '__cmp_once_unique' > __cmp_once_unique(op, type, x, y, __UNIQUE_ID(x_), __UNIQUE_ID(y_)) > ^~~~~~~~~~~~~~~~~ > include/linux/minmax.h:213:27: note: in expansion of macro '__cmp_once' > #define min_t(type, x, y) __cmp_once(min, type, x, y) > ^~~~~~~~~~ > kernel/resource.c:1855:11: note: in expansion of macro 'min_t' > addr <= min_t(resource_size_t, base->end, MAX_PHYS_ADDR); > ^~~~~ > > > vim +93 include/linux/minmax.h > > d03eba99f5bf7c David Laight 2023-09-18 91 > 017fa3e8918784 Linus Torvalds 2024-07-28 92 #define __cmp_once_unique(op, type, x, y, ux, uy) \ > 017fa3e8918784 Linus Torvalds 2024-07-28 @93 ({ type ux = (x); type uy = (y); __cmp(op, ux, uy); }) > 017fa3e8918784 Linus Torvalds 2024-07-28 94 > > :::::: The code at line 93 was first introduced by commit > :::::: 017fa3e89187848fd056af757769c9e66ac3e93d minmax: simplify and clarify min_t()/max_t() implementation > > :::::: TO: Linus Torvalds > :::::: CC: Linus Torvalds >