From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 503CCC36001 for ; Fri, 21 Mar 2025 23:53:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9E2D6280002; Fri, 21 Mar 2025 19:53:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9944D280001; Fri, 21 Mar 2025 19:53:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 85A2D280002; Fri, 21 Mar 2025 19:53:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 68FC8280001 for ; Fri, 21 Mar 2025 19:53:15 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 97E1D160679 for ; Fri, 21 Mar 2025 23:53:15 +0000 (UTC) X-FDA: 83247211950.08.3AB05D9 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf12.hostedemail.com (Postfix) with ESMTP id BDC8940004 for ; Fri, 21 Mar 2025 23:53:13 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=rW6gV7HH; dmarc=none; spf=pass (imf12.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742601193; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3zmxxbMFgU1+QnJymL34Ym6pm2fspx3wKLNQhwMTRcc=; b=rPX91dkIGIiii3KBjyMczGHv5RFFNRlYYlVxF0KR5gRsKC57f+p+wAuNdtba+XDwPlI61y ekO6N2RFAJGmwiyZqVjs7faLRi8RQJ2Xe91lcZOYVTzA6NbhuOQVDtBxeRbFa94oW4kHe9 wLoYE7OurLmKp2kFwfYzR7MZfDN4uLQ= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=rW6gV7HH; dmarc=none; spf=pass (imf12.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742601193; a=rsa-sha256; cv=none; b=a/hr6xf4sshKdiLPrkjqUk4OE5AqawPi7wmW3PSuhAll122qQDxkpISO2ybz/LAAGDE/Wi 0rDyNvCiJjvR/wLfEKpShdIs8GTrmeGdNd7FSAcUS9CNd06p9IVFwbxWw5kL9myfHZ7wx+ /v3KkeJXDoEwAqjHcokC7AXX4nrHFY4= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id A66085C0359; Fri, 21 Mar 2025 23:50:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0AEB5C4CEE3; Fri, 21 Mar 2025 23:53:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1742601192; bh=TEY2yXDUKVYLRAs/dwMUuBs9Jo4hjLJ/j1NqGNyR9go=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=rW6gV7HHwLr9jI43m29FCZC/a4Swa6sR+2sZTxWGun/kXZIYrs73OXMUkQLooC+w0 GMGtNes09qEvSPOqCGz0CWdAGfeDX0d7KngrQt4h4m9/lUYHPoibFKkeRWccG61tM3 nknKLsvmnsXOGeYMNjg3ERazLJRGiLOJ/iNyjZ+s= Date: Fri, 21 Mar 2025 16:53:11 -0700 From: Andrew Morton To: David Hildenbrand Cc: Vlastimil Babka , Gavin Shan , linux-mm@kvack.org, linux-kernel@vger.kernel.org, willy@infradead.org, linmiaohe@huawei.com, gehao@kylinos.cn, shan.gavin@gmail.com Subject: Re: [PATCH v2 2/2] mm/debug: Fix parameter passed to page_mapcount_is_type() Message-Id: <20250321165311.fac5a8d9b37c69d977df210b@linux-foundation.org> In-Reply-To: <3e6040c1-81f4-4977-bbb7-70908104aa45@redhat.com> References: <20250321120222.1456770-1-gshan@redhat.com> <20250321120222.1456770-3-gshan@redhat.com> <809792d8-8717-41d9-8dd8-ca91a5b54a28@suse.cz> <3e6040c1-81f4-4977-bbb7-70908104aa45@redhat.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam01 X-Stat-Signature: e6pga37a33srtda1kba8y1w91gxfc7b8 X-Rspam-User: X-Rspamd-Queue-Id: BDC8940004 X-HE-Tag: 1742601193-577237 X-HE-Meta: U2FsdGVkX18VsvTKYgG5HIEz84sEl2QIJLkC0fVo5+p/JcrY5Ifa4WbXzwWG4+zZ4rnbneGg6nOTOgAO/VYausLYtXFO9p9v/WGWKZT2lY1jyMTe3KxIs8maHw0vxaY8jOj34hVnd8ssegvETqV+m0u+aiHDCpQDS7h73Rv4hHmWrjPKjaopg/F1Xlyye/OGl0ue9Jt1dIRynJlF8BY2h2RsKSESJgrf0YSPt7Vw5OZm9OOmJF8aEO+yTe+e1M9XCz/ZNVdjW3cDCj9QQ/7V0TP+rpkBktNaOxNNzK8NlWDKFBsNh3X49sb6jfZU616OVNlLmFyiEj0hgDxBQrqNZKu5MOzBlhJDdOzE7QV7cJXa4OJZIQU9xuRhg8BmT9REOZQdx8DDjApPCE6iqnA7zJOJu3JI0W8P/XJ6gyHKN9RcPHbfbQtliRAEUydcHzSSRrCkkN3NaUF0FLuF1su+qP7BkJS24AykcaPCY7ueIF2S0V/9+S/4jSb/8xvOYnQvoGU3b6qVR4Fx8OgUZoZL05KVetfU+uUmCNr2+Vjn21osoUcEzwzrmHy5QUoYqY7xLBm3xOYJIP9bbOcGMbAC2xK+iWi9V2gKcgJDOEOpgKBO0KdjzbP5HH8BoActOoqntAOBRzfYhPTO5a1Wr6RZ9DJH6F7eAB9dyxL0IziOsUxSYEdSp7bh35p1gN/c+F14tgTrt0cIx3Oz5VeEuQb9wFMtvbXgAIM82nEXOWe+TfrdeUq3E9ooDoB24+H0Kf28OQxtTGR0oKngMaTZEm6M/rtBOuGfKJPgda35OuTgA8q1o1KolJ3uF31DJ1nyfv4PLmJC7xZLVBQptKG2pwiiuSbn4zhvmJ3d9R6ikgAwDBLBE4PxN7qM8nnIpsKw/+08euPq2tZ5dKUrHhnSBM9WVwofcE3J6NfRsw8MTjx87+cP6NCMFbpcV9T5Q5J2scri0TNrxAHqM24XtucwmNl gmNCZHIy OQMaPDiTr4sYIN0M10NNzae2DMtadj5BwtzO49FuNU7k+47Sico9FAjeR5wMqMHTEh4mIcXyFAPSQPaLc+Uv2O9/lYALEuivA+Wv6+acwWcMGfgQD0UIRXlz2PFLcEC0h/R7ynsXuqRTtIBuK/ZuQGdHGjyDW7PyqlDM5GDNhhdPT70vzE3uMY0h6WABsNGU6D4S66vMxE0NGy4jIaKqKc8STrZvpKHIo/vUiP+J8J23i/CXYChwyhQkiKEdAFWLjARRmQhORLObuetst8jlOT9e5Wk1URxHtPM8DhEvLKYNzOCnpf8OKCua4its8xwmeihQXf3rlTuoHViae+PCzO1ch/B26lHAOPYdREf6ZLVLpWFX2aNiYmyj7dlm+vntZX82xrW/w/Zk6KHs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 21 Mar 2025 16:38:29 +0100 David Hildenbrand wrote: > >> - mapcount = page_mapcount_is_type(mapcount) ? 0 : mapcount + 1; > >> + mapcount = page_mapcount_is_type(mapcount) ? 0 : mapcount; > > > > At this point it would be perhaps more obvious: > > > > if (page_mapcount_is_type(mapcount)) > > mapcount = 0; > > Agreed, maybe Andrew can fix that up. Sure. I'll be adding this series to the 6.15-rc1 pile.