From: Andrew Morton <akpm@linux-foundation.org>
To: David Hildenbrand <david@redhat.com>
Cc: Vlastimil Babka <vbabka@suse.cz>, Gavin Shan <gshan@redhat.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
willy@infradead.org, linmiaohe@huawei.com, gehao@kylinos.cn,
shan.gavin@gmail.com
Subject: Re: [PATCH v2 2/2] mm/debug: Fix parameter passed to page_mapcount_is_type()
Date: Fri, 21 Mar 2025 16:53:11 -0700 [thread overview]
Message-ID: <20250321165311.fac5a8d9b37c69d977df210b@linux-foundation.org> (raw)
In-Reply-To: <3e6040c1-81f4-4977-bbb7-70908104aa45@redhat.com>
On Fri, 21 Mar 2025 16:38:29 +0100 David Hildenbrand <david@redhat.com> wrote:
> >> - mapcount = page_mapcount_is_type(mapcount) ? 0 : mapcount + 1;
> >> + mapcount = page_mapcount_is_type(mapcount) ? 0 : mapcount;
> >
> > At this point it would be perhaps more obvious:
> >
> > if (page_mapcount_is_type(mapcount))
> > mapcount = 0;
>
> Agreed, maybe Andrew can fix that up.
Sure. I'll be adding this series to the 6.15-rc1 pile.
prev parent reply other threads:[~2025-03-21 23:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-21 12:02 [PATCH v2 0/2] " Gavin Shan
2025-03-21 12:02 ` [PATCH v2 1/2] mm: " Gavin Shan
2025-03-21 15:09 ` Vlastimil Babka
2025-03-21 12:02 ` [PATCH v2 2/2] mm/debug: " Gavin Shan
2025-03-21 15:19 ` Vlastimil Babka
2025-03-21 15:38 ` David Hildenbrand
2025-03-21 23:53 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250321165311.fac5a8d9b37c69d977df210b@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=gehao@kylinos.cn \
--cc=gshan@redhat.com \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shan.gavin@gmail.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox