From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A624BC36000 for ; Fri, 21 Mar 2025 13:55:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3D744280003; Fri, 21 Mar 2025 09:55:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 35FA0280001; Fri, 21 Mar 2025 09:55:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1D951280003; Fri, 21 Mar 2025 09:55:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id EF3B5280001 for ; Fri, 21 Mar 2025 09:55:32 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id A30DAC1E45 for ; Fri, 21 Mar 2025 13:55:33 +0000 (UTC) X-FDA: 83245705746.14.6A5FCAE Received: from mail-qt1-f174.google.com (mail-qt1-f174.google.com [209.85.160.174]) by imf06.hostedemail.com (Postfix) with ESMTP id 6B4B3180003 for ; Fri, 21 Mar 2025 13:55:31 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=nQllPS3M; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf06.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.174 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742565331; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Zkaw5iQ5n3Q/0Lpyrz/8zsFxGsxzzffjeg2zbqFtr2Y=; b=lysIpe3sVOw9JNR3JKBsysArEyMtSL+K7c20xgyvhwzvR+vVOfq5x4K/vxsqLgtsx4UpMB RngB4SoZCSh4VMAnb8H/OtAN7tuzU/mPUeXVSafs7MnRaeJTB45GOslppZTr+qZsCKQ9Wr pENKdWsjO1CNarE0mIcwbHfzUo1O1ms= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742565331; a=rsa-sha256; cv=none; b=YySdN3F9m7Cm9DIy/DpGZNftiSuGVcDb+4Mz4OmqIbOH0MXmfIqdjxxxdSFn2dkyUEV+Gw Mb35IpW2J1QhIbkLZNleAhlrqxEIsk36xycW/hW+9LHUAcCBb9QyWG/GD7UdvE4ECeCuhc RgbgroyA35H+u2s6dKiEEeYSNKPvXJU= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=nQllPS3M; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf06.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.174 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org Received: by mail-qt1-f174.google.com with SMTP id d75a77b69052e-47662449055so10143371cf.1 for ; Fri, 21 Mar 2025 06:55:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1742565330; x=1743170130; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Zkaw5iQ5n3Q/0Lpyrz/8zsFxGsxzzffjeg2zbqFtr2Y=; b=nQllPS3MGItuOLJtyk8abH0FAD4FTtqshwN4nkPYkPnH2q+ZQJq5/otKYgchgRHfCt 6vYUc1IP27nes+B8yU1rDXNN80OdEu5eFKGoGwpTCXyhVXCOvO7UK3auAAxK4IVLlNLi blrKuje3aY6VVk5kkBJEcyL4i9A9TlnMIfVvNFN4hQ94DJrjXv3IEvV0aMbEQEbVeEo4 aLKdal8Xip0SJKGUW/ZFe/QS8fCzT3oGMBoZMXM6jst6mSG7Um7VoDfSEYjzt9jAKh89 NIrRRteqICHCAGlupDigcsRnfdhP028xo8nB7Y7KB0Znr50bSbhcTq/bqU89AexQ7WZy B+Bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742565330; x=1743170130; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Zkaw5iQ5n3Q/0Lpyrz/8zsFxGsxzzffjeg2zbqFtr2Y=; b=hNUpbAzdY6MZcJDY91uj2qfJCKsj14DrbjfrxBhCNUsvAIVB8zYTRQ3l7JyVlb3tSi u30IiEtQJMwofr9B1CcOczrnvhtVGaxwgUkBi+54nvUA0NoSDo0TJCeulOAiQtQaXmNI kYxXMM27hDQPj3wT1Zfs20d4rFMNnRHM6nZjChuOs+VD8qa+WBo7tFWWcMbnX8lQxjro vVbxgHFqDyH/2Sk4ZBsA5kgpCPF8Q8L3Po6KNeMXnLv2J0G0JnfegC+BP9uIta/+peUc dINkbZidntIxq7Y2nphrjPdAVKLjggx5tzcuqrKoVQYLjAr9fnMpZs0mIg6+NC8XUW2P +iKw== X-Forwarded-Encrypted: i=1; AJvYcCWfAhNf8nNKfeH5IC5SfuFth4fV7oKHPJjmXDIg6XEmopCWmTCWAtIRN0gH9cdM4rSXnb0JVgm7rw==@kvack.org X-Gm-Message-State: AOJu0Yy8H2BkhgPbO0wmfLqUwlMKd2xjQf3SPPRQJWIwEeoVJwgdsSli 7iYQ4DUlg8kkdYbW8ppQMs/re2gapu7bt+zxr0KymT7kAbcMVbqsJxp0vFT+dHfvFYEnS6sUBMM d X-Gm-Gg: ASbGncvodrFbHKSBcrCC+tpzJ1QTi9te1wqYonYxJB4CSkvrLqmsG09yRVLMKNxPAJw bIc0X8EKDStF3PULVr3Gnim7VA8iJQPKTHUirWOWQliXtcIWVPYTY9Pvw1iLO7KH/LeDh1sTjTp cCAyBWnk+/aREb+UAiRxNo+DOF2aBKKXXCzBRu0Q5yfYOTUsjEz2Xe84NcmisWKXxpxIYOvkLgb tyc0aoH2LCAWFzha+zdRu6kjB1qxBSZ0mmN7w7YTvmLlfeEyQATHvYZOYxDOK8FcDvrR7D2Zc8s xj48DnvkvgU9zMSTZORTYjHTkC9GKGV2FxPpwdTzqbM= X-Google-Smtp-Source: AGHT+IEbXh5FE8O7VAveIGhz62AHSuu58vMlCms/I/PLbVH2bCgBpWKIinMzMYIWRzFsFMsCidgO4g== X-Received: by 2002:a05:622a:2b0b:b0:476:8e85:2a2f with SMTP id d75a77b69052e-4771dd943f4mr53309741cf.20.1742565330289; Fri, 21 Mar 2025 06:55:30 -0700 (PDT) Received: from localhost ([2603:7000:c01:2716:da5e:d3ff:fee7:26e7]) by smtp.gmail.com with UTF8SMTPSA id d75a77b69052e-4771d64d5f6sm12262101cf.81.2025.03.21.06.55.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Mar 2025 06:55:29 -0700 (PDT) Date: Fri, 21 Mar 2025 09:55:24 -0400 From: Johannes Weiner To: kernel test robot Cc: oe-lkp@lists.linux.dev, lkp@intel.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Vlastimil Babka , Mel Gorman , Zi Yan Subject: Re: [PATCH 1/5] mm: compaction: push watermark into compaction_suitable() callers Message-ID: <20250321135524.GA1888695@cmpxchg.org> References: <20250313210647.1314586-2-hannes@cmpxchg.org> <202503201604.a3aa6a95-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202503201604.a3aa6a95-lkp@intel.com> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 6B4B3180003 X-Stat-Signature: w9yxbrw356fu6745dyj9ojrxtkuzp1ut X-Rspam-User: X-HE-Tag: 1742565331-684187 X-HE-Meta: U2FsdGVkX18qrl47dMGIjQDEvSrFVBjhNn1PI3prVSX1uE2NmCgockah/HZ8j+80tTqIJ5pT59Uzd9wkyb1WaXZZr4USH0JiFeDI0cMr57Oi4YdUnZR/oLwXU5CpYbbVhKXS/iSUeN6YU3mZLwS8lNMdQHdfK1VVpL9XoanKSPvpXCYZzMd/NlMI2LZN++uRMMMkZsInUS7WYaT+0k7xSwk0tPsCSLBdZXOo9MAcw8/1UssK8jTMIw+fF0pzxdpR6SICJS8qw/cABiqkMyvMpynCxKgh+PSrlCffpZDI4ymV/EX0baxM7APOQTO0oEzDuzGvpFSbgwulmTL05SjaJnuzsLnSOfMmD44dRdGJ9jOJvoqSz9fX6FkQaufr3v7km8tv7IRf3HVnYvX0geTzy0s+CiOfChssgfC4IZwLQ3P0BbUrP7n8jY7gc9VdGinVqzGZty4kE29kTzFqun1LWQZl4qbPpbaVVJryhkBAK+2g9bZmXyVvs9KXxcZm2U/4nY0orxbzUqhvMJx59bJKdOXkXb5rMCL6cXiHsA5au6dIKhF3gkWWw7WHeZIbQSXy9trS9aojWb/ljTDRRSE+VKD1kJzYCt66gNyrjtRrXAKoDEH2edAcKcHYAFqyJhRDx8si1GdIK659bIuzCqq+E6teOb1yhcbGNfFu8Sq8fq9WKX8cyJvoN/gPjjn/m/1KlXyb/Wt3DpW6K1c6kD38q5doeEtZv3hZoCC1NOMI4ka7ILtxJcS2P8XqyLhR8A4yMCm2hcPExY/OsTY8Is+wJv3ktGf+mUgDklxkY0gfDAudB14oBYCNK6YLoht2pfRuf1E/nlD5emnIjAc/vvK2lgvmOKeeUf2I7aieScz2phZ9wuw18+/VVSc/zu8o3sWyXrGof6BFWt0Ypd8SthLvT3N9TijDQclWmbSLo1jKtNwByTCt9d4ZT2wpeqRRukscjLVdl6AbAic2YGwTAd5 215f7StN Fk9iiBqmPaURur8IxnYXoCcL+p+O6jbLky3ZJqTgH/2wzc4E6J7RcsYNfSOr7T9J2f65Qj/ZcD4oTbW82vASn1b5D/eDoAyCgopAQOnZ/dIc0DqXR6nRC1OYhCfho5TBr99wX/itmbEJKCzZhxKUjRnwZa3kCrRwPPfoZ390Lhv1UeP0ckn8eKwnYFD2omx6mRq3IYCZKl1LVEWblUnidQRD6g4jjH0Sl52Q2E8kCtJ5DtSHIlJCOSiJsLFTurdeZbvsqhtUAYM3lkd4pYMr7Gr7F41+1xSQDCpvZ7iaYCwL+CbuNoNEVmMX+PPv0xpyJJn/mieQUPJ3jrk6DqvZMIkaliq5+QotrIDKcUGdYwfJCuNhp3+pJp9Tu6cCfJz+8JP7BPklK2lOVyqdvOjLv2GhvPKsB3WnunzDC9PYZNfLRVhpRIHrlc0XZyAkZxylvGLftVe1NaPKZ2lnCMPQCbVDb6Jt4b+PPCjxJeTKNEvTKg93zbYb7BKqfaA0FlzsxeM1GCkTpQyV0w3a6N9/xalh+JwBdqPf6RjWYpnBW+aVBZ0eb6Oa6G0C1Qk/LbJjOc5hKPY9yUUGC7ZlVnoedz4z767+rwS9JZV7/ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Mar 21, 2025 at 02:21:20PM +0800, kernel test robot wrote: > commit: 6304be90cf5460f33b031e1e19cbe7ffdcbc9f66 ("[PATCH 1/5] mm: compaction: push watermark into compaction_suitable() callers") > url: https://github.com/intel-lab-lkp/linux/commits/Johannes-Weiner/mm-compaction-push-watermark-into-compaction_suitable-callers/20250314-050839 > base: https://git.kernel.org/cgit/linux/kernel/git/akpm/mm.git mm-everything > patch link: https://lore.kernel.org/all/20250313210647.1314586-2-hannes@cmpxchg.org/ > patch subject: [PATCH 1/5] mm: compaction: push watermark into compaction_suitable() callers > test machine: qemu-system-x86_64 -enable-kvm -cpu SandyBridge -smp 2 -m 16G > [ 24.321289][ T36] BUG: unable to handle page fault for address: ffff88844000c5f8 > [ 24.322631][ T36] #PF: supervisor read access in kernel mode > [ 24.323577][ T36] #PF: error_code(0x0000) - not-present page > [ 24.324482][ T36] PGD 3a01067 P4D 3a01067 PUD 0 > [ 24.325301][ T36] Oops: Oops: 0000 [#1] PREEMPT SMP PTI > [ 24.326157][ T36] CPU: 1 UID: 0 PID: 36 Comm: kcompactd0 Not tainted 6.14.0-rc6-00559-g6304be90cf54 #1 > [ 24.327631][ T36] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.16.2-debian-1.16.2-1 04/01/2014 > [ 24.329194][ T36] RIP: 0010:__zone_watermark_ok (mm/page_alloc.c:3256) > [ 24.330125][ T36] Code: 84 c0 78 14 4c 8b 97 48 06 00 00 45 31 db 4d 85 d2 4d 0f 4f da 4c 01 de 49 29 f1 41 f7 c0 38 02 00 00 0f 85 92 00 00 00 48 98 <48> 03 54 c7 38 49 39 d1 7e 7e b0 01 85 c9 74 7a 83 f9 0a 7f 73 48 > All code > ======== > 0: 84 c0 test %al,%al > 2: 78 14 js 0x18 > 4: 4c 8b 97 48 06 00 00 mov 0x648(%rdi),%r10 > b: 45 31 db xor %r11d,%r11d > e: 4d 85 d2 test %r10,%r10 > 11: 4d 0f 4f da cmovg %r10,%r11 > 15: 4c 01 de add %r11,%rsi > 18: 49 29 f1 sub %rsi,%r9 > 1b: 41 f7 c0 38 02 00 00 test $0x238,%r8d > 22: 0f 85 92 00 00 00 jne 0xba > 28: 48 98 cltq > 2a:* 48 03 54 c7 38 add 0x38(%rdi,%rax,8),%rdx <-- trapping instruction That would be the zone->lowmem_reserve[highest_zoneidx] deref: long int lowmem_reserve[4]; /* 0x38 0x20 */ > 2f: 49 39 d1 cmp %rdx,%r9 > 32: 7e 7e jle 0xb2 > 34: b0 01 mov $0x1,%al > 36: 85 c9 test %ecx,%ecx > 38: 74 7a je 0xb4 > 3a: 83 f9 0a cmp $0xa,%ecx > 3d: 7f 73 jg 0xb2 > 3f: 48 rex.W > > Code starting with the faulting instruction > =========================================== > 0: 48 03 54 c7 38 add 0x38(%rdi,%rax,8),%rdx > 5: 49 39 d1 cmp %rdx,%r9 > 8: 7e 7e jle 0x88 > a: b0 01 mov $0x1,%al > c: 85 c9 test %ecx,%ecx > e: 74 7a je 0x8a > 10: 83 f9 0a cmp $0xa,%ecx > 13: 7f 73 jg 0x88 > 15: 48 rex.W > [ 24.333001][ T36] RSP: 0018:ffffc90000137cd0 EFLAGS: 00010246 > [ 24.334003][ T36] RAX: 00000000000036a8 RBX: 0000000000000001 RCX: 0000000000000000 > [ 24.335270][ T36] RDX: 0000000000000006 RSI: 0000000000000000 RDI: ffff88843fff1080 and %rax and %rdx look like the swapped watermark and zoneidx (36a8 is 14k pages, or 54M, which matches a min watermark on a 16G system). So this is the bug that Hugh fixed here: https://lore.kernel.org/all/005ace8b-07fa-01d4-b54b-394a3e029c07@google.com/ It's resolved in the latest version of the patch in -mm.