From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C467CC36000 for ; Fri, 21 Mar 2025 13:49:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F24F6280006; Fri, 21 Mar 2025 09:49:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ED0C0280001; Fri, 21 Mar 2025 09:49:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D4B13280006; Fri, 21 Mar 2025 09:49:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id B5D49280001 for ; Fri, 21 Mar 2025 09:49:01 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 30BFAABD46 for ; Fri, 21 Mar 2025 13:49:01 +0000 (UTC) X-FDA: 83245689282.15.4850E29 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2083.outbound.protection.outlook.com [40.107.237.83]) by imf14.hostedemail.com (Postfix) with ESMTP id 25EC210000B for ; Fri, 21 Mar 2025 13:48:57 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=Q06rafH6; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=reject) header.from=nvidia.com; spf=pass (imf14.hostedemail.com: domain of jgg@nvidia.com designates 40.107.237.83 as permitted sender) smtp.mailfrom=jgg@nvidia.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742564938; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eVjjSaw11boavQBJicbnwVw7UaKJKUYbA6xJoJbYDoY=; b=uf1VycspJ7bK6iGCGZ6NAl10O9u6I9mSxGwN/TqGZ/Ae8bO+cZPhiCMXE2IVwuUW9cCPCj ZNzl3sWJ783eha5bSPO/oV6QNWmUqCdM3NcMEaP9hf1Xgwfdpx/efnP6Y4e0H+s8RwKPm/ uxq6aI/VQfqMt32REQV3ab68PvUh+qc= ARC-Authentication-Results: i=2; imf14.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=Q06rafH6; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=reject) header.from=nvidia.com; spf=pass (imf14.hostedemail.com: domain of jgg@nvidia.com designates 40.107.237.83 as permitted sender) smtp.mailfrom=jgg@nvidia.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1742564938; a=rsa-sha256; cv=pass; b=xQ7OrBkR1WQkXTdF2Kni1dXf97GSa8fKpm8hnrQwYwzBfPh8Z8cbDn2Pcok2GVKTqAt8b0 RANvRIYUCHxXh8GrBWNKj9Yi/Wi09ShQ0Ne6hmcYAMrqMH12b1WCUNwZivd6W6oXcvBQeY 8iONJvr8RwI/MN32Py4oazJuf81cKrw= ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=EEjh7COA/1809GnU7EfEzTThZ0zmb3kKNtUvR9kRAQcmeP2Fd5wempH9lFde3Q7XVKk0yjTjiU5QMOF9u4x7px6fUt4DodsB9JpIJn7oocCDZY/i8tExAmPTSwQF172glbMhmD6oHyT+cqaH5GMAALSxRRaAT8ePBXaOM1UCyHLtBQr+/62y63hf8J1+69bTQ2ptE+OQ3rE6xedn57NuhMmhxct8PS9pfbeB/dMRoh7z3fspXGlvYuPDOf5yBr2cyq1BPI68m/LXLXIIfDkWRUPh6rcyF9JD15W8rYAKkf0l9+zIaBNmElSnyVuDvQKBBEqrOwKON8LVYiZXbzf0cw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eVjjSaw11boavQBJicbnwVw7UaKJKUYbA6xJoJbYDoY=; b=BHnt+XsEjKIJGRQK3/WXP95LCdAuGNNS7zW2y6pZNXZbizEcaiuL/8I3dAi4JQVm5GxDZ4UGNjaaORJEB3IdugkGgGH+g4XEh4WrngIw9fP+PjYwsKJsCTrG7Q9A+0BXB9qGbDIsQwbK0NXmeTgGL8SyxrjLbenviHLHrOjATs0WKSwMBfEMi3jh3xtKm3VVTrmohdbxJ/reXClicAy8SPRKVxBDF7qkfb4j7NC9cGFTZkhEFYVxlXPFINTObuw7Wy+msdhWKkC6QlbNV17SobhM0ZLd2YPN3eNQb53q9EvF8Uph9MSh8JuG43BZZkPG0hQlYtQ/D8JyvQlqBzEZXw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eVjjSaw11boavQBJicbnwVw7UaKJKUYbA6xJoJbYDoY=; b=Q06rafH6gvAUQYH5/D8TLDr4eEj347PN/85247aMGLmhvJVxhm/4D5OtW/IRoyzFBRrcBjcjy2mRKF5t8jkuc62a9kQm2wZUcNsQPrQibkSaEv2FxAHth3DmM/YQlp6CnapbpvUhHl/T1nf81+UJzH6MRDt2NSUSZnYbn4rKklz3AmNMUdmC1nJXvQkRlF4I0cFwpLUZdCYEYnu6/FDoEcoO2WLm/H4s4scOfe4Fj9CKgVWC/22eOsT0ddw7F4OBBxV5vCUs/jTuAFLjjAJ3QNsJuvsVyG6svbXkIcjwj+gtuaJNoq4p1vq7MSop3YyvEmo40tPafuE9z6XKNajekw== Received: from CH3PR12MB8659.namprd12.prod.outlook.com (2603:10b6:610:17c::13) by IA1PR12MB8264.namprd12.prod.outlook.com (2603:10b6:208:3f5::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8534.34; Fri, 21 Mar 2025 13:48:55 +0000 Received: from CH3PR12MB8659.namprd12.prod.outlook.com ([fe80::6eb6:7d37:7b4b:1732]) by CH3PR12MB8659.namprd12.prod.outlook.com ([fe80::6eb6:7d37:7b4b:1732%4]) with mapi id 15.20.8534.036; Fri, 21 Mar 2025 13:48:55 +0000 Date: Fri, 21 Mar 2025 10:48:54 -0300 From: Jason Gunthorpe To: Changyuan Lyu Cc: linux-kernel@vger.kernel.org, graf@amazon.com, akpm@linux-foundation.org, luto@kernel.org, anthony.yznaga@oracle.com, arnd@arndb.de, ashish.kalra@amd.com, benh@kernel.crashing.org, bp@alien8.de, catalin.marinas@arm.com, dave.hansen@linux.intel.com, dwmw2@infradead.org, ebiederm@xmission.com, mingo@redhat.com, jgowans@amazon.com, corbet@lwn.net, krzk@kernel.org, rppt@kernel.org, mark.rutland@arm.com, pbonzini@redhat.com, pasha.tatashin@soleen.com, hpa@zytor.com, peterz@infradead.org, ptyadav@amazon.de, robh+dt@kernel.org, robh@kernel.org, saravanak@google.com, skinsburskii@linux.microsoft.com, rostedt@goodmis.org, tglx@linutronix.de, thomas.lendacky@amd.com, usama.arif@bytedance.com, will@kernel.org, devicetree@vger.kernel.org, kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org Subject: Re: [PATCH v5 10/16] kexec: add KHO support to kexec file loads Message-ID: <20250321134854.GB252045@nvidia.com> References: <20250320015551.2157511-1-changyuanl@google.com> <20250320015551.2157511-11-changyuanl@google.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250320015551.2157511-11-changyuanl@google.com> X-ClientProxiedBy: MN2PR05CA0061.namprd05.prod.outlook.com (2603:10b6:208:236::30) To CH3PR12MB8659.namprd12.prod.outlook.com (2603:10b6:610:17c::13) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PR12MB8659:EE_|IA1PR12MB8264:EE_ X-MS-Office365-Filtering-Correlation-Id: 20d9b702-4ef1-49d3-06ff-08dd687f1f46 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|1800799024|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?grXFAbXaL4vuNaRoFd60tc3iLmGrf9Cl9Yp+NuMkp2TTCBNmRRPTALIVR6Aq?= =?us-ascii?Q?F5nvy51Iow9kaNKu2QJrLMPF+7/80hjP6dDU92Acsc+h9Jyyroc8Q1FhrOhD?= =?us-ascii?Q?mYjKmPP9JlRai7Kgr/cJa6TBUihE3abLiKUTJkVX4l8yQUHtgd1s/SF+OT/O?= =?us-ascii?Q?+8a2lS1X5+RB+PxsJccu1khH8/GScB1HFqhEgWUmTvTuAKrF2XUmFGs37Hxr?= =?us-ascii?Q?N3Q6YE68FVSNo4BspV3CJuHuL3C2k++pjljPuWdq+nGVsCVn7Fc6KJHpg+io?= =?us-ascii?Q?Ynr3k7m3n0QHl5NjagqzrzF71NAuQm4qxaoLGaH76antAjSdjZXoGsjEYgmi?= =?us-ascii?Q?1L9foMh5Me3m48Ol+aE6B/eFZaa8x7pS8ws9LtyeI5LYCsMUoFBx0qps4BLT?= =?us-ascii?Q?irhae02byk5kddh1Xo1ASCO8liCqfCGkwAgdKD2NLgbEjNGnJceYFTp0NVz7?= =?us-ascii?Q?zS5kHSUHJLKC0Eun+ggyENF3zyUxcviZKdQYm5wlZig287t8SC5JHFibKveU?= =?us-ascii?Q?f/+QoEDPnLxr+1e0wxcutPxkoqlPQggX/iAlh3T2BK7iZ/i6dHmbppjbU7nu?= =?us-ascii?Q?DJJfzreS1EGqOZQLR07dB8eKXCC48CR7rhDw0fQ4hyqWOLBONc9u3LQwP4BQ?= =?us-ascii?Q?V3W8nWPlS5YT9dotoNh3jdGlSRXXf3AGGTf4SQfv5aeDCp3Fovpe8qe2pxZ9?= =?us-ascii?Q?zPFRgAICZ4o0J0pHLbIPsZqUyu9S4suWwYfv3AmbrL+Qt1exIKCfF7rduhta?= =?us-ascii?Q?rXOwfVihxFQbbvue0q55ZEH2B7oojNZMPmxypTQ37d3kgElI0eCQZ0xSmQr0?= =?us-ascii?Q?nA8fTVJOdu4a0f3Ic+ocRva0uqgzXmXMyK3BGzYMtF5ovP/8A+svGhE2gkxj?= =?us-ascii?Q?GaE2XJr1+00ep18pxJJzZ3MIxi7jCjpuOij0MFtktR5fRVmDKMYS8KT4gbT9?= =?us-ascii?Q?+JAcMz42wHHMvn2WhswENSD4kCP3Xq7c/TUlStJrV5+yMDKRRkw/wVfvzId1?= =?us-ascii?Q?k+4kDJXUjziQ4JoNzVhoatWv0U4vVczTnPd0+QSQe5tvHP/s1dFIVAEo+Rhj?= =?us-ascii?Q?vAxYIIHjNBmbxZq+RQeM0ohaiwhpCGEZKsFGsWDlW4N6yMKxXcozIxr5f46n?= =?us-ascii?Q?FZojzzRGoeQxR8qgbvhJ3XqCTvUghQ51tenLs6tpwS38QvOOJAWn4ys1L6g9?= =?us-ascii?Q?CT4C9aBtao4MOizVfjWfCkEC66rdHLvrYaizEelVe7t8+MepUeeyDP5ILBCy?= =?us-ascii?Q?MAxrlWLK1OkYC6APPcprrzKPLxnA+QZxuWpsbU8e9JQ6+6Jawv5k7SckZIgM?= =?us-ascii?Q?xMVTp/1+j11fzHgt/kFIK0J64qyIZnbdEnIvHQ4Uuuj6/EARN1G8HsArbag5?= =?us-ascii?Q?zCFWROExfpZn4ooMJXshO+8AeAZk?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH3PR12MB8659.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(1800799024)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ZpGZxSSlucsgvPEu8Gs953DLLhRl2nqqN7cB8Z+FBN10vDs46FVe5bcKk5YK?= =?us-ascii?Q?fX1p5Xkz5GDAtKinI93clv8nt3eMFCkmVHzNCaYTqd+/N/O9LK6/k5stZ7M/?= =?us-ascii?Q?hnizBzViL/BxR3nJlmGFlb096nl1ddBPMA/cVdTTwDLEn/Pv1NQVhDhOOG/x?= =?us-ascii?Q?TPXtbro7KvO0yu3rlvDfR77nPZdWDaz04dGNJXD8wNlT5yJfxAnO4F32dnai?= =?us-ascii?Q?34pASWIzC7up0wSGNG0m/FnnMsyZwZozzemUJeylCoML/w24IonmREBLjmtq?= =?us-ascii?Q?BYH7Bgje1V1gCfImifwZeJr7DBGZB2ROQDV3xlsqvXQbJO2UHK3UfY4xDD0S?= =?us-ascii?Q?GXM89e7bUCC84P8unmCAN1hDC2IWt+ShCeVnJmTZs2TbJaTIq1aJIpWDPO8j?= =?us-ascii?Q?1LHJDIPhON6JJ1PaSa8c5mdMyVUICHHn9PBz1rZKo8GNpfv4gmKZTFJma73w?= =?us-ascii?Q?ULgUCTUK3ls7/CjDq/nxo0fQ9Vz2kp0Vc+z5OF/dHljIHm7MSrNT1CI95Bx9?= =?us-ascii?Q?Cvk2Hz/F2NvXns/cXyaoe1xW7ZfctfGmTDOW0Ukze1rNGWWGOdrq841ui2qo?= =?us-ascii?Q?Psxvtsgf9AbgaPOrKP7tV8wFpz7lsD58LH/2KHcaRerZM/EST5xuIJ6MGY9j?= =?us-ascii?Q?VeS7djU6MUfeKHNK+h83KFrDP5nyMPD9+KqwAE7KaI8fGsyDjpYvDEuQaYeo?= =?us-ascii?Q?+YDIp6eIivEmNakbYFNiYW4tJhm72AtdoOUm6aYVZmCjymNbvmcexd22pvim?= =?us-ascii?Q?MY+VhTCi7Smxdl69aje0lj44QmfBmw/+qHVVzF7HLvNNPUItsABEs5zt0OZC?= =?us-ascii?Q?BcGgu5eGD7lcEWqkWyi6GML9tGUSFh7iCUOr0BPi1k/DQ7y3+6aqaEK24zZ0?= =?us-ascii?Q?AOsHQUG2ycYARfpu4++tSnsD5rEV5POhnF2y1xKBpJzhPKg/xFmUFDeAeg2Y?= =?us-ascii?Q?tiQMqnbmoiLV5wYcFWp5b5SOygm6/Ish86r7UZ0PYWbbmBl7/cishzD2WJ66?= =?us-ascii?Q?nzBCvsyWYSOSdLL8ExRGbT2l8EpSIZMAsNwgH2uG3hkbVHt4p9oVebhWgcP1?= =?us-ascii?Q?hHxe97Jwo/pxjeoQ5L3i8pDhS3FGsKUz33XKT4PqGiX7XItrvHO3T6mY2ZnX?= =?us-ascii?Q?uW8Ka58eCaAZPXqFqvWtCsWw5oCw97qJ6OR3iL3x6CGIOFEpXlIyyqGT2FRT?= =?us-ascii?Q?O8q/DNIrCi3imt2039e2K2AciO6UJjnMpc4jTWCMLqfgWJIdRAs8AqnGU1zr?= =?us-ascii?Q?UCsNf2TyXWDnCPS+pWdgWxpO4PqGVGc+Nfns81vWzHz+2glGuEHvNyP/CNWA?= =?us-ascii?Q?HXmuxbednVEQGz0Lk8VVfhbAQxotB82GgdHjsTTUNZAnucD2nONJDsmHZfav?= =?us-ascii?Q?VbKqFWNsEjBiZNz8DRF+zSi0/yVkCcKvxcO94LGRZDAWX//fYrBBfJNdcOfi?= =?us-ascii?Q?BLYKZg6/kJnzqRI2g5tqTOVDgT9fe/Jlmo1b7T7M0jKRZEhus1ezhVViyD7T?= =?us-ascii?Q?OVFAv/Ly941IxBQ4o/0oaF+YApT0S7UdNLPwibriQr4PKGWqvl16BJa2KCR1?= =?us-ascii?Q?XTb30yqDMf0xQlH+KfVKZ7jNxI+Hjmwumz79uwZR?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 20d9b702-4ef1-49d3-06ff-08dd687f1f46 X-MS-Exchange-CrossTenant-AuthSource: CH3PR12MB8659.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Mar 2025 13:48:55.3763 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9p7fh1lOdxHo68l5yu8gKDJXRWdiCWZZERG6SN8E/9Fl9Pvb8b3Lw6WZwvhTO4yJ X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB8264 X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 25EC210000B X-Stat-Signature: u1hua9nuh3ffouuh13rx1y9r33hmmcsp X-Rspam-User: X-HE-Tag: 1742564937-920590 X-HE-Meta: U2FsdGVkX1/B0beka1gSqSDMCYamuDFf2xqOFs35ePIadDU+6CzUcn82QvTfSw7iXnjuc8jeMJ5D+JOmFSLvkevP2HkwCjyPgAiy0xhx4EBepf5aaInmagd4Vd4WSj8PecDpBPVVIV7hL32LBxkwkg4UoydvXDJsIjjD2dEUOU7am7r3BcDLKn426V4wktjpdvhYCtXVRzHBKP/wxSwsiqr5QThj+oZsQ2qwAbSBb3MxWu0IoAFecdu+vOeA2x/YUfqqM686tIaJdExj3JgVxgdqTib7BYTuvz6wgY67lFLt9BiVrjofV7rpD8nvZYzbwS4qUrilwjVuknqTKfgZRr9Mb5dJScs2l+midJJiuDj/k6GPR5i5BR5RPYCrxIydheXEzs6ZFwmXVmjP1u9K822WHUEIvDhLfmRbNNuh4AhTI47L/Lo13hIXolFap4LVqowfDdul9Pe5YruT+ztAJgUHmmz0ImbyGEU8Q1lqekeCYLKGbkn/IqIJ5LDS63AJ0hFHtRYzQgNdnfOR0gXWTzJ4W63B1GwO0Ci+f1Zw0eIdbGfvPrS3yQJE2E92zF0noKtXfDqUGq/ENvr+VRKiwVz8AZeHFNaPi0xf9TloewJzPABOie4Ng8ZXaSZT+61RZK/kPk3QVj7irvs7JChe3Jl1LHhplXvG2THipDmLQKL2UDosWqjQDr5HPgSh5piVJGTXcUkXtEm3DDDHXIpuUZCWXnCipYojppjzdN4ls6l5R7N542uTQAuvbKlkfa8UTM2ism4HMiSPr9uK/xyYwiKkj1tnr1Ls+ZsiOo5cgRQvNdUPIq6h4vD1pOCAhqCgmEhd1Uq2gW5FuiPS/J38XF4LHvGBdXIWoXU1AXl3Spi6VxBbYWaLVmYmTDiFkqkyYKDsJll1M561kzcK+WgFBs4XKHkYf9EgSh8Qh3C6zrUbTO0t9gQDkc5vsPrvMvWOup3+t6ySl63J69reKDy TPPkYWR2 93MRDb3A/VIhGhh1n9akZAmOiblNBerEKtkzKEhicBUsDxcex4/rMqp80fe78r/vaAq4P7YvLmaNtTxFGWgc+uJIVXNPSESDcKvjGJWakeaz8awr1iAYpdAY2AZUQxotmdxyj6YmBYTi2rfGlskrnVpIJ+rxcD4+ly1yTPXNOdeFrGTiZXKxWxAGZZBcBtrNb/zDF/74MaQnzww78FLqq/pg+JklAEDD1NBCuuyR9mCqc4mstHm4J47zLdJx+IGE4Mv7JmgYi7KJoL85qMDLmoXVCkCS9K6PTHb/KoywKmdUXN+ObOmLNx8ZLy8fpZ/pHb674hD141gtTWlrjM/8877uUqb67uwfYFab9JRhmh/4td6dHJnasauvs9xV3cZ6umOVMIqQtX3vGVdGWuGeWOpuT9RTM6tMDG5cKxgsKC5T/p6KiElPtxDM2DBnkUL6eKxIuiciF/CyT3aEb26VsFWmQbkpLGO5iG9Wb X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Mar 19, 2025 at 06:55:45PM -0700, Changyuan Lyu wrote: > +int kho_copy_fdt(struct kimage *image) > +{ > + int err = 0; > + void *fdt; > + > + if (!kho_enable || !image->file_mode) > + return 0; > + > + if (!kho_out.fdt) { > + err = kho_finalize(); > + kho_out_update_debugfs_fdt(); > + if (err) > + return err; > + } > + > + fdt = kimage_map_segment(image, image->kho.fdt->mem, > + PAGE_ALIGN(kho_out.fdt_max)); > + if (!fdt) { > + pr_err("failed to vmap fdt ksegment in kimage\n"); > + return -ENOMEM; > + } I continue to think this copying is kind of pointless. I liked the point where we could get the FDT blob into userspace and validate it ie through debugfs. But as a way to actually do the kexec, I think you should not copy but preserve the memory holding FDT using the new preservation mechanism and simply put a 16 byte size/length on the image to refer to it. This would clean up the special hard coded memblock reserve to preserve the FDT memory too as normal preservation would take care fo it. Now that this is all in the kernel it seems like there is no reason to do the copying version any more. Jason