From: Gavin Shan <gshan@redhat.com>
To: linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
willy@infradead.org, david@redhat.com, vbabka@suse.cz,
linmiaohe@huawei.com, gehao@kylinos.cn, shan.gavin@gmail.com
Subject: [PATCH v2 1/2] mm: Fix parameter passed to page_mapcount_is_type()
Date: Fri, 21 Mar 2025 22:02:21 +1000 [thread overview]
Message-ID: <20250321120222.1456770-2-gshan@redhat.com> (raw)
In-Reply-To: <20250321120222.1456770-1-gshan@redhat.com>
As the comments of page_mapcount_is_type() indicate, the parameter
passed to the function should be one more than page->_mapcount.
However, page->_mapcount (equivalent to page->page_type) is passed
to the function by commit 4ffca5a96678 ("mm: support only one page_type
per page") page_type_has_type() is replaced by page_mapcount_is_type(),
but the parameter isn't adjusted.
Fix it by replacing page_mapcount_is_type() with page_type_has_type()
in page_has_type(). Note that the issue doesn't cause any visible impacts
due to the safety gap introduced by PGTY_mapcount_underflow limit.
Fixes: 4ffca5a96678 ("mm: support only one page_type per page")
Signed-off-by: Gavin Shan <gshan@redhat.com>
Acked-by: David Hildenbrand <david@redhat.com>
---
include/linux/page-flags.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h
index 36d283552f80..e1a9f84bd5ab 100644
--- a/include/linux/page-flags.h
+++ b/include/linux/page-flags.h
@@ -950,7 +950,7 @@ static inline bool page_mapcount_is_type(unsigned int mapcount)
static inline bool page_has_type(const struct page *page)
{
- return page_mapcount_is_type(data_race(page->page_type));
+ return page_type_has_type(data_race(page->page_type));
}
#define FOLIO_TYPE_OPS(lname, fname) \
--
2.48.1
next prev parent reply other threads:[~2025-03-21 12:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-21 12:02 [PATCH v2 0/2] " Gavin Shan
2025-03-21 12:02 ` Gavin Shan [this message]
2025-03-21 15:09 ` [PATCH v2 1/2] mm: " Vlastimil Babka
2025-03-21 12:02 ` [PATCH v2 2/2] mm/debug: " Gavin Shan
2025-03-21 15:19 ` Vlastimil Babka
2025-03-21 15:38 ` David Hildenbrand
2025-03-21 23:53 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250321120222.1456770-2-gshan@redhat.com \
--to=gshan@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=gehao@kylinos.cn \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shan.gavin@gmail.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox