linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Gavin Shan <gshan@redhat.com>
To: linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
	willy@infradead.org, david@redhat.com, vbabka@suse.cz,
	osalvador@suse.de, gehao@kylinos.cn, shan.gavin@gmail.com
Subject: [PATCH 1/2] mm: Fix parameter passed to page_mapcount_is_type()
Date: Fri, 21 Mar 2025 15:31:47 +1000	[thread overview]
Message-ID: <20250321053148.1434076-2-gshan@redhat.com> (raw)
In-Reply-To: <20250321053148.1434076-1-gshan@redhat.com>

As the comments of page_mapcount_is_type() indicate, the parameter
passed to the function should be one more than page->__mapcount.
However, page->__mapcount (equivalent to page->page_type) is passed to
the function by commit 4ffca5a96678 ("mm: support only one page_type per
page") where page_type_has_type() is replaced by page_mapcount_is_type(),
but the parameter isn't adjusted.

Fix the parameter passed to page_mapcount_is_type() to be (page->__mapcount
+ 1).

Fixes: 4ffca5a96678 ("mm: support only one page_type per page")
Cc: stable@vger.kernel.org # v6.12+
Signed-off-by: Gavin Shan <gshan@redhat.com>
---
 include/linux/page-flags.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h
index 36d283552f80..ad87b4cf1f9a 100644
--- a/include/linux/page-flags.h
+++ b/include/linux/page-flags.h
@@ -950,7 +950,7 @@ static inline bool page_mapcount_is_type(unsigned int mapcount)
 
 static inline bool page_has_type(const struct page *page)
 {
-	return page_mapcount_is_type(data_race(page->page_type));
+	return page_mapcount_is_type(data_race(page->page_type) + 1);
 }
 
 #define FOLIO_TYPE_OPS(lname, fname)					\
-- 
2.48.1



  reply	other threads:[~2025-03-21  5:32 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-21  5:31 [PATCH 0/2] " Gavin Shan
2025-03-21  5:31 ` Gavin Shan [this message]
2025-03-21 10:13   ` [PATCH 1/2] mm: " David Hildenbrand
2025-03-21 11:26     ` Gavin Shan
2025-03-21 11:28       ` David Hildenbrand
2025-03-21  5:31 ` [PATCH 2/2] mm/debug: " Gavin Shan
2025-03-21 10:14   ` David Hildenbrand
2025-03-21  5:34 ` [PATCH 0/2] " Gavin Shan
2025-03-21  9:23 ` Vlastimil Babka
2025-03-21 10:11   ` David Hildenbrand
2025-03-21 11:25     ` Gavin Shan
2025-03-21 11:27       ` David Hildenbrand
2025-03-21 11:33       ` Vlastimil Babka
2025-03-21 12:07         ` Gavin Shan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250321053148.1434076-2-gshan@redhat.com \
    --to=gshan@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=david@redhat.com \
    --cc=gehao@kylinos.cn \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=osalvador@suse.de \
    --cc=shan.gavin@gmail.com \
    --cc=vbabka@suse.cz \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox