From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1ADFAC35FF3 for ; Fri, 21 Mar 2025 04:37:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5745C280002; Fri, 21 Mar 2025 00:37:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 52052280001; Fri, 21 Mar 2025 00:37:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3E864280002; Fri, 21 Mar 2025 00:37:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 22F19280001 for ; Fri, 21 Mar 2025 00:37:11 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 04E1BAD25A for ; Fri, 21 Mar 2025 04:37:11 +0000 (UTC) X-FDA: 83244298704.07.867FCD2 Received: from invmail4.hynix.com (exvmail4.skhynix.com [166.125.252.92]) by imf27.hostedemail.com (Postfix) with ESMTP id 773CF40009 for ; Fri, 21 Mar 2025 04:37:09 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=none; spf=pass (imf27.hostedemail.com: domain of rakie.kim@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=rakie.kim@sk.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742531830; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BAfUsmJZr4K2cMPSo8Me9dy7uh7CJM3ZDExGjgT4124=; b=pMw+G/1L22Cco8Cht5P6/wGfN4oqcr5tfWL4Q+UQBerkjb7JkgDjTaIeUmFt3bvDYepkuo x3mRGAMUffzf4NM1JwqSgU23Oc9NyZ5uRr7DKMNVwSz4Bh6qzwj/kH+nv1VuYnvKYRKj0+ DAubvxv6UMzckRziEPgRb1Zqme/iCvA= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; spf=pass (imf27.hostedemail.com: domain of rakie.kim@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=rakie.kim@sk.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742531830; a=rsa-sha256; cv=none; b=LuyLJlKLYOaze8t1VsVYFE5lYTWT69bmo5K7cIR96gTPt6yKetLnhzasYNt5Z8XGbEk3th aA30OYi834MX0Z2z9T8Vs70T1OnSnPmmwGF/BEqw1D4Vgzdhqwv8NjDu6o4I3KIkA/rJ7V S/jfLHu4RJCOj6ma5xPDtTBefDhb4Mk= X-AuditID: a67dfc5b-681ff7000002311f-d6-67dcecf2c08f From: Rakie Kim To: Gregory Price Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-cxl@vger.kernel.org, joshua.hahnjy@gmail.com, dan.j.williams@intel.com, ying.huang@linux.alibaba.com, david@redhat.com, Jonathan.Cameron@huawei.com, kernel_team@skhynix.com, honggyu.kim@sk.com, yunjeong.mun@sk.com, Rakie Kim Subject: Re: [PATCH v3 1/3] mm/mempolicy: Fix memory leaks in weighted interleave sysfs Date: Fri, 21 Mar 2025 13:36:55 +0900 Message-ID: <20250321043701.928-1-rakie.kim@sk.com> X-Mailer: git-send-email 2.48.1.windows.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrPLMWRmVeSWpSXmKPExsXC9ZZnoe6nN3fSDf7fs7CYs34Nm8X0qRcY Lb6u/8Vs8fPucXaLVQuvsVkc3zqP3eL8rFMsFpd3zWGzuLfmP6vF6jUZDlweO2fdZffobrvM 7tFy5C2rx+I9L5k8Nn2axO5xYsZvFo+dDy093u+7yubxeZNcAGcUl01Kak5mWWqRvl0CV8a+ e/NYC6bxVXyb1MbcwDiDu4uRk0NCwERi7alX7DD2zY0nmboYOTjYBJQkju2NATFFBFQl2q64 dzFycTALPGKSON2+lBUkLiwQLtE6QxSkkwWoZNrnTWwgNq+AscTCT3+ZISZqSjRcuscEYnMK mEmcubYXrEZIgEfi1Yb9jBD1ghInZz5hAbGZBeQlmrfOZgbZJSHwmk1i9YZHjBCDJCUOrrjB MoGRfxaSnllIehYwMq1iFMrMK8tNzMwx0cuozMus0EvOz93ECAz2ZbV/oncwfroQfIhRgINR iYfX4s/tdCHWxLLiytxDjBIczEoivCIdQCHelMTKqtSi/Pii0pzU4kOM0hwsSuK8Rt/KU4QE 0hNLUrNTUwtSi2CyTBycUg2M8mmTeMpqKgtfHHwgsMhZ3/A2e7Mf94nJXotKk1cu+hmgmn77 mHpYokfInpvip7VPLnpyuOXjYXa/23snHOATniWTFJ3df1KP/bJNXJwkR2JrzAeWz29+3lzr yh0neSrOYP6BnWuceDnlffs3GM67+IL9vcuzmqkpT37/XHmM7c2xc2f8y78FK7EUZyQaajEX FScCACO+hSFyAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrJLMWRmVeSWpSXmKPExsXCNUNNS/fTmzvpBlev61jMWb+GzWL61AuM Fl/X/2K2+Hn3OLvF52evmS1WLbzGZnF86zx2i8NzT7JanJ91isXi8q45bBb31vxntTh07Tmr xeo1GRa/t61gc+Dz2DnrLrtHd9tldo+WI29ZPRbvecnksenTJHaPEzN+s3jsfGjp8X7fVTaP b7c9PBa/+MDk8XmTXAB3FJdNSmpOZllqkb5dAlfGvnvzWAum8VV8m9TG3MA4g7uLkZNDQsBE 4ubGk0xdjBwcbAJKEsf2xoCYIgKqEm1X3LsYuTiYBR4xSZxuX8oKEhcWCJdonSEK0skCVDLt 8yY2EJtXwFhi4ae/zBATNSUaLt1jArE5BcwkzlzbC1YjJMAj8WrDfkaIekGJkzOfsIDYzALy Es1bZzNPYOSZhSQ1C0lqASPTKkaRzLyy3MTMHFO94uyMyrzMCr3k/NxNjMAAX1b7Z+IOxi+X 3Q8xCnAwKvHwWvy5nS7EmlhWXJl7iFGCg1lJhFekAyjEm5JYWZValB9fVJqTWnyIUZqDRUmc 1ys8NUFIID2xJDU7NbUgtQgmy8TBKdXAmH8pU/Hemc1Tkw8/nvTspHSystI9/5fLmTYVFlyq srgYvXFptvEU9hRri0fRkvstVzZ/TUj6fHlPyNWrlaeL4+Y/OSP91Cd1Qc8eh71iaz8d2BQ4 793Rg7NXBjYIT17sbM5/vvPCwcqwgjVV80zubeefmLOA8ePSlm8Ldto0LGKTXa7ady/ExkWJ pTgj0VCLuag4EQB+26AAbAIAAA== X-CFilter-Loop: Reflected X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 773CF40009 X-Stat-Signature: xxa7htswazdmeake9jzp1s7mru4itk19 X-Rspam-User: X-HE-Tag: 1742531829-941859 X-HE-Meta: U2FsdGVkX19GG/dtZqGUIkiscb6C1HI/86AkSLQRRBRc6k33LVNzgLh7XuiCmKZj2Rzr0KsQxtNJUlb9C6y8kSfke0EU22acYm3jBOf1fMCGhYbH8FigiRTtVed39RYJ3DQ5zHG2ha4FtDhVQsjB85DI8k+3B+K/YkudqcaBkbhBzEYOsrRepCTWNyyaH6mG5ogmRGhZVeXkUNOZRA5KGhkOi4KYvor8ZHjwWNxUqDbeSmcIDN00yMQdIvVXhmjPDU/ORpf34FEuv553msNHsIm52Wo8fNR61VsKc+A7Tf/3rsQhbru7vILUNI1d5VOgyzdCpFX3zX2Dl2yHkOjA+Fq6lNF7uJgvi73XTy1Qvx34NJvxyET1tXebPtfTK+zkvyXSCMs0O5fKZBtjUedGJbshBACCiXW5ScOixSHQfI2ES4yvoVerOF1vvhaeW2zfxMXN1ERjUTXPFZW1n52jstiXymaIu1JoBLI8n6QHYAKbwiF7kV7hBW3DxL9r+tvSbi5a7CIbtZtaAz1LZTNtotwDhvQ72n7iaaPA7GSXwM7aFdjvK4egG7Iivc0wLkbfdKFkZnLi4qUHWR2NqSQMvY+n+SMkdtuEOMQf88U7rX6Pp9sB4AGfIBvoWwQ7ukwTF5/XhzfTigKc/p2+Zr50kTWCySw1YM70qFQlFwsA63sVyY4rxDHB0GhOqTWjJ0fE1a5VqD3Ji/51Chumq6RoRSxAw8YGcTmChc+0OyNoRmJCckg/eUkT0H3poUzh+dtTVGgIAIDv2gEKedRb7Re7yXEp8Or2s31GitC5fPpQkLOtCLHhbLOSdsuJXSzQdGzvtPzzxk179LVyHaPA1UgBFHMfU02+4OuwAu4oI3+M7jG6pyZdbZ1Zd8rQXv8D36Rbq813VfzBgMqkXt9auEYWNtYnhCQKawtR4Uu5qdl/fWRc9WZ4fW05CVjOTbee8FnkGWjfOgFMfEbIqLuURQ3 1H2wVB3m wYOWBsZxly08roFE7Q2N8FpZFyxyGnFAtFvE5NDbTxGilynP0GkRbQgw8Mhvcp46lpkl+kj1LDyqe1UTS8o+d1Ev+ymix0qjiEpziAAv42B5Qkxyghc+vuykpNaW5JOdJaK/NCv1Uykh28Kx4/g0GlXQoi0OcK03GOfmf X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 20 Mar 2025 12:59:32 -0400 Gregory Price wrote: > On Thu, Mar 20, 2025 at 02:40:01PM +0900, Rakie Kim wrote: > > On Thu, 20 Mar 2025 13:17:46 +0900 Rakie Kim wrote: > > > > Hi Gregory > > > > I initially planned to separate this patch from the hotplug-related patch > > series as an independent update. However, after reviewing the code following > > Jonathan's suggestion to consolidate `kobject` and `node_attrs` into a single > > struct, I realized that most of the intended functionality for Patch 2 was > > already incorporated. > > > > As a result, Patch 1 now only contains the `kobject_put` fix, while the > > struct consolidation work has been included in Patch 2. Given the current > > design, it seems more natural to keep Patch 1 and Patch 2 together as part > > of the same patch series rather than separating them. > > > > Rakie > > > > The point of submitting separately was to backport this to LTS via > -stable. We probably still want this since it ostensibly solves a > memory leak - even if the design is to support this work. > > ~Gregory > Patch 1 and Patch 2 are closely related, and I believe that both patches need to be combined to fully support the functionality. Initially, I thought that Patch 1 was the fix for the original issue and considered it the candidate for a backport. However, upon further reflection, I believe that all changes in Patch 1 through Patch 3 are necessary to fully address the underlying problem. Therefore, I now think it makes more sense to merge Patch 1 and Patch 2 into a single patch, then renumber the current Patch 3 as Patch 2, and treat the entire set as a proper -stable backport candidate. I'd appreciate your thoughts on this suggestion. Rakie