From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A9A4C36001 for ; Fri, 21 Mar 2025 14:06:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 43E35280003; Fri, 21 Mar 2025 10:06:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4130E280001; Fri, 21 Mar 2025 10:06:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 30268280003; Fri, 21 Mar 2025 10:06:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 0D21A280001 for ; Fri, 21 Mar 2025 10:06:15 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id BA90E16252A for ; Fri, 21 Mar 2025 14:06:14 +0000 (UTC) X-FDA: 83245732668.03.D94F636 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf25.hostedemail.com (Postfix) with ESMTP id 066C0A0027 for ; Fri, 21 Mar 2025 14:06:08 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=TtomZVYe; spf=pass (imf25.hostedemail.com: domain of conor@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=conor@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742565969; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oJaLMY9QN+tDgU4cokiF5R9hlYPzHSPoq0nCjE8IMf4=; b=yYWlGomxPDQ7AjJ+Iz1kob+T7vqQDGKYlX3xXDou0FDv1Kn6abWTJO7Nuj2Qfpfuz4Vg/a MNSd86ST33qP2yHAibI8QNnJEqi6IO+ccQV3+hdHLPrV4vOO5IKGGqWdmVqmL+qBVKxu1h VTPiVwPoM0apxzgGinHUQR4T9CfOAHE= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=TtomZVYe; spf=pass (imf25.hostedemail.com: domain of conor@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=conor@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742565969; a=rsa-sha256; cv=none; b=A6BwBQuQ05QidxLtXGQJkEH40VU6jba6iz+UVfIlZPMdVSppXcbDT5X5S5v50TPZYrBHQ3 rOO3i66Yq5uo3RF7epIjkvwJippsF71xZdypRQamDyZymJmrXTbJhea13znJv2KpATQ+cJ +Oz3eT7lmuTWrq8aCRRYncphyzkB4vo= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 93A0543470; Fri, 21 Mar 2025 14:06:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8F51FC4CEE9; Fri, 21 Mar 2025 14:06:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1742565966; bh=Efp2oPA71k6HAIzm+TmV+Ye55dV032TIttlnUM1IzOA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TtomZVYeDy8wuAU9Z1FLMBCNPF80tqxAb9OYMid0PPJqMYM3GP6Y13h3xTFT3duda EsZJtubJ4eo1f27/8eijbytMXypXK9OpAQvtR6SSvixcT5H5Vii2MhLoL5SLtzb/Lu 0s/caJoC/vby0Y1EP4mDAykVW2LxQXapv6BFXtpmQyPrxZgK6STqVkdLGCyTYHu8Vm mCCFPWNOppzziuF3ByXKJs3Ie2dXyK1dl1rP19u8nYcVc1S745ZPh8fdb1rtan7e9q Du4G1UQee+eAtGBrbvm+tFS9gYh0kewyZAIG31l16DPgHomybi/A7b0/1WpyBnZYBO txFCMNNUxYjnQ== Date: Fri, 21 Mar 2025 14:05:58 +0000 From: Conor Dooley To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, willy@infradead.org, david@redhat.com, vbabka@suse.cz, lorenzo.stoakes@oracle.com, liam.howlett@oracle.com, alexandru.elisei@arm.com, peterx@redhat.com, hannes@cmpxchg.org, mhocko@kernel.org, m.szyprowski@samsung.com, iamjoonsoo.kim@lge.com, mina86@mina86.com, axboe@kernel.dk, viro@zeniv.linux.org.uk, brauner@kernel.org, hch@infradead.org, jack@suse.cz, hbathini@linux.ibm.com, sourabhjain@linux.ibm.com, ritesh.list@gmail.com, aneesh.kumar@kernel.org, bhelgaas@google.com, sj@kernel.org, fvdl@google.com, ziy@nvidia.com, yuzhao@google.com, minchan@kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, iommu@lists.linux.dev, linux-kernel@vger.kernel.org, Minchan Kim Subject: Re: [RFC 3/3] mm: integrate GCMA with CMA using dt-bindings Message-ID: <20250321-unhelpful-doze-791895ca5b01@spud> References: <20250320173931.1583800-1-surenb@google.com> <20250320173931.1583800-4-surenb@google.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="fM541kW8FgR5YYtY" Content-Disposition: inline In-Reply-To: <20250320173931.1583800-4-surenb@google.com> X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 066C0A0027 X-Stat-Signature: g4zzson6eqfqzxsqwnpiaor1fmwpcyb3 X-HE-Tag: 1742565968-613916 X-HE-Meta: U2FsdGVkX1+ZWJYH64z3aS+DDFFJOUrfGCF0lBFAHjffbhcC8X0SOuWOOmk8e8dVPUjsDqua/cMsU/UvcaLhqOdCmqmEcdb4f1mZuetfPQXuBQ7JGKMGpLrglPTR40+inrSnl4pEu6WXm9MC34Us8YiNisLgx3Cl3unfaQ4JWBm58MWXmgUEzCsjvWIVIFgrE4QFCrYQCl5CvmoyEmSuY3KPhANauBvmRzJjUmc3sCj2ouVDWlyZtzVv8UCmYrs8TwQrJ0AkZ6cWEpNLsZTjdYHvAPlxY6IW4g5uWDGP08TeJW+3ab+OJ+bvPA0qL4uZHabA7WzyS6hsRGBB++aF9ou6OV7pfuie3TJyeUV6utYhGR0r7mYEkqDmIcolfPEFnt8fPOcRMuZgGDnlsWCb48WErGeQwm42Cm0fiBisgS7aTodhyv/SzOjb8xU/6B32ARJ/kjc3JCn2pAj8oiejFDY33/Qepf0PYDO6gsx8aqicknnTMhGwuzoejuK01qvoBQHdiNElfHhiW9q/Qg3HFDwFaePWA43Pz/fZH0qPmx26MFRqRjCe0W8XKOjDFdECLs/lFQdG87WmanfhWnz2mJ0jjPK/z+XN83ByEz18CtXP7IQrhPtAfumBNlYlKPVIwU5GE+AVU6WevTg058jFrhzQpAH1OY6YDr6iijpb+ihBuNfp68DUaLuZjoLrxVdxrm8kp5FaIzkSunAP1TAbGvH/0JgugiuAuCDOB/D6RlCl6ne5zZYWFHbfYfuyIX3LBz/gsmWi7Ul3JDzYU6R5SaXjU//JjLN8CQcxKqOHBGiemWVXP43mCeZvn7F906Zt5vWcav3h9mA7NH1ncmJRGMBxis2A8H0ThdMHYkel2THUPGrZmnPb4K8LDUL8Ta98lYIVlzAP8B14vB8+RD/7W22Vnmv0FvRO2kQwAs4dhvssQ6UxLWX4IRrwBIj88EXTGSC4NGgqfS7pQZ+ea95 ohY8IexX MXY8mjD4zg1pQItituPq7XP38c1K1RUEsJzm3u9nOHc+mvUGchPeL1+Lc1Vlh++ZVVRsBWmml93L+DsEoHu5ydzZHC0GY0Zq9RzowZ8uFfmHEJfzZhgSMQlxo5Y6ljdtomxxMZBeRNAOf6tj85Qr3uuOymA4Sw2A/RnyZ9chrCjgAVW1YE3pFqZMshNg9nqu4D0S7mmznK1aP09QkKdi4Jj8iUA86OLr5G2YXtkUX8CIiDAx0vGjERCP51PuTRQ3GVZ9iizoi/O1XSCR/7tlgSqf4pItsY0eB3Rp3/MHAJiGZSAYX/6XN+OD6sxXJKl1o/6wH48ElbvLy/wBeZu25P2WGuGcuXe1JJIessh/a79P1IUkzPJyyO2c6dIIYO9bczbfH3xl+qD9+YCR1Gt+cZKQcuLhQq/XqvFZlXCdBOao2PAp001SI6vrThdkWXaIBHAwW X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --fM541kW8FgR5YYtY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Mar 20, 2025 at 10:39:31AM -0700, Suren Baghdasaryan wrote: > This patch introduces a new "guarantee" property for shared-dma-pool. > With this property, admin can create specific memory pool as > GCMA-based CMA if they care about allocation success rate and latency. > The downside of GCMA is that it can host only clean file-backed pages > since it's using cleancache as its secondary user. >=20 > Signed-off-by: Minchan Kim > Signed-off-by: Suren Baghdasaryan > --- > arch/powerpc/kernel/fadump.c | 2 +- > include/linux/cma.h | 2 +- > kernel/dma/contiguous.c | 11 ++++++++++- > mm/cma.c | 33 ++++++++++++++++++++++++++------- > mm/cma.h | 1 + > mm/cma_sysfs.c | 10 ++++++++++ > 6 files changed, 49 insertions(+), 10 deletions(-) >=20 > diff --git a/arch/powerpc/kernel/fadump.c b/arch/powerpc/kernel/fadump.c > index 4b371c738213..4eb7be0cdcdb 100644 > --- a/arch/powerpc/kernel/fadump.c > +++ b/arch/powerpc/kernel/fadump.c > @@ -111,7 +111,7 @@ void __init fadump_cma_init(void) > return; > } > =20 > - rc =3D cma_init_reserved_mem(base, size, 0, "fadump_cma", &fadump_cma); > + rc =3D cma_init_reserved_mem(base, size, 0, "fadump_cma", &fadump_cma, = false); > if (rc) { > pr_err("Failed to init cma area for firmware-assisted dump,%d\n", rc); > /* > diff --git a/include/linux/cma.h b/include/linux/cma.h > index 62d9c1cf6326..3207db979e94 100644 > --- a/include/linux/cma.h > +++ b/include/linux/cma.h > @@ -46,7 +46,7 @@ extern int __init cma_declare_contiguous_multi(phys_add= r_t size, > extern int cma_init_reserved_mem(phys_addr_t base, phys_addr_t size, > unsigned int order_per_bit, > const char *name, > - struct cma **res_cma); > + struct cma **res_cma, bool gcma); > extern struct page *cma_alloc(struct cma *cma, unsigned long count, unsi= gned int align, > bool no_warn); > extern bool cma_pages_valid(struct cma *cma, const struct page *pages, u= nsigned long count); > diff --git a/kernel/dma/contiguous.c b/kernel/dma/contiguous.c > index 055da410ac71..a68b3123438c 100644 > --- a/kernel/dma/contiguous.c > +++ b/kernel/dma/contiguous.c > @@ -459,6 +459,7 @@ static int __init rmem_cma_setup(struct reserved_mem = *rmem) > unsigned long node =3D rmem->fdt_node; > bool default_cma =3D of_get_flat_dt_prop(node, "linux,cma-default", NUL= L); > struct cma *cma; > + bool gcma; > int err; > =20 > if (size_cmdline !=3D -1 && default_cma) { > @@ -476,7 +477,15 @@ static int __init rmem_cma_setup(struct reserved_mem= *rmem) > return -EINVAL; > } > =20 > - err =3D cma_init_reserved_mem(rmem->base, rmem->size, 0, rmem->name, &c= ma); > + gcma =3D !!of_get_flat_dt_prop(node, "guarantee", NULL); When this (or if I guess) this goes !RFC, you will need to document this new property that you're adding. --fM541kW8FgR5YYtY Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZ91yRgAKCRB4tDGHoIJi 0vghAQCIfI8+ZQNSSUJvyG5N5hCisJl/fWg9Vm7F5uQooGdzzwD/TYcjtjBBKsJv aa6VSuGFaENELpO0FBTADe4awZ04uA0= =vA0y -----END PGP SIGNATURE----- --fM541kW8FgR5YYtY--