From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD989C28B30 for ; Thu, 20 Mar 2025 17:00:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6D74E280005; Thu, 20 Mar 2025 13:00:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 686B7280004; Thu, 20 Mar 2025 13:00:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 577EA280005; Thu, 20 Mar 2025 13:00:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 3A22F280004 for ; Thu, 20 Mar 2025 13:00:17 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id BB81516085B for ; Thu, 20 Mar 2025 17:00:17 +0000 (UTC) X-FDA: 83242542474.28.23894BD Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf25.hostedemail.com (Postfix) with ESMTP id 21597A0026 for ; Thu, 20 Mar 2025 17:00:15 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ESWSty1K; spf=pass (imf25.hostedemail.com: domain of sj@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742490016; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0zpFvPhWKcK9faYUvYApMpgh2e8DD5I28lUPJ6sXcmQ=; b=vSW4pFgy0D3L+rvlFC2BpJfW8KFPZBUUB4+xSdAQjVAUxQ1v+oCdMhV8O9jWi++bjo71f0 34JiNnf9+TbIO/IfCU0BaEzm2nYBKEpyKfJKflYDXCpI+RaLgJCMAEkhQUgIkQDXoNHpMw 10cS60uDTBVgg0nYA2WPI+N+h+PYLB8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742490016; a=rsa-sha256; cv=none; b=rNehoTr0ffU6uYUVzyMPC7FRRQmGv4AxCOLjC8iFufs259+jXbfQxIhLXs3S/CNJedDXWM j/kPat9OebyC9i/xCgKvoquD4P2AdKnd8DGca+4yPQhTIpq039MWEjEsZXj7AczuaGR5mv QHp7lt9pp6InVrZv5sMtSXqXrGQCBdk= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ESWSty1K; spf=pass (imf25.hostedemail.com: domain of sj@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 43F8D44483; Thu, 20 Mar 2025 17:00:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6AF9EC4CEDD; Thu, 20 Mar 2025 17:00:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1742490014; bh=RjyJtuow2YtDXYzaNkugeAaIcyRIfeznyBJyOoDhNnQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ESWSty1KgPSe/jOD7QJStmexHasg+g6Mli4HbB+50vF+HX4MfCGzWXqYpMD/UCNJF 1ytlYxxvxOSswV82lemdmVOIqovbZasJXAGeIWyE1rYwr4QEpe3UPVZtpLpKdky4ZA mO9ge7QMx0FlcHn9qu6jKnuRV2iHlFwiwBFGxcS4q7c/mbw5yCEwcMlVY5bBbCCFbK AEaIMnVRjfq0HvmfQyUu5RtgRpyVz9eAkHP49xSormhHdUQiwO6ZvTkPW8ejQ5hHUm PoqSVXElN1TC6Z9SYkcaMn4nuE/dmoBhze/ftTo9TbtkWzcH/tQ0HoZqvTtgWh3a3/ Gmcnyd185TOGg== From: SeongJae Park To: Taotao Chen Cc: SeongJae Park , akpm@linux-foundation.org, linux-kernel@vger.kernel.org, damon@lists.linux.dev, linux-mm@kvack.org Subject: Re: [PATCH] mm/damon/core: simplify control flow in damon_register_ops() Date: Thu, 20 Mar 2025 10:00:11 -0700 Message-Id: <20250320170011.42114-1-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 21597A0026 X-Stat-Signature: znq99zqacniiq4howz6r8drpjcyu4x7h X-HE-Tag: 1742490015-194190 X-HE-Meta: U2FsdGVkX1/3YJ15exVxALQElCqqRhZXwmunMUbbst+F5iAbbMVFbpVF+MfTehY42i8PpgYTfLD9+PdIP3/e4SMP7iR6AilsXGZkt+Sb+cgjK/JeSnRrIzSdLyiiFIXHinahY9AnyCEads9I3XRbOPhiX2U5whUTnbnR/wdvB19Dyo+rs7DkhJrW7PJKlvqa3mX18VLew7TLV9ycr4YPFTqoB1/fDjCzq49Y/4VZdRjfEsbFkqzCBev267aY89f4xr8bymXrdeetVZmZ5tq8/9gNc8S1UiW+P6eJPQ2qVp5Gemkk2uz34PuvkqbJpz6RmwcIkoGaqzj/qxHlZ3dRQAXx1jhgFqO2MoReKkVWv/mj/Tnm+PdeArYCsm5bOotvGFNWI8TySCcjVFFmIOMNGU60zGp1hN6+0r/+xAUWwRZTFZBsze/HeARBIsTlMFqEnNsbnyFxKJU+L6qRFimxbnzMMxP/lriMbqUip0n0Fn3ZeT9VWJO10egFVHKwD+5dM5778jkIYBbLJzanza1HcT7tPauY73z85b/KYistca5kyci0WsOv5Jux3yVkuxhd9Vq9vT1h5wq8bqfhv1LswSDjPKPzMXYeOgvgqOcpl2VP6kPlER8bseYbOpSLSdkYaiQ8/UrnKF+LkL4nrgcZ0hUKJRJIbWtd/jOzWT4wdz6VglrKsBAOXJSigZu4QrGG87CQQXZMrJZkdQQv8gxU61N2uWR0Xi6uo4ur3yIDFsbBKVqr3+qtuvhDJqik0E2VHXMnHLuxXB33wcvmXB5WMzJzcxeT52trnEqchjnf+VUqSwwKXnFmzTo5lQI99ZSdq2gpzyiIDpMjALUYTJgk2Huy5nacr8yMpB4NfJJ5e9JXUEnqz5yzXO08gWvwn33ZO0NdQrPhSEh57FZPYdUgYEksEglv07X7xmTqV2JqVn4hddfkKji1h8aUapy9QRI4BjKU3/XMEXaFF/IdWLe 8xvYna1Q cq52d X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: + damon@ and linux-mm@ mailing lists. Hello Taotao, On Thu, 20 Mar 2025 18:44:00 +0800 Taotao Chen wrote: > The function logic is not complex, so using goto is unnecessary. > Replace it with a straightforward if-else to simplify control flow > and improve readability. Good catch and nice cleanup, thank you! > > Signed-off-by: Taotao Chen Reviewed-by: SeongJae Park Thanks, SJ [...]