From: SeongJae Park <sj@kernel.org>
To: Taotao Chen <chentaotao@didiglobal.com>
Cc: SeongJae Park <sj@kernel.org>,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
damon@lists.linux.dev, linux-mm@kvack.org
Subject: Re: [PATCH] mm/damon/core: simplify control flow in damon_register_ops()
Date: Thu, 20 Mar 2025 10:00:11 -0700 [thread overview]
Message-ID: <20250320170011.42114-1-sj@kernel.org> (raw)
In-Reply-To: <Z9vxcPCw8tDsjKw1@OneApple>
+ damon@ and linux-mm@ mailing lists.
Hello Taotao,
On Thu, 20 Mar 2025 18:44:00 +0800 Taotao Chen <chentaotao@didiglobal.com> wrote:
> The function logic is not complex, so using goto is unnecessary.
> Replace it with a straightforward if-else to simplify control flow
> and improve readability.
Good catch and nice cleanup, thank you!
>
> Signed-off-by: Taotao Chen <chentaotao@didiglobal.com>
Reviewed-by: SeongJae Park <sj@kernel.org>
Thanks,
SJ
[...]
parent reply other threads:[~2025-03-20 17:00 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <Z9vxcPCw8tDsjKw1@OneApple>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250320170011.42114-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=chentaotao@didiglobal.com \
--cc=damon@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox