From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19668C28B30 for ; Thu, 20 Mar 2025 05:31:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 19AD0280002; Thu, 20 Mar 2025 01:31:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0FB28280001; Thu, 20 Mar 2025 01:31:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EB837280002; Thu, 20 Mar 2025 01:31:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id CA4DE280001 for ; Thu, 20 Mar 2025 01:31:55 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 8FF1D160B9E for ; Thu, 20 Mar 2025 05:31:55 +0000 (UTC) X-FDA: 83240807790.29.6566524 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf22.hostedemail.com (Postfix) with ESMTP id 94682C0005 for ; Thu, 20 Mar 2025 05:31:53 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=none; spf=pass (imf22.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742448714; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NrdE6rmQW1PwprDARFdH5cwQ7GBTn/vI7ylT0gueklQ=; b=GYLa/PwBafkZ6vApG2otCSF7bZeBGGpkWu8YDHv/WtRmW9X187rjnZIDOVmyV6gAHRcK/G mPVLLyVbhQNSyoUv6gaiB4AI+bzjc8eyMI3o9uVykM+vCvuoDJFb8HWoTIuK9pU/BhBZcw HDFT0H7J3b6VwvCRqQz6x4mUOmm28Hk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742448714; a=rsa-sha256; cv=none; b=cVO6w+AK0/VBopmgalD9OX1lIRTqiqwGBCzs8w4HdJKAjGEw8x/iJQ4O0L5KAvmIk62fOS 9j7z1dAuGq7QumEVRi1jUMkoXdbcLCt1nUt30N8cFwD6clxAjAuQAzVTdjjeCyWPiVsQu1 u28k/jJiqHSfJyTZv9Yz9C3pwrwNocQ= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=none; spf=pass (imf22.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de; dmarc=none Received: by verein.lst.de (Postfix, from userid 2407) id E972B68AA6; Thu, 20 Mar 2025 06:31:47 +0100 (CET) Date: Thu, 20 Mar 2025 06:31:47 +0100 From: Christoph Hellwig To: Gao Xiang Cc: Christoph Hellwig , akpm@linux-foundation.org, bingbu.cao@linux.intel.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, lorenzo.stoakes@oracle.com, opensource.kernel@vivo.com, rppt@kernel.org, ryan.roberts@arm.com, urezki@gmail.com, ziy@nvidia.com, vivek.kasireddy@intel.com, Huan Yang Subject: Re: [PATCH] mm/vmalloc: fix mischeck pfn valid in vmap_pfns Message-ID: <20250320053147.GB12560@lst.de> References: <20250317055304.GB26662@lst.de> <5a12454c-16a1-4400-a764-f49293d8dece@vivo.com> <20250318064805.GA16121@lst.de> <5229b24f-1984-4225-ae03-8b952de56e3b@vivo.com> <20250318083330.GB18902@lst.de> <20250318084453.GB19274@lst.de> <64a43d16-606c-4255-8a8b-96d6e4e44729@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <64a43d16-606c-4255-8a8b-96d6e4e44729@linux.alibaba.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 94682C0005 X-Stat-Signature: c57eyj69u8u1b9wx335e4bc795y6xc1j X-HE-Tag: 1742448713-248964 X-HE-Meta: U2FsdGVkX1+S2wJWIZY9MjGRoppMY28ciXpAsEEGY2rwvMoAs+FIDU//0ppFrG2XMZzvYOyMRz7T6/YroLMhnzu2mT6H0w4FpR1MTFemMZAYvFbOVI9ORPUhM6p0/ZY8LL6NbMl6ri3CqnsC9MXRLJJGBu0i1om/JkNaVPTGj2Hi99r3jXYp9zX70R/vwoA8ljseL8h8Yy5tJ0zK0y3ZJFTrpuqZJouh16/KhnkpHm/EVIbU/d62chlnMP1GOSzFUtfCocVx++QlZeb9J+0KxioCkDEMTr4NEPWS/tCnAYGdYFPW7gNHI+iR4FGAMsd6oYFUWesj325RD2JU37d1PJjAFbTQddF+aJINU6T/FM5QI+aFfdGldTpRYphyt6nRgeGdZ+v1RpL+sreS1l5FtTVL+Bxtvyp0AQ0jVLyA1VMHBzZfDCqNv/8auabw2FOCYrIxWDLpvNBZQHz/+NJxHYTi6RGfrmcb4yYHjfSagUU4KiPlMwLTQLcxJrOAB42nbtWdhUXL43eNK87NSYsWKzDzXSCuEEaAPeGZjNij13Obrs+Rm8TuuZYGNdcWxyms9pUyPMwRAGLprQOgbm1SLDMBd25bAy5Kd4umEri/+ESBk/3rHbgUSNmPnt+nBzGFUWJdH9Tl+xRPdHc3qBd/LHRgFRmCLLW8p8FSlAhVaxYgTWbBM1EFMjs3dvuU4WMKCY3eYXy5UM+VM6cx934X+B6PwQQOZ8h2WKKQeMMsUVKb8DbVqwasb+bXoYNGEw6akwjr5tbl/9hmgq0aPKJEfzRccJj90NmhtsAjji6r2Tc/qoGMwh71blI72U3nwbPHJRPjkYzKuS9lBn/9Q56c6hHIU7fFPPk+mRZoDsFxblYGe1P8hxvlF/sMOvKkg8+EUNxXctuYocVsIMwboB6mn6v4fg4jclH7JQZ7yNVMVDwAPD0obHh3hEsTB4XRz4r72vH/FE9Pv6s9ee+hhL1 N49PTwvX SUnK9dZ0pWCSbktY5RRvNTCzHWbv2NAd5KooiUIo3wan/aGKrQ6U9304WPCHHx6ueXbZLz6tt+UInVKZFElVxoOem6A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.004537, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Mar 19, 2025 at 05:09:06PM +0800, Gao Xiang wrote: > The minimum map unit is page size instead of variable-size folio. > > For many cases, vmap (to combine many partial folios) is useful > (instead of split all folios to order-0 folios in advance) but > I agree page array may be inefficient. > > So I don't think another folio vmap() version is better overall > anyway. Then just reject the mappings for now. vmap/vm_map_ram isn't really intended for mapping totally arbitrary scattered memory anyway. As mentioned before udmabuf also has a grave bug in the dma mapping part, so just marking it broken would be another very sensible option.