From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E1D7C28B30 for ; Thu, 20 Mar 2025 08:30:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0C243280003; Thu, 20 Mar 2025 04:30:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 07005280001; Thu, 20 Mar 2025 04:30:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E7A64280003; Thu, 20 Mar 2025 04:30:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B7DC6280001 for ; Thu, 20 Mar 2025 04:30:52 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 0F9BEC0ED1 for ; Thu, 20 Mar 2025 08:30:53 +0000 (UTC) X-FDA: 83241258786.03.B00DE7A Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf04.hostedemail.com (Postfix) with ESMTP id 7473940010 for ; Thu, 20 Mar 2025 08:30:51 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=LEkJKg+e; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf04.hostedemail.com: domain of krzk@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=krzk@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742459451; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=v1f7vYLVQ4kLido9b67URFtXyj2TSNX9XgKK9/HjKEY=; b=YfLSSvdbJ+FdFCzwRD++z1nVZ5kHZFboqnlhTGJDc12HDTfUVvGmyXskyPxD4scOUjCnx5 DrqDP6QZwv/uTzkjjd6IUsUtwsBUOPs4nIgPZud5XVTMNSk4oCtx+9hAulhRf1pdFi4kMU +xAt/yL9+p45nkVkwmX2QL2jS+qians= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742459451; a=rsa-sha256; cv=none; b=ouPV6UeByKOc+7KznHypgI4GnCYKN4k021TCDwyUggtMaM+RbfiUVe288/UlhiRWZnaWlW hERnahMkgEKjaCnLYtb/OOfgl5CbpVN+d8wLfWeecgpfooGS8YK+DWtfS8L5e1JgXSdQNj YXcc/wslrLP2WYJJ0BzVEaZGMmLzf4w= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=LEkJKg+e; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf04.hostedemail.com: domain of krzk@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=krzk@kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id E4C9461579; Thu, 20 Mar 2025 08:30:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 82EF6C4CEDD; Thu, 20 Mar 2025 08:30:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1742459450; bh=v+FOAUR/wqoAqHaoplhVPRBHIikWSf8V1laXOuxnNfk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LEkJKg+eJogLP7TusVxf7b7P/d9nFvPAwJ5TKX+AvnXMsyoNB9Uf9tgOI6jR88QCM JkYvO2jo5I7eAB1u9/xJZpDu+Oopr3mT2NVSZ/EvU3R7jh6dZlhAZ16GVDmlTvpffq iiSDgZBbF1JkdErKodK9X7EiWFC3Yg13LAnitCwjXwRjzEy8zMTLp1Wq3sscrIIWeM FgmpDRVRnJ37VPZfmcEgw3YliLJJdIJCmGuvzrskhLpVCAdq6HYTXmRZnTX/wOuHDY YyGVPP0jB0PQbEJ3m2aeUQfqftuMQ8nfawOMqXiDaJiTxOpnJPFcSB1Wf3yRH0h/Eg AMVe5byYQWq0Q== Date: Thu, 20 Mar 2025 09:30:46 +0100 From: Krzysztof Kozlowski To: Changyuan Lyu , linux-kernel@vger.kernel.org Cc: graf@amazon.com, akpm@linux-foundation.org, luto@kernel.org, anthony.yznaga@oracle.com, arnd@arndb.de, ashish.kalra@amd.com, benh@kernel.crashing.org, bp@alien8.de, catalin.marinas@arm.com, dave.hansen@linux.intel.com, dwmw2@infradead.org, ebiederm@xmission.com, mingo@redhat.com, jgowans@amazon.com, corbet@lwn.net, rppt@kernel.org, mark.rutland@arm.com, pbonzini@redhat.com, pasha.tatashin@soleen.com, hpa@zytor.com, peterz@infradead.org, ptyadav@amazon.de, robh+dt@kernel.org, robh@kernel.org, saravanak@google.com, skinsburskii@linux.microsoft.com, rostedt@goodmis.org, tglx@linutronix.de, thomas.lendacky@amd.com, usama.arif@bytedance.com, will@kernel.org, devicetree@vger.kernel.org, kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org Subject: Re: [PATCH v5 12/16] arm64: add KHO support Message-ID: <20250320-muscular-cougar-of-apotheosis-e4c80b@krzk-bin> References: <20250320015551.2157511-1-changyuanl@google.com> <20250320015551.2157511-13-changyuanl@google.com> <55a5e3f3-1b3f-469b-bde0-69abfff826e4@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <55a5e3f3-1b3f-469b-bde0-69abfff826e4@kernel.org> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 7473940010 X-Stat-Signature: cgqzqk3a1biaq4sbtrpch14qt8kiq1gz X-HE-Tag: 1742459451-290023 X-HE-Meta: U2FsdGVkX18PrpIkDsSQoBgipqqD604/SwjCZhFa7LDUf/TBwxHUJ3KSK7DEBgo8CgqwQOrV6T50bPtmqCsWqfMY42Wad901CBYNGNwIHhAXQ99iunMiawuSQBYFnOrpmLdBNtJQz4SXtoHjZZv7GZHhFQp+iud9IK1hsF3oJtSN0mRIhaQv4hN+p7E4QcHNr0fNWmdWTyHKUl0AJ1WXWUWlesEr32llhPFsMjI/Z4WpZSFLTd+s373Xw9r/LmtlBYfCjiJ9HeTQ4cgJaWHZ/FYH/B2IYpADaJVDUf74HwzwDbX4d0ICTrqSh0T+tlsXGPzk+JC5AZ4quOAC/wa72rEzGkut/qtl0WdTFqjepw4lIsDvrBOrqGCi4hBbnh2FmtCxMY0ctxZpINSvM9QD/OB6DzNT/5fHyw/2tHian58w1Txett64vBnfZTDAJRBW1sWiYIs3LV5FuWfD8V9itFlFTnPWP9qwhHbBozqdKjCqM9uPc+y5F4l/gBTJdGHVwOXMsGE6TChBRire7fs4benNgq0dqa79VP0qMjPZjKxp0m4tYPTP8+0TNOSyivsYOVBlurxGwIMFcJ/QHTkp9gLxR0DwSKxwnQ36f4HAdbnYPJWNb4dN2kNIVubVOBv3CUMZJMgzxXajRUDMRYWJAkiKrY9V2aAf+fZzye1WjQr7ooi/o9uHuU3rexxTMVMcNqxBr9temmL6mgoaQi5K5ulPC3Hcf1eCCUMF7qSHqTbdsnIv4rdG7Ooii4JSdNbyixNNaKoYOnP61HzVVe0pjj2bk8/mzZK7uIT5MBYOB/iItXNduzgJfIN3KIPCizm0CgX3NWKmY09V5yc7Mge8DAJZuetv8WViwUllxS8pEUuPmhy/jq5gClb4ZWULueZxxgtsg5sdaZHCIw7n+FFrOhglCQ/8yw2rTlzopQ7BDsQCxs+QWegzO3IGxEn0EyJb3L7AQxEz2QH8JAxoXkz 3QORJTR2 y8HvLJHAnjOxo2FkbpJB4BHWYrh8r5M2uOQqu/C1dOb0L+5yc+BQV3ehjllB6VLgOTI5KljXde3RdT2p24eSVIBVLC+oYM2AMupImo7uWf/xlMIPem7HDb9B2MX+mDyiQgoe2AC2HmEA8p1DQtmfOwKiICVUH+fefPGa+O5vBGn+ekA8XbC4qOxtf9qWlv+xzMBewq5GCwxuUUmn4BA4xauTLSsFSUWmxmk8sM1F5anttivEyKVD/C5cMWH/TNLsOZO2OxKeSnf0zDm08ozXsufxRTelXeJi5Y1OKcYicSECMahXN4UnSgrveGwFn3gTlHnNwE2dGbh5ImSI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Mar 20, 2025 at 08:13:24AM +0100, Krzysztof Kozlowski wrote: > On 20/03/2025 02:55, Changyuan Lyu wrote: > > > > +/** > > + * early_init_dt_check_kho - Decode info required for kexec handover from DT > > + */ > > +static void __init early_init_dt_check_kho(void) > > +{ > > + unsigned long node = chosen_node_offset; > > + u64 kho_start, scratch_start, scratch_size; > > + const __be32 *p; > > + int l; > > + > > + if (!IS_ENABLED(CONFIG_KEXEC_HANDOVER) || (long)node < 0) > > + return; > > + > > + p = of_get_flat_dt_prop(node, "linux,kho-fdt", &l); > > > You are adding undocumented ABI for OF properties. That's not what was > explained last time. > > NAK. Also there are checkpatch warnings :/ Best regards, Krzysztof