From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BE97C36000 for ; Wed, 19 Mar 2025 15:44:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 838C2280002; Wed, 19 Mar 2025 11:44:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7E8DB280001; Wed, 19 Mar 2025 11:44:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 68906280002; Wed, 19 Mar 2025 11:44:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 4AEF2280001 for ; Wed, 19 Mar 2025 11:44:38 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 5E601B2673 for ; Wed, 19 Mar 2025 15:44:38 +0000 (UTC) X-FDA: 83238723036.14.74EC68A Received: from mail-qt1-f175.google.com (mail-qt1-f175.google.com [209.85.160.175]) by imf23.hostedemail.com (Postfix) with ESMTP id 2674714000D for ; Wed, 19 Mar 2025 15:44:34 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=27ZwZl1v; spf=pass (imf23.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.175 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742399075; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9si6QKET998u7WyNlD/oIsbCSW0xvxa41wWw0Ozqipk=; b=QVg1OXTNUSlPnB5mc7iN4LcM51MLN+/S8zuXOP1oTCpeKwgw+M1hOJuaRlBmAtQMDmdpS5 8RLQIZz4moMDVqkm5u5AZnDYupelg3iYwAElqf3hLpu467J3QtunB4oadnozMkFotSOW5X 6GSyfObVgSClF/ZkICkSkI0HkY71524= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742399075; a=rsa-sha256; cv=none; b=wNpa8h++uPPWTKockGLV/Qb4aTyD+FUm5b6FjyaOsRw+gkYhQL7+7HFn/IHJ/m8NdMNJPR A0kzB7SwanY822ZtruPPexyN0d82mOv64OrFISGRQ3zM4O3TvwwAvoETjxQJywya7esFxk cGTeeeJWI4PJoggLeNwVkGb4kW9QTgQ= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=27ZwZl1v; spf=pass (imf23.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.175 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org Received: by mail-qt1-f175.google.com with SMTP id d75a77b69052e-476ac73c76fso68427541cf.0 for ; Wed, 19 Mar 2025 08:44:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1742399074; x=1743003874; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=9si6QKET998u7WyNlD/oIsbCSW0xvxa41wWw0Ozqipk=; b=27ZwZl1v8ivrEYn3Cv9eDMurd1GH0g+zeEIk/TYm6Dw/5qxqI0SUAX+LD5GNvnImlc GNc2dPerqh1MPofdUKzi/byImF+ZE5HCP2WWktZMnxYcgf5qBqA4YwycapOt4qNh9Cid ZBGpQvbU6q/m06egGgt9CDrf8PINGFJOJ7DMHMHhokyXwCaLacKwjIXEYK/J6GvFWqbw WUAUNqGwH1X8AFNsS9hOQ3P6arDj5eJ03VRF/Sz8qfgq0mVzMl7ISjGvjD5s1MAaYjJm YFo85eN6n6J4nRYoUeFz8AOYHjpw5RrA7YlAmuIqoxXLGHKpYwvuiqSlcUHci8zXDLMI zVhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742399074; x=1743003874; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9si6QKET998u7WyNlD/oIsbCSW0xvxa41wWw0Ozqipk=; b=dY5ScuNBFkYBxAuANW280CHjZAXgXqVtLuNNZZ4U2GA5+yTfASfcD+cSbSatXUi+Yz P4o49A2CZ8H6QEhYsay36CfXWlIjhGh0g9c8d9zJj/+MChOxfUi7ypUUzmjymFSbfBQr 1f58HsmZaY6aixkh6YRKVRrBjyNC+aoNMui6PU2XNww/OD99Z6bmXNp04fExWbgU3Lv9 Kk6eQH4GFCVrv1cZPwtL6JuksXRUU5OEW7fHQcVl27kGdxjERrKvT3pkKw23z63Lifca vYUl2Y6ps1+iQd8P5lkw2mNaHn8o5K4ZOxdFdgyxhoFDfw+83ZXhgYZihSTBEKE9etNo D2vg== X-Forwarded-Encrypted: i=1; AJvYcCWdENeuUocVa1Pa3u61EspcUhW0MyXdlM27MkEevsVYGwYbcudGyJz1vXtBEcvZ4nWMjwaxV+YLfQ==@kvack.org X-Gm-Message-State: AOJu0YyS1P4mM2h2hPzvRWaFTJaVdOquqbUQYOq9OJnhB6edcE1xySyR RDCM31SFaG3eRkVvk2nxEMhRBv0bZNhxcP5g1rFujD3s0qffqnbqyFBwbQGK6SOy1VH6UN+tFEJ 5 X-Gm-Gg: ASbGncvoeC23U0tJ1ld05fxF2aaJTKP1nnjt/KCKpRBUxbIMrPr7alPijpAyDNYFCo9 rVJHWROv0+aS1HBdKD8B5kN9sm+FKsX+BbkNUjT/rkJdVWJdhtm+ll+ouJDqhvIZZPCelWG62tH JMAK5Ewvhpv9+G+WqjQBT5UsO9mNfcySZrZjQupYHxChwyEmgEKdVOzPFhqUi0cwF29DF3Syn0r xK8tF7pJ9nbfgIgk8eyUVZLGYQW0dDk938tIxUX6W9X4opI0QFrvYDP5arR4JVmnKxym+HQy+Qf +oRjKhNPdzY11ndGWhOjrbSA1LDyocn0JLL3i65lWF0= X-Google-Smtp-Source: AGHT+IH2ElysGznDqaVkF9K0dG1j3qwf6OVzHoFCKXB3QMfIF6k7b3yKuQfRi9aAY26/yEo88wfixQ== X-Received: by 2002:a05:622a:2b4a:b0:476:8296:17e5 with SMTP id d75a77b69052e-477082f00f2mr50488621cf.17.1742399074007; Wed, 19 Mar 2025 08:44:34 -0700 (PDT) Received: from localhost ([2603:7000:c01:2716:da5e:d3ff:fee7:26e7]) by smtp.gmail.com with UTF8SMTPSA id d75a77b69052e-476bb7f3c86sm81158871cf.54.2025.03.19.08.44.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Mar 2025 08:44:32 -0700 (PDT) Date: Wed, 19 Mar 2025 11:44:28 -0400 From: Johannes Weiner To: Michal =?iso-8859-1?Q?Koutn=FD?= Cc: Hao Jia , Hao Jia , akpm@linux-foundation.org, tj@kernel.org, corbet@lwn.net, mhocko@kernel.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH 1/2] mm: vmscan: Split proactive reclaim statistics from direct reclaim statistics Message-ID: <20250319154428.GA1876369@cmpxchg.org> References: <20250318075833.90615-1-jiahao.kernel@gmail.com> <20250318075833.90615-2-jiahao.kernel@gmail.com> <3a7a14fb-2eb7-3580-30f8-9a8f1f62aad4@lixiang.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 2674714000D X-Stat-Signature: zycpy4icb9m7s8jxt4x1katkry9rwrez X-HE-Tag: 1742399074-949618 X-HE-Meta: U2FsdGVkX1+F1i/P+hJG+6Z1zvUj6cG60HnAvxCWP82gTF6xy0womZztlzM728Iiagj+vtJcQ3s/3UfLQtr3PHjxB1KA2mkikwqSNf0XxaFtYVyAOL1yipZw3TzDKaCOGGOV+ui4sUfAqq8FHWgDWRMcasdQKE514DkDukk1VQ953IylUsCfs2nTGhN9qt168n/Uc02QZsDdIpmkHimWTvkWYyY47agHAZf3qt/IivqCx8hYgRAfUtKTC8w75MBivVkQ2u3oET1RQDh9Nm/umyY6JFgfGFBSMJ6HdhXx5YQkjmNyOpeI3/4yDg8bRmXm05eXfHLQtjtCw52nUIsi1Y7QLNkH0MKyEiE+VuykBhtH1I1LRPHGeY8nwmsyWravHsCuQ4GE6sNUyzDWjVhgqtutHDzKss0R4QLBWzRzqj+INPS57HLVikaV71COKaHVzvOHpRfn50F9+oGBGOYu6AwmNi4h6MdubaK+GvLajLEENZBWmYhMJMrx2p91muDliMy3i3CE9y8r6E9aH/gqGSPDRJrgcwxHFjjClWmz585KYGCkbUP70V2vvMQpp8qcc/wKxitUZ8+Pr3eWMBnQa0HiEC9j14ExSPq3ysByqgi5DRj9LxqLMqlZu/5NDCdEHvplL9KpQoL/nrvxlSGYf0x8aHf3C8R2xnbJz/VU1JXu4l5jhgQPnJfeJzsm372gZVg0+4nJxnwsodALmtaRNjjhexyFa6KAJ5FbnrEy3e6h3wXwb0d7XnmQc+76EkpwF2DPRE8KZhSEq42HBzLEs7wcYcQPIhyWhySBwoV8IndIp09S79Z2PybU8Dbvy3KQpsKbpJaMD+OTLlbFFcP8A8udxA2jCapWCJXZ6J/TD8osQP5uYff4CWwJYzwumGZrxExV8lyCFZU1wx6q3P35tmyE8qkEMVqz3hSUPwoIGYbx7DEq6NL/lnuCHfA+ZCx8uR1+oXSklcfZziWT4uf TSYSNRDw MxnRtVMtrPlunxL6mftche5JHjQ5M5zt+IIU284iMBIfo69Z+pNfef63UsFtJKJLarjfuNn/65JvdUlYOEtqfqMgJ26qzDybvuCn8E+hYUl/gbD2f5MGVz+GebocxL4fhl+wE2AWRywzU7izIuuRhj/sgQSwG21Uoeihb2DRw/ZVcWAiuj+A8RhR6+gFVWvd/hS5It8MbTfqJElxRqS7hIo4MdGCJ3VCGrTWgV61O3s4m/jJyEjODi0SdkBBAUm0c8afrVtuC/KnnJy3UkAHV3S9dDhl4vaXIMmTj45/y2xizKRLqXWoCvPt5tPnX3Fp6WRSYusSJL0ZV/YSnqJpxu4PMi0UEy+eAs7fcZONFFbnl+pl6yqrKOWd1TSZBi0f2qwUYjVUfAYlhKAW4UuXRPsYH11fZxpVyXq7PyC3PeQVcC7BYOFt/I8teMUGeAE3viwR+IFSxK1tZepo5zYFAeAS1E5mSTVZbhAFb1vHn3F861obvGVjLlM2ECiBrFnelKDyZfYBXTU2nSyfVMr0GT9A2xlVE1LEOy8ivxPovRygGgKIJt1kKKsENPA3n67Z8XJAGy7KJsJVF80chIBENZmIi0ssG47j28HYDMOX5uT+qb5vqzlGKL/FYow== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000020, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hey Michal, On Wed, Mar 19, 2025 at 11:33:10AM +0100, Michal Koutný wrote: > On Wed, Mar 19, 2025 at 05:49:15PM +0800, Hao Jia wrote: > > root > > `- a `- b`- c > > > > We have a userspace proactive memory reclaim process that writes to > > a/memory.reclaim, observes a/memory.stat, then writes to > > b/memory.reclaim and observes b/memory.stat. This pattern is the same > > for other cgroups as well, so all memory cgroups(a, b, c) have the > > **same writer**. So, I need per-cgroup proactive memory reclaim statistics. > > Sorry for unclarity, it got lost among the mails. Originally, I thought > about each write(2) but in reality it'd be per each FD. Similar to how > memory.peak allows seeing different values. WDYT? Can you clarify if you're proposing this as an addition or instead of the memory.stat items? The memory.stat items are quite useful to understand what happened to a cgroup in the past. In Meta prod, memory.stat is recorded over time, and it's go-to information when the kernel team gets looped into an investigation around unexpected workload behavior at some date/time X. The proactive reclaimer data points provide a nice bit of nuance to this. They can easily be aggregated over many machines etc. A usecase for per-fd stats would be interesting to hear about, but I don't think they would be a suitable replacement for memory.stat data.