From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67DE9C35FFA for ; Wed, 19 Mar 2025 12:01:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 36E80280002; Wed, 19 Mar 2025 08:01:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 31D82280001; Wed, 19 Mar 2025 08:01:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1E596280002; Wed, 19 Mar 2025 08:01:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 04196280001 for ; Wed, 19 Mar 2025 08:01:23 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 8B6AF1A1D1A for ; Wed, 19 Mar 2025 12:01:23 +0000 (UTC) X-FDA: 83238160446.11.F61D683 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf10.hostedemail.com (Postfix) with ESMTP id 94651C000E for ; Wed, 19 Mar 2025 12:01:20 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OOB2CpOJ; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf10.hostedemail.com: domain of oleg@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=oleg@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742385681; a=rsa-sha256; cv=none; b=CYLSBxs+A63zuzGkS9ukG6+d3bKHzZ1SMOZ7PtUUIIvuQ0gyYYsNfe+4e4rb7r+AHnbwKL CpD432TGOI93aIotXs/v6tpVGlUOzJWAfwhfxlBSGSc4a+4A3pd89W2ZM4+Zo/ISg0x7pS QfliW86uFeYv18ew2Y7Dn9cV4+90/O0= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OOB2CpOJ; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf10.hostedemail.com: domain of oleg@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=oleg@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742385681; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YqwTqw0LkuMJVhI7nUbav86stM0t9airgBDOJOw1FA0=; b=KeC+nr3hObz09aCjFTVboCDRC19YjmZMXwGtFuEApNU0LceI7+IEb9AQikqVWFZNMZdgH9 DQ6UcHV7qko5Q7zCNkNZohMlwFRm4c4QGFaXRMrXckPDKXp9R0BSHWW8xQLx4uBTClrthx +B9T4U8mC4aGnyE1j5eor2auGhj2hn4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1742385679; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YqwTqw0LkuMJVhI7nUbav86stM0t9airgBDOJOw1FA0=; b=OOB2CpOJbN9/+gDR+W+kICphuH/MSx/kXuV9FfWUZgrYmIXH8BuZE44r9BsbjG4ULaoPjU A8p9/6RJ9PU1WWg6vv8ZUOskTRq+Rjug/oheogEiu8LCVZdTF+eb8ssu03t05rBqAOVumJ VJ1M9NNb5qQVfmymFo6GLS2pH8/xVoQ= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-554-Ep91YsP_MAa5nA-2OQLbTA-1; Wed, 19 Mar 2025 08:01:16 -0400 X-MC-Unique: Ep91YsP_MAa5nA-2OQLbTA-1 X-Mimecast-MFC-AGG-ID: Ep91YsP_MAa5nA-2OQLbTA_1742385673 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id EC50F180AF69; Wed, 19 Mar 2025 12:01:11 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.45.226.12]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id 5D85E1801751; Wed, 19 Mar 2025 12:01:02 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Wed, 19 Mar 2025 13:00:39 +0100 (CET) Date: Wed, 19 Mar 2025 13:00:29 +0100 From: Oleg Nesterov To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-trace-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Andrew Morton , Andrii Nakryiko , Matthew Wilcox , Russell King , Masami Hiramatsu , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , "Liang, Kan" , Tong Tiangen Subject: Re: [PATCH v2 3/3] kernel/events/uprobes: uprobe_write_opcode() rewrite Message-ID: <20250319120028.GA26879@redhat.com> References: <20250318221457.3055598-1-david@redhat.com> <20250318221457.3055598-4-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250318221457.3055598-4-david@redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Rspam-User: X-Rspamd-Queue-Id: 94651C000E X-Rspamd-Server: rspam05 X-Stat-Signature: z8sasupncok37t8ur4fws5xu643kb5ak X-HE-Tag: 1742385680-164945 X-HE-Meta: U2FsdGVkX19bwOyGoIjXTs8TkCS7kLQfpzwXFfvcat7TEKaiwliaEq3uoted1ZMkZ6OfYDvWwHW2WoHdmvHb1Jk0dzelXe0nE8Ln0D3KwCzaEPdgVNWbwxb6ffdsDcccz4eJTVuZrRCm4wapUyag6y8pdmpkIiEYQ17Mv7792SlxA6VCsABp4LQKV00Wv8m30wZjqNmTZEAWcq0U3jEuhth3PzMnoooUZng8pHEtWvoF4wKOpV3E10V0R/q9RRt5aBnifYHFbYGlu1KhrJnOtm7ClZHRfC67adH/N5J8yyXWwe40w6YUILLOIRV1d2SVpUwe/9VWoAo/mZhMpTEdmQDgp0qzn5ZWAMNKT3ZM/bStZAbMpPAHRIgIs+vpRj6HakQBzzw9b6or0NfhyodfWygltLqGi2x8rFotJsBXwbAy9Ie+mKlhmmlzz47ZpILSesEAWNASMafDBrndbKFKV/LXugGfJOBve1tDKBER3AOBEg30aEYyAaYYq8iTwqYgd3/cw2iqwPeAns10bMG3CPGqTA5wE4FTiuIjAGis2gKLMCly6wOXg5+pB8H2iseHXaeb6NEhTYfFXCUfF1SKjx2VhuCzz1DeZHvfnz9rNUM+1H5mnknVXGfX7JrAWtjpGFVhojF47uGvs7+m9aFdBAuD2zxBZ/A7fS7KuF51DIQ7Yjim1bML6vfsGT/0GEwD3KdazmPD1y5Z0lZshpaoh+lzgbeHnPThuU59GoiLSnkhvjp24eqH+HLBXja3dUt9Ol/ZvyYX/bG3V3uhys77pOHMHBCq6fXMtTynhv6k/71/fbi7sUHz5k1FEUBOhREShidlKjHFIhIWLnBb034HvWIr/wnUNVe1rjSfGSlwD7PrTV3ZX4ud6+/TOfOzLCnJrb540P/GB0CM9HPI1LjAdhKlmipRaKv+prfiYWEqZk6aDxvLDwiCw5fNBTbyT4Y0mwMujCUdk7dzTTJ7S/Z IwJ7nux7 oYw2/MUdsbJFKeerj4czkh35qWXmVtRQ9kTcN2e6KIKivyM1SwiZ9ORIEwHFfi1vh7Trq0mBuHhGjIaV0mms3ZCIN0z71zZWNhuw4uTnUVAokCZ98k+0UWSJy64MeU/2g2uVOboHzz3dgfYH6FBRsbkVj+H530c9FpUCCrFnHzx9HXlbRgin0A0SdUiPS+XBN+tO5C2SHeWkDANCLuSuxZNC1Hk3ciS1d0nzD0BKjhNPL982YtEw2sUfqvrpVoqWQGDa7fj0YKMNy/cfLIAImpxX9p6zs3Jaslsvp6n2nVUh8WZ2/5PfiA+bgvYJkUfODhqnC9auSUuNsyVYIUirnV+qmdSHXNK8K4kuZwDzO6iO64Etq9uU4HH5oxdYAunuz/DFfIEaVWXZfUO3a8D4G36+9dMJgzWtp+5B0yT0dX+FNwZg7iFxHO4hC7iY8rV/4FIc8vz34q0gH1Ist9+I94p8C9mmYaJG+4SKeEK3Pg76lmrY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 03/18, David Hildenbrand wrote: > > + if (unlikely(!folio_test_anon(folio))) { > + VM_WARN_ON_ONCE(is_register); > + goto out; > + } Don't we need folio_put() before "goto out" ? Other than that, for this series: Acked-by: Oleg Nesterov