linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v4] mm/page_alloc: Remove unnecessary __maybe_unused in order_to_pindex()
@ 2025-03-19  9:17 Liu Ye
  0 siblings, 0 replies; only message in thread
From: Liu Ye @ 2025-03-19  9:17 UTC (permalink / raw)
  To: akpm; +Cc: linux-mm, linux-kernel, Liu Ye

From: Liu Ye <liuye@kylinos.cn>

The `movable` variable is always used when `CONFIG_TRANSPARENT_HUGEPAGE`
is enabled, so the `__maybe_unused` attribute is not necessary.
This patch removes it and keeps the variable declaration within the
`#ifdef` block for better clarity.

Signed-off-by: Liu Ye<liuye@kylinos.cn>

---
V4: Update from.
V3: Update from.
V2: Update from and Signed-off-by.
---
---
 mm/page_alloc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 542d25f77be8..fe76fd237dd0 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -508,9 +508,9 @@ static void bad_page(struct page *page, const char *reason)
 
 static inline unsigned int order_to_pindex(int migratetype, int order)
 {
-	bool __maybe_unused movable;
 
 #ifdef CONFIG_TRANSPARENT_HUGEPAGE
+	bool movable;
 	if (order > PAGE_ALLOC_COSTLY_ORDER) {
 		VM_BUG_ON(order != HPAGE_PMD_ORDER);
 
-- 
2.25.1



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2025-03-19  9:17 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-03-19  9:17 [PATCH v4] mm/page_alloc: Remove unnecessary __maybe_unused in order_to_pindex() Liu Ye

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox