From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28DCEC35FFA for ; Wed, 19 Mar 2025 08:12:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B12F8280002; Wed, 19 Mar 2025 04:12:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AAF9E280001; Wed, 19 Mar 2025 04:12:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 950AD280002; Wed, 19 Mar 2025 04:12:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 768D9280001 for ; Wed, 19 Mar 2025 04:12:16 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id D9D361A1A67 for ; Wed, 19 Mar 2025 08:12:16 +0000 (UTC) X-FDA: 83237583072.23.1DFFB53 Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) by imf23.hostedemail.com (Postfix) with ESMTP id D8FA414000B for ; Wed, 19 Mar 2025 08:12:14 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=IVpsPuZk; spf=pass (imf23.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.44 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742371935; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=g6LER6Zc804dueOJWjEVUMSRCuA11MVDbrJsbbGQOIo=; b=rBCVm7O3q31OwJb/BMcNpbSJBAGiIHhxGIIdNXbJXyb7MqSUYzFNSmz2BhFmk2RJV8xT94 wdblxBGZXBst0CRYRfz+yHZ//+Aq5CUJ9HXpsCSXcetR/OTJjbachj8TkyHahIxSEzeUrB 6XnybXehSecK7wCs0oXXkSdiZJbqp6Q= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=IVpsPuZk; spf=pass (imf23.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.44 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742371935; a=rsa-sha256; cv=none; b=pxykB7FgxtPnMWacDKU6mz4sOigoI3bTf9Dcv92FKHIhymiF1VXLTYddtFootq1lWbageq nqtYJq9hpXIhyxmRPcuREj27BP41QGOR6aviOgmRwoeRE4d5SFJBMSCvxcJw2lcHVxD3Cu 0Wfnh3LbfDS2ZYHzaE3V1eca4rWqU8I= Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-5e61375c108so8442039a12.1 for ; Wed, 19 Mar 2025 01:12:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742371933; x=1742976733; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=g6LER6Zc804dueOJWjEVUMSRCuA11MVDbrJsbbGQOIo=; b=IVpsPuZksgzhVciKIpZLt3cSJ0r0qUdad0yPyeCUG4OFnt1iEpWWmBeayEtGmToqyJ CmeI+i0hSrbjBd6GM+7dhZBy+5SewDlFXa+vq3LV9RsXtyu9ue5R7V96v5ohoTyL0dYy ctquf6eXSJAC11cImkCSG4miaF2GcsyVOFaaTvOq5iwtW0JWo1PelwnVm/Wy4JK7oJMh S8zRr2edE5a3MQJl6LtLNF+PBLcWoAbiejhaQ9SVfQzAPWp07YloP2PrL3JZXDb8WdV+ qXMT1nO6xincxCvrGubq8vrieR4vMMlIndEL7Ke/05ApMsBZjQKzbPzHbnr7Lb8KWTD9 0X3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742371933; x=1742976733; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=g6LER6Zc804dueOJWjEVUMSRCuA11MVDbrJsbbGQOIo=; b=FxP9rpSVkz9F2h+o/oW5bq3KgAeMPtkyaJ1VbV2ZutNKABV02UnAykFVoWD6vek28g FfFVPsEYCtA5EAccAZkwqPJKp4pU9AmwKNr4LIUkb7DLDKeQTFQ2eEk/tQiXUnDKMbDp iycfem805Wr4H2aE+fSISVx1ZiT+cATkkyBFOb1PVgYf+yeZzkwgrLgIScfvSbGjZ0DS HV104oWBUzQZV6LfPp+cPSPatr54HwFQxdTKxG4vPfmW2tJR/IcqSt3JwMMdq29rjbiG 29TNkJnR4jIW5ME1ORb7TiKNaa9BUzWt3C9Y7WxijmbuCVpgDGMmgKB6sTXhKfbpLTPB 8WhQ== X-Forwarded-Encrypted: i=1; AJvYcCWvlS6zWZ8SJxFbDj3cuOxPyJ5CJ2Dvx0rFX6K9FLK71Sg8Koz8WhHrcL7NWvu2O4uonFL91N8oeg==@kvack.org X-Gm-Message-State: AOJu0YzyWeMLWYErou/mr8bHjK2Yl+zgvH9w7wcVzW2VquAef9RIbbIz VD3POQAjr0yVUH5sbw530ZlpxptCYZbQeWUGQ4GhEfEReHkPQ4Nj X-Gm-Gg: ASbGncsTDmtKbClu/p5cJpOtp23ntjPWQZSYJulKWr5bFiOXsz8bpUZ31Ju6NgBdKe+ aRBpsG5vmGBCly/vyJLmwj3LFrVZ3L4U9Zn1QdDYpmHQbZJ/4dOuSZMCpH/uN2+Sp8AVTcB/bO4 3UKGZxZI44NCx8z3+lsY4SzY4QNfQxr8sFmtTkvT0NXZ/OfPYRaC66bcDZstJsBttC7q7mlU2P4 gyx9tx+ykCFKOyuZoUnWla9S88FaqtiRKF0xf7NuQReP4Io3Zq49XzIli7aQDsJwv2//i0/kob0 v45Ko0lxr3Q7Q4LUS+epm1vVsAQPFT4wMcVh0oUCse18 X-Google-Smtp-Source: AGHT+IHSikBo+dlkg5EFijI5CqsmrJ6JKgVw15gwKTA5Eh0NXXD5K2kuGO7yBKzI5uC9/9Ch0lHiBQ== X-Received: by 2002:a05:6402:40c6:b0:5dc:c531:e5c0 with SMTP id 4fb4d7f45d1cf-5eb80fa4388mr1757689a12.27.1742371932982; Wed, 19 Mar 2025 01:12:12 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e81697509csm8721327a12.30.2025.03.19.01.12.12 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 19 Mar 2025 01:12:12 -0700 (PDT) Date: Wed, 19 Mar 2025 08:12:11 +0000 From: Wei Yang To: Anshuman Khandual Cc: Wei Yang , rppt@kernel.org, akpm@linux-foundation.org, yajun.deng@linux.dev, linux-mm@kvack.org, stable@vger.kernel.org Subject: Re: [Patch v2 2/3] mm/memblock: repeat setting reserved region nid if array is doubled Message-ID: <20250319081211.c5ewa7ngdvuqasn6@master> Reply-To: Wei Yang References: <20250318071948.23854-1-richard.weiyang@gmail.com> <20250318071948.23854-3-richard.weiyang@gmail.com> <0bce0252-dd32-4cef-99f7-2222add43e2c@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0bce0252-dd32-4cef-99f7-2222add43e2c@arm.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Rspam-User: X-Rspamd-Queue-Id: D8FA414000B X-Rspamd-Server: rspam08 X-Stat-Signature: 7ro8aws11o75t7a5fu48ry7f3scc676k X-HE-Tag: 1742371934-755130 X-HE-Meta: U2FsdGVkX1+tjCgdU/r1anpT4tlf+lqHth2cqQU1ug5SoVWSD0Wy6G74+BcJGGXo3lQ3NJNH6VCEdLNTV1WcIWWMSVa6q3UxEMAzyXT85sQzuEo18gHY0AZ5AyAmFnRvqFzRn1Hi8kbpjUBtlG2DOWSiwjAVUn2tnbBj6k5IHBo3PKcXLr4DiLnBjQlGq+NLxxYz+i/Izpvaibeklm/Squ279YI3WEryCKlmGBZCE/8FCou8DogTtXG6ArphdB3rt2x91raw/RiiJuHt8jtYlOTYF2/BlbfLylEws1l/fYG7i3a6kIxRJ7PYMH3rSDNevmjL9k4yhWP6q7XX41XQEV01bjCG2llYRALSXhCNx8xghW0veRYq8xIEOl71TIfWPIEkTww3eLPuKFVeXKyuisg5LxF1m+QrwQy8bcTxVCTfp/Ta5zjYbgmvUvdDYaBaVQa9pKxOQ9U97+RMMzdRn3uS6DirVpXO066GAAr0ayUtMntapGOzhhKtsMSpGZa55s8A20RP7t1Yw5eI38R1+PUq9WF6d1F71XL+gJn9TGISMEbAq2feAO6j0jZ8qSWxexOmsv7ED7VPIraDGevxczJX0xRlyhsJA43jY8dn6n3lStp6yW4aKtr0ZmhVQx9U2qrCX21EbP3cl5BJPHVWqT+TS56fxE5iK9HkVdDnEVwOYZiu+Ncf/p9DWfn6+FENBXtwrSNKRDdqsOrYLdeu07qwWHzrJB9O00rECSL+63s9BWyHE7kd/JwEuWDXZapttiA0pOLzh3GalBdI8kEvhpmoJGdaXpEOub6LDMOHfLGNhlPYl/A0iNYL01chVf1rooABKWuCYm0FA3OCK8L7Cd61oFOiFjkjqIK779u0NAYvnC0z+zcPNKoFuYv+0owib3kgQU9QciZYf5SjnCbwRb0O0DNJ+KXuXAcUWTu6TK35ciNatYC8qlCrtjVCN/FNUwfJGP1wE0MvBWqrYCd HKkn9MVr W14uS8x8/btkZQbj0y6VntLAPburtjy0Eo261xROhm7XQiSkqaepKR5Zu32EeM+PKmywPkRg9LWW678XQ6e8wR4kyDuJecSvH2WGbJ+cfhusF+ggFNFArhZvfhXESm8Mg5KOVKxsNN4WnOBNuWHhKJw/zg09uVx1nFu1sqHqAkYwI2nXhQQQH+pbylhyQQKyyd5CPdkbdrC3rsbh7kRSz2KCNJ274xDEMbqdDsd5bFEzxGdllVdN5aS8XQPOnswQGE78AiL8pG0oNhJar2pEoaECi6Wu9HtwfV1dR+rHlHJ8YRjZoeqWZ3ZX0RJDgbLA9mrL8TV5C4cP6SaeIhtILX6u3brH7KAHf/2P6oasZVqs7SjFVI2jKvgSdlj6IV+akQDefYP/bNI3wPYaFE0QfBVb5C6jr0w5xMKGyG7BcpbCmHOtCqpJhr5ZqGurJ5Ndkiie50gsCB+f1G/4WsUrNjPYkF/27YGseI7c4Ex5Yh7U7yJMrHn2XxcnKEoKYjiHMJNiAzD5Ne4HkISTK3ERopACZUHhZisoBoSHWLTa1j8jcGq4BSKyYMVEcNN/RB/wzx8XFjlkRFWiRTDtT0Y9NYR2O4+QdHwkeXQRaNhVvwVFNmd2Bek1ohiS2OlAPNYIiiIirWjFaMhu65jdjt7C2jJPvU0YS4a19vJS1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.124016, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Mar 18, 2025 at 04:25:23PM +0530, Anshuman Khandual wrote: >On 3/18/25 12:49, Wei Yang wrote: >> Commit 61167ad5fecd ("mm: pass nid to reserve_bootmem_region()") introduce >> a way to set nid to all reserved region. >> >> But there is a corner case it will leave some region with invalid nid. >> When memblock_set_node() doubles the array of memblock.reserved, it may >> lead to a new reserved region before current position. The new region >> will be left with an invalid node id. > >But is it really possible for the memblock array to double during >memmap_init_reserved_pages() ? Just wondering - could you please >give some example scenarios. > The possibility is low, but I think it is possible. I have created a test case to reproduce it. Not sure it could explain ?