From: Wei Yang <richard.weiyang@gmail.com>
To: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: Wei Yang <richard.weiyang@gmail.com>,
rppt@kernel.org, akpm@linux-foundation.org, yajun.deng@linux.dev,
linux-mm@kvack.org, stable@vger.kernel.org
Subject: Re: [Patch v2 2/3] mm/memblock: repeat setting reserved region nid if array is doubled
Date: Wed, 19 Mar 2025 08:12:11 +0000 [thread overview]
Message-ID: <20250319081211.c5ewa7ngdvuqasn6@master> (raw)
In-Reply-To: <0bce0252-dd32-4cef-99f7-2222add43e2c@arm.com>
On Tue, Mar 18, 2025 at 04:25:23PM +0530, Anshuman Khandual wrote:
>On 3/18/25 12:49, Wei Yang wrote:
>> Commit 61167ad5fecd ("mm: pass nid to reserve_bootmem_region()") introduce
>> a way to set nid to all reserved region.
>>
>> But there is a corner case it will leave some region with invalid nid.
>> When memblock_set_node() doubles the array of memblock.reserved, it may
>> lead to a new reserved region before current position. The new region
>> will be left with an invalid node id.
>
>But is it really possible for the memblock array to double during
>memmap_init_reserved_pages() ? Just wondering - could you please
>give some example scenarios.
>
The possibility is low, but I think it is possible.
I have created a test case to reproduce it. Not sure it could explain ?
next prev parent reply other threads:[~2025-03-19 8:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-18 7:19 [Patch v2 0/3] memblock: some fix for memmap_init_reserved_pages() Wei Yang
2025-03-18 7:19 ` [Patch v2 1/3] mm/memblock: pass size instead of end to memblock_set_node() Wei Yang
2025-03-18 10:29 ` Anshuman Khandual
2025-03-18 7:19 ` [Patch v2 2/3] mm/memblock: repeat setting reserved region nid if array is doubled Wei Yang
2025-03-18 10:55 ` Anshuman Khandual
2025-03-19 8:12 ` Wei Yang [this message]
2025-03-18 7:19 ` [Patch v2 3/3] memblock tests: add test for memblock_set_node Wei Yang
2025-04-07 2:58 ` [Patch v2 0/3] memblock: some fix for memmap_init_reserved_pages() Wei Yang
2025-04-07 6:34 ` Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250319081211.c5ewa7ngdvuqasn6@master \
--to=richard.weiyang@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=linux-mm@kvack.org \
--cc=rppt@kernel.org \
--cc=stable@vger.kernel.org \
--cc=yajun.deng@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox