From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57106C35FFA for ; Wed, 19 Mar 2025 08:09:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 58D7C280002; Wed, 19 Mar 2025 04:08:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 53CC4280001; Wed, 19 Mar 2025 04:08:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 42BF9280002; Wed, 19 Mar 2025 04:08:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 253E6280001 for ; Wed, 19 Mar 2025 04:08:59 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 21F68594DB for ; Wed, 19 Mar 2025 08:08:59 +0000 (UTC) X-FDA: 83237574798.11.B8750BF Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf29.hostedemail.com (Postfix) with ESMTP id 223A8120010 for ; Wed, 19 Mar 2025 08:08:56 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=none; spf=pass (imf29.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742371737; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yk+nvubqqyf6230LwsnMkGTUAn84BlEYVnHrFk73oTw=; b=a0c2av5SBGu32XvPgq1+9OAWA/M+5f1R/qwGh4jICFGSPEynO/6tIDGLywnmtGTVHu1IuT kuc19EgR4J0Y3itvZdM3EVIQOYGmPGJKBs4uL/SrK/mnQRyQtKaZGI7oAmGudrLf73Y7wR dC/dH7BBNUXfbTRVarzo8MRCWLc7MCI= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=none; spf=pass (imf29.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742371737; a=rsa-sha256; cv=none; b=BxjRqXNUrqNJ4is1lGD4GsADgOtW1nYeC5RZ1RvIaeOcY7PSGjUsWHFRz1LWuzOY/aATzq oEjhVERM3HpX9roouvBRNaJQGSxt2jXQWU865Bbzh6nCj6b/qzmf3Tizg4tczmhoQEmuhs hLDpQQg8Y2/xChaeWByZR6gBqzgjgc4= Received: by verein.lst.de (Postfix, from userid 2407) id CD84C67373; Wed, 19 Mar 2025 09:08:51 +0100 (CET) Date: Wed, 19 Mar 2025 09:08:51 +0100 From: Christoph Hellwig To: Hillf Danton Cc: Huan Yang , Christoph Hellwig , bingbu.cao@linux.intel.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, opensource.kernel@vivo.com, urezki@gmail.com, vivek.kasireddy@intel.com Subject: Re: [PATCH] mm/vmalloc: fix mischeck pfn valid in vmap_pfns Message-ID: <20250319080851.GA26281@lst.de> References: <20250317055304.GB26662@lst.de> <5a12454c-16a1-4400-a764-f49293d8dece@vivo.com> <20250318064805.GA16121@lst.de> <5229b24f-1984-4225-ae03-8b952de56e3b@vivo.com> <20250318083330.GB18902@lst.de> <20250318084453.GB19274@lst.de> <20250319050359.3484-1-hdanton@sina.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250319050359.3484-1-hdanton@sina.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspam-User: X-Rspamd-Queue-Id: 223A8120010 X-Rspamd-Server: rspam03 X-Stat-Signature: dsyey3djiu4heng4mbh79y9czn1bxh5h X-HE-Tag: 1742371736-53006 X-HE-Meta: U2FsdGVkX19r+Uc5GIe8TzbWB1gsWxxANYjPEXwRPqH0B8cNTBx2/dcOvhEFulw1I8/IXiG/DWGCLaXBVvBUVMHCBkRjKrlW6Xf3UUJYss9o5kUxgEjivOGIT/YRU0oQlUvtkZlUkU8zMKFT1lCWw8TOQIngX7E21HqRr5TCsc0hFtglggCwtu2i1lI30j6z54XbkYXto+Y+DDd0S0H7Sa6w1eyDLhJZIZZrT4s6kEFP5zC/LzUkv1k9HNoR8mnof7Ld+yHRZQ3y9ShALj7FlRvew2lNPt9GOgw2T4l+OY2dEfSa7nAZavrCDOTwjbO7TVBlVg0EIiZ5XKnT4OR7ZYRkrVlhoaEPQqAL2nWLonP2bKFcxFZqHVfrDNLpL89wl/FRdHe8CebcqeCX8FlbXoR/xqryVmRVnanTcOp4FxedfuvLP/viSFZGRvvqwDQDija9uKy7HLGtw4sMZ67HRBRlvPkGllOW99zrS9Grx0o6IkPRcS6oJ7K6p49spJlFQ9HYocNQgoQJR5RPq7B+1tFZUJYIIyYLDcSzjgMApoFZIj3OwPkjzCC73IjHonv2R1DxAoD/5+MNihBxlNPmmIEWeaVb41Xd/AltqJaMEL8dM0yt7Zb4Mb31w3iNa4WYyFgBoMbW0s7furJ1gsJI/9JBPvwejws4Y+nBnltXkCpW9ABPnH1rhpf2nnZCoawrtvM6hAzrKlpuBjbUh6Y+iTP6LfM+OsgA1hwB7cye1v4m5HZbVb8jSHwflEp4YyP9Oaimb4y4dtvpuko2l2zOetLXMuQ7oB6EuV/o9xbvWbvrRyO6ZZovXFSVX9EWtNg8T5rRu3sDZZIQv09wr1gqSekEJlEAjPi/HcXcF+aSrED2zkmqpSEfXtqNJVngpa3gQXaRkMR9mnEcXGze2mCQyg3MYkir+EZfYRZj8FodDQ6sSdkAV7bCyQMzVUJURlzKIVj2iNHT0wpzzuWxw98 FHJwsETR 4nzW9e55jrz9W4mD7/WPQfwhlZTW821bCFjtK/FbpDGktS/R32TfixuHBWEPdVIRfBHKQADOHpsPF6qC3eGpbb4RxLPEJ1Sa+umEyjuZDK8mTzl0jLUGJ0bA9tw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Mar 19, 2025 at 01:03:55PM +0800, Hillf Danton wrote: > A quick fix is to add a vmap_pfn variant to walk around the pfn > check in question, like the following diff (just for idea show). No.