From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33BC8C35FF9 for ; Tue, 18 Mar 2025 08:45:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 08DBE280003; Tue, 18 Mar 2025 04:45:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 03FED280001; Tue, 18 Mar 2025 04:44:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E7147280003; Tue, 18 Mar 2025 04:44:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id C8A76280001 for ; Tue, 18 Mar 2025 04:44:59 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 2E786C0C6A for ; Tue, 18 Mar 2025 08:45:01 +0000 (UTC) X-FDA: 83234036802.19.E068500 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf01.hostedemail.com (Postfix) with ESMTP id 6DC5140004 for ; Tue, 18 Mar 2025 08:44:59 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf01.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742287499; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gaH7x1QywFDMRvXvM0i5ll30KFXxm0ARU3YjWu5yjfI=; b=hGi0CcHy06GOatw8FfBCYNrNSz9Nceu4j/O9mf23VVIZR4TcQPDq6Ua1Lz/pezsWGgdqMs QCRjKQE1qEDPPF0hhKxcWD4eUzhu3ISeVGXypX9I/sS+Pk+YEYGOkTydbPPgNvHH5HTYKq LR2bAGimcfpX4g3emVvdLJAtnPRpue8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742287499; a=rsa-sha256; cv=none; b=wE+QHjtwKKQpxT/fNcBWrR30F05eA8uTPwKCY7YHxkfJasrQDel8RvoqgAHXQw7FsVCWWd cuWQpc4Xn/8ILrvUq6qUC4c1hT5zDOUm4eaFEUyfyj5fCMUxWWKBaozeivejVnLh5hpQV1 nPebIZxsegJKVhNau7pjGQFNrsWcmGY= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf01.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de Received: by verein.lst.de (Postfix, from userid 2407) id 26DC268AFE; Tue, 18 Mar 2025 09:44:54 +0100 (CET) Date: Tue, 18 Mar 2025 09:44:53 +0100 From: Christoph Hellwig To: Huan Yang Cc: Christoph Hellwig , akpm@linux-foundation.org, bingbu.cao@linux.intel.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, lorenzo.stoakes@oracle.com, opensource.kernel@vivo.com, rppt@kernel.org, ryan.roberts@arm.com, urezki@gmail.com, ziy@nvidia.com, vivek.kasireddy@intel.com Subject: Re: [PATCH] mm/vmalloc: fix mischeck pfn valid in vmap_pfns Message-ID: <20250318084453.GB19274@lst.de> References: <20250317055304.GB26662@lst.de> <5a12454c-16a1-4400-a764-f49293d8dece@vivo.com> <20250318064805.GA16121@lst.de> <5229b24f-1984-4225-ae03-8b952de56e3b@vivo.com> <20250318083330.GB18902@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 6DC5140004 X-Stat-Signature: w675hby9w47rerttwp3us7s57x9sx7sp X-HE-Tag: 1742287499-478669 X-HE-Meta: U2FsdGVkX1+9BSDITGPBWumFtb+hSt0163qOJuWcCc6Mn1puSl7OS0rfr5wcyndWop9YXXkIBqiIIaIBSIGlDGVvp6AgD//qpwP1p333w9KkgMAmfZbAQg6fQvEGBjIsIRoVAekA2oaWXjxQj1uIRIHiAt4E4ftufu7aQqVQ0y17MEZc5U7uzzOfBjnB9cmHCaBoiYHm2qlMttpNHDDy2/9AWtEyTncSMyQw0J1g7rD9Uh/fHGli6U9VEPpBUPAgLSFIkOhn3nIxupDMHz/+eVSCbg3ziVWirbP9GJiVaAAtVDhjWmR/FqcknSS1mMguP3cbjcpWR0F0cGPXo9B67AnSnHQ9FnCzdEI8HZrL1GixmrDvYOhhAIl5yglYXonfO1+jEt4aTyNHy/hPgQM/L1HfmQ4DI1yErGNmosi5SKaYwVgJ45aXxblPZ6PkxkYLvpgXJK6yyicEZDib0unkf91uWQKwU1FD2hgHO9s6aKpzp1Q7HiPDZU6uwDHvqNXIvhNhjq5r1aFkYzLymcXbN7RrwpLKXh1CK4/9leomDb3lNsgcCtHZpaGdcnwIl/1QkHvMjUb/+c/Jghx6QJqnsBuBVQZY2nViwVUOZGfL7J9BX0KW7/whwUfYuaDBWRymU9Qfs5UrH5I+CPVKPlcfMW4YqY8ccxczWV7rCAiko7pwkPfcabGGdrW9LsLNO+fmrVHhSO7pr/q1Xx+hLOJWp9buAeiKHZ4WerXKDbmnn7r5BNCfJFbQlPFf2IOGU1Kg9uzqzV8mJ1onUtSGbR6VXHFjwGu4MJvyRk8bTGqO6yE5t0j47H4CoPocLAB7tSwsyQyb8NaxKYkbEdZfgDlG/0g5idZL+vYU++CXp6yRWJweeQXzPswmkTY0LPisCCYYsG4POKSLECZIrdDAzE3v8bRV4c1WsNBhOgUgr42D+ifHD9oYPiGqPDNQ2W1ZJNQdHzEfKNRvDClw7K3OY6t s6xjrCZd XqMxUgO0yjYskMYBgviJZf7sHwW8mOweko0UZ2ATXZlSbnkQF8zfma2m1biW4yDwjdmbe5DNK+bq67ng7kxxRekEaqZmI6TYbds0gz1CmPx5/RVunvy247mHjag== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000318, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Mar 18, 2025 at 04:39:40PM +0800, Huan Yang wrote: > A folio may be 2MB or more large 1GB, what if we only need a little, 1M or 512MB, can vmap based on folio can solve it? Then you only map part of it by passing a length argument. Note that in general when you have these large folios you also don't have highmem, so if you only map one of them, or part of one of them you don't actually need vmap at all and can just use folio-address.. > Normally, can offer 4k-page based array map it. But consider HVO, can't. That's why wanto base on pfn. Well, for any large folio using this 4k based page interface is actually highly inefficient. So let's fix that. And my loop in willy as Mr. Folio while you're at it.