From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 905F3C282EC for ; Tue, 18 Mar 2025 03:03:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2403D280003; Mon, 17 Mar 2025 23:03:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1C9D4280001; Mon, 17 Mar 2025 23:03:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 06A67280003; Mon, 17 Mar 2025 23:03:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E181C280001 for ; Mon, 17 Mar 2025 23:03:40 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 7EAF2A9CF9 for ; Tue, 18 Mar 2025 03:03:42 +0000 (UTC) X-FDA: 83233176684.17.7A0FF92 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf28.hostedemail.com (Postfix) with ESMTP id CE6DFC0010 for ; Tue, 18 Mar 2025 03:03:40 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=tAdtXjf4; spf=pass (imf28.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742267020; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=st+/KHFeNgn0IiiR6UWsvQEZ3r5sa7AcBa/R77g3fLY=; b=JYTpr8HxhwJNgGzJvZOQv3/3rY/i2OZobJb+rQF10lhW9ZKQSPE+7yIxFFKlkZ0fXk6V9F 0fljIlOr4aXLLlH+RubxIdEGnSDWypwuUVoJLfhIB+vslYY/XxM0/Kl2UgsYmFc+7SIN0Y jGrRDdcmZxxtK/TS6ut4tVlzL7DB9ck= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=tAdtXjf4; spf=pass (imf28.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742267020; a=rsa-sha256; cv=none; b=eDgjLZ4TT639ZponUCdH6O9guzzst/p4ELqiFaYW1tQwyE7mOaGeR5HYxexffa3CG4Uqa+ sdPGLSbYsROLvIDBHhxJclo6eRqFs+HyNQk9co0xSjuONnYJ/DXLYybPLzhD+qdbT4k6Vz zVGxKluYeAQMIlwDZH7kAFL10ARjKPk= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 4DFABA48E53; Tue, 18 Mar 2025 02:58:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 07FC8C4CEE3; Tue, 18 Mar 2025 03:03:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1742267019; bh=o+tf22H0kP+fWEj0xzJyUcyCNlkJ7CClEUKtHNlbIYU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=tAdtXjf4DNGQx83LugQAfbDYv+baT02AD1KiN6eoL0uA0oGikJxKCevs1GYUYww5Z MLeDZpQ9cdxLLuViqhxsmOsNb//OJ706jc00aEZTA04LkEGTl/DXLNhdthAT4wZS+9 8JL3LvO7M2lWPqmA9dPSjCEzpp+wVxTeLzbbE17g= Date: Mon, 17 Mar 2025 20:03:38 -0700 From: Andrew Morton To: Liu Ye Cc: hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, willy@infradead.org, david@redhat.com, svetly.todorov@memverge.com, vbabka@suse.cz, ran.xiaokai@zte.com.cn, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, Liu Ye Subject: Re: [PATCH v3] fs/proc/page: Refactoring to reduce code duplication. Message-Id: <20250317200338.c38679f5b7e4b67f86c58dc4@linux-foundation.org> In-Reply-To: <20250318025138.170876-1-liuyerd@163.com> References: <20250318025138.170876-1-liuyerd@163.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: tc79gttfwkfkgggwdabt3pcptigooyc7 X-Rspamd-Queue-Id: CE6DFC0010 X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1742267020-89931 X-HE-Meta: U2FsdGVkX18yhTDIXw5wSr2qPq6+Gee7lSQZTiZmFNlLhkAYbzKEoL1sSIX8v9mH31drJtuKBoS8GWILsAaqbG/Cek3opuwLYVgiCi8soCcv5LETuX1YNAkugkztQ6PoOkfFOFZ1H1Y3eqd5TsCTH5F66BPMyaCrB1AMmzxR9lLuvgvTvCyGaDclEk+ZuCv0P0PoQGUU9zS+0MyDoANRq/vKRDKbL8Mv7z+LoNnIa4lzj0lDq4XBpLVSNgjENADs/p2bntTj8TN2XoYz3nBSO3xTEwvA3aPviyjOnVWuMEIaiYzpHsTe1EEi3OG7iOVr/a7TxdccAWyX8mrEVNn3r0q6ynDNSjciAvBH/C0VeZp0vi9nq51ED/BYJO5hB61YQ9fdX7Eh9+sarBLNnsSxnkvQvQMuiklr57n0+aU/6XL1POtJjMb35aDjdnp80EswZx6DgSG9YPWtWT3dKCZU7o2E3DQXf+8oFAGwHtUr7umgvKM+QGNzpZj9Yz9RUGThLTKnQmpF0SktSmmrDqX2HGEXJJpelkRRSPGg9y5sGeKsFqg4jQCczJv4HyQYulndzAJVne/H9ik0xMzWCpqE+hAF4KrwSoXce08XgIuXymJakiGb6i6938JluTt/OjOo083Vbe5/5r8KKMw77+9FP7iO40qd1ZHPvgwzvjG4It9Lpf5wmcENSc7M6x88Wpb2QPRKrn6+ndsz7bBPcSu17c2X2hI6uy56WOy4TgSpl4VwLd5SatozOPbYv4xqXFG7RNCFe9D/33Nzd3PvhZ6N1u54VNSLfGJ7W7zztIHQY8Sec+DB5GFtSnM9cJjDTrZGEnH7qqzT7ZCxGUzM/a4thH+RuE78UPeICEITiRT9iHI72zw53mt6fHJCZYgf6TtTU+5X5h4SDBHMpG1X6GMgYn6BirhMCZo29NwJxZdnv/9WujJMNGrexZ/Myo4iwoW9m0DPSeNjjwgeI70hH8R m4800L2d vLQlHX80xTlw5WcV3qHdALgOift9JFL93twe61ApJ6waIVb92yqLkuc96rgRwK8IbCcRc4lk3/eBCjhoW/Urbr/0BqOyafk05++XGhpa/t1U8RReqJ2zn/uyIpDYW9rwHlFpRbizjrB6s2Y3itlzz80iTgvaPoNDv5flMDOQLad1VWI2zEjwCJ+O34B4cPtmcb3m2egZMejjWfnsUNuwV4LNDjgvzGmci73ptHNiyNZ3j5ugZ4ukPxivLDba1VTVpWdYSMDxujwVrR0SDYsMntJLTlZtMsQ+Eijk33qDxIvgZkENQWpRatsO4XG75IewnQWo4sOB2QhNx0JSI7zk4ciicWDHTv0hUd/9fcyfKx1/sJjQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 18 Mar 2025 10:51:38 +0800 Liu Ye wrote: > From: Liu Ye > > The function kpageflags_read and kpagecgroup_read is quite similar > to kpagecount_read. Consider refactoring common code into a helper > function to reduce code duplication. > The code in mm.git's mm-unstable branch (and in linux-next) has changed significantly. Please take a look?